- 23 Sep, 2021 3 commits
-
-
Mauro Carvalho Chehab authored
Add a level for debug, in order to allow it to be extended to debug other parts of the script. Signed-off-by:
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Link: https://lore.kernel.org/r/0203416c6c418abb4fc20577a5f48d0d2a41bae7.1632411447.git.mchehab+huawei@kernel.orgSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Mauro Carvalho Chehab authored
The $what conversions need to replace some characters to avoid breaking regex expressions found on some What:. only after replacing them back, the script should get the $leave devnode. Fixes: ca8e055c ("scripts: get_abi.pl: add a graph to speedup the undefined algorithm") Signed-off-by:
-
Mauro Carvalho Chehab authored
Currently, the get_abi.pl will print an invalid symbol (\xac character). Fix it. Fixes: ab9c1480 ("scripts: get_abi.pl: Better handle multiple What parameters") Signed-off-by:
-
- 21 Sep, 2021 37 commits
-
-
Mauro Carvalho Chehab authored
Searching for symlinks is an expensive operation with the current logic, as it is at the order of O(n^3). In practice, running the check spends 2-3 minutes to check all symbols. Fix it by storing the directory tree into a graph, and using a Breadth First Search (BFS) to find the links for each sysfs node. With such improvement, it can now report issues with ~11 seconds on my machine. It comes with a price, though: there are more symbols reported as undefined after this change. I suspect it is due to some sysfs circular loops that are dropped by BFS. Despite such increase, it seems that the reports are now more coherent. Signed-off-by:
-
Mauro Carvalho Chehab authored
In order to speedup the parser and store less data, handle fs/cgroup exceptions a lot earlier. Signed-off-by:
-
Mauro Carvalho Chehab authored
The search algorithm used inside check_undefined_symbols has an optimization: it seeks only whats that have the same leave name. This helps not only to speedup the search, but it also allows providing a hint about a partial match. There's a drawback, however: when "what:" finishes with a wildcard, the logic will skip the what, reporting it as "not found". Fix it by grouping the remaining cases altogether, and disabing any hints for such cases. Signed-off-by:
-
Mauro Carvalho Chehab authored
The output of this script can be too big. Add an option to filter out results, in order to help finding issues at the ABI files. Signed-off-by:
-
Mauro Carvalho Chehab authored
The way sysfs works is that the same leave may be present under /sys/devices, /sys/bus and /sys/class, etc, linked via soft symlinks. To make it harder to parse, the ABI definition usually refers only to one of those locations. So, improve the logic in order to retrieve the symlinks. Signed-off-by:
-
Mauro Carvalho Chehab authored
Check for the symbols that exists under /sys but aren't defined at Documentation/ABI. Signed-off-by:
-
Mauro Carvalho Chehab authored
Using a comma here is problematic, as some What: expressions may already contain a comma. So, use \xac character instead. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Acked-by:
Richard Cochran <richardcochran@gmail.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
%x is not a valid wildcard. Use <x> instead, as this allows script/get_abi.pl to convert it into a regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Acked-by:
Peter Rosin <peda@axentia.se> Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Acked-by:
Johan Hovold <johan@kernel.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Reviewed-by:
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Acked-by:
Bjorn Helgaas <bhelgaas@google.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Acked-by:
Jason Gunthorpe <jgg@nvidia.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
In order to let script/get_abi.pl to convert it into a Regex, replace the three "..." at the end, meaning a wildcard to a real filesystem wildcard. Signed-off-by:
-
Mauro Carvalho Chehab authored
This what: /sys/class/typec/<port>-partner>/identity/ Contains an extra ">" character. Remove it. Reviewed-by:
Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
If both /sys/fs/pstore/... and /dev/pstore/... are possible, it should use, instead, two What: fields. Acked-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
On most ABI files, the wildcards are used as <x>, instead of (x). Replace it to make it using a more standard wildcard. That helps get_abi.pl to convert it into a regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
On most ABI files, the wildcards are used as <x>, instead of (x). Replace it to make it using a more standard wildcard. That helps get_abi.pl to convert it into a regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
The What: field should have just the location of the ABI. Anything else should be inside the description. This fixes its parsing by get_abi.pl script. Acked-by:
Andrew Donnellan <ajd@linux.ibm.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
While humans may be able to understand that something like: /sys/bus/rapidio/devices/nn:d:iiii could actually mean: /sys/bus/rapidio/devices/00:e:0000 This is something that computers can't easily identify. As get_abi.pl needs to convert it into a regex, change What: lines to: /sys/bus/rapidio/devices/<nn>:<d>:<iiii> Which is the commonly-used pattern on ABI files for wildcards. Signed-off-by:
-
Mauro Carvalho Chehab authored
Change how this expression is defined: /sys/class/tpm/tpmX/pcr-H/N in order to allow get_abi.pl to convert it into this regex: /sys/class/tpm/tpmX/pcr-.*/.* Reviewed-by:
Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
The What: definitions there are wrong, pointing to different locations than what's expected. Reviewed-by:
Mimi Zohar <zohar@linux.ibm.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
the "cache" part of the description is actually a wildcard, as, in practice, this will use per-subsystem names: /sys/kernel/slab/Acpi-Namespace/align /sys/kernel/slab/Acpi-Operand/align /sys/kernel/slab/Acpi-Parse/align ... /sys/kernel/slab/zswap_entry/align Signed-off-by: -
Mauro Carvalho Chehab authored
On almost all ABI documents, variable arguments are declared as <foo_bar>. Change it here too, in order to allow replacing such wildcards by regexes on a scriptable way. Signed-off-by:
-
Mauro Carvalho Chehab authored
On almost all ABI documents, variable arguments are declared as <foo_bar>. Change it here too, in order to allow replacing such wildcards by regexes on a scriptable way. Acked-by:
Rajat Jain <rajatja@google.com> Acked-by:
-
