- 27 Aug, 2017 11 commits
-
-
Arnd Bergmann authored
Making some functions 'static' has uncovered a few functions that have no caller, through the gcc warnings: atomisp/i2c/imx/imx.c:1111:12: error: 'imx_t_focus_vcm' defined but not used [-Werror=unused-function] atomisp/i2c/imx/imx.c:1103:12: error: 'imx_vcm_init' defined but not used [-Werror=unused-function] atomisp/i2c/imx/imx.c:1095:12: error: 'imx_vcm_power_down' defined but not used [-Werror=unused-function] atomisp/i2c/imx/imx.c:1087:12: error: 'imx_vcm_power_up' defined but not used [-Werror=unused-function] All four of these can be removed. Since they call indirect functions, I also looked at how those are used in turn: - The power_up/power_down callbacks are called from other functions and are still needed. - The t_focus_vcm callbacks pointers are completely unused and can be removed in both imx and ov8858. Some of the handlers are called directly and can now be marked static, the others are dummy implemntations that we can remove. - vcm_init is unused in imx, but dw9718_vcm_init is used in ov8858, but is not used in imx, so that one needs to stay around. The callback pointers in imx can be removed. Fixes: 9a5a6911 ("staging: imx: fix non-static declarations") Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@s-opensource.com>
-
Sakari Ailus authored
Add the as3645a flash controller to the DT source. Signed-off-by:
Sebastian Reichel <sebastian.reichel@collabora.co.uk> Acked-by:
Pavel Machek <pavel@ucw.cz> Signed-off-by:
-
Sakari Ailus authored
Add a LED flash class driver for the as3654a flash controller. A V4L2 flash driver for it already exists (drivers/media/i2c/as3645a.c), and this driver is based on that. Signed-off-by:
Jacek Anaszewski <jacek.anaszewski@gmail.com> Signed-off-by:
-
Sakari Ailus authored
Document DT bindings for Analog Devices as3645a flash LED controller which also supports an indicator LED. Signed-off-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Sakari Ailus authored
The v4l2_flash_init() keeps a reference to the ops struct but not to the config struct (nor anything it contains). Document this. Signed-off-by:
Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:
-
Sakari Ailus authored
The V4L2 flash interface allows controlling multiple LEDs through a single sub-devices if, and only if, these LEDs are of different types. This approach scales badly for flash controllers that drive multiple flash LEDs or for LED specific associations. Essentially, the original assumption of a LED driver chip that drives a single flash LED and an indicator LED is no longer valid. Address the matter by registering one sub-device per LED. Signed-off-by:
-
Rui Miguel Silva authored
We are allocating memory for the v4l2 flash configuration structure and leak it in the normal path. Just use the stack for this as we do not use it outside of this function. Also use IS_ERR() instead of IS_ERR_OR_NULL() to check return value from v4l2_flash_init() for it never returns NULL. Fixes: 2870b52b ("greybus: lights: add lights implementation") Reported-by:
Rui Miguel Silva <rmfrfs@gmail.com> Reviewed-by:
Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
Solve the following issues: Documentation/media/uapi/v4l/dev-sliced-vbi.rst:208: ERROR: Content block expected for the "raw" directive; none found. Documentation/media/uapi/v4l/dev-sliced-vbi.rst:216: ERROR: Content block expected for the "raw" directive; none found. Documentation/media/uapi/v4l/pixfmt-packed-rgb.rst:645: ERROR: Content block expected for the "raw" directive; none found. Fixes: 70b074df ("media: fix pdf build with Spinx 1.6") Signed-off-by:
-
Christophe JAILLET authored
Check memory allocation failure and return -ENOMEM in such a case. Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by:
-
Arnd Bergmann authored
A debug printk statement was copied incorrectly into the new csi1 parser code and causes a warning there: drivers/media/platform/omap3isp/isp.c: In function 'isp_probe': include/linux/dynamic_debug.h:134:3: error: 'i' may be used uninitialized in this function [-Werror=maybe-uninitialized] Since there is only one lane, the index is never set. This changes the debug print to always print a zero instead, keeping the original format of the message. Fixes: 9211434b ("media: omap3isp: Parse CSI1 configuration from the device tree") Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by:
-
Mauro Carvalho Chehab authored
Sphinx 1.6 generates some LaTeX code before each table, starting its own environment before calling tabulary, apparently to improve table layout. The problem is that such environment is incompatible with adjustbox. While, in thesis, it should be possible to override it or to redefine tabulary, I was unable to produce such patch. Also, that would likely break on some future Sphinx version. So, instead, let's just change the font size on bigger tables, in order for them to fit into the page size. That is not as good as adjustbox, and require some manual work, but it should be less sensitive to Sphinx changes. While here, adjust a few other tables whose text is exceeding the cell boundaries. Signed-off-by:
-
- 26 Aug, 2017 29 commits
-
-
Mauro Carvalho Chehab authored
As reported by smatch: drivers/media/platform/qcom/camss-8x16/camss-vfe.c:1136 vfe_release_wm() error: buffer overflow 'vfe->wm_output_map' 7 <= 7 Signed-off-by: -
Mauro Carvalho Chehab authored
Fix those warnings when building on i386: drivers/media/platform/qcom/camss-8x16/camss-csiphy.c:333:22: warning: constant 1000000000000 is so big it is long long drivers/media/platform/qcom/camss-8x16/camss-csiphy.c:339:32: warning: constant 1000000000000 is so big it is long long Signed-off-by: -
Todor Tomov authored
Add abbreviations explanation at the top header blocks in source files. Signed-off-by:
Todor Tomov <todor.tomov@linaro.org> Signed-off-by:
-
Todor Tomov authored
Add explanations for VFE's PIX and RDI interfaces. Signed-off-by:
-
Todor Tomov authored
Update the Qualcomm Camera Subsystem driver document with a media controller pipeline graph diagram. Signed-off-by:
-
Todor Tomov authored
Use standard V4L2 control to get pixel clock rate from a sensor linked in the media controller pipeline. Then calculate clock rates on CSIPHY, CSID and VFE to use the lowest possible. If the currnet pixel clock rate of the sensor cannot be read then use the highest possible. This case covers also the CSID test generator usage. If VFE is already powered on by another pipeline, check that the current VFE clock rate is high enough for the new pipeline. If not return busy error code as VFE clock rate cannot be changed while VFE is running. Signed-off-by:
-
Todor Tomov authored
Update the Qualcomm Camera Subsystem driver document for VFE scale and crop modules support. Signed-off-by:
-
Todor Tomov authored
Add crop module configuration support to be able to apply cropping. Signed-off-by:
-
Todor Tomov authored
Extend selection ioctls to handle cropping configuration. Signed-off-by:
-
Todor Tomov authored
Add scaler module configuration support to be able to apply scaling. Signed-off-by:
-
Todor Tomov authored
Add compose selection ioctls to handle scaling configuration. Signed-off-by:
-
Todor Tomov authored
Add support for horizontal and vertical frame padding. Signed-off-by:
-
Todor Tomov authored
Update Qualcomm Camera Subsystem driver document for the PIX interface and format conversion support. Signed-off-by:
-
Todor Tomov authored
Use VFE PIX input interface and do format conversion in VFE. Supported input format is UYVY (single plane YUV 4:2:2) and its different sample order variations. Supported output formats are: - NV12/NV21 (two plane YUV 4:2:0) - NV16/NV61 (two plane YUV 4:2:2) Signed-off-by:
-
Todor Tomov authored
Add Makefile and update platform/Kconfig and platform/Makefile to enable building of the QCom CAMSS driver. Signed-off-by:
-
Todor Tomov authored
These files implement the platform driver code. Signed-off-by:
-
Todor Tomov authored
These files handle the video device nodes of the camss driver. Signed-off-by:
-
Todor Tomov authored
These files control the VFE module. The VFE has different input interfaces. The PIX input interface feeds the input data to an image processing pipeline. Three RDI input interfaces bypass the image processing pipeline. The VFE also contains the AXI bus interface which writes the output data to memory. RDI interfaces are supported in this version. PIX interface is not supported. Signed-off-by:
-
Todor Tomov authored
These files control the ISPIF module which handles the routing of the data streams from the CSIDs to the inputs of the VFE. Signed-off-by:
-
Todor Tomov authored
These files control the CSID modules which handle the protocol and application layer of the CSI2 receivers. Signed-off-by:
-
Todor Tomov authored
These files control the CSIPHY modules which are responsible for the physical layer of the CSI2 receivers. Signed-off-by:
-
Todor Tomov authored
Add a document to describe Qualcomm Camera Subsystem driver. Signed-off-by:
-
Todor Tomov authored
Add an entry for Qualcomm Camera subsystem driver. Signed-off-by:
-
Todor Tomov authored
Add DT binding document for Qualcomm Camera subsystem driver. CC: Rob Herring <robh+dt@kernel.org> CC: devicetree@vger.kernel.org Signed-off-by:
-
Sakari Ailus authored
These formats are compressed 12-bit raw bayer formats with four different pixel orders. They are similar to 10-bit variants. The formats added by this patch are V4L2_PIX_FMT_SBGGR12P V4L2_PIX_FMT_SGBRG12P V4L2_PIX_FMT_SGRBG12P V4L2_PIX_FMT_SRGGB12P Signed-off-by:
-
Gustavo A. R. Silva authored
Call function v4l2_m2m_dst_buf_remove_by_buf() instead of v4l2_m2m_src_buf_remove_by_buf() Addresses-Coverity-ID: 1415317 Signed-off-by:
Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by:
Stanimir Varbanov <stanimir.varbanov@linaro.org> Signed-off-by:
Hans Verkuil <hansverk@cisco.com> Cc: <stable@vger.kernel.org> # for v4.13 Signed-off-by:
-
Colin Ian King authored
The calculation of the left volume looks suspect, the value of 0x1f - ((val << 8) & 0x1f) is always 0x1f. The debug prior to the assignment of value[1] prints the left volume setting using the calculation 0x1f - (val >> 8) & 0x1f which looks correct to me. Fix the left volume by using the correct expression as used in the debug. Detected by CoverityScan, CID#146140 ("Wrong operator used") Fixes: 850d24a5 ("[media] em28xx-alsa: add mixer support for AC97 volume controls") Signed-off-by:Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Arvind Yadav authored
videobuf_queue_ops are not supposed to change at runtime. All functions working with videobuf_queue_ops provided by <media/videobuf-core.h> work with const videobuf_queue_ops. So mark the non-const structs as const. Signed-off-by:
Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by:
-
Arvind Yadav authored
videobuf_queue_ops are not supposed to change at runtime. All functions working with videobuf_queue_ops provided by <media/videobuf-core.h> work with const videobuf_queue_ops. So mark the non-const structs as const. Signed-off-by:
-
