1. 20 Aug, 2019 1 commit
  2. 15 May, 2019 27 commits
  3. 02 May, 2019 1 commit
  4. 16 Apr, 2019 1 commit
    • Rikard Falkeborn's avatar
      tools lib traceevent: Fix missing equality check for strcmp · f32c2877
      Rikard Falkeborn authored
      There was a missing comparison with 0 when checking if type is "s64" or
      "u64". Therefore, the body of the if-statement was entered if "type" was
      "u64" or not "s64", which made the first strcmp() redundant since if
      type is "u64", it's not "s64".
      
      If type is "s64", the body of the if-statement is not entered but since
      the remainder of the function consists of if-statements which will not
      be entered if type is "s64", we will just return "val", which is
      correct, albeit at the cost of a few more calls to strcmp(), i.e., it
      will behave just as if the if-statement was entered.
      
      If type is neither "s64" or "u64", the body of the if-statement will be
      entered incorrectly and "val" returned. This means that any type that is
      checked after "s64" and "u64" is handled the same way as "s64" and
      "u64", i.e., the limiting of "val" to fit in for example "s8" is never
      reached.
      
      This was introduced in the kernel tree when the sources were copied from
      trace-cmd in commit f7d82350
      
       ("tools/events: Add files to create
      libtraceevent.a"), and in the trace-cmd repo in 1cdbae6035cei
      ("Implement typecasting in parser") when the function was introduced,
      i.e., it has always behaved the wrong way.
      
      Detected by cppcheck.
      Signed-off-by: default avatarRikard Falkeborn <rikard.falkeborn@gmail.com>
      Reviewed-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
      Cc: Tzvetomir Stoyanov <tstoyanov@vmware.com>
      Fixes: f7d82350 ("tools/events: Add files to create libtraceevent.a")
      Link: http://lkml.kernel.org/r/20190409091529.2686-1-rikard.falkeborn@gmail.com
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      f32c2877
  5. 01 Apr, 2019 10 commits