Commits · 4f564f4f9fdd4d120ee04678b0c22e40cc8b6b47 · Kirill Smelkov / linux

21 Jan, 2024 7 commits

bcachefs: bch2_prt_compression_type() · 4f564f4f

Kent Overstreet authored Jan 06, 2024

bounds checking helper, since compression types are extensible
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

4f564f4f

bcachefs: helpers for printing data types · e58f963c

Kent Overstreet authored Jan 06, 2024

We need bounds checking since new versions may introduce new data types.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

e58f963c

bcachefs: BTREE_TRIGGER_ATOMIC · 38c23fb8

Kent Overstreet authored Jan 07, 2024

Add a new flag to be explicit about when we're running atomic triggers.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

38c23fb8

bcachefs: drop to_text code for obsolete bps in alloc keys · 9d5dba2b
Kent Overstreet authored Jan 06, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
9d5dba2b
bcachefs: eytzinger_for_each() declares loop iter · 3fe8a186
Kent Overstreet authored Jan 06, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
3fe8a186

bcachefs: Don't log errors if BCH_WRITE_ALLOC_NOWAIT · 4ecad0da

Kent Overstreet authored Jan 10, 2024

Previously, we added logging in the write path to ensure that any
unexpected errors getting reported to userspace have a log message; but
BCH_WRITE_ALLOC_NOWAIT is a special case, it's used for promotes where
errors are expected and not reported out to userspace - so we need to
silence those.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

4ecad0da

bcachefs: fix memleak in bch2_split_devs · e240c1b3

Su Yue authored Jan 08, 2024

The pointer dev_name can be modified by strseq(),
then causes the memleak:

unreferenced object 0xffff9d08a2916c80 (size 32):
  comm "mount.bcachefs", pid 9090, jiffies 4295856224 (age 17.564s)
  hex dump (first 32 bytes):
    2f 64 65 76 2f 6d 61 70 70 65 72 2f 74 65 73 74  /dev/mapper/test
    2d 30 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -0..............
  backtrace:
    [<00000000c5d3be7d>] __kmem_cache_alloc_node+0x1f3/0x2c0
    [<0000000052215d26>] __kmalloc_node_track_caller+0x51/0x150
    [<0000000069fea956>] kstrdup+0x32/0x60
    [<000000000877fcf1>] bch2_split_devs+0x3f/0x150 [bcachefs]
    [<000000007ee93204>] bch2_mount+0xcb/0x640 [bcachefs]
    [<000000002dd1e04b>] legacy_get_tree+0x30/0x60
    [<000000006afc31d3>] vfs_get_tree+0x28/0xf0
    [<000000007b0c538e>] path_mount+0x475/0xb60
    [<0000000092de5882>] __x64_sys_mount+0x105/0x140
    [<0000000054fc05d8>] do_syscall_64+0x42/0xf0
    [<00000000df584910>] entry_SYSCALL_64_after_hwframe+0x6e/0x76

Fix it by copy pointer dev_name at beginning and free the copied
pointer at end.
Signed-off-by: Su Yue <glass.su@suse.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

e240c1b3

06 Jan, 2024 33 commits
- bcachefs: eytzinger0_find() search should be const · 169de419
  Kent Overstreet authored Jan 05, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  169de419
- bcachefs: move "ptrs not changing" optimization to bch2_trigger_extent() · f5d4481c
  Kent Overstreet authored Dec 28, 2023
```
This is useful for btree ptrs as well, when we're just updating
sectors_written.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  f5d4481c
- bcachefs: fix simulateously upgrading & downgrading · e7999235
  Kent Overstreet authored Jan 05, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  e7999235
- bcachefs: Restart recovery passes more reliably · 72e2c920
  Kent Overstreet authored Jan 05, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  72e2c920
- bcachefs: bch2_dump_bset() doesn't choke on u64s == 0 · d04d2727
  Kent Overstreet authored Jan 05, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  d04d2727
- bcachefs: improve checksum error messages · 4819b66e
  Kent Overstreet authored Jan 05, 2024
```
new helpers:
 - bch2_csum_to_text()
 - bch2_csum_err_msg()

standardize our checksum error messages a bit, and print out the
checksums a bit more nicely.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  4819b66e
- bcachefs: improve validate_bset_keys() · 2d02bfb0
  Kent Overstreet authored Jan 05, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  2d02bfb0
- bcachefs: print sb magic when relevant · 5e448c48
  Kent Overstreet authored Jan 05, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  5e448c48
- bcachefs: __bch2_sb_field_to_text() · 5b883656
  Kent Overstreet authored Jan 05, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  5b883656
- bcachefs: %pg is banished · 1f5af5fc
  Kent Overstreet authored Jan 05, 2024
```
not portable to userspace
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  1f5af5fc
- bcachefs: Improve would_deadlock trace event · c13fbb7d
  Kent Overstreet authored Jan 04, 2024
```
We now include backtraces for every thread involved in the cycle.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  c13fbb7d
- bcachefs: fsck_err()s don't need to manually check c->sb.version anymore · 074cbcda
  Kent Overstreet authored Jan 03, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  074cbcda
- bcachefs: Upgrades now specify errors to fix, like downgrades · 15eaaa4c
  Kent Overstreet authored Jan 03, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  15eaaa4c
- bcachefs: no thread_with_file in userspace · d641d4ca
  Kent Overstreet authored Jan 03, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  d641d4ca
- bcachefs: Don't autofix errors we can't fix · a64a3733
  Kent Overstreet authored Jan 03, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  a64a3733
- bcachefs: add missing bch2_latency_acct() call · e9bc59f9
  Kent Overstreet authored Jan 03, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  e9bc59f9
- bcachefs: increase max_active on io_complete_wq · 4798bd24
  Kent Overstreet authored Jan 03, 2024
```
this definitely should _not_ be 1, and we don't actually want any
concurrency limiting at all here - btree node read completions are
getting blocked behind btree node write submissions.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  4798bd24
- bcachefs: add time_stats for btree_node_read_done() · c72e4d7a
  Kent Overstreet authored Jan 03, 2024
```
Seeing weird latency issues in the btree node read path - add one
bch2_btree_node_read_done().
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  c72e4d7a
- bcachefs: don't clear accessed bit in btree node fill · b819f308
  Kent Overstreet authored Jan 03, 2024
```
Seeing strange performance issues that might be caused by memory
pressure causing prefetched nodes to be evicted before they're used.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  b819f308
- bcachefs: Add an option to control btree node prefetching · 49a5192c
  Kent Overstreet authored Jan 03, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  49a5192c
- bcachefs: kill useless return ret · 8a0dda6f
  Kent Overstreet authored Jan 03, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  8a0dda6f
- bcachefs: Combine .trans_trigger, .atomic_trigger · f0431c5f
  Kent Overstreet authored Dec 31, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  f0431c5f
- bcachefs: unify extent trigger · 4f9ec59f
  Kent Overstreet authored Dec 28, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  4f9ec59f
- bcachefs: bch2_trigger_stripe_ptr() · 5a82ec3f
  Kent Overstreet authored Dec 29, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  5a82ec3f
- bcachefs: Online fsck can now fix errors · d55ddf6e
  Kent Overstreet authored Dec 31, 2023
```
BCH_FS_fsck_done -> BCH_FS_fsck_running; set when we might be fixing
fsck errors. Also; set fix_errors to ask by default when fsck is
running.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  d55ddf6e
- bcachefs: bch2_trigger_pointer() · 1f34c21b
  Kent Overstreet authored Dec 29, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  1f34c21b
- bcachefs: unify stripe trigger · e4eb3e5a
  Kent Overstreet authored Dec 28, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  e4eb3e5a
- bcachefs: move stripe triggers to ec.c · f4f78779
  Kent Overstreet authored Dec 28, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  f4f78779
- bcachefs: unify alloc trigger · 153d1c63
  Kent Overstreet authored Dec 28, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  153d1c63
- bcachefs: move bch2_mark_alloc() to alloc_background.c · 6820ac2c
  Kent Overstreet authored Dec 28, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  6820ac2c
- bcachefs: unify reservation trigger · 6cacd0c4
  Kent Overstreet authored Dec 28, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  6cacd0c4
- bcachefs: unify reflink_p trigger · 7bc4d18a
  Kent Overstreet authored Dec 28, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  7bc4d18a
- bcachefs: unify inode trigger · 08bc9590
  Kent Overstreet authored Dec 28, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  08bc9590