- 06 Apr, 2016 12 commits
-
-
Jesse Brandeburg authored
BugLink: http://bugs.launchpad.net/bugs/1547674 The probe routine already had a u32 val declared, no need to do it again. Found by W=2 compile. Change-ID: Id7b65f6d0ef6bb71067d0557f5be0202b6d8741e Signed-off-by:
Jesse Brandeburg <jesse.brandeburg@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from net-next commit f3699b3c ) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Catherine Sullivan authored
BugLink: http://bugs.launchpad.net/bugs/1547674 Bump. Change-ID: I21aa520a3c8c5f4f562a98019bf8b76b3706c480 Signed-off-by:
Catherine Sullivan <catherine.sullivan@intel.com> Tested-by:
-
Jesse Brandeburg authored
BugLink: http://bugs.launchpad.net/bugs/1547674 Probe routine already has too many locals, just convert one used for kzalloc into a kcalloc, eliminating the local. Change-ID: I349049872b71f858cbeb91ad7836e6767fc7b7d1 Signed-off-by:
Anjali Singhai <anjali.singhai@intel.com> Tested-by:
-
Mitch Williams authored
BugLink: http://bugs.launchpad.net/bugs/1547674 Sometimes, ARQ overflows are a big deal and tell us that the firmware/hardware/driver/something is having problems. But normally they're no big deal. To assist in assessing this, add a counter to our Ethtool stats. A handful of ARQ overflows during VF init is no problem. A large, ever-growing number indicates that Something Bad is happening. Change-ID: Ie5348bfbc8a54a890559cb00279c28d976a55096 Signed-off-by:
Mitch Williams <mitch.a.williams@intel.com> Tested-by:
-
Catherine Sullivan authored
BugLink: http://bugs.launchpad.net/bugs/1547674 Add some missing reporting/advertisement of 100Mb capability for adapters that support it. Change-ID: I8b8523fbdc99517bec29d90c71b3744db11542ac Signed-off-by:
-
Jesse Brandeburg authored
BugLink: http://bugs.launchpad.net/bugs/1547674 As done per ixgbe, use a private workqueue to avoid blocking the system workqueue. This avoids some strange side effects when some other entity is depending on the system work queue. Change-ID: Ic8ba08f5b03696cf638b21afd25fbae7738d55ee Signed-off-by:
-
Anjali Singhai Jain authored
BugLink: http://bugs.launchpad.net/bugs/1547674 This patch adds another way to access the RSS keys and lut using the AQ for X722 devices. Signed-off-by:
-
Anjali Singhai Jain authored
BugLink: http://bugs.launchpad.net/bugs/1547674 Add the KX and QSFP device IDs for X722. Signed-off-by:
-
Catherine Sullivan authored
BugLink: http://bugs.launchpad.net/bugs/1547674 Bump. Change-ID: Ic9a495feb9ab0606f953c3848b0acf67169d3930 Signed-off-by:
-
Jesse Brandeburg authored
BugLink: http://bugs.launchpad.net/bugs/1547674 Synchronize code bases and add SCTP offload support. Change-ID: I9f99071f7176225479026930c387bf681a47494e Signed-off-by:
-
Anjali Singhai Jain authored
BugLink: http://bugs.launchpad.net/bugs/1547674 The restart-autoneg work around does not apply to X722. Added a flag to set it only for the right MAC and right FW version where the work around should be applied. Signed-off-by:
-
Kiran Patil authored
BugLink: http://bugs.launchpad.net/bugs/1547674 Add MAC filter element to the end of the list in the given order, just to be tidy, and just in case there are ever any ordering issues in the future. Change-ID: Idc15276147593ea9393ac72c861f9c7905a791b4 Signed-off-by:
Kiran Patil <kiran.patil@intel.com> Tested-by:
-
- 29 Feb, 2016 28 commits
-
-
Eric Dumazet authored
Fixes following build warnings : drivers/net/ethernet/intel/i40e/i40e_main.c:7057:13: warning: 'i40e_sync_udp_filters_subtask' defined but not used [-Wunused-function] drivers/net/ethernet/intel/i40e/i40e_main.c:8524:13: warning: 'i40e_add_vxlan_port' defined but not used [-Wunused-function] drivers/net/ethernet/intel/i40e/i40e_main.c:8569:13: warning: 'i40e_del_vxlan_port' defined but not used [-Wunused-function] drivers/net/ethernet/intel/i40e/i40e_main.c:8604:13: warning: 'i40e_add_geneve_port' defined but not used [-Wunused-function] drivers/net/ethernet/intel/i40e/i40e_main.c:8651:13: warning: 'i40e_del_geneve_port' defined but not used [-Wunused-function] Fixes: 6a899024 ("i40e: geneve tunnel offload support") Signed-off-by:
Eric Dumazet <edumazet@google.com> Tested-by:
-
Jesse Brandeburg authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Somehow an ID that has never been productized is in the code. There are no plans to use it, so just get rid of it. Change-ID: I59117d48ea9ee0360b0fe33833ac8092f8a24b4c Signed-off-by:
-
Sowmini Varadhan authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This is the i40e equivalent of commit c762dff2 ("ixgbe: Look up MAC address in Open Firmware or IDPROM"). As with that fix, attempt to look up the MAC address in Open Firmware on systems that support it, and use IDPROM on SPARC if no OF address is found. In the case of the i40e there is an assumption that the default mac address has already been set up as the primary mac filter on probe, so if this filter is obtained from the Open Firmware or IDPROM, an explicit write is needed via i40e_aq_mac_address_write() and i40e_aq_add_macvlan() invocation. The I40E_FLAG_PF_MAC flag in the platform-private i40e_pf structure tracks whether a platform-specific mac address was found, in which case calls to i40e_aq_mac_address_write() and i40e_aq_add_macvlan() will be triggered. Reviewed-by:
Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by:
Sowmini Varadhan <sowmini.varadhan@oracle.com> Acked-by:
Shannon Nelson <shannon.nelson@intel.com> Tested-by:
-
Singhai, Anjali authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch adds a call to geneve_get_rx_port in i40e so that when it comes up it can learn about the existing geneve tunnels. Signed-off-by:
David S. Miller <davem@davemloft.net> (cherry picked from commit cd866606 ) Signed-off-by:
-
Singhai, Anjali authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch adds driver hooks to implement ndo_ops to add/del udp port in the HW to identify GENEVE tunnels. Signed-off-by:
-
Catherine Sullivan authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Bump. Change-ID: I2b8976bde070244de144e2ed8990b083de39f332 Signed-off-by:
-
Shannon Nelson authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Clean the whole mac filter list when resetting after an intermediate add or delete push to the firmware. The code had evolved from using a list from the stack to a heap allocation, but the memset() didn't follow the change correctly. This now cleans the whole list rather that just part of the first element. Change-ID: I4cd03d5a103b7407dd8556a3a231e800f2d6f2d5 Reported-by:
Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by:
-
Mitch Williams authored
BugLink: http://bugs.launchpad.net/bugs/1536474 These messages seem big and scary, but they're really not. The driver can fully recover from any of these. The overflow error in particular can happen when enabling a bunch of VFs and the VF driver is not blacklisted. Since these messages are really for debugging purposes, reclassify them as such. Change-ID: I628d0f5e135e7063450ba05393a50b7af23aa6d7 Signed-off-by:
-
Michal Kosiarz authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This is a part of implementation which contains data structures and opcode for new AQ command. There's a new ARQ message that gets sent near the end of the NVM update process that the driver should recognize and ignore, rather than printing an Unknown Event error. Change-ID: I04830a5bcae14823e16b9424cc4165e169336c1f Signed-off-by:
Michal Kosiarz <michal.kosiarz@intel.com> Acked-by:
-
Mitch Williams authored
BugLink: http://bugs.launchpad.net/bugs/1536474 The virtual channel interface was using incorrect semantics to remove MAC addresses, which would leave incorrect filters active when using VLANs. To correct this, add a new function that unconditionally removes MAC addresses from all VLANs, and call this function when the VF requests a MAC filter removal. Change-ID: I69826908ae4f6c847f5bf9b32f11faa760189c74 Signed-off-by:
-
Jesse Brandeburg authored
BugLink: http://bugs.launchpad.net/bugs/1536474 BIT_ULL was used on a u32 or less where it can simply be BIT. This fixes some trivial static analyzer warnings. Chomp, chomp. Tested with objdump of binary before and after, no changes to code. Change-ID: I6245e9abd447192dbde1669c747aeb2878126c7d Signed-off-by:
-
Singhai, Anjali authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This reverts commit 8fe26999 . The case where VXLAN is a module and i40e driver is inbuilt will not be handled properly with this change since i40e will have an undefined symbol vxlan_get_rx_port in it. v2: Add a signed-off-by. Signed-off-by:
-
Joe Perches authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Commit 7fd89545 ("i40e: remove BUG_ON from feature string building") added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in function i40e_print_features. Fix it. Miscellanea: - Remove unnecessary string variable - Add space before not after fixed strings - Use kmalloc not kzalloc - Don't initialize i to 0, use result of first snprintf Reported-by:
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Catherine Sullivan authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Bump. Change-ID: Id8c83c64c973349a722bab40d285ad8ded8c28f7 Signed-off-by:
-
Neerav Parikh authored
BugLink: http://bugs.launchpad.net/bugs/1536474 The separate functions to gather Flow control Rx XOFF stats was to determine if the Tx for a queue was paused due to Link Flow Control(LFC) or Priority Flow Control(PFC). But, with recent change in the i40e driver the logic for checking th Tx hang has been removed and these functions don't do anything meaningful. Hence, there is no need to keep these separate functions to gather Rx XOFF stats for LFC or PFC. This patch removes these functions and moves the stat collection for XOFF Rx to the i40e_update_pf_stats() that collects all the PF stats. Change-ID: Iec1452dac3a6766f0d968e754cb407530d7c60cd Signed-off-by:
Neerav Parikh <neerav.parikh@intel.com> Tested-by:
-
Jesse Brandeburg authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Instead of having our own custom symbol, we can just rely on whether or not the kernel has the feature enabled. In this case use IS_ENABLED(CONFIG_VXLAN) in order to handle built-in or module in the current BKM way. Change-ID: I5890fbb518ff8ed6bb07c3362fb0a8a829f9b241 Signed-off-by:
-
Mitch Williams authored
BugLink: http://bugs.launchpad.net/bugs/1536474 i40e_sync_vsi_filters() is the surly teenager of this driver. It says it's going to report errors, but it doesn't actually do that most of the time. And when it does, it leaves a mess. Change this function to have a common exit point so it will properly release the busy lock on the VSI. Propagate errors to the callers. Finally, adjust a few callers to check for and deal with errors from this function. Change-ID: Ic6af4956491e72402ebb3c538a3c31a0ad7f8667 Signed-off-by:
-
Kiran Patil authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch contains following changes: - detection and recovery logic (issue SW interrupt) has been moved to service_task from timeout function. - added some more debug info from tx_timeout. Logic to detect and recover TX queue hung is now two step process: - service_task detects TX queue hung and sets a bit(hung_detected) if it was not set. - if bit was set (means this is back-back hung condition detected), issue SW interrupt and clear the bit. - napi_poll clears the bit unconditionally since it cleans TX/RX queues. Change-ID: Ieed03a48927c845a988b3ff375090bf37caeb903 Signed-off-by:
-
Jesse Brandeburg authored
BugLink: http://bugs.launchpad.net/bugs/1536474 With the final edition of the patches to remove sleeps from the driver's entry points, the grab_rtnl argument is no longer needed, so partially revert the commit that added it. Change-ID: Ib9778476242586cc9e58b670f5f48d415cb59003 Signed-off-by:
-
Jesse Brandeburg authored
BugLink: http://bugs.launchpad.net/bugs/1536474 The driver was being called by VLAN, bonding, teaming operations that expected to be able to hold locks like rcu_read_lock(). This causes the driver to be held to the requirement to not sleep, and was found by the kernel debug options for checking sleep inside critical section, and the locking validator. Change-ID: Ibc68c835f5ffa8ffe0638ffe910a66fc5649a7f7 Signed-off-by:
-
Catherine Sullivan authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Bump. Change-ID: I00ebbb2e5e5572f947502b8f6db4d94f666d6b14 Signed-off-by:
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch fixes the confusing kernel message of enabled RSS size, by reporting it together with the hardware maximum RSS size. Change-ID: I64864dbfbc13beccc180a7871680def1f3d5a339 Signed-off-by:
Helin Zhang <helin.zhang@intel.com> Tested-by:
-
Carolyn Wyborny authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch fixes an issue where adminq init failures always provided a message that NVM was newer than expected. This is not always the case for init_adminq failures. Without this patch, if adminq init fails for any reason, newer NVM message would be given. This problem is fixed by adding a check for that specific error condition and a different hopefully helpful message otherwise. Change-ID: Iaeaebee4e398989eae40bb70f943ab66a3a521a5 Signed-off-by:
Carolyn Wyborny <carolyn.wyborny@intel.com> Tested-by:
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch renames rss_size to alloc_rss_size in i40e_pf, which is clearer and avoids confusion. It also adds comments to the other related structure members to help clarify usage. Change-ID: Ia90090609d006ab589cb639975bb8a0af795d16f Signed-off-by:
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch adds new fields to i40e_vsi to store user configured RSS config data and code to use it. Signed-off-by:
-
Catherine Sullivan authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Bump. Change-ID: I2d1ce93b2ce74e4eef2394c932aef52cba99713f Signed-off-by:
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch renames the old pf-specific function in order to clarify its scope. This patch also creates a more generic configure RSS function with the old name. This patch also creates a new more generic function to get RSS configuration, using the appropriate method. Change-ID: Ieddca2707b708ef19f1ebccdfd03a0a0cd63d3af Signed-off-by:
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Adjust the RSS configure functions so that there is a generic way to hook to ethtool hooks. Change-ID: If446e34fcfaf1bc3320d9d319829a095b5976e67 Signed-off-by:
-
