- 22 Jan, 2015 3 commits
-
-
Viresh Kumar authored
Request type for all other protocols is defined like: GB_<protocol>_TYPE_<operation>, but for UART is like: GB_<protocol>_REQ_<operation>. Replace REQ with TYPE to make it consistent. It will also be useful in a later patch that creates get_version() routines with the help of a macro. Signed-off-by:
Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by:
Alex Elder <elder@linaro.org> Signed-off-by:
Greg Kroah-Hartman <greg@kroah.com>
-
Viresh Kumar authored
Some files are still prefixed with "gb-" with the reasoning that the modules would be named so, i.e. gb-*.ko. But this can be done by playing a bit in Makefile instead and keep uniform naming of .c files. Lets try it. Signed-off-by:
-
Viresh Kumar authored
Some files are prefixed with "gb-" and some are suffixed with "-gb". The rationale behind the first one is that the modules would be named so, i.e. gb-*.ko. But there is no reason to keep the "-gb" suffix in the second case. Remove the unnecessary suffix. Signed-off-by:
-
- 21 Jan, 2015 5 commits
-
-
Greg Kroah-Hartman authored
This is just a copy of ES1 for now, things will start to diverge soon. Any common functionality will be factored out over time. Signed-off-by: -
Greg Kroah-Hartman authored
In next_free_urb(), just return usb_alloc_urb(), don't waste the time assigning it to a local variable that we then return. Signed-off-by: -
Rui Miguel Silva authored
in protocol register replace the protocol find code with the call to the already existing function. Signed-off-by:
Rui Miguel Silva <rmfrfs@gmail.com> Signed-off-by:
-
Rui Miguel Silva authored
if error is return when submiting the urb, we need to make sure to release the urb from the pool, or from the dinamicly allocated. As in it, factor out the free code and create the free_urb function. Signed-off-by:
-
Rui Miguel Silva authored
just return the result of usb_alloc_urb up, no need to rededunt check for NULL Signed-off-by:
-
- 16 Jan, 2015 5 commits
-
-
Perry Hung authored
An extra reference is taken out on an operation in gb_operation_request_send(). If the response never arrives, we need to put back the reference. Signed-off-by:
Perry Hung <perry@leaflabs.com> Tested-by:
Mitchell Tasman <tasman@leaflabs.com> Reviewed-by:
-
Perry Hung authored
If an operation is issued and the response never comes back, gb_operation_timeout() cancels the operation but never wakes up the waiter in gb_operation_request_send(). This patch removes the timeout workqueue and changes the request wait to wait_for_completion_interruptible_timeout(), with timeout set to OPERATION_TIMEOUT_DEFAULT. Signed-off-by:
-
Bill Pemberton authored
offset is defined as unsigned so there is no point checking for negative values of offset. Signed-off-by:
Bill Pemberton <wfp5p@worldbroken.com> Signed-off-by:
-
Bill Pemberton authored
Signed-off-by:
-
Bill Pemberton authored
val is an unsigned long so there is no point in checking if it is less than zero. Signed-off-by:
-
- 15 Jan, 2015 6 commits
-
-
Greg Kroah-Hartman authored
This .c file isn't needed by the kernel driver, it's there for firmware developers only, so just move it into the Documentation directory to reduce confusion. Signed-off-by:
-
Greg Kroah-Hartman authored
Use the "gb-" prefix for the ES1 Host controller driver. Signed-off-by:
-
Greg Kroah-Hartman authored
Use the "gb" prefix for module names, not a suffix. Signed-off-by:
-
Greg Kroah-Hartman authored
Use the "gb" prefix for module names, not a suffix. Signed-off-by:
-
Greg Kroah-Hartman authored
This module provides the Bridged PHY protocols, so name the thing properly. Signed-off-by:
-
Greg Kroah-Hartman authored
Provide an install Makefile target for those that want to install the kernel modules. Signed-off-by:
-
- 14 Jan, 2015 1 commit
-
-
Alexandre Bailon authored
The data_in_size variable was set to 1 for the status byte. But now, the status byte has move to header. Then, the status byte is "allocated" twice and cause bad message size error. Signed-off-by:
Alexandre Bailon <abailon@baylibre.com> Reviewed-by:
-
- 02 Jan, 2015 10 commits
-
-
Greg Kroah-Hartman authored
Right now some sysfs attributes have \n and some do not, so fix that and put \n at the end of all of them to make it easier to parse things properly in userspace. Signed-off-by: -
Greg Kroah-Hartman authored
When removing a connection with no protocol assigned to it, the kernel oopses as we always thought protocols were always there. Fix that problem, oopses are bad. Signed-off-by:
-
Greg Kroah-Hartman authored
We want to be able to "blame" a protocol for things at times, so give them a name we can refer to them by. Announce when they are added or removed from the system so we have a chance to know what is going on in the kernel logs. Signed-off-by:
-
Greg Kroah-Hartman authored
Use the list that the driver core keeps of our structure, no need to duplicate it with a local list as well. This gets rid of a static lock too, always a nice thing to do. Signed-off-by:
-
Greg Kroah-Hartman authored
The i2c protocol belongs in the gpbridge driver, so move it there. Signed-off-by:
-
Greg Kroah-Hartman authored
This bundles together the existing GP Bridged PHY protocols that were part of the Greybus core: USB, UART, SDIO, PWM, and GPIO. This is now a stand-alone kernel module. More logic will be moving here in the future to handle bridged devices. Signed-off-by:
-
Greg Kroah-Hartman authored
This moves the battery class protocol to be a stand-alone kernel module. Signed-off-by:
-
Greg Kroah-Hartman authored
We can't use the gb_protocol_driver() macro here as we need to do some init and exit logic when loading and removing, so "open code" the module init and exit functions. Signed-off-by:
-
Greg Kroah-Hartman authored
Now that protocols can be in a module, we need to reference count them to lock them into memory so they can't be removed while in use. So add a module owner structure, and have it automatically be assigned when registering the protocol. Signed-off-by:
-
Greg Kroah-Hartman authored
Use a "name" for when we don't have a valid device id yet, instead of a magic value of 0xff. Reported-by:
-
- 24 Dec, 2014 5 commits
-
-
Greg Kroah-Hartman authored
This splits the i2c-gb protocol into a stand-alone kernel module. It's not going to stay in this fashion for long, this was done to test the "can a protcol be loaded later" logic. Future refactoring is going to move the gpbridge protocols to a separate kernel module, where this protocol is going to live. But for now, split it out, it is good to test with, and shows a bug in gbsim at the moment. Reviewed-by:
-
Greg Kroah-Hartman authored
When adding a new protocol to the system, walk all bundles and try to hook up any connections that do not have a protocol already. This sets the stage to allow for protocols to be loaded at any time, not just before the device is seen in the system. Reviewed-by:
-
Greg Kroah-Hartman authored
Protocol handlers need some greybus symbols, so export them so that they can be built outside of the greybus core. Reviewed-by:
-
Greg Kroah-Hartman authored
We will want to return this value as a return value for module_init() and bool does not play well with module_init(). So make it a "real" error value and return int and fix up all callers of the function. Reviewed-by:
-
Greg Kroah-Hartman authored
The list was global and had no locking. It's not like we were ever parsing more than one manifest at the same time right now, but we might in the future. And we really want this to be local to the interface itself, for future work redoing how to bind protocols to bundles, so move the list to the interface structure. Reviewed-by:
-
- 23 Dec, 2014 1 commit
-
-
Greg Kroah-Hartman authored
Modules in the greybus system sit above the interface, so insert them early in the sysfs tree. We dynamically create them when we have an interface that references a module, as we don't get a "module create" message directly. They also dynamically go away when the last interface associated with a module is removed. Naming scheme for modules/interfaces/bundles/connections is bumped up by one ':', and now looks like the following: /sys/bus/greybus $ tree . ├── devices │ ├── 7 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7 │ ├── 7:7 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7 │ ├── 7:7:0 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7/7:7:0 │ └── 7:7:0:1 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7/7:7:0/7:7:0:1 ├── drivers ├── drivers_autoprobe ├── drivers_probe └── uevent 6 directories, 3 files /sys/bus/greybus $ grep . devices/*/uevent devices/7/uevent:DEVTYPE=greybus_module devices/7:7/uevent:DEVTYPE=greybus_interface devices/7:7:0/uevent:DEVTYPE=greybus_bundle devices/7:7:0:1/uevent:DEVTYPE=greybus_connection We still have some "confusion" about interface ids and module ids, which will be cleaned up later when the svc control protocol changes die down, right now we just name a module after the interface as we don't have any modules that have multiple interfaces in our systems. This has been tested with gbsim. Signed-off-by:
-
- 19 Dec, 2014 4 commits
-
-
Greg Kroah-Hartman authored
It's a local interface lock, not a modules lock, so rename it. Reviewed-by:
-
Greg Kroah-Hartman authored
This is really a list of interfaces, not modules, so rename it so that we don't get confused when we really do add modules to the whole system later on. Reviewed-by:
-
Greg Kroah-Hartman authored
rename gb_add_module -> gb_add_interface rename gb_remove_modules -> gb_remove_interfaces rename gb_remove_module -> gb_remove_interface And move the function prototypes to interface.h, where they belong. Reviewed-by:
-
Greg Kroah-Hartman authored
Align up the BIT() #defines and properly comment the include block define. Reviewed-by:
-
