- 24 Sep, 2022 40 commits
-
-
Sakari Ailus authored
The return value from register writes is ignored apart from the last value. Fix this. Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@kernel.org>
-
Sakari Ailus authored
The state argument for the functions for obtaining various parts of the state is NULL if it is called by drivers for active state. Fail graciously in that case instead of dereferencing a NULL pointer. Suggested-by:
Bingbu Cao <bingbu.cao@intel.com> Signed-off-by:
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Signed-off-by:
-
Sakari Ailus authored
What the IMGU driver did was that it first acquired the pointers to active and try V4L2 subdev state, and only then figured out which one to use. The problem with that approach and a later patch (see Fixes: tag) is that as sd_state argument to v4l2_subdev_get_try_crop() et al is NULL, there is now an attempt to dereference that. Fix this. Also rewrap lines a little. Fixes: 0d346d2a ("media: v4l2-subdev: add subdev-wide state struct") Cc: stable@vger.kernel.org # for v5.14 and later Signed-off-by:
-
Sakari Ailus authored
ret in ar0521_set_fmt is never set to values other than 0. Replace it with plain 0. Reported-by:
-
Yang Yingliang authored
Return error code if ar0521_write_regs() fails in ar0521_power_on(). Fixes: 852b50ae ("media: On Semi AR0521 sensor driver") Signed-off-by:
Yang Yingliang <yangyingliang@huawei.com> Acked-by:
Krzysztof Hałasa <khalasa@piap.pl> Signed-off-by:
-
Slark Xiao authored
Replace 'the the' with 'the' in the comment. Signed-off-by:
Slark Xiao <slark_xiao@163.com> Reviewed-by:
Jacopo Mondi <jacopo@jmondi.org> Signed-off-by:
-
Alexander Stein authored
The doc says the I²C device's name is used if devname is NULL, but actually the I²C device driver's name is used. Fixes: 06582930 ("media: v4l: subdev: Add a function to set an I²C sub-device's name") Signed-off-by:
Alexander Stein <alexander.stein@ew.tq-group.com> Signed-off-by:
-
Paul Elder authored
Switch to using runtime PM for power management. Make it optional, however, to support ACPI. Signed-off-by:
Paul Elder <paul.elder@ideasonboard.com> Reviewed-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
-
Jean-Michel Hautbois authored
The documentation states that the BNR factor is a multiplier coded as u3.13 and with a range of (0, 8). This is not correct, as the isp is adding 1.0 to the gain applied, ie Pout = { Pin * (1 + Gx) }. It means that a gain of 1.0 should be coded as 0. Signed-off-by:Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com> Reviewed-by:
Kieran Bingham <kieran.bingham@ideasonboard.com> Signed-off-by:
-
Benjamin Gaignard authored
Luma and chroma depth are set on different hardware registers. Even if they aren't identical the bitstream can be compliant to HEVC specifications and decoded by the hardware. With this patch TSUNEQBD_A_MAIN10_Technicolor_2 conformance test is successfully decoded. Signed-off-by:
Benjamin Gaignard <benjamin.gaignard@collabora.com> Reviewed-by:
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Signed-off-by:
Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:
-
Benjamin Gaignard authored
Expose 10bit pixel formats to enable 10bit decoding in IMX8M SoCs. Signed-off-by:
-
Benjamin Gaignard authored
Stop limiting HEVC support to 8-bits bitstreams also accept 10-bits bitstreams. Signed-off-by:
-
Benjamin Gaignard authored
Move output format setting in postproc and make sure that 8/10bit configuration is correctly set. Signed-off-by:
-
Benjamin Gaignard authored
The chroma offset depends of the bitstream depth. Make sure that ctx->bit_depth is used to compute it. Signed-off-by:
-
Benjamin Gaignard authored
SAO and FILTER buffers size depend of the bit depth. Make sure we have enough space for 10bit bitstreams. Signed-off-by:
-
Benjamin Gaignard authored
Store HEVC bit depth in context. Bit depth is equal to hevc sps bit_depth_luma_minus8 + 8. Signed-off-by:
-
Hangyu Hua authored
v4l2_device_unregister need to be called to put the refcount got by v4l2_device_register when vdec_probe fails or vdec_remove is called. Signed-off-by:
Hangyu Hua <hbh25y@gmail.com> Signed-off-by:
-
Rory Liu authored
The Google Kuldax device uses the same approach as the Google Brask which enables the HDMI CEC via the cros-ec-cec driver. Signed-off-by:
Rory Liu <hellojacky0226@hotmail.com> Signed-off-by:
-
Lukas Bulwahn authored
Commit e33fdb5a ("media: saa7146: deprecate hexium_gemini/orion, mxb and ttpci") moves some media drivers to the staging subsystem, and unfortunately only partially adjusts the entry in MAINTAINERS. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a broken reference. As the files matching include/media/drv-intf/saa7146* are moved to drivers/staging/media/deprecated/saa7146/common, this directory is already covered by the existing file entry drivers/staging/media/deprecated/saa7146/. Repair this file reference in SAA7146 VIDEO4LINUX-2 DRIVER. Signed-off-by:
Lukas Bulwahn <lukas.bulwahn@gmail.com> Signed-off-by:
-
Lukas Bulwahn authored
Commit 2a0c2806 ("media: zoran: move to mainline") moves the zoran driver from the staging to the media subsystem, but does not adjust the entry in MAINTAINERS. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a broken reference. Repair this file reference in ZR36067 VIDEO FOR LINUX DRIVER. Signed-off-by:
-
ye xingchen authored
Return the value xc_send_i2c_data() directly instead of storing it in another redundant variable. Signed-off-by:
ye xingchen <ye.xingchen@zte.com.cn> Signed-off-by:
-
Sun Ke authored
mdp_comp_clock_on will increase runtime PM usage counter, and mdp_comp_clock_off will decrease the runtime PM usage counter. so, if mdp_comp_clock_on failed after increment runtime PM usage counter, it should decrease it before return a error code. pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. And if failed to enable clk, add pm_runtime_put() to decrease the runtime PM usage counter. Fixes: 61890cca ("media: platform: mtk-mdp3: add MediaTek MDP3 driver") Signed-off-by:
Sun Ke <sunke32@huawei.com> Signed-off-by:
-
Dan Carpenter authored
Return a negative error code if mdp_vpu_shared_mem_alloc() fails. Fixes: 61890cca ("media: platform: mtk-mdp3: add MediaTek MDP3 driver") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by:
Matthias Brugger <matthias.bgg@gmail.com> Signed-off-by:
-
ye xingchen authored
Return the value v4l2_fh_release() directly instead of storing it in another redundant variable. Signed-off-by:
-
Daniel Lundberg Pedersen authored
v4l2_mmap returns a void*, also link to mmap instead of munmap Signed-off-by:
Daniel Lundberg Pedersen <dlp@qtec.com> Signed-off-by:
-
Moudy Ho authored
Fix two errors reported by smatch: drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c:292 mdp_probe() error: we previously assumed 'mdp' could be null drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c:460 mdp_cmdq_send() error: we previously assumed 'cmd' could be null Also, avoid warnings reported by smatch: drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c:872 mdp_comp_create() warn: passing devm_ allocated variable to kfree. 'comp' [hverkuil: fix devm_kfree call] Signed-off-by:Moudy Ho <moudy.ho@mediatek.com> Signed-off-by:
-
Linus Walleij authored
The driver includes the legacy <linux/gpio.h> header but uses <linux/gpio/consumer.h>. Cc: Dinesh Ram <Dinesh.Ram@cern.ch> Cc: Eduardo Valentin <edubezval@gmail.com> Signed-off-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
-
Linus Walleij authored
This driver is using GPIO descriptors but uses the legacy include header <linux/gpio.h>. Fix it by including the intended <linux/gpio/consumer.h>. Cc: Marek Vasut <marex@denx.de> Signed-off-by:
-
Hans Verkuil authored
Add support for this new CEC message. This was added in HDMI 2.1a. Signed-off-by:
-
Hans Verkuil authored
Fix a compiler warning: drivers/media/dvb-frontends/drxk_hard.c: In function 'drxk_read_ucblocks': drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: 'err' may be used uninitialized [-Wmaybe-uninitialized] 6673 | *ucblocks = (u32) err; | ^~~~~~~~~ drivers/media/dvb-frontends/drxk_hard.c:6663:13: note: 'err' was declared here 6663 | u16 err; | ^~~ Signed-off-by: -
Hans Verkuil authored
The type ops for equal, init and validate have an elems argument, but this can be taken from struct v4l2_ctrl: ctrl->elems for equal and init, and ctrl->new_elems for validate (since you are validating a new control value). So drop this argument and update all callers. Signed-off-by:
-
Ming Qian authored
release m2m ctx in the callback function that release the vpu instance, then there is no need to add lock around releasing m2m ctx. Fixes: 3cd08451 ("media: amphion: add vpu v4l2 m2m support") Signed-off-by:
Ming Qian <ming.qian@nxp.com> Reviewed-by:
Tommaso Merciai <tommaso.merciai@amarulasolutions.com> Signed-off-by:
-
Philipp Zabel authored
coda9_jpeg_dec_huff_setup() never returns anything but 0. Drop return value and superfluous error handling at the call site. Signed-off-by:
Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by:
-
Jilin Yuan authored
Delete the redundant word 'is'. Signed-off-by:
Jilin Yuan <yuanjilin@cdjrlc.com> Signed-off-by:
-
Jilin Yuan authored
Delete the redundant word 'my'. Signed-off-by:
-
Jilin Yuan authored
Delete the redundant word 'for'. Signed-off-by:
-
Hans Verkuil authored
I expect that the hardware will have limited this to 16, but just in case it hasn't, check for this corner case. Signed-off-by:
-
Hans Verkuil authored
I expect that the hardware will have limited this to 16, but just in case it hasn't, check for this corner case. Signed-off-by:
-
Laurent Pinchart authored
The local sd_fmt variable in rkisp1_capture_link_validate() has uninitialized fields, which causes random failures when calling the subdev .get_fmt() operation. Fix it by initializing the variable when declaring it, which zeros all other fields. Signed-off-by:
Dafna Hirschfeld <dafna@fastmail.com> Signed-off-by:
-
Laurent Pinchart authored
The ISP8000Nano v18.02 (found in the i.MX8MP) requires the ISP to be enabled (as indicated by the ISP_CTRL.ISP_ENABLE bit) to configure the lens shading table in internal RAM. The driver currently configures all ISP initial parameters before enabling the ISP, which causes the LSC RAM to not be initialized properly. To fix this, split the rkisp1_params_configure() function into a rkisp1_params_pre_configure() and a rkisp1_params_post_configure(). The former configures all ISP parameters but LSC, while the latter configures LSC. To implement this, the rkisp1_params_apply_params_cfg() function is deconstructed, with two small helpers created to deal with the parameters buffers, which are then used in rkisp1_params_isr(), rkisp1_params_pre_configure() and rkisp1_params_post_configure(). While this initialization ordering is only needed for the ISP8000Nano v18.02, it doesn't affect other ISP versions negatively, and can thus be followed unconditionally. Signed-off-by:
-
