- 18 Jan, 2023 11 commits
-
-
Tom Rix authored
Smatch reports: drivers/scsi/qla2xxx/qla_mid.c:1189:6: warning: symbol 'qla_trim_buf' was not declared. Should it be static? drivers/scsi/qla2xxx/qla_mid.c:1221:6: warning: symbol '__qla_adjust_buf' was not declared. Should it be static? These functions are only used in qla_mid.c, so they should be static. Fixes: 1f8f9c34 ("scsi: qla2xxx: edif: Reduce memory usage during low I/O") Signed-off-by:
Tom Rix <trix@redhat.com> Link: https://lore.kernel.org/r/20230114013724.3943580-1-trix@redhat.comSigned-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
-
Fabio M. De Francesco authored
The use of kmap() is deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as the mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it might block when the mapping space is fully utilized until a slot becomes available. With kmap_local_page() the mappings are per thread, CPU local, can take page faults, and can be called from any context (including interrupts). It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore, the tasks can be preempted and, when they are scheduled to run again, the kernel virtual addresses are restored and still valid. Therefore, replace kmap() with kmap_local_page() in ipr_copy_ucode_buffer() and, instead of open-coding local mappings + memcpy() + local un-mappings, use the better suited memcpy_to_page() helper. Suggested-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Fabio M. De Francesco <fmdefrancesco@gmail.com> Link: https://lore.kernel.org/r/20230103182556.29080-1-fmdefrancesco@gmail.comSigned-off-by:
-
Fabio M. De Francesco authored
kmap_atomic() is deprecated in favor of kmap_local_page(). Therefore, replace kmap_atomic() with kmap_local_page() in ips_is_passthru(). In the meantime remove an unnecessary comment, align code, and remove spaces. kmap_atomic() is implemented like a kmap_local_page() which also disables page-faults and preemption (the latter only for !PREEMPT_RT kernels). The code within the mapping/unmapping in ips_is_passthru() is already in atomic context because of a call to local_irq_save() and kmap_local_page() can be called in atomic context too (including interrupts). Therefore, a mere replacement of the old API with the new one is all it is required (i.e., there is no need to explicitly add any calls to pagefault_disable() and/or preempt_disable()). Suggested-by:
-
Paul Menzel authored
Linux logs the error below: $ dmesg --level=err | grep mpt [ 7.647675] mpt3sas_cm0: Trace buffer memory 2048 KB allocated This state does not denote an error condition (and also no warning), so demote the level from error to info. Cc: it+linux-scsi@molgen.mpg.de Signed-off-by:Paul Menzel <pmenzel@molgen.mpg.de> Link: https://lore.kernel.org/r/20230103150438.45922-1-pmenzel@molgen.mpg.deSigned-off-by:
-
Arnd Bergmann authored
Printing a size_t value that is the result of the sizeof() operator requires using the %z format string modifier to avoid a warning on 32-bit architectures: drivers/scsi/qla2xxx/qla_mid.c: In function 'qla_create_buf_pool': drivers/scsi/qla2xxx/qla_mid.c:1094:51: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'unsigned int' [-Werror=format=] 1094 | "Failed to allocate buf_map(%ld).\n", sz * sizeof(unsigned long)); | ~~^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | long int unsigned int | %d Fixes: 82d8dfd2 ("scsi: qla2xxx: edif: Fix performance dip due to lock contention") Signed-off-by:Arnd Bergmann <arnd@arndb.de> Reviewed-by:
Bart Van Assche <bvanassche@acm.org> Reviewed-by:
Himanshu Madhani <himansnhu.madhani@oracle.com <mailto:himansnhu.madhani@oracle.com>> Reviewed-by:
Nick Desaulniers <ndesaulniers@google.com> Link: https://lore.kernel.org/r/20230117170029.2387516-1-arnd@kernel.orgSigned-off-by:
-
Alim Akhtar authored
Add maintainer entry for Exynos UFS driver. Signed-off-by:
Alim Akhtar <alim.akhtar@samsung.com> Reviewed-by:
-
Alim Akhtar authored
PA_GRANULARITY is duplicated, delete one of the entries. Signed-off-by:
-
Kees Cook authored
struct MPI2_RAID_SCSI_IO_REQUEST ends with a single SGL, but expects to copy multiple. Add a flexible array member so the compiler can reason about the size of the memcpy(). This will avoid the run-time false positive warning: memcpy: detected field-spanning write (size 128) of single field "&r1_cmd->io_request->SGL" at drivers/scsi/megaraid/megaraid_sas_fusion.c:3326 (size 16) This change results in no binary output differences. Reported-by:
Holger Kiehl <Holger.Kiehl@dwd.de> Link: https://lore.kernel.org/all/88de8faa-56c4-693d-2d3-67152ee72057@diagnostix.dwd.de/ Cc: Kashyap Desai <kashyap.desai@broadcom.com> Cc: Sumit Saxena <sumit.saxena@broadcom.com> Cc: Shivasharan S <shivasharan.srikanteshwara@broadcom.com> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com> Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: megaraidlinux.pdl@broadcom.com Cc: linux-scsi@vger.kernel.org Link: https://lore.kernel.org/r/20230106053153.never.999-kees@kernel.orgSigned-off-by:
Kees Cook <keescook@chromium.org> Tested-by:
-
Martin K. Petersen authored
Mike Christie <michael.christie@oracle.com> says: The following patches were made over Martin's scsi-staging/next branch. They add a struct that contains optinal arguments to the scsi_execute* functions. This will be needed for the patches that allow the SCSI passthrough users to control retries because I'm adding a new optional argument. I separated the 2 sets to make it easier to review and post. Link: https://lore.kernel.org/r/20221229190154.7467-1-michael.christie@oracle.comSigned-off-by:
-
Mike Christie authored
scsi_execute() and scsi_execute_req() are no longer used so remove them. Signed-off-by:
Mike Christie <michael.christie@oracle.com> Reviewed-by:
John Garry <john.g.garry@oracle.com> Reviewed-by:
Christoph Hellwig <hch@lst.de> Signed-off-by:
-
Mike Christie authored
scsi_execute() is going to be removed. Convert cxlflash to use scsi_execute_cmd(). [mkp: roll in fix for issue reported by sfr] Signed-off-by:
-
- 14 Jan, 2023 29 commits
-
-
Mike Christie authored
scsi_execute_req() is going to be removed. Convert pscsi to scsi_execute_cmd(). Signed-off-by:
-
Mike Christie authored
scsi_execute_req() is going to be removed. Convert virtio_scsi to scsi_execute_cmd(). Signed-off-by:
-
Mike Christie authored
scsi_execute*() is going to be removed. Convert sr to scsi_execute_cmd(). Signed-off-by:
-
Mike Christie authored
scsi_execute_req() is going to be removed. Convert ses to scsi_execute_cmd(). Signed-off-by:
-
Mike Christie authored
scsi_execute_req() is going to be removed. Conver zbc to scsi_execute_cmd(). Signed-off-by:
-
Mike Christie authored
scsi_execute*() is going to be removed. Convert sd_mod to use scsi_execute_cmd(). Signed-off-by:
-
Mike Christie authored
scsi_execute() is going to be removed. Convert to the SPI class to scsi_execute_cmd(). Signed-off-by:
-
Mike Christie authored
scsi_execute_req() is going to be removed. Convert SCSI midlayer to scsi_execute_cmd(). Signed-off-by:
-
Mike Christie authored
scsi_execute() is going to be removed. Convert the scsi_dh users to scsi_execute_cmd(). Signed-off-by:
-
Mike Christie authored
scsi_execute_req() is going to be removed. Convert ch to scsi_execute_cmd(). Signed-off-by:
-
Mike Christie authored
scsi_execute_req() is going to be removed. Convert drivetemp to scsi_execute_cmd(). Signed-off-by:
-
Mike Christie authored
scsi_execute_req() is going to be removed. Convert libata to scsi_execute_cmd(). Signed-off-by:
Damien Le Moal <damien.lemoal@opensource.wdc.com> Reviewed-by:
-
Mike Christie authored
Move the SCSI execution functions to use a struct for passing in optional args. This commit adds the new struct, temporarily converts scsi_execute() and scsi_execute_req() ands a new helper, scsi_execute_cmd(), which takes the scsi_exec_args struct. There should be no change in behavior. We no longer allow users to pass in any request->rq_flags value, but they were only passing in RQF_PM which we do support by allowing users to pass in the BLK_MQ_REQ flags used by blk_mq_alloc_request(). Subsequent commits will convert scsi_execute() and scsi_execute_req() users to the new helpers then remove scsi_execute() and scsi_execute_req(). Signed-off-by:
-
Martin K. Petersen authored
Can Guo <quic_cang@quicinc.com> says: This patch series is to enable Event Specific Interrupt (ESI) which can used in MCQ mode. Link: https://lore.kernel.org/r/1671073583-10065-1-git-send-email-quic_cang@quicinc.comSigned-off-by:
-
Martin K. Petersen authored
Asutosh Das <quic_asutoshd@quicinc.com> says: This patch series is an implementation of UFS Multi-Circular Queue. Please consider this series for next merge window. This implementation has been verified on a Qualcomm & MediaTek platform. UFS Multi-Circular Queue (MCQ) has been added in UFSHCI v4.0 to improve storage performance. The implementation uses the shared tagging mechanism so that tags are shared among the hardware queues. The number of hardware queues is configurable. This series doesn't include the ESI implementation for completion handling. Link: https://lore.kernel.org/r/cover.1673557949.git.quic_asutoshd@quicinc.comSigned-off-by:
-
Can Guo authored
Add MCQ ESI config vendor specific ops. Co-developed-by:
Asutosh Das <quic_asutoshd@quicinc.com> Signed-off-by:
Can Guo <quic_cang@quicinc.com> Reviewed-by:
-
Can Guo authored
Add and export two functions to enable ESI and config ESI base addresses. The calls to these exported functions will be added by the next patch in this series. Signed-off-by:
-
Can Guo authored
As Event Specific Interrupt message format is not defined in UFSHCI JEDEC specs, and the ESI handling highly depends on how the format is designed, hence add a vendor specific ops such that SoC vendors can configure their own ESI handlers. If ESI vops is not provided or returning error, go with the legacy (central) interrupt way. Signed-off-by:
-
Asutosh Das authored
Enable MCQ in the Host Controller. Signed-off-by:
Manivannan Sadhasivam <mani@kernel.org> Reviewed-by:
Stanley Chu <stanley.chu@mediatek.com> Signed-off-by:
-
Asutosh Das authored
Complete CQE requests in poll. Assumption is that several poll completion may happen in different CPUs for the same completion queue. Hence a spin lock protection is added. Co-developed-by:
-
Asutosh Das authored
Add support for completing requests from Completion Queue. Some host controllers support vendor specific registers that provide a bitmap of all CQs which have at least one completed CQE. Add this support. The MCQ specification doesn't provide the Task Tag or its equivalent in the Completion Queue Entry. So use an indirect method to find the Task Tag from the Completion Queue Entry. Co-developed-by:
-
Asutosh Das authored
Modify completion path APIs and add completion queue entry. Co-developed-by:
-
Asutosh Das authored
Add support to find the hardware queue on which the request would be queued. Since the very first queue is to serve device commands, an offset of 1 is added to the index of the hardware queue. Co-developed-by:
-
Asutosh Das authored
Add support to send commands using multiple submission queues in MCQ mode. Modify the functions that use ufshcd_send_command(). Co-developed-by:
-
Asutosh Das authored
Enable shared tags for MCQ. For UFS, this should not have a huge performance impact. It however simplifies the MCQ implementation and reuses most of the existing code in the issue and completion path. Also add multiple queue mapping to map_queue(). Co-developed-by:
-
Asutosh Das authored
Runtime and operation registers are defined per Submission and Completion queue. The location of these registers is not defined in the spec; meaning the offsets and stride may vary for different HC vendors. Establish the stride, base address, and doorbell address offsets from vendor host driver and program it. Co-developed-by:
-
Asutosh Das authored
To read the bqueuedepth, the device descriptor is fetched in Single Doorbell Mode. This allocated memory may not be enough for MCQ mode because the number of tags supported in MCQ mode may be larger than in SDB mode. Hence, release the memory allocated in SDB mode and allocate memory for MCQ mode operation. Define the UFS hardware queue and Completion Queue Entry. Co-developed-by:
-
Asutosh Das authored
The UFS device defines the supported queuedepth by bqueuedepth which has a max value of 256. The HC defines MAC (Max Active Commands) that defines the max number of commands that in flight to the UFS device. Calculate and configure the nutrs based on both these values. Co-developed-by:
-
Asutosh Das authored
Define the MCQ resources and add support to ioremap the resource regions. Co-developed-by:
-
