- 23 May, 2014 40 commits
-
-
navin patidar authored
Signed-off-by:
navin patidar <navin.patidar@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Christian Engelmayer authored
(status != _SUCCESS) immediately after 'status = _SUCCESS' will never evaluate true. Thus remove the logically dead code. Detected by Coverity - CID 1077553. Signed-off-by:
Christian Engelmayer <cengelma@gmx.at> Acked-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Christian Engelmayer authored
Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS as long as not explicitly set. Thus initialize 'status' to FAIL, in order to prevent undefined behaviour if going through the exit paths. Detected by Coverity - CID 1077832. Signed-off-by:
-
Christian Engelmayer authored
Fix a potential leak in the error path of rtw_set_key(). In case the requested algorithm is not supported by the driver, the function returns without enqueuing or freeing the already allocated command and parameter structs. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077716, 1077717. Signed-off-by:
-
Christian Engelmayer authored
Fix a potential leak in the error path of function update_bcn_wps_ie(). Move the affected input verification to the beginning of the function so that it may return directly without leaking already allocated memory. Detected by Coverity - CID 1077718. Signed-off-by:
-
Christian Engelmayer authored
Function rtw_mp_pwrtrk() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - 1077715. Signed-off-by:
-
Christian Engelmayer authored
Function rtw_mp_SetRFPath() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077714. Signed-off-by:
-
Christian Engelmayer authored
Function rtw_mp_QueryDrv() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077713. Signed-off-by:
-
Christian Engelmayer authored
Function rtw_wx_set_enc_ext() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077712. Signed-off-by:
-
Christian Engelmayer authored
Function rtw_wx_read32() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077711. Signed-off-by:
-
navin patidar authored
Remove unused variable 'u8 fragcnt'. Signed-off-by:
-
navin patidar authored
Remove unused variable 'int frame_tag'. Signed-off-by:
-
navin patidar authored
Remove unused variable 'void *precvbuf'. Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Use usb_free_urb() instead of rtw_os_recvbuf_resource_free() to free URB. Signed-off-by:
-
navin patidar authored
rtw_hostapd_mlme_rx() has empty defination, so we can remove it. Signed-off-by:
-
navin patidar authored
rtw_os_recv_resource_free() has empty defination, so we can remove it. Signed-off-by:
-
navin patidar authored
rtw_os_recv_resource_init() has empty defination, so we can remove it. Signed-off-by:
-
navin patidar authored
Remove unused struct zero_bulkout_context. Signed-off-by:
-
navin patidar authored
Remove unused variable 'spinlock_t lock'. Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Remove unused variable 'semaphore allrxreturnevt'. Signed-off-by:
-
Remi Pommarel authored
This patch fixes all prohibited spaces after open '(' checkpatch.pl errors for rtl8188eu. Signed-off-by:Remi Pommarel <repk@triplefau.lt> Signed-off-by:
-
Tuomas Tynkkynen authored
Fix sparse warnings by adding __user and __iomem annotations where necessary and removing certain unnecessary casts. While at it, also use u32 in place of __u32. Signed-off-by:
Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Rickard Strandqvist authored
Removal of null pointer checks that could never happen Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by:
-
Benoit Taine authored
Export of symbols statement must be placed right after the definition to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // <smpl> @ r @ identifier f; @@ - EXPORT_SYMBOL(f); @@ identifier r.f; @@ f(...) { ... } + EXPORT_SYMBOL(f); // </smpl> Signed-off-by:
Benoit Taine <benoit.taine@lip6.fr> Signed-off-by:
-
Peter Senna Tschudin authored
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // </smpl> Signed-off-by:
Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
bDiversityRegCtlON is always false. In later vendor driver code has been commented out. Remove diversity timers and variables. Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
Functions are now dead and of no use. Signed-off-by:
-
Malcolm Priestley authored
Replace with ether_crc_le which gives the same result. Signed-off-by:
-
Malcolm Priestley authored
CRCdwGetCrc32 is a bitwise not of ether_crc_le. Replace with ether_crc_le. Signed-off-by:
-
Malcolm Priestley authored
Remove dead strutures Signed-off-by:
-
Malcolm Priestley authored
Remove dead strutures and macros. Signed-off-by:
-
Kees Cook authored
This makes sure the cfg->name can never accidentally be processed as a format string in the worker thread name. Signed-off-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
-
Konrad Zapalowicz authored
This commit fixes the following sparse warnings: drivers/staging/rtl8821ae/rtl8821ae/sw.c: - 48:6: warning: symbol 'rtl8821ae_init_aspm_vars' was not declared. Should it be static? - 228:5: warning: symbol 'rtl8812ae_rx_command_packet_handler' was not declared. Should it be static? - 263:20: warning: symbol 'rtl8821ae_hal_ops' was not declared. Should it be static? - 314:23: warning: symbol 'rtl8821ae_mod_params' was not declared. Should it be static? - 321:20: warning: symbol 'rtl8821ae_hal_cfg' was not declared. Should it be static? All of this symbols are local, that is there are no references to them in the other files from this driver. Signed-off-by:Konrad Zapalowicz <bergo.torino@gmail.com> Signed-off-by:
-
Konrad Zapalowicz authored
This commit fixes the following sparse warning: drivers/staging/rtl8821ae/rtl8821ae/sw.c: - 449:14: warning: duplicate const Signed-off-by: -
Levente Kurusa authored
Found by checkpatch. Signed-off-by:
Levente Kurusa <levex@linux.com> Signed-off-by:
-
Tair Rzayev authored
* Move Check_D_MediaFmt() implementation up in smilmain.c to keep all the non-static functions at the top of the file; * Remove unnecessary extern and newlines from "init.h"; Signed-off-by:
Tair Rzayev <tair.rzayev@gmail.com> Signed-off-by:
-
Chase Southwood authored
This function is already compliant with the comedi API and is behaving as comedi core expects. This patch moves it out of addi-data/hwdrv_apci1564.c and into the driver proper since no further work needs to be done on it. Signed-off-by:
Chase Southwood <chase.southwood@gmail.com> Reviewed-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
