- 01 Feb, 2015 2 commits
-
-
Chris Rorvick authored
Use of this function ended with commits 3e58c868 ("staging: line6: drop midi_mask_receive") and af89d289 ("staging: line6: drop midi_mask_transmit".) [Removed the corresponding line in midibuf.h, too -- tiwai] Signed-off-by:
Chris Rorvick <chris@rorvick.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
Chris Rorvick authored
This function has not been used since merging the driver into the kernel (and a good while before that.) [Removed the corresponding line in midibuf.h, too -- tiwai] Signed-off-by:
-
- 30 Jan, 2015 1 commit
-
-
Takashi Iwai authored
-
- 28 Jan, 2015 37 commits
-
-
Takashi Iwai authored
-
Takashi Iwai authored
Protect the call with a mutex, as this may be called in parallel (either from the PCM rate change and the clock change). Acked-by:
Jaroslav Kysela <perex@perex.cz> Tested-by:
Pavel Hofman <pavel.hofman@ivitera.com> Signed-off-by:
-
Takashi Iwai authored
Define snd_ak4114_suspend() and snd_ak4114_resume() functions to handle PM properly, stopping and restarting the work at PM. Currently only ice1712/juli.c deals with the PM and ak4114, so fix the calls there appropriately. The same PM functions are defined in ak4113.c, too, although they aren't currently called yet (ice1712/quartet.c may be enhanced to support PM later). Acked-by:
-
Takashi Iwai authored
... just to follow the standard coding style. Acked-by:
-
Takashi Iwai authored
When ak4114 work calls its callback and the callback invokes ak4114_reinit(), it stalls due to flush_delayed_work(). For avoiding this, control the reentrance by introducing a refcount. Also flush_delayed_work() is replaced with cancel_delayed_work_sync(). The exactly same bug is present in ak4113.c and fixed as well. Reported-by:
-
Takashi Iwai authored
It's just superfluous and doesn't give any better readability. Signed-off-by: -
Takashi Iwai authored
PODxt Live Variax doesn't have PCM and HWMON but only MIDI. Signed-off-by: -
Takashi Iwai authored
It's identical with struct usb_line6. Signed-off-by: -
Takashi Iwai authored
Most of them are rather relevant with the definitions in driver.h, and there are only a few lines, so just rip it off. Signed-off-by: -
Takashi Iwai authored
The definition is no longer used. Signed-off-by: -
Takashi Iwai authored
Just reformatting the comments and typos fixed, no functional changes. Particularly, - avoid the kerneldoc marker "/**", - reduce multiple comment lines into single lines, - corrected wrongly referred function names Signed-off-by: -
Takashi Iwai authored
Signed-off-by: -
Takashi Iwai authored
The user-space API definition for usb_stream stuff should be moved to include/uapi/sound to be exposed publicly. While we're at it, add the missing ifdef guard for double inclusion, too. Signed-off-by: -
Takashi Iwai authored
Signed-off-by: -
Takashi Iwai authored
Signed-off-by: -
Takashi Iwai authored
Nowadays it's recommended. Replace all in a shot. Signed-off-by: -
Arnd Bergmann authored
The soundscape driver uses the ISA inb/outb functions declared in linux/io.h, so it needs to include this header to avoid a build error: sscape.c: In function 'sscape_write_unsafe': sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration] Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Takashi Iwai authored
-
Takashi Iwai authored
Tested-by:
-
Takashi Iwai authored
Both playback and capture callbacks are identical, so let's merge them. Tested-by:
-
Takashi Iwai authored
The current code deals with the stream start / stop solely via line6_pcm_acquire() and line6_pcm_release(). This was (supposedly) intended to avoid the races, but it doesn't work as expected. The concurrent acquire and release calls can be performed without proper protections, thus this might result in memory corruption. Furthermore, we can't take a mutex to protect the whole function because it can be called from the PCM trigger callback that is an atomic context. Also spinlock isn't appropriate because the function allocates with kmalloc with GFP_KERNEL. That is, these function just lead to singular problems. This is an attempt to reduce the existing races. First off, separate both the stream buffer management and the stream URB management. The former is protected via a newly introduced state_mutex while the latter is protected via each line6_pcm_stream lock. Secondly, the stream state are now managed in opened and running bit flags of each line6_pcm_stream. Not only this a bit clearer than previous combined bit flags, this also gives a better abstraction. These rewrites allows us to make common hw_params and hw_free callbacks for both playback and capture directions. For the monitor and impulse operations, still line6_pcm_acquire() and line6_pcm_release() are used. They call internally the corresponding functions for both playback and capture streams with proper lock or mutex. Unlike the previous versions, these function don't take the bit masks but the only single type value. Also they are supposed to be applied only as duplex operations. Tested-by:
-
Takashi Iwai authored
Clearing prev_fsize in line6_pcm_acquire() is pretty racy. This can be called at any time while the stream is being played. Rather better to clear prev_fbuf and prev_fsize at the proper place like the stream stop for capture, and just after copying the monitor / impulse data inside the spinlock. Tested-by:
-
Takashi Iwai authored
The impulse and monitor handling in submit_audio_out_urb() isn't protected thus this can be racy with the capture stream handling. This patch extends the range to protect via each stream's spinlock (now the whole submit_audio_*_urb() are covered), and take the capture stream lock additionally for the impulse and monitor handling part. Tested-by:
-
Takashi Iwai authored
Move the check of multi configurations before snd_card_new() as a short path, and reduce superfluous pointer references. Tested-by:
-
Takashi Iwai authored
Instead of allocating the private data individually in each driver's probe at first, let snd_card_new() allocate the data that is called in line6_probe(). This simplifies the primary probe functions. Tested-by:
-
Takashi Iwai authored
The interface argument is used just for retrieving the assigned device, which can be already found in line6->ifcdev. Drop them from the callbacks. Also, pass the usb id to private_init so that the driver can deal with it there. This is a preliminary work for the further cleanup to move the whole allocation into driver.c. Tested-by:
-
Takashi Iwai authored
A minor optimization; while pausing, the driver just copies the zero that doesn't need any volume changes. Tested-by:
-
Takashi Iwai authored
Tested-by:
-
Takashi Iwai authored
The PCM stream buffer allocation and free are identical for both playback and capture streams. Provide single helper functions. These are used only in pcm.c, thus they can be even static. Tested-by:
-
Takashi Iwai authored
This is the last remaining snd_printk() usage in this driver. Tested-by:
-
Takashi Iwai authored
The codes to unlink and sync URBs are identical for both playback and capture streams. Consolidate to single helper functions. Tested-by:
-
Takashi Iwai authored
Introduce a new line6_pcm_stream structure and group individual fields of snd_line6_pcm struct to playback and capture groups. This patch itself just does rename and nothing else. More meaningful cleanups based on these fields shuffling will follow. Tested-by:
-
Takashi Iwai authored
If the problem still really remains, we should fix it instead of papering over it like this... Tested-by:
-
Takashi Iwai authored
Using a decremental loop without particular reasons worsens the readability a lot. Use incremental loops instead. Tested-by:
-
Takashi Iwai authored
The trigger callback is already spinlocked, so we need no more lock here (even for the linked substreams). Let's drop it. Tested-by:
-
Takashi Iwai authored
line6_pcm_acquire() tries to restore the newly obtained resources at the error path. But some flags aren't recorded and released properly when the corresponding buffer is already present. These bits have to be cleared in the error recovery, too. Also, "flags_final" can be initialized to zero since we pass only the subset of "channels" bits. Tested-by:
-
Takashi Iwai authored
Fixed a few places using bits OR wrongly for condition checks. Tested-by:
-
