- 25 Jan, 2022 40 commits
-
-
Zhou Qingyang authored
In amdgpu_dm_connector_add_common_modes(), amdgpu_dm_create_common_mode() is assigned to mode and is passed to drm_mode_probed_add() directly after that. drm_mode_probed_add() passes &mode->head to list_add_tail(), and there is a dereference of it in list_add_tail() without recoveries, which could lead to NULL pointer dereference on failure of amdgpu_dm_create_common_mode(). Fix this by adding a NULL check of mode. This bug was found by a static analyzer. Builds with 'make allyesconfig' show no new warnings, and our static analyzer no longer warns about this code. Fixes: e7b07cee ("drm/amd/display: Merge amdgpu_dm_types and amdgpu_dm") Signed-off-by:
Zhou Qingyang <zhou1615@umn.edu> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Zhou Qingyang authored
In calculate_bandwidth(), the tag free_sclk and free_yclk are reversed, which could lead to a memory leak of yclk. Fix this bug by changing the location of free_sclk and free_yclk. This bug was found by a static analyzer. Builds with 'make allyesconfig' show no new warnings, and our static analyzer no longer warns about this code. Fixes: 2be8989d ("drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap") Signed-off-by:
-
Alex Deucher authored
Check IP versions rather than asic types. Acked-by:
Evan Quan <evan.quan@amd.com> Signed-off-by:
-
Alex Deucher authored
Extend secondary function handling for runtime pm beyond audio to USB and UCSI. Reviewed-by:
-
Alex Deucher authored
Seems more logical to enable runtime pm at the end of the init sequence so we don't end up entering runtime suspend before init is finished. Reviewed-by:
-
Alex Deucher authored
We need to set the APU flag from IP discovery before we evaluate this code. Acked-by:
-
Alex Deucher authored
Use the IP versions to set the APU flag when necessary. Reviewed-by:
Aaron Liu <aaron.liu@amd.com> Acked-by:
-
Alex Deucher authored
Earlier chips only had two performance levels, but newer ones potentially had more. The message is harmless. Drop the message to avoid spamming the log. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1874Reviewed-by:
-
Nicholas Kazlauskas authored
[Why] A porting error resulted in the stream assignment for the link being retained without being released - a memory leak. [How] Fix the porting error by adding back the dc_stream_release() intended as part of the original patch. Fixes: 0bb24555 ("drm/amd/display: retain/release at proper places in link_enc assignment") Signed-off-by:
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Reviewed-by:
Harry Wentland <harry.wentland@amd.com> Signed-off-by:
-
Eric Yang authored
[Why] To help triage issues and coordinate driver/bios release dependency [How] Only enable the new Z9 interface when debug option is set, otherwise treat Z10 only support case as Zstate disallowed. Tested-by:
Daniel Wheeler <daniel.wheeler@amd.com> Reviewed-by:
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Signed-off-by:
Eric Yang <Eric.Yang2@amd.com> Signed-off-by:
-
Eric Yang authored
[Why] psr_feature_enabled flag is dynamically updated, and sometimes when zstate allow status is determined the flag has not been set to true yet even on PSR enabled config, lid off/on is such a case, which will result in zstate disabled even though PSR is supported. [How] Check the supported PSR version and the PSR disable status instead. Tested-by:
-
David Galiffi authored
[How & Why] Disable physym clock when it's not in use. Tested-by:
David Galiffi <David.Galiffi@amd.com> Signed-off-by:
-
David Galiffi authored
[How & Why] Updated procedure to match hardware programming guide. Tested-by:
-
Wenjing Liu authored
[why] There is a change previously to disallow DM to set dp drive setings when stream is not present. The logic might not work well with DP PHY complaince scenario with a PHY test fixture attachment. We need to make the method allow DP link drive settings changes even without stream attached to it. [how] revert back to previous code in set drive setting function then add an empty link_resource structure, then assign link resource based on current link resource if link resource is allocated to the current pipe. Tested-by:
Wayne Lin <Wayne.Lin@amd.com> Acked-by:
Wenjing Liu <wenjing.liu@amd.com> Signed-off-by:
-
Aric Cyr authored
Tested-by:
Aric Cyr <aric.cyr@amd.com> Signed-off-by:
-
Aric Cyr authored
This version brings along the following fixes: - Z9 improvements - Clocks management adjustments - Code cleanup - Improve DSC and MST code Tested-by:
-
Wayne Lin authored
[Why & How] In order to easily test ilr by immediately reset the preferred training settings, fix the code to disable skip_immediate_retrain. Tested-by:
Solomon Chiu <solomon.chiu@amd.com> Acked-by:
-
Anthony Koo authored
- Add Scr8 for GPINT messaging between driver and fw Tested-by:
Anthony Koo <Anthony.Koo@amd.com> Signed-off-by:
-
Reza Amini authored
[why] OnSetSourceContentAttribute it does not trigger an update for the VSC with TF change. [how] In this call, create a new VSC infoPacket based on the new config, and allow DisplayTarget decide if an update and pursuant passive flip is necessary Tested-by:
Krunoslav Kovac <Krunoslav.Kovac@amd.com> Acked-by:
Reza Amini <Reza.Amini@amd.com> Signed-off-by:
-
Sung Joon Kim authored
[why] Due to bad hardware, the PHY repeater count in LTTPR cap is read as 0xFF in some monitors while the LTTPR is actually present. [how] Remove PHY repeater counter check when configuring LTTPR mode. Tested-by:
Jun Lei <Jun.Lei@amd.com> Acked-by:
Sung Joon Kim <sungkim@amd.com> Signed-off-by:
-
Roy Chan authored
[Why] indirect register index/data pair may be used by multi-threads. when it happens, it would cause register access issue that is hard to trace. [How] Using cgs service, which provide a sync indirect reg access api. Tested-by:
Roy Chan <roy.chan@amd.com> Signed-off-by:
-
Fangzhi Zuo authored
DSC sequence for non virtual dpcd synaptics hub Tested-by:
Hersen Wu <hersenxs.wu@amd.com> Acked-by:
Fangzhi Zuo <Jerry.Zuo@amd.com> Signed-off-by:
-
Fangzhi Zuo authored
Determine if DFP present and the type of downstream device based on dsc_aux Tested-by:
-
Fangzhi Zuo authored
Sequence to reset synaptics SDP fifo before enabling first stream Tested-by:
-
Shen, George authored
[Why/How] We need to handle cable capabilities for cables that support cable ID. The cable attributes are intersected with the verified link caps to determine appropriate max link rate. After determining cable attributes we update the DP receiver. Tested-by:
George Shen <George.Shen@amd.com> Signed-off-by:
-
Nicholas Kazlauskas authored
[Why] If the DPCD caps specifies a PSR version newer than PSR_VERSION_1 then we fallback to using PSR_VERSION_1 in amdgpu_dm_set_psr_caps. This gets overriden with the raw DPCD value in amdgpu_dm_link_setup_psr, which can result in DMCUB hanging if we pass in an unsupported PSR version number. [How] Fix the hang by using link->psr_settings.psr_version directly during amdgpu_dm_link_setup_psr. Tested-by:
-
Ian Chen authored
Prepare for future dm can have different implementation depends on the return value. Tested-by:
Ian Chen <ian.chen@amd.com> Signed-off-by:
-
Nicholas Kazlauskas authored
[Why] DMCUB will hang if we send a PSR unsupported set version command. This can occur if we fall-through into the default case in the switch statement for PSR version. [How] Add an unsupported check after the switch statement. Tested-by:
-
Varone authored
[WHY?] SKUs that contain an unused eDP connector will throw an error when no display is connected. [HOW?] Change error to a warning. Tested-by:
Martin Leung <Martin.Leung@amd.com> Acked-by:
Dillon Varone <divarone@amd.com> Signed-off-by:
-
Alvin Lee authored
Implement handling for escape call to query the MCLK switch support for the current display config. Tested-by:
Alvin Lee <Alvin.Lee2@amd.com> Signed-off-by:
-
Josip Pavic authored
[Why & How] Increase width of some variables to avoid comparing integers of different widths Tested-by:
Josip Pavic <Josip.Pavic@amd.com> Signed-off-by:
-
Martin Tsai authored
[Why] Link encoders are created based on its engine ID. The position of a link encoder in an array could be null since it didn't be allocated. Current matching logic didn't consider this situation and could get null encoder. [How] To add null encoder check to make the matching logic can go to next to get a valid one. Tested-by:
Martin Tsai <martin.tsai@amd.com> Signed-off-by:
-
Wayne Lin authored
[Why] Currently, when we're tentatively detecting link configuration under mst case, we will wrongly notify a none existing stream sink to drm layer. It's due to we'll call amdgpu_dm_update_connector_after_detect() within dm_helpers_read_local_edid() to update connector when we're still under tentative detection procedure. [How] dm_helpers_read_local_edid() was designed to do "read" only. Don't update drm connector status when we're still under detection process. Tested-by:
-
Wenjing Liu authored
[why] There is a recent refactor that contains a typo to cause set throttled vcp size skipped for dpia link. The change is to fix this typo so it won't cause black screen Tested-by:
-
Wenjing Liu authored
[why] This is internal to dc so we don't have to add a prefix to indicate it is dc link_hwss instead someone else link_hwss. Tested-by:
-
Wenjing Liu authored
[why] as we add more link_hwss we are making a generic way to determine which type of link_hwss we should use. Later on we may think of introduce a link policy layer. it could be a thin layer that decide the type of link_hwss we use. So instead of passing in link and link_res we can just pass in link_policy and swtich based on link_policy->get_link_hwss_type. Tested-by:
-
Wenjing Liu authored
[why] Current we have hundreds of if/else or switch statement to check encoder type in dc_link level. The reason is because depending on the type of encoder dc_link needs to perform similar programming task but with different encoder interfaces. The story is to abstract these interfaces so dc_link can just perform the programming task without knowing the detail of which encoder it's dealing with. Tested-by:
-
Wenjing Liu authored
[Why & How] DCN guard is not necessary for DP2.x relevant logic. Drop them. v2: squash in fix for misplaced #endif (Alex) Tested-by:
-
Jimmy Kizito authored
[Why] According to the USB4 specification, FEC and DSC should be disabled when a USB4 DPIA operates in TBT3 compatibility mode. [How] Upon detecting that a USB4 DPIA is connected to a device that is known to operate in TBT3 mode, disable FEC and DSC support if they have been reported by the TBT3 device. Tested-by:
Meenakshikumar Somasundaram <Meenakshikumar.Somasundaram@amd.com> Acked-by:
Jimmy Kizito <Jimmy.Kizito@amd.com> Signed-off-by:
-
Wenjing Liu authored
[why] dc_link_detect_helper has multiple purpose: 1. Detect link and local sink. 2. Verify link capability by performing detection link training. 3. Start mst topology discovery and if succeeded fails the current interface. This is difficult to maintain as item 2 has become more destructive to current dc state. The change is to decouple these sequences to its own functions. Eventually only item 2 is a destructive method and we will redesign this sequence with a more unified policy across different encoder types. Tested-by:
Chris Park <Chris.Park@amd.com> Acked-by:
-
