Commits · 5b9470dbbe1c074ecf9a30934fa7b2f25b1182f3 · Kirill Smelkov / linux

30 Dec, 2004 8 commits

[ide] make host drivers aware of the changes made to ide_setup_pci_device{s} · 5b9470db

Bartlomiej Zolnierkiewicz authored Dec 30, 2004

- nothing clever here: the most noticeable change is the change of
  returned value for (*init_setup) in struct ide_pci_device_s which
  goes from void to int. Anything else is editing and checking for
  errors in the output of the compiler;
- pci_disable_device() added for the error path in pci_init_sgiioc4();
- BUG() removed in amd74xx_probe(): good old printk() is enough.
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

5b9470db

[ide] propagate the error status in ide_pci_enable/ide_setup_pci_controller · 9a2f7ca4

Bartlomiej Zolnierkiewicz authored Dec 30, 2004

- no need to overwrite the status code returned by the pci_xyz() functions;
- jump into the new century and use DMA_32BIT_MASK;
- misc cleanup in the error paths. It should not add a huge value in
  ide_pci_enable() due to the FIXME comment but it should not bite too hard
  either.
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

9a2f7ca4

[ide] clean up error path in do_ide_setup_pci_device() · fe2f6725

Bartlomiej Zolnierkiewicz authored Dec 30, 2004

ide_setup_pci_controller() puts the device in a PCI enabled state.
The patch adds a small helper to balance it when things go wrong.

Actually the helper does not *exactly* balance the setup: if it can
not do a better job, ide_setup_pci_controller() may only enable some
BARS whereas the new counterpart will try to disable everything.
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

fe2f6725

[ide] propagation of error code in PCI IDE setup · 85cb671e

Bartlomiej Zolnierkiewicz authored Dec 30, 2004

- Change the return value and the prototype of do_ide_setup_pci_device
  Due to lack of appropriate return status code, the current clients of
  do_ide_setup_pci_device() can not distinguish a failing invocation
  from a successfull one. The patch modify do_ide_setup_pci_device() so
  that it can propagate some of the errors from the lower layers.

- Make ide_setup_pci_device() aware of the change and propagate the news
  itself. I only gave a quick sight to create_proc_ide_interfaces() (and
  ide_remove_proc_entries()) but they do seem sane and it should not matter
  if it fails or not.

- ide_setup_pci_devices(): mostly the same thing than ide_setup_pci_device().
  do not look trivially suspect.
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

85cb671e

[ide] fix return codes in the generic PCI IDE driver · 205a0365

Bartlomiej Zolnierkiewicz authored Dec 30, 2004

From: Alan Cox <alan@redhat.com>

This patch updates ide/pci/generic.c to fix the incorrect returns
causing PCI devices to be left reserved wrongly by the driver.

From: Francois Romieu <romieu@fr.zoreil.com>

Use -ENODEV instead of -EAGAIN.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

205a0365

[ide] it8172: incorrect return from it8172_init_one() · de20380f

Bartlomiej Zolnierkiewicz authored Dec 30, 2004

From: Alan Cox <alan@lxorguk.ukuu.org.uk>

Several IDE drivers return positive values as errors in the PCI setup
code. Unfortunately the PCI layer considers positive values as success
so the driver skips the device but still claims it and things then go
downhill.

This fixes the IT8172 driver.

From: Francois Romieu <romieu@fr.zoreil.com>

Use -ENODEV instead of -EAGAIN.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

de20380f

[ide] fix cleanup_module() in ide.c · a7766f89

Bartlomiej Zolnierkiewicz authored Dec 30, 2004

DMA should be already released by ide_unregister()
(unless interface is still busy).
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

a7766f89

[ide] ide-proc: kill destroy_proc_ide_interfaces() · dacb88a6

Bartlomiej Zolnierkiewicz authored Dec 30, 2004

/proc interface entries should be already unregistered
by ide_unregister() (unless interface is still busy).
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

dacb88a6

28 Dec, 2004 2 commits

[ide] serverworks: add support for CSB6 RAID · 78fd8b53

Bartlomiej Zolnierkiewicz authored Dec 29, 2004

From: Alan Cox <alan@lxorguk.ukuu.org.uk>

The ServerWorks chips include a RAID variant that the 2.6 driver didn't
support. This enables support for this and removes a pile of #if and
other pointless obfuscations. This removes the need to use various
vendor binary only drivers for CSB6 RAID.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

78fd8b53

[ide] add "ide=nodma" to documentation · b63c6fbf

Bartlomiej Zolnierkiewicz authored Dec 28, 2004

Here's a quick patch to add the currently-undocumented ide=nodma option
to the Documentation/ide.txt file. Since the code does not mark this
option as obsolete as far as I can see, I can only assume that it should
be in the documentation
Signed-off-by: Vadim Lobanov <vlobanov@speakeasy.net>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

b63c6fbf

26 Dec, 2004 10 commits