An error occurred fetching the project authors.
  1. 02 Dec, 2023 9 commits
    • Andrii Nakryiko's avatar
    • Andrii Nakryiko's avatar
      bpf: rearrange bpf_func_state fields to save a bit of memory · 45b5623f
      Andrii Nakryiko authored
      It's a trivial rearrangement saving 8 bytes. We have 4 bytes of padding
      at the end which can be filled with another field without increasing
      struct bpf_func_state.
      
      copy_func_state() logic remains correct without any further changes.
      
      BEFORE
      ======
      struct bpf_func_state {
              struct bpf_reg_state       regs[11];             /*     0  1320 */
              /* --- cacheline 20 boundary (1280 bytes) was 40 bytes ago --- */
              int                        callsite;             /*  1320     4 */
              u32                        frameno;              /*  1324     4 */
              u32                        subprogno;            /*  1328     4 */
              u32                        async_entry_cnt;      /*  1332     4 */
              bool                       in_callback_fn;       /*  1336     1 */
      
              /* XXX 7 bytes hole, try to pack */
      
              /* --- cacheline 21 boundary (1344 bytes) --- */
              struct tnum                callback_ret_range;   /*  1344    16 */
              bool                       in_async_callback_fn; /*  1360     1 */
              bool                       in_exception_callback_fn; /*  1361     1 */
      
              /* XXX 2 bytes hole, try to pack */
      
              int                        acquired_refs;        /*  1364     4 */
              struct bpf_reference_state * refs;               /*  1368     8 */
              int                        allocated_stack;      /*  1376     4 */
      
              /* XXX 4 bytes hole, try to pack */
      
              struct bpf_stack_state *   stack;                /*  1384     8 */
      
              /* size: 1392, cachelines: 22, members: 13 */
              /* sum members: 1379, holes: 3, sum holes: 13 */
              /* last cacheline: 48 bytes */
      };
      
      AFTER
      =====
      struct bpf_func_state {
              struct bpf_reg_state       regs[11];             /*     0  1320 */
              /* --- cacheline 20 boundary (1280 bytes) was 40 bytes ago --- */
              int                        callsite;             /*  1320     4 */
              u32                        frameno;              /*  1324     4 */
              u32                        subprogno;            /*  1328     4 */
              u32                        async_entry_cnt;      /*  1332     4 */
              struct tnum                callback_ret_range;   /*  1336    16 */
              /* --- cacheline 21 boundary (1344 bytes) was 8 bytes ago --- */
              bool                       in_callback_fn;       /*  1352     1 */
              bool                       in_async_callback_fn; /*  1353     1 */
              bool                       in_exception_callback_fn; /*  1354     1 */
      
              /* XXX 1 byte hole, try to pack */
      
              int                        acquired_refs;        /*  1356     4 */
              struct bpf_reference_state * refs;               /*  1360     8 */
              struct bpf_stack_state *   stack;                /*  1368     8 */
              int                        allocated_stack;      /*  1376     4 */
      
              /* size: 1384, cachelines: 22, members: 13 */
              /* sum members: 1379, holes: 1, sum holes: 1 */
              /* padding: 4 */
              /* last cacheline: 40 bytes */
      };
      Acked-by: default avatarEduard Zingerman <eddyz87@gmail.com>
      Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
      Link: https://lore.kernel.org/r/20231202175705.885270-2-andrii@kernel.orgSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
      45b5623f
    • Alexei Starovoitov's avatar
      Merge branch 'bpf-file-verification-with-lsm-and-fsverity' · 6685aadc
      Alexei Starovoitov authored
      Song Liu says:
      
      ====================
      bpf: File verification with LSM and fsverity
      
      Changes v14 => v15:
      1. Fix selftest build without CONFIG_FS_VERITY. (Alexei)
      2. Add Acked-by from KP.
      
      Changes v13 => v14:
      1. Add "static" for bpf_fs_kfunc_set.
      2. Add Acked-by from Christian Brauner.
      
      Changes v12 => v13:
      1. Only keep 4/9 through 9/9 of v12, as the first 3 patches already
         applied;
      2. Use new macro __bpf_kfunc_[start|end]_defs().
      
      Changes v11 => v12:
      1. Fix typo (data_ptr => sig_ptr) in bpf_get_file_xattr().
      
      Changes v10 => v11:
      1. Let __bpf_dynptr_data() return const void *. (Andrii)
      2. Optimize code to reuse output from __bpf_dynptr_size(). (Andrii)
      3. Add __diag_ignore_all("-Wmissing-declarations") for kfunc definition.
      4. Fix an off indentation. (Andrii)
      
      Changes v9 => v10:
      1. Remove WARN_ON_ONCE() from check_reg_const_str. (Alexei)
      
      Changes v8 => v9:
      1. Fix test_progs kfunc_dynptr_param/dynptr_data_null.
      
      Changes v7 => v8:
      1. Do not use bpf_dynptr_slice* in the kernel. Add __bpf_dynptr_data* and
         use them in ther kernel. (Andrii)
      
      Changes v6 => v7:
      1. Change "__const_str" annotation to "__str". (Alexei, Andrii)
      2. Add KF_TRUSTED_ARGS flag for both new kfuncs. (KP)
      3. Only allow bpf_get_file_xattr() to read xattr with "user." prefix.
      4. Add Acked-by from Eric Biggers.
      
      Changes v5 => v6:
      1. Let fsverity_init_bpf() return void. (Eric Biggers)
      2. Sort things in alphabetic orders. (Eric Biggers)
      
      Changes v4 => v5:
      1. Revise commit logs. (Alexei)
      
      Changes v3 => v4:
      1. Fix error reported by CI.
      2. Update comments of bpf_dynptr_slice* that they may return error pointer.
      
      Changes v2 => v3:
      1. Rebase and resolve conflicts.
      
      Changes v1 => v2:
      1. Let bpf_get_file_xattr() use const string for arg "name". (Alexei)
      2. Add recursion prevention with allowlist. (Alexei)
      3. Let bpf_get_file_xattr() use __vfs_getxattr() to avoid recursion,
         as vfs_getxattr() calls into other LSM hooks.
      4. Do not use dynptr->data directly, use helper insteadd. (Andrii)
      5. Fixes with bpf_get_fsverity_digest. (Eric Biggers)
      6. Add documentation. (Eric Biggers)
      7. Fix some compile warnings. (kernel test robot)
      
      This set enables file verification with BPF LSM and fsverity.
      
      In this solution, fsverity is used to provide reliable and efficient hash
      of files; and BPF LSM is used to implement signature verification (against
      asymmetric keys), and to enforce access control.
      
      This solution can be used to implement access control in complicated cases.
      For example: only signed python binary and signed python script and access
      special files/devices/ports.
      
      Thanks,
      Song
      ====================
      
      Link: https://lore.kernel.org/r/20231129234417.856536-1-song@kernel.orgSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
      6685aadc
    • Song Liu's avatar
      selftests/bpf: Add test that uses fsverity and xattr to sign a file · 1030e915
      Song Liu authored
      This selftests shows a proof of concept method to use BPF LSM to enforce
      file signature. This test is added to verify_pkcs7_sig, so that some
      existing logic can be reused.
      
      This file signature method uses fsverity, which provides reliable and
      efficient hash (known as digest) of the file. The file digest is signed
      with asymmetic key, and the signature is stored in xattr. At the run time,
      BPF LSM reads file digest and the signature, and then checks them against
      the public key.
      
      Note that this solution does NOT require FS_VERITY_BUILTIN_SIGNATURES.
      fsverity is only used to provide file digest. The signature verification
      and access control is all implemented in BPF LSM.
      Signed-off-by: default avatarSong Liu <song@kernel.org>
      Link: https://lore.kernel.org/r/20231129234417.856536-7-song@kernel.orgSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
      1030e915
    • Song Liu's avatar
      selftests/bpf: Add tests for filesystem kfuncs · 341f06fd
      Song Liu authored
      Add selftests for two new filesystem kfuncs:
        1. bpf_get_file_xattr
        2. bpf_get_fsverity_digest
      
      These tests simply make sure the two kfuncs work. Another selftest will be
      added to demonstrate how to use these kfuncs to verify file signature.
      
      CONFIG_FS_VERITY is added to selftests config. However, this is not
      sufficient to guarantee bpf_get_fsverity_digest works. This is because
      fsverity need to be enabled at file system level (for example, with tune2fs
      on ext4). If local file system doesn't have this feature enabled, just skip
      the test.
      Signed-off-by: default avatarSong Liu <song@kernel.org>
      Link: https://lore.kernel.org/r/20231129234417.856536-6-song@kernel.orgSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
      341f06fd
    • Song Liu's avatar
      selftests/bpf: Sort config in alphabetic order · 6b0ae456
      Song Liu authored
      Move CONFIG_VSOCKETS up, so the CONFIGs are in alphabetic order.
      Signed-off-by: default avatarSong Liu <song@kernel.org>
      Link: https://lore.kernel.org/r/20231129234417.856536-5-song@kernel.orgSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
      6b0ae456
    • Song Liu's avatar
      Documentation/bpf: Add documentation for filesystem kfuncs · 0de267d9
      Song Liu authored
      Add a brief introduction for file system kfuncs:
      
        bpf_get_file_xattr()
        bpf_get_fsverity_digest()
      
      The documentation highlights the strategy to avoid recursions of these
      kfuncs.
      Signed-off-by: default avatarSong Liu <song@kernel.org>
      Link: https://lore.kernel.org/r/20231129234417.856536-4-song@kernel.orgSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
      0de267d9
    • Song Liu's avatar
      bpf, fsverity: Add kfunc bpf_get_fsverity_digest · 67814c00
      Song Liu authored
      fsverity provides fast and reliable hash of files, namely fsverity_digest.
      The digest can be used by security solutions to verify file contents.
      
      Add new kfunc bpf_get_fsverity_digest() so that we can access fsverity from
      BPF LSM programs. This kfunc is added to fs/verity/measure.c because some
      data structure used in the function is private to fsverity
      (fs/verity/fsverity_private.h).
      
      To avoid recursion, bpf_get_fsverity_digest is only allowed in BPF LSM
      programs.
      Signed-off-by: default avatarSong Liu <song@kernel.org>
      Acked-by: default avatarEric Biggers <ebiggers@google.com>
      Link: https://lore.kernel.org/r/20231129234417.856536-3-song@kernel.orgSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
      67814c00
    • Song Liu's avatar
      bpf: Add kfunc bpf_get_file_xattr · ac9c05e0
      Song Liu authored
      It is common practice for security solutions to store tags/labels in
      xattrs. To implement similar functionalities in BPF LSM, add new kfunc
      bpf_get_file_xattr().
      
      The first use case of bpf_get_file_xattr() is to implement file
      verifications with asymmetric keys. Specificially, security applications
      could use fsverity for file hashes and use xattr to store file signatures.
      (kfunc for fsverity hash will be added in a separate commit.)
      
      Currently, only xattrs with "user." prefix can be read with kfunc
      bpf_get_file_xattr(). As use cases evolve, we may add a dedicated prefix
      for bpf_get_file_xattr().
      
      To avoid recursion, bpf_get_file_xattr can be only called from LSM hooks.
      Signed-off-by: default avatarSong Liu <song@kernel.org>
      Acked-by: default avatarChristian Brauner <brauner@kernel.org>
      Acked-by: default avatarKP Singh <kpsingh@kernel.org>
      Link: https://lore.kernel.org/r/20231129234417.856536-2-song@kernel.orgSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
      ac9c05e0
  2. 01 Dec, 2023 16 commits
  3. 30 Nov, 2023 15 commits
    • Linus Torvalds's avatar
      Merge tag 'net-6.7-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 6172a518
      Linus Torvalds authored
      Pull networking fixes from Paolo Abeni:
       "Including fixes from bpf and wifi.
      
        Current release - regressions:
      
         - neighbour: fix __randomize_layout crash in struct neighbour
      
         - r8169: fix deadlock on RTL8125 in jumbo mtu mode
      
        Previous releases - regressions:
      
         - wifi:
             - mac80211: fix warning at station removal time
             - cfg80211: fix CQM for non-range use
      
         - tools: ynl-gen: fix unexpected response handling
      
         - octeontx2-af: fix possible buffer overflow
      
         - dpaa2: recycle the RX buffer only after all processing done
      
         - rswitch: fix missing dev_kfree_skb_any() in error path
      
        Previous releases - always broken:
      
         - ipv4: fix uaf issue when receiving igmp query packet
      
         - wifi: mac80211: fix debugfs deadlock at device removal time
      
         - bpf:
             - sockmap: af_unix stream sockets need to hold ref for pair sock
             - netdevsim: don't accept device bound programs
      
         - selftests: fix a char signedness issue
      
         - dsa: mv88e6xxx: fix marvell 6350 probe crash
      
         - octeontx2-pf: restore TC ingress police rules when interface is up
      
         - wangxun: fix memory leak on msix entry
      
         - ravb: keep reverse order of operations in ravb_remove()"
      
      * tag 'net-6.7-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (51 commits)
        net: ravb: Keep reverse order of operations in ravb_remove()
        net: ravb: Stop DMA in case of failures on ravb_open()
        net: ravb: Start TX queues after HW initialization succeeded
        net: ravb: Make write access to CXR35 first before accessing other EMAC registers
        net: ravb: Use pm_runtime_resume_and_get()
        net: ravb: Check return value of reset_control_deassert()
        net: libwx: fix memory leak on msix entry
        ice: Fix VF Reset paths when interface in a failed over aggregate
        bpf, sockmap: Add af_unix test with both sockets in map
        bpf, sockmap: af_unix stream sockets need to hold ref for pair sock
        tools: ynl-gen: always construct struct ynl_req_state
        ethtool: don't propagate EOPNOTSUPP from dumps
        ravb: Fix races between ravb_tx_timeout_work() and net related ops
        r8169: prevent potential deadlock in rtl8169_close
        r8169: fix deadlock on RTL8125 in jumbo mtu mode
        neighbour: Fix __randomize_layout crash in struct neighbour
        octeontx2-pf: Restore TC ingress police rules when interface is up
        octeontx2-pf: Fix adding mbox work queue entry when num_vfs > 64
        net: stmmac: xgmac: Disable FPE MMC interrupts
        octeontx2-af: Fix possible buffer overflow
        ...
      6172a518
    • Linus Torvalds's avatar
      Merge tag 'pmdomain-v6.7-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/linux-pm · e8f60209
      Linus Torvalds authored
      Pull pmdomain fix from Ulf Hansson:
      
       - Avoid polling for the scmi_perf_domain on arm
      
      * tag 'pmdomain-v6.7-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/linux-pm:
        pmdomain: arm: Avoid polling for scmi_perf_domain
      e8f60209
    • Linus Torvalds's avatar
      Merge tag 'mmc-v6.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc · 09443a14
      Linus Torvalds authored
      Pull MMC fixes from Ulf Hansson:
       "MMC core:
         - Fix CQE error recovery path
      
        MMC host:
         - cqhci: Fix CQE error recovery path
         - sdhci-pci-gli: Fix initialization of LPM
         - sdhci-sprd: Fix enabling/disabling of the vqmmc regulator"
      
      * tag 'mmc-v6.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc:
        mmc: sdhci-sprd: Fix vqmmc not shutting down after the card was pulled
        mmc: sdhci-pci-gli: Disable LPM during initialization
        mmc: cqhci: Fix task clearing in CQE error recovery
        mmc: cqhci: Warn of halt or task clear failure
        mmc: block: Retry commands in CQE error recovery
        mmc: block: Be sure to wait while busy in CQE error recovery
        mmc: cqhci: Increase recovery halt timeout
        mmc: block: Do not lose cache flush during CQE error recovery
      09443a14
    • Linus Torvalds's avatar
      Merge tag 'leds-fixes-6.7' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/leds · 16864755
      Linus Torvalds authored
      Pull LED fix from Lee Jones:
      
       - Remove duplicate sysfs entry 'color' from LEDs class
      
      * tag 'leds-fixes-6.7' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/leds:
        leds: class: Don't expose color sysfs entry
      16864755
    • Linus Torvalds's avatar
      Merge tag 'efi-urgent-for-v6.7-1' of git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi · 9d3eac3c
      Linus Torvalds authored
      Pull EFI fix from Ard Biesheuvel:
      
       - Fix for EFI unaccepted memory handling
      
      * tag 'efi-urgent-for-v6.7-1' of git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi:
        efi/unaccepted: Fix off-by-one when checking for overlapping ranges
      9d3eac3c
    • Eric Dumazet's avatar
      net: page_pool: fix general protection fault in page_pool_unlist · f9893fda
      Eric Dumazet authored
      syzbot was able to trigger a crash [1] in page_pool_unlist()
      
      page_pool_list() only inserts a page pool into a netdev page pool list
      if a netdev was set in params.
      
      Even if the kzalloc() call in page_pool_create happens to initialize
      pool->user.list, I chose to be more explicit in page_pool_list()
      adding one INIT_HLIST_NODE().
      
      We could test in page_pool_unlist() if netdev was set,
      but since netdev can be changed to lo, it seems more robust to
      check if pool->user.list is hashed  before calling hlist_del().
      
      [1]
      
      Illegal XDP return value 4294946546 on prog  (id 2) dev N/A, expect packet loss!
      general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN
      KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
      CPU: 0 PID: 5064 Comm: syz-executor391 Not tainted 6.7.0-rc2-syzkaller-00533-ga3799729 #0
      Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023
      RIP: 0010:__hlist_del include/linux/list.h:988 [inline]
      RIP: 0010:hlist_del include/linux/list.h:1002 [inline]
      RIP: 0010:page_pool_unlist+0xd1/0x170 net/core/page_pool_user.c:342
      Code: df 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 90 00 00 00 4c 8b a3 f0 06 00 00 48 b8 00 00 00 00 00 fc ff df 4c 89 e2 48 c1 ea 03 <80> 3c 02 00 75 68 48 85 ed 49 89 2c 24 74 24 e8 1b ca 07 f9 48 8d
      RSP: 0018:ffffc900039ff768 EFLAGS: 00010246
      RAX: dffffc0000000000 RBX: ffff88814ae02000 RCX: 0000000000000000
      RDX: 0000000000000000 RSI: 0000000000000004 RDI: ffff88814ae026f0
      RBP: 0000000000000000 R08: 0000000000000000 R09: fffffbfff1d57fdc
      R10: ffffffff8eabfee3 R11: ffffffff8aa0008b R12: 0000000000000000
      R13: ffff88814ae02000 R14: dffffc0000000000 R15: 0000000000000001
      FS:  000055555717a380(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
      CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      CR2: 0000000002555398 CR3: 0000000025044000 CR4: 00000000003506f0
      DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
      Call Trace:
       <TASK>
       __page_pool_destroy net/core/page_pool.c:851 [inline]
       page_pool_release+0x507/0x6b0 net/core/page_pool.c:891
       page_pool_destroy+0x1ac/0x4c0 net/core/page_pool.c:956
       xdp_test_run_teardown net/bpf/test_run.c:216 [inline]
       bpf_test_run_xdp_live+0x1578/0x1af0 net/bpf/test_run.c:388
       bpf_prog_test_run_xdp+0x827/0x1530 net/bpf/test_run.c:1254
       bpf_prog_test_run kernel/bpf/syscall.c:4041 [inline]
       __sys_bpf+0x11bf/0x4920 kernel/bpf/syscall.c:5402
       __do_sys_bpf kernel/bpf/syscall.c:5488 [inline]
       __se_sys_bpf kernel/bpf/syscall.c:5486 [inline]
       __x64_sys_bpf+0x78/0xc0 kernel/bpf/syscall.c:5486
      
      Fixes: 083772c9 ("net: page_pool: record pools per netdev")
      Reported-and-tested-by: syzbot+f9f8efb58a4db2ca98d0@syzkaller.appspotmail.com
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Tested-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Link: https://lore.kernel.org/r/20231130092259.3797753-1-edumazet@google.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      f9893fda
    • Paolo Abeni's avatar
      Merge branch 'net-ethernet-convert-to-platform-remove-callback-returning-void' · 7e022268
      Paolo Abeni authored
      Uwe Kleine-König says:
      
      ====================
      net: ethernet: Convert to platform remove callback returning void
      
      in (implicit) v1 of this series
      (https://lore.kernel.org/netdev/20231117091655.872426-1-u.kleine-koenig@pengutronix.de)
      I tried to address the resource leaks in the three cpsw drivers. However
      this is hard to get right without being able to test the changes. So
      here comes a series that just converts all drivers below
      drivers/net/ethernet to use .remove_new() and adds a comment about the
      potential leaks for someone else to fix the problem.
      
      See commit 5c5a7680 ("platform: Provide a remove callback that
      returns no value") for an extended explanation and the eventual goal.
      The TL;DR; is to prevent bugs like the three noticed here.
      
      Note this series results in no change of behaviour apart from improving
      the error message for the three cpsw drivers from
      
      	remove callback returned a non-zero value. This will be ignored.
      
      to
      
      	Failed to resume device (-ESOMETHING)
      ====================
      
      Link: https://lore.kernel.org/r/20231128173823.867512-1-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      7e022268
    • Uwe Kleine-König's avatar
      net: ethernet: ezchip: Convert to platform remove callback returning void · 7ec1bb2c
      Uwe Kleine-König authored
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new(), which already returns void. Eventually after all drivers
      are converted, .remove_new() will be renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      7ec1bb2c
    • Uwe Kleine-König's avatar
      net: ethernet: ti: cpsw-new: Convert to platform remove callback returning void · a76772e2
      Uwe Kleine-König authored
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new(), which already returns void. Eventually after all drivers
      are converted, .remove_new() will be renamed to .remove().
      
      Replace the error path returning a non-zero value by an error message
      and a comment that there is more to do. With that this patch results in
      no change of behaviour in this driver apart from improving the error
      message.
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarRoger Quadros <rogerq@kernel.org>
      Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      a76772e2
    • Uwe Kleine-König's avatar
      net: ethernet: ti: cpsw: Convert to platform remove callback returning void · 7ac3f867
      Uwe Kleine-König authored
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new(), which already returns void. Eventually after all drivers
      are converted, .remove_new() will be renamed to .remove().
      
      Replace the error path returning a non-zero value by an error message
      and a comment that there is more to do. With that this patch results in
      no change of behaviour in this driver apart from improving the error
      message.
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarRoger Quadros <rogerq@kernel.org>
      Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      7ac3f867
    • Uwe Kleine-König's avatar
      net: ethernet: ti: am65-cpsw: Convert to platform remove callback returning void · 7234dc5c
      Uwe Kleine-König authored
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new(), which already returns void. Eventually after all drivers
      are converted, .remove_new() will be renamed to .remove().
      
      Replace the error path returning a non-zero value by an error message
      and a comment that there is more to do. With that this patch results in
      no change of behaviour in this driver apart from improving the error
      message.
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarRoger Quadros <rogerq@kernel.org>
      Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      7234dc5c
    • Paolo Abeni's avatar
      Merge branch 'devlink-warn-about-existing-entities-during-reload-reinit' · 04447185
      Paolo Abeni authored
      Jiri Pirko says:
      
      ====================
      devlink: warn about existing entities during reload-reinit
      
      Recently there has been a couple of attempts from drivers to block
      devlink reload in certain situations. Turned out, the drivers do not
      properly tear down ports and related netdevs during reload.
      
      To address this, add couple of checks to be done during devlink reload
      reinit action. Also, extend documentation to be more explicit.
      ====================
      
      Link: https://lore.kernel.org/r/20231128115255.773377-1-jiri@resnulli.usSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      04447185
    • Jiri Pirko's avatar
      devlink: warn about existing entities during reload-reinit · 9b2348e2
      Jiri Pirko authored
      During reload-reinit, all entities except for params, resources, regions
      and health reporter should be removed and re-added. Add a warning to
      be triggered in case the driver behaves differently.
      Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
      Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
      Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      9b2348e2
    • Jiri Pirko's avatar
      Documentation: devlink: extend reload-reinit description · 15d74e65
      Jiri Pirko authored
      Be more explicit about devlink entities that may stay and that have to
      be removed during reload reinit action.
      Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
      Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
      Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      15d74e65
    • Yujie Liu's avatar
      bpf/tests: Remove duplicate JSGT tests · f690ff91
      Yujie Liu authored
      It seems unnecessary that JSGT is tested twice (one before JSGE and one
      after JSGE) since others are tested only once. Remove the duplicate JSGT
      tests.
      
      Fixes: 0bbaa02b ("bpf/tests: Add tests to check source register zero-extension")
      Signed-off-by: default avatarYujie Liu <yujie.liu@intel.com>
      Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
      Acked-by: default avatarJohan Almbladh <johan.almbladh@anyfinetworks.com>
      Link: https://lore.kernel.org/bpf/20231130034018.2144963-1-yujie.liu@intel.com
      f690ff91