1. 27 Sep, 2017 28 commits
    • Corey Minyard's avatar
      ipmi: Move lun and address out of channel struct · 5fdb1fb2
      Corey Minyard authored
      Put it in it's own struct, getting ready for channel information
      being dynamically changed.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      5fdb1fb2
    • Corey Minyard's avatar
      ipmi: Retry BMC registration on a failure · c0734bd5
      Corey Minyard authored
      If the BMC fails to register, just set up to retry periodically.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      c0734bd5
    • Corey Minyard's avatar
      ipmi: Rework device id and guid handling to catch changing BMCs · b2cfd8ab
      Corey Minyard authored
      A BMC's guid or device id info may change dynamically, this could
      result in a different configuration that needs to be done.  Adjust
      the BMCs dynamically.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      b2cfd8ab
    • Corey Minyard's avatar
      ipmi: Use a temporary BMC for an interface · c659ff34
      Corey Minyard authored
      This is getting ready for the ability to redo the BMC if it's
      information changes, we need a fallback mechanism.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      c659ff34
    • Corey Minyard's avatar
      ipmi: Dynamically fetch GUID periodically · 28f26ac7
      Corey Minyard authored
      This will catch if the GUID changes.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      28f26ac7
    • Corey Minyard's avatar
      ipmi: Always fetch the guid through ipmi_get_device_id() · 39d3fb45
      Corey Minyard authored
      This is in preparation for making ipmi_get_device_id() dynamically
      return the guid and device id.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      39d3fb45
    • Corey Minyard's avatar
      ipmi: Remove the device id from ipmi_register_smi() · 1e5058ea
      Corey Minyard authored
      It's no longer used, dynamic device id handling is in place now.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      1e5058ea
    • Jeremy Kerr's avatar
      ipmi: allow dynamic BMC version information · aa9c9ab2
      Jeremy Kerr authored
      Currently, it's up to the IPMI SMIs to provide the product & version
      details of BMCs behind registered IPMI SMI interfaces. This device ID is
      provided on SMI regsitration, and kept around for all future queries.
      
      However, this version information isn't always static. For example, a
      BMC may be upgraded at runtime, making the old version information
      stale.
      
      This change allows querying the BMC device ID & version information
      dynamically. If no static device_id argument is provided to
      ipmi_register_smi, then the IPMI core code will perform a Get Device ID
      IPMI command to query the version information when needed. We keep a
      short-term cache of this information so we don't need to re-query
      for every attribute access.
      Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      
      I basically rewrote this, I fixed some locking issues and simplified
      things.  Same functional change, though.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      aa9c9ab2
    • Corey Minyard's avatar
      ipmi: Don't use BMC product/dev ids in the BMC name · 68e7e50f
      Corey Minyard authored
      There are a lot of bad things that a set of BMCs could do that
      would really confuse the IPMI driver; it's possible for BMCs with
      different GUIDs to have the same product/devid (though that's
      not technically legal), which would result in platform device
      namespace collisions.  Fixing it would involve either using
      the GUID in the BMC name, which resulted in huge names, or
      just using an ida for numbering the BMCs.  The latter approach
      was chosen to avoid the huge names.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      68e7e50f
    • Jeremy Kerr's avatar
      ipmi: Make ipmi_demangle_device_id more generic · c468f911
      Jeremy Kerr authored
      Currently, ipmi_demagle_device_id requires a full response buffer in its
      data argument. This means we can't use it to parse a response in a
      struct ipmi_recv_msg, which has the netfn and cmd as separate bytes.
      
      This change alters the definition and users of ipmi_demangle_device_id
      to use a split netfn, cmd and data buffer, so it can be used with
      non-sequential responses.
      Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      
      Fixed the ipmi_ssif.c and ipmi_si_intf.c changes to use data from the
      response, not the data from the message, when passing info to the
      ipmi_demangle_device_id() function.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      c468f911
    • Jeremy Kerr's avatar
      ipmi: Add a reference from BMC devices to their interfaces · a9137c3d
      Jeremy Kerr authored
      In an upcoming change, we'll want to grab a reference to the ipmi_smi_t
      from a struct bmc_device. This change adds a pointer to allow this.
      Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      
      Reworked to support multiple interfaces on a BMC.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      a9137c3d
    • Corey Minyard's avatar
      ipmi: Get the device id through a function · 511d57dc
      Corey Minyard authored
      This makes getting the device id consistent, and make it possible
      to add a function to fetch it dynamically later.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      511d57dc
    • Corey Minyard's avatar
      ipmi: Fix printing the BMC guid · 9b64a8ba
      Corey Minyard authored
      It was just wrong.  Make it print according to the guid spec.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      9b64a8ba
    • Corey Minyard's avatar
      ipmi: Rework BMC registration · a2cb600f
      Corey Minyard authored
      There was a certain error case where the BMC wouldn't be deregistered
      like it should be.  Rework the BMC registration to make calling
      ipmi_bmc_unregister() ok even if it's not registered and to clean up
      the error handling for ipmi_bmc_register().
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      a2cb600f
    • Corey Minyard's avatar
      ipmi: Prefer ACPI system interfaces over SMBIOS ones · 7e030d6d
      Corey Minyard authored
      The recent changes to add SMBIOS (DMI) IPMI interfaces as platform
      devices caused DMI to be selected before ACPI, causing ACPI type
      of operations to not work.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      7e030d6d
    • Corey Minyard's avatar
      ipmi: Fix issues with BMC refcounts · 9ca15af3
      Corey Minyard authored
      BMC device refcounts were not being decremented after fetching from
      driver_find_device().  Also, document the use of ipmidriver_mutex
      and tighten it's span some by incrementing the BMC's usecount in
      the BMC find routines and not later.  This will be important for
      future changes where a long mutex hold area will complicate things.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      9ca15af3
    • Corey Minyard's avatar
      ipmi: Check that the device type is BMC when scanning device · eae4a36a
      Corey Minyard authored
      Just an added safety check.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      eae4a36a
    • Corey Minyard's avatar
      ipmi: Move bmc find routing to below bmc device type · f33e4df8
      Corey Minyard authored
      No functional change, this is for a later change that uses the
      bmc device type.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      f33e4df8
    • Corey Minyard's avatar
      ipmi: Fix getting the GUID data · 72630d9a
      Corey Minyard authored
      It was off by one.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      72630d9a
    • Bhumika Goyal's avatar
      IPMI: make ipmi_poweroff_handler const · e6dd76a6
      Bhumika Goyal authored
      Make this const as it is only passed to a const argument of the function
      ipmi_create_user.
      Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      e6dd76a6
    • Corey Minyard's avatar
      ipmi: Make IPMI panic strings always available · 1c9f98d1
      Corey Minyard authored
      They were set by config items, but people complained that they were
      never turned on.  So have them always available and enabled by a
      module parameter.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      1c9f98d1
    • Colin Ian King's avatar
      char: ipmi: make function ipmi_get_info_from_resources static · b72fce52
      Colin Ian King authored
      The function ipmi_get_info_from_resources is local to the source and
      does not need to be in global scope, so make it static.  Add in
      newline to function declaration to make it checkpatch warning clean.
      
      Cleans up sparse warnings:
      symbol 'ipmi_get_info_from_resources' was not declared. Should it
      be static?
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      b72fce52
    • Corey Minyard's avatar
      ipmi: fix unsigned long underflow · 392a17b1
      Corey Minyard authored
      When I set the timeout to a specific value such as 500ms, the timeout
      event will not happen in time due to the overflow in function
      check_msg_timeout:
      ...
      	ent->timeout -= timeout_period;
      	if (ent->timeout > 0)
      		return;
      ...
      
      The type of timeout_period is long, but ent->timeout is unsigned long.
      This patch makes the type consistent.
      Reported-by: default avatarWeilong Chen <chenweilong@huawei.com>
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      Tested-by: default avatarWeilong Chen <chenweilong@huawei.com>
      Cc: <stable@vger.kernel.org> # 3.16.x
      392a17b1
    • Hanjun Guo's avatar
      char: ipmi: eliminate misleading print info when being probed via ACPI · 719c1b38
      Hanjun Guo authored
      When ipmi is probed via ACPI, the boot log shows
      
      [   17.945139] ipmi_si IPI0001:00: probing via device tree
      [   17.950369] ipmi_si IPI0001:00: ipmi_si: probing via ACPI
      [   17.955795] ipmi_si IPI0001:00: [io  0x00e4-0x3fff] regsize 1 spacing 1 irq 0
      [   17.962932] ipmi_si: Adding ACPI-specified bt state machine
      
      which "ipmi_si IPI0001:00: probing via device tree" is misleading
      with a ACPI HID "IPI0001" but probing via DT.
      
      Eliminate this misleading print info by checking of_node is valid
      or not before calling of_ipmi_probe().
      Signed-off-by: default avatarHanjun Guo <hanjun.guo@linaro.org>
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      719c1b38
    • Linus Torvalds's avatar
      Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs · 9cd6681c
      Linus Torvalds authored
      Pull quota and isofs fixes from Jan Kara:
       "Two quota fixes (fallout of the quota locking changes) and an isofs
        build fix"
      
      * 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs:
        quota: Fix quota corruption with generic/232 test
        isofs: fix build regression
        quota: add missing lock into __dquot_transfer()
      9cd6681c
    • Linus Torvalds's avatar
      Merge tag 'linux-kselftest-4.14-rc3-fixes' of... · 225d3b67
      Linus Torvalds authored
      Merge tag 'linux-kselftest-4.14-rc3-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
      
      Pull kselftest fixes from Shuah Khan:
       "This update consists of:
      
         - fixes to several existing tests
      
         - a test for regression introduced by b9470c27 ("inet: kill
           smallest_size and smallest_port")
      
         - seccomp support for glibc 2.26 siginfo_t.h
      
         - fixes to kselftest framework and tests to run make O=dir use-case
      
         - fixes to silence unnecessary test output to de-clutter test results"
      
      * tag 'linux-kselftest-4.14-rc3-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest: (28 commits)
        selftests: timers: set-timer-lat: Fix hang when testing unsupported alarms
        selftests: timers: set-timer-lat: fix hang when std out/err are redirected
        selftests/memfd: correct run_tests.sh permission
        selftests/seccomp: Support glibc 2.26 siginfo_t.h
        selftests: futex: Makefile: fix for loops in targets to run silently
        selftests: Makefile: fix for loops in targets to run silently
        selftests: mqueue: Use full path to run tests from Makefile
        selftests: futex: copy sub-dir test scripts for make O=dir run
        selftests: lib.mk: copy test scripts and test files for make O=dir run
        selftests: sync: kselftest and kselftest-clean fail for make O=dir case
        selftests: sync: use TEST_CUSTOM_PROGS instead of TEST_PROGS
        selftests: lib.mk: add TEST_CUSTOM_PROGS to allow custom test run/install
        selftests: watchdog: fix to use TEST_GEN_PROGS and remove clean
        selftests: lib.mk: fix test executable status check to use full path
        selftests: Makefile: clear LDFLAGS for make O=dir use-case
        selftests: lib.mk: kselftest and kselftest-clean fail for make O=dir case
        Makefile: kselftest and kselftest-clean fail for make O=dir case
        selftests/net: msg_zerocopy enable build with older kernel headers
        selftests: actually run the various net selftests
        selftest: add a reuseaddr test
        ...
      225d3b67
    • Linus Torvalds's avatar
      Merge branch 'x86-fpu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 7031b641
      Linus Torvalds authored
      Pull x86 fpu fixes and cleanups from Ingo Molnar:
       "This is _way_ more cleanups than fixes, but the bugs were subtle and
        hard to hit, and the primary reason for them existing was the
        unnecessary historical complexity of some of the x86/fpu interfaces.
      
        The first bunch of commits clean up and simplify the xstate user copy
        handling functions, in reaction to the collective head-scratching
        about the xstate user-copy handling code that leads up to the fix for
        this SkyLake xstate handling bug:
      
           0852b374: x86/fpu: Add FPU state copying quirk to handle XRSTOR failure on Intel Skylake CPUs
      
        The cleanups don't change any functionality, they just (hopefully)
        make it all clearer, more consistent, more debuggable and more robust.
      
        Note that most of the linecount increase comes from these commits,
        where we better split the user/kernel copy logic by having more
        variants, instead repeated fragile patterns of:
      
                     if (kbuf) {
                             memcpy(kbuf + pos, data, copy);
                     } else {
                             if (__copy_to_user(ubuf + pos, data, copy))
                                     return -EFAULT;
                     }
      
        The next bunch of commits simplify the FPU state-machine to get rid of
        old lazy-FPU idiosyncrasies - a defensive simplification to make all
        the code easier to review and fix. No change in functionality.
      
        Then there's a couple of additional debugging tweaks: static checker
        warning fix and move an FPU related warning to under WARN_ON_FPU(),
        followed by another bunch of commits that represent a finegrained
        split-up of the fixes from Eric Biggers to handle weird xstate bits
        properly.
      
        I did this finegrained split-up because some of these fixes also
        impact the ABI for weird xstate handling, for which we'd like to have
        good bisection results, should they cause any problems. (We also had
        one regression with the more monolithic fixes, so splitting it all up
        sounded prudent for robustness reasons as well.)
      
        About the whole series: the commits up to 03eaec81 have been in
        -next for months - but I've recently rebased them to remove a state
        machine clean-up commit that was objected to, and to make it more
        bisectable - so technically it's a new, rebased tree.
      
        Robustness history: this series had some regressions along the way,
        and all reported regressions have been fixed. All but one of the
        regressions manifested itself as easy to report warnings. The previous
        version of this latest series was also in linux-next, with one
        (warning-only) regression reported which is fixed in the latest
        version.
      
        Barring last minute brown paper bag bugs (and the commits are now
        older by a day which I'd hope helps paperbag reduction), I'm
        reasonably confident about its general robustness.
      
        Famous last words ..."
      
      * 'x86-fpu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: (42 commits)
        x86/fpu: Use using_compacted_format() instead of open coded X86_FEATURE_XSAVES
        x86/fpu: Use validate_xstate_header() to validate the xstate_header in copy_user_to_xstate()
        x86/fpu: Eliminate the 'xfeatures' local variable in copy_user_to_xstate()
        x86/fpu: Copy the full header in copy_user_to_xstate()
        x86/fpu: Use validate_xstate_header() to validate the xstate_header in copy_kernel_to_xstate()
        x86/fpu: Eliminate the 'xfeatures' local variable in copy_kernel_to_xstate()
        x86/fpu: Copy the full state_header in copy_kernel_to_xstate()
        x86/fpu: Use validate_xstate_header() to validate the xstate_header in __fpu__restore_sig()
        x86/fpu: Use validate_xstate_header() to validate the xstate_header in xstateregs_set()
        x86/fpu: Introduce validate_xstate_header()
        x86/fpu: Rename fpu__activate_fpstate_read/write() to fpu__prepare_[read|write]()
        x86/fpu: Rename fpu__activate_curr() to fpu__initialize()
        x86/fpu: Simplify and speed up fpu__copy()
        x86/fpu: Fix stale comments about lazy FPU logic
        x86/fpu: Rename fpu::fpstate_active to fpu::initialized
        x86/fpu: Remove fpu__current_fpstate_write_begin/end()
        x86/fpu: Fix fpu__activate_fpstate_read() and update comments
        x86/fpu: Reinitialize FPU registers if restoring FPU state fails
        x86/fpu: Don't let userspace set bogus xcomp_bv
        x86/fpu: Turn WARN_ON() in context switch into WARN_ON_FPU()
        ...
      7031b641
    • Jan Kara's avatar
      quota: Fix quota corruption with generic/232 test · 4c6bb696
      Jan Kara authored
      Eric has reported that since commit d2faa415 "quota: Do not acquire
      dqio_sem for dquot overwrites in v2 format" test generic/232
      occasionally fails due to quota information being incorrect. Indeed that
      commit was too eager to remove dqio_sem completely from the path that
      just overwrites quota structure with updated information. Although that
      is innocent on its own, another process that inserts new quota structure
      to the same block can perform read-modify-write cycle of that block thus
      effectively discarding quota information update if they race in a wrong
      way.
      
      Fix the problem by acquiring dqio_sem for reading for overwrites of
      quota structure. Note that it *is* possible to completely avoid taking
      dqio_sem in the overwrite path however that will require modifying path
      inserting / deleting quota structures to avoid RMW cycles of the full
      block and for now it is not clear whether it is worth the hassle.
      
      Fixes: d2faa415Reported-and-tested-by: default avatarEric Whitney <enwlinux@gmail.com>
      Signed-off-by: default avatarJan Kara <jack@suse.cz>
      4c6bb696
  2. 26 Sep, 2017 12 commits