- 03 Feb, 2016 40 commits
-
-
Bhumika Goyal authored
Replaced explicit NULL comparision with its simplier form. Found using coccinelle: @replace_rule@ expression e; @@ -e == NULL + !e Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Bhumika Goyal authored
Remove explicit NULL comparision and replace it with a simpier form. Detected using checkpatch.pl. Signed-off-by:
-
Bhumika Goyal authored
Fixed 'braces {} are not necessary for single statement blocks' checkpatch.pl warning. Signed-off-by: -
Sushuruth Sadagopan authored
Fix style of several comments. Signed-off-by:
Sushuruth Sadagopan <sushsada@gmail.com> Signed-off-by:
-
Anjali Menon authored
Added a spaces around '|' to fix the check detected by checkpatch.pl CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by:
Anjali Menon <cse.anjalimenon@gmail.com> Signed-off-by:
-
Bhumika Goyal authored
This patch removes the return statement at the end of a void function as it is not necessary.This was found by checkpatch.pl . Signed-off-by:
-
Parinay Kondekar authored
The libcfs_ioctl.h header has a comment about a snapshot ioctl which has been removed for years. Lets remove the comment to avoid confusion. Broken out of patch 17492. Signed-off-by:
Parinay Kondekar <parinay.kondekar@seagate.com> Signed-off-by:
James Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5844 Reviewed-on: http://review.whamcloud.com/17492Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Reviewed-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
John L. Hammond <john.hammond@intel.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Frank Zago authored
This fixes a bunch of sparse warnings. There is no code change. Signed-off-by:
frank zago <fzago@cray.com> Reviewed-on: http://review.whamcloud.com/11819 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5396Reviewed-by:
James Simmons <uja.ornl@gmail.com> Reviewed-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Oleg Drokin authored
When casting unsingned long userspace pointer from ioctl argument to a pointer suitable for use with userspace access functions, need to remember to add __user attribute, to make sparse happy. Signed-off-by:
-
Oleg Drokin authored
This makes sparse happy. Signed-off-by:
-
Oleg Drokin authored
This makes sparse happier. Signed-off-by:
-
Oleg Drokin authored
When calling ll_fid2path, it expects a userspace pointer. Signed-off-by:
-
Oleg Drokin authored
unsigned long user address must be casted with __user attribute to make sparse happy when used with userspace access functions. Signed-off-by:
-
Oleg Drokin authored
Since it is a userspace pointer, this makes things neater and sparse happier. Signed-off-by:
-
Oleg Drokin authored
This makes sparse happy too. Signed-off-by:
-
Oleg Drokin authored
When casting unsigned long userspace pointer for use with userspace-accessing functions, need to use __user attribute to make sparse happy. Signed-off-by:
-
Oleg Drokin authored
This shuts some sparse address space mismatch warnings Signed-off-by:
-
Oleg Drokin authored
Casts for get/put_user and copy_to/from_user should have __user attribute for the userspace buffer address. Signed-off-by:
-
Oleg Drokin authored
This is a user pointer, so that makes sparse a lot happier. Signed-off-by:
-
Oleg Drokin authored
Cannot use memcpy, but use copy_to/from_user instead Signed-off-by:
-
Oleg Drokin authored
Also update all callers. This fixes a bunch of address space mismatch warnings from sparse. Signed-off-by:
-
Oleg Drokin authored
sysfs store methods provide us with a kernel buffer already, but lprocfs_write_helper is expecting a user buffer. Replace lprocfs_write_helper with kstrto[u]int() calls instead in contention_seconds_store() and lockless_truncate_store() Signed-off-by:
-
Oleg Drokin authored
The buffer that lprocfs_write_frac_u64_helper is working on is presumed to be a userspace one, so it's not suitable for use on kernel buffers. Signed-off-by:
-
Oleg Drokin authored
This also silents a sparse address space warning Signed-off-by:
-
Oleg Drokin authored
Also update all methods and calls everywhere. Signed-off-by:
-
Oleg Drokin authored
For some crazy reason ll_obd_statfs decided to decode async flag passed from userspace and then pass it via a userspace pointer argument to lov_iocontrol. This patch moves flags decoding to lov_iocontrol where it belongs. Signed-off-by:
-
Oleg Drokin authored
This also happens to silence sparce warnings about different address spaces. Signed-off-by:
-
Oleg Drokin authored
arg is a userspace pointer and marking it as such makes sparse happy. Signed-off-by:
-
Oleg Drokin authored
Make them void __user * instead of char * (or char __user *), void * removes the necessity of explicit casts to proper type where people also need to remember __user qualifiers, so I think it works better here. Signed-off-by:
-
Oleg Drokin authored
Make them void __user * instead of char * (or char __user *), void * removes the necessity of explicit casts to proper type where people also need to remember __user qualifiers, so I think it works better here. Signed-off-by:
-
Oleg Drokin authored
Just make clear which pointers are from userspace and which are not in libcfs_ioctl_getdata/libcfs_ioctl_popdata and their callers. Signed-off-by:
-
John L. Hammond authored
In lustre/obdecho/echo_client.c, remove handling of lov_stripe_md passed from userspace (since userspace never passes it). Remove the LOV specific code (ed_next_islov) from the echo client (since it doesn't work). Remove echo_get_stripe_off_id() and all calls to it since the stripe count of the passed in lsm is always 0 and the funciton does nothing in this case. Remove the then unused lsm parameters of echo_client_page_debug_setup() and echo_client_page_debug_check(). In the OBD_IOC_GETATTR and OBD_IOC_SETATTR cases of echo_client_iocontrol() do not set the oi_md member of struct obd_info since only LOV OBD methods access it. Signed-off-by:
Bobi Jam <bobijam@gmail.com> Reviewed-by:
-
Oleg Drokin authored
Remove long unused ECHO_IOC_GET_STRIPE, ECHO_IOC_SET_STRIPE, ECHO_IOC_ENQUEUE and ECHO_IOC_CANCEL ioctls. Signed-off-by:
-
Oleg Drokin authored
This has been unused for ages and could be safely removed now. Signed-off-by:
-
Oleg Drokin authored
IOC_LIBCFS_DEBUG_PEER was added back in the stone ages to print debug statistics on a peer when peer timeout happens. Redo it properly as a separate LNet API call, also get rid of "ioctl" forwarding into the underlying LNDs, since no current LNDs implement this function anymore. Signed-off-by:
-
Oleg Drokin authored
It's not used anywhere outside of api-ni.c anyway. Signed-off-by:
-
Julia Lawall authored
This export_operations structure is never modified, so declare it as const. Most other structures of this type are already const. Done with the help of Coccinelle. Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
Julia Lawall authored
These lu_device_operations and cl_device_operations structures are never modified, so declare them as const. Other structures of these types are already const. Done with the help of Coccinelle. Signed-off-by:
-
Joshua Clayton authored
nrs_resource_put_safe() might hold a lock one one struct while operating on the other. There are 2 levels of structures. Use nrs_policy_put(), which has locking baked in. sparse gives the following warning: drivers/staging/lustre//lustre/ptlrpc/nrs.c:498:39: warning: context imbalance in 'nrs_resource_put_safe' - different lock contexts for basic block Signed-off-by:
Joshua Clayton <stillcompiling@gmail.com> Signed-off-by:
-
Valdis Kletnieks authored
Clean up another case of the compiler remininding the programmer they are an idiot: drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c:308:34: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] LASSERT(page_pools.epp_waitqlen >= 0); Just lose the assert, and save a page of compiler spew. Signed-off-by:
Valdis Kletnieks <Valdis.Kletnieks@vt.edu> Signed-off-by:
-
