1. 24 Jan, 2011 3 commits
    • Eliad Peller's avatar
      wl12xx: fix some sparse warnings · 6177eaea
      Eliad Peller authored
      Note that wl1271_write32() calls cpu_to_le32() by itself, so calling
      wl1271_write32(addr, cpu_to_le32(val)) is in fact a bug on BE systems.
      
      Fix the following sparse warnings:
      
      drivers/net/wireless/wl12xx/cmd.c:662:16: warning: incorrect type in assignment (different base types)
      drivers/net/wireless/wl12xx/cmd.c:662:16:    expected unsigned short [unsigned] [addressable] [usertype] llc_type
      drivers/net/wireless/wl12xx/cmd.c:662:16:    got restricted __be16 [usertype] <noident>
      drivers/net/wireless/wl12xx/cmd.c:674:17: warning: incorrect type in assignment (different base types)
      drivers/net/wireless/wl12xx/cmd.c:674:17:    expected unsigned int [unsigned] [addressable] [usertype] sender_ip
      drivers/net/wireless/wl12xx/cmd.c:674:17:    got restricted __be32 [usertype] ip_addr
      drivers/net/wireless/wl12xx/rx.c:202:4: warning: incorrect type in argument 3 (different base types)
      drivers/net/wireless/wl12xx/rx.c:202:4:    expected unsigned int [unsigned] [usertype] val
      drivers/net/wireless/wl12xx/rx.c:202:4:    got restricted __le32 [usertype] <noident>
      drivers/net/wireless/wl12xx/acx.c:1247:23: warning: incorrect type in assignment (different base types)
      drivers/net/wireless/wl12xx/acx.c:1247:23:    expected restricted __le32 [usertype] ht_capabilites
      drivers/net/wireless/wl12xx/acx.c:1247:23:    got unsigned long
      drivers/net/wireless/wl12xx/acx.c:1250:24: warning: invalid assignment: |=
      drivers/net/wireless/wl12xx/acx.c:1250:24:    left side has type restricted __le32
      drivers/net/wireless/wl12xx/acx.c:1250:24:    right side has type unsigned long
      drivers/net/wireless/wl12xx/acx.c:1253:24: warning: invalid assignment: |=
      drivers/net/wireless/wl12xx/acx.c:1253:24:    left side has type restricted __le32
      drivers/net/wireless/wl12xx/acx.c:1253:24:    right side has type unsigned long
      drivers/net/wireless/wl12xx/acx.c:1256:24: warning: invalid assignment: |=
      drivers/net/wireless/wl12xx/acx.c:1256:24:    left side has type restricted __le32
      drivers/net/wireless/wl12xx/acx.c:1256:24:    right side has type unsigned long
      Signed-off-by: default avatarEliad Peller <eliad@wizery.com>
      Signed-off-by: default avatarLuciano Coelho <coelho@ti.com>
      6177eaea
    • Dan Carpenter's avatar
      wl12xx: use after free in debug code · 0dd38667
      Dan Carpenter authored
      If debugging is turned on, then wl1271_dump() dereferences a freed
      variable.
      Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
      Signed-off-by: default avatarLuciano Coelho <luciano.coelho@nokia.com>
      0dd38667
    • Eliad Peller's avatar
      wl12xx: remove redundant debugfs_remove_recursive() call · 3c2c04a1
      Eliad Peller authored
      Upon rmmod, the <debugfs>/ieee80211/phyX dir is being removed.
      later, we try to remove <debugfs>/ieee80211/phyX/wl12xx, which
      might result in NULL dereference.
      
      Remove the excessive debugfs_remove_recursive() call.
      (consequently, there is no more need to save wl->rootdir)
      Reported-by: default avatarArik Nemtsov <arik@wizery.com>
      Signed-off-by: default avatarEliad Peller <eliad@wizery.com>
      Signed-off-by: default avatarLuciano Coelho <luciano.coelho@nokia.com>
      3c2c04a1
  2. 21 Jan, 2011 27 commits
  3. 19 Jan, 2011 10 commits