- 16 Nov, 2020 40 commits
-
-
Sakari Ailus authored
If starting a video buffer queue fails, the buffers are returned to videobuf2. Remove the reference to the buffer from the driver's queue as well. Fixes: c2a6a07a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") Signed-off-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Cc: stable@vger.kernel.org # v4.16 and up Reviewed-by:
Andy Shevchenko <andy.shevchenko@gmail.com> Reviewed-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-
Sakari Ailus authored
CIO2_IMAGE_MAX_LENGTH is the maximum height of the image. Rename it as "CIO2_IMAGE_MAX_HEIGHT" in order to better describe what it is. Suggested-by:
-
Sakari Ailus authored
Now that the values are unsigned, we can remove the explicit cast to u32. Signed-off-by:
-
Sakari Ailus authored
Use unsigned values for width, height, bit shifts and registers, effectively for all definitions that are not signed. Signed-off-by:
-
Sakari Ailus authored
The ipu3-cio2 doesn't make use of the field and this is reflected in V4L2 buffers as well as the try format. Do this in active format, too. Fixes: c2a6a07a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") Signed-off-by:
Bingbu Cao <bingbu.cao@intel.com> Reviewed-by:
-
Sakari Ailus authored
Validate media bus code, width and height when setting the subdev format. This effectively reworks how setting subdev format is implemented in the driver. Fixes: c2a6a07a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") Signed-off-by:
-
Sakari Ailus authored
Pad format can be accessed from user space. Serialise access to it. Fixes: c2a6a07a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") Signed-off-by:
-
Sakari Ailus authored
Return actual subdev format on ipu3-cio2 subdev pads. The earlier implementation was based on an infinite recursion that exhausted the stack. Reported-by:
Tsuchiya Yuto <kitakar@gmail.com> Fixes: c2a6a07a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") Signed-off-by:
-
Sakari Ailus authored
The existing link format validation failure debug message in media-entity.c helped to pinpoint the point of failure but provided no additional information what's wrong. Tell the user exactly why the validation failed. Signed-off-by:
-
Lad Prabhakar authored
Add support for test pattern control supported by the sensor. Signed-off-by:
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by:
Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by:
Jacopo Mondi <jacopo@jmondi.org> Signed-off-by:
-
Lad Prabhakar authored
Add support to read the bus-type for V4L2_MBUS_BT656 and enable BT.656 mode in the sensor if needed. For backward compatibility with older DTS where the bus-type property was not mandatory, assume V4L2_MBUS_PARALLEL as it was the only supported bus at the time. v4l2_fwnode_endpoint_alloc_parse() will not fail if 'bus-type' is not specified. Signed-off-by:
Jacopo Mondi <jacopo+renesas@jmondi.org> Signed-off-by:
-
Lad Prabhakar authored
Parse endpoint properties using v4l2_fwnode_endpoint_alloc_parse() to determine the bus type and store it in the driver structure. Set bus_type to V4L2_MBUS_PARALLEL as it's the only supported one Signed-off-by:
-
Niklas Söderlund authored
The only supported bus for the R-Car CSI-2 driver is CSI-2 DPHY, specify this before parsing the fwnode. Signed-off-by:
Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by:
-
Niklas Söderlund authored
Use the fwnode_graph_get_endpoint_by_id() interface instead of of_graph_get_endpoint_by_regs() to fetch the fwnode. This saves translating between a device_node and fwnode_handle. Signed-off-by:
-
Niklas Söderlund authored
Add the YAML dt-bindings document for ADV7604. Signed-off-by:
-
Niklas Söderlund authored
Convert ADV7604 video decoder documentation to json-schema. Signed-off-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Niklas Söderlund authored
As of [1] the hpd-gpios property is optional, document it as such. 1. commit 269bd132 ("[media] media: adv7604: improve usage of gpiod API") Signed-off-by:
-
Sakari Ailus authored
Earlier it was expected that there would be more variable size endpoint properties and that most if not all drivers would need them. For that reason it was expected also that v4l2_fwnode_endpoint_parse would no longer be needed. What actually happened that not all drivers require "link-frequencies", the only variable size media endpoint property without a small upper limit. Therefore drivers that do not need that information are fine using v4l2_fwnode_endpoint_parse. So don't tell drivers to use v4l2_fwnode_endpoint_alloc_parse in all cases. Signed-off-by:
-
Sakari Ailus authored
Rework the documentation of v4l2_fwnode_endpoint_parse for better readability, usefulness and correctness. Signed-off-by:
-
Sakari Ailus authored
Don't zero parts of the vep argument to v4l2_fwnode_endpoint_parse() anymore as this can no longer be done while still supporting defaults on multiple bus types. Signed-off-by:
-
Sakari Ailus authored
Document that the caller of v4l2_fwnode_endpoint_parse() must init the fields of struct v4l2_fwnode_endpoint (vep argument) fields. It used to be that the fields were zeroed by v4l2_fwnode_endpoint_parse when bus type was set to V4L2_MBUS_UNKNOWN but with recent changes (Fixes: line below) that no longer makes sense. Fixes: bb4bba92 ("media: v4l2-fwnode: Make bus configuration a struct") Signed-off-by:
-
Sakari Ailus authored
The v4l2_fwnode_parse_endpoint() function can make use of defaults in multiple bus types. To use this feature, all callers must zero the rest of the fields of this struct, too. All other drivers appear to do that already apart from this one. Signed-off-by:
-
Philipp Zabel authored
Convert to YAML and add generic IP core compatibles "cnm,codadx6", "cnm,codahx4", "cnm,coda7541", and "cnm,coda960" in addition to the SoC specific compatibles. The new generic compatibles are already used in the SoC device trees and replace the free form comments. For example: - compatible : should be "fsl,<chip>-src" for i.MX SoCs: (a) "fsl,imx27-vpu" for CodaDx6 present in i.MX27 turns into: properties: compatible: oneOf: - items: - const: fsl,imx27-vpu - const: cnm,codadx6 This allows to properly specify the secondary JPEG unit interrupt that is only present on cnm,coda960. Also add the missing "fsl,imx6dl-vpu", "cnm,coda960" compatible. The AXI bus connection to the internal SRAM is different between i.MX6Q and i.MX6DL, which requires the driver to load a different firmware depending on the SoC. Further, specify the power-domain property for i.MX6 and change the clock order from "ahb", "per" to "per", "ahb". This order is currently used in all SoC device trees. Signed-off-by:Philipp Zabel <p.zabel@pengutronix.de> Reviewed-by:
-
Jacopo Mondi authored
Document endpoint properties for the parallel bus type and add them to the example. Specify a few constraints: - If the bus type is BT.656 no hsync or vsync polarities can be specified. - If the bus width is 10 bits, not data-shift can be applied. Reviewed-by:
-
Jacopo Mondi authored
In order to establish required properties based on the selected bus type, make the 'bus-type' property mandatory. As this change documents an endpoint property, also document the 'remote-endpoint' one now that the 'endpoint' schema has been expanded. Binary compatibility with existing DTB is kept as the driver does not enforce the property to be present, and shall fall-back to default parallel bus configuration, which was the only supported bus type, if the property is not specified. Reviewed-by:
-
Jacopo Mondi authored
Convert the ov772x binding document to json-schema and update the MAINTAINERS file accordingly. Reviewed-by:
-
Jacopo Mondi authored
Convert the imx214 bindings document to json-schema and update the MAINTAINERS file accordingly. Reviewed-by:
-
Jacopo Mondi authored
Convert the mt9v111 bindings document to json-schema and update the MAINTAINERS file accordingly. Reviewed-by:
-
Eugen Hristev authored
Add support for the mode 6 for the sensor, this mode uses 3/8 subsampling and 3 horizontal binning. Aspect ratio is changed. Split the bin_ratio variable into two parts, one for width and one for height, as the ratio is no longer preserved when doing subsampling in this mode. Signed-off-by:
Eugen Hristev <eugen.hristev@microchip.com> Reviewed-by:
Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by:
-
Eugen Hristev authored
Binning enum is unused. Remove from driver. Suggested-by:
Sakari Ailus <sakari.ailus@ifi.fi> Signed-off-by:
-
Sowjanya Komatineni authored
IMX274 has analog 2.8V supply, digital core 1.8V supply, and vddl digital io 1.2V supply which are optional based on camera module design. IMX274 also need external 24Mhz clock and is optional based on camera module design. This patch adds support for IMX274 power on and off to enable and disable these supplies and external clock. Reviewed-by:
Sowjanya Komatineni <skomatineni@nvidia.com> Signed-off-by:
-
Sowjanya Komatineni authored
Sensor should already be in standby during remove and there is no need to configure sensor registers for stream stop. Signed-off-by:
Thierry Reding <treding@nvidia.com> Signed-off-by:
-
Sowjanya Komatineni authored
As per Sony IMX274 Y_OUT_SIZE should be the height of effective image output from the sensor which are the actual total lines sent over MIPI CSI to receiver. So, Y_OUT_SIZE should be same as crop height and this patch fixes it. Signed-off-by:
-
Kieran Bingham authored
Fix the incorrect spelling asyncrhronous as asynchronous, which is visible in the public documentation of enum v4l2_async_match_type. Fixes: ab4f5a4a ("[media] v4l2-async: document the remaining stuff") Signed-off-by:
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Signed-off-by:
-
Sergey Senozhatsky authored
Fix OV2740 build breakage by selecting REGMAP_I2C config: ov2740.c:1011:23: error: variable has incomplete type 'struct regmap_config' struct regmap_config regmap_config = { }; ^ ov2740.c:1011:9: note: forward declaration of 'struct regmap_config' struct regmap_config regmap_config = { }; ^ ov2740.c:1028:11: error: implicit declaration of function 'devm_regmap_init_i2c' regmap = devm_regmap_init_i2c(client, ®map_config); Signed-off-by:Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Signed-off-by:
-
Bingbu Cao authored
The minimal valid exposure value should be 4 lines instead of 8 for ov2740 mannual exposure control. Signed-off-by:
-
Krzysztof Kozlowski authored
The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by:Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by:
-
Krzysztof Kozlowski authored
The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: -
Krzysztof Kozlowski authored
The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: -
Krzysztof Kozlowski authored
The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by:
-
