- 28 Aug, 2021 3 commits
-
-
Phillip Potter authored
Add entry for CFG80211 to reflect that it is currently being worked on and is a desirable feature to have for this driver. Leave entries for LIB80211 and MAC80211 in case anyone else wishes to work on them - they can always be removed later, but MAC80211 in particular would certainly be good to aim for. Also, include an entry for improving error handling, as this is another goal of the cleanup effort. Signed-off-by:
Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20210828000231.1458-1-phil@philpotter.co.ukSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Aldas Taraškevičius authored
checkpatch.pl warning: It's generally not useful to have the filename in the file Remove the filenames. Signed-off-by:
Aldas Taraškevičius <aldas60@gmail.com> Link: https://lore.kernel.org/r/20210827163203.4100-1-aldas60@gmail.comSigned-off-by:
-
Aakash Hemadri authored
p80211_hdr->frame_control is u16, change to __le16 to satisfy sparse warning: wlan-ng/prism2sta.c:253:43: warning: invalid assignment: |= wlan-ng/prism2sta.c:253:43: left side has type unsigned short wlan-ng/prism2sta.c:253:43: right side has type restricted __le16 Fixes: 6277fbfd ("staging: wlan-ng: Remove pointless a3/a4 union") Reviewed-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
Aakash Hemadri <aakashhemadri123@gmail.com> Link: https://lore.kernel.org/r/20210828042949.2276341-1-aakashhemadri123@gmail.comSigned-off-by:
-
- 27 Aug, 2021 7 commits
-
-
Michael Straube authored
Rename fields of struct rtl_ps to avoid camel case. PreCCAState -> pre_cca_state CurCCAState -> cur_cca_state PreRFState -> pre_rf_state CurRFState -> cur_rf_state Rssi_val_min -> rssi_val_min Reg874 -> reg_874 RegC70 -> reg_c70 Reg85C -> reg_85c RegA74 -> reg_a74 Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210827094144.13290-5-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
Function ODM_DynamicPrimaryCCA_DupRTS() is unused, remove it. Signed-off-by:
-
Michael Straube authored
Rename fields of struct dyn_primary_cca to avoid camel case. PriCCA_flag -> pri_cca_flag DupRTS_flag -> dup_rts_flag Monitor_flag -> monitor_flag Signed-off-by:
-
Michael Straube authored
Rename struct field Wifi_Error_Status to avoid camel case. Wifi_Error_Status -> wifi_error_status Signed-off-by:
-
Fabio M. De Francesco authored
Provide a TODO file that lists the tasks that should be carried out in order to move this driver off drivers/staging. Acked-by:
Fabio M. De Francesco <fmdefrancesco@gmail.com> Link: https://lore.kernel.org/r/20210827100813.18610-1-fmdefrancesco@gmail.comSigned-off-by:
-
Jing Yangyang authored
Eliminate the following coccicheck warning: ./drivers/staging/r8188eu/os_dep/os_intfs.c:505:6-12: Unneeded variable "status". Return "_SUCCESS" on line 577 ./drivers/staging/r8188eu/os_dep/os_intfs.c:772: 4-7: Unneeded variable "ret". Return "_SUCCESS" on line 818 ./drivers/staging/r8188eu/os_dep/os_intfs.c:823:4-8: Unneeded variable "ret8". Return "_SUCCESS" on line 849 Reported-by:
Zeal Robot <zealci@zte.com.cn> Signed-off-by:
Jing Yangyang <jing.yangyang@zte.com.cn> Link: https://lore.kernel.org/r/20210825061531.69678-1-deng.changcheng@zte.com.cnSigned-off-by:
-
Jing Yangyang authored
Found with scripts/coccinelle/misc/boolconv.cocci. Reported-by:
Pavel Skripkin <paskripkin@gmail.com> Acked-by:
-
- 26 Aug, 2021 30 commits
-
-
Pavel Skripkin authored
These 2 functions are unused, so they can be simply removed Signed-off-by:
-
Saurav Girepunje authored
Remove the condition with no effect (if == else) in rtw_led.c file. Acked-by:
Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YSFgrLUfXzgcT6k4@userSigned-off-by:
-
Michael Straube authored
There are only two definitions from ethernet.h used in the driver. Namely: #define ETHERNET_HEADER_SIZE 14 /* Ethernet Header Length */ #define LLC_HEADER_SIZE 6 /* LLC Header Length */ Both are only used in the file core/rtw_recv.c. Replace the usage of ETHERNET_HEADER_SIZE with ETH_HLEN, move the definition of LLC_HEADER_SIZE into rtw_recv.h and remove the now unused ethernet.h header file. Signed-off-by:
-
Michael Straube authored
The struct ip_options declared in ip.h is only unsed in the optlength macro which is also defined in ip.h and not used in the driver code. All other definitions/declarations in ip.h are duplicated from <include/uapi/linux/ip.h>. Remove the ip.h header file and its includes. Signed-off-by:
-
Michael Straube authored
All constants, declarations and macros in if_ether.h are either duplicated from <uapi/linux/if_ether.h> or unused. Remove the file if_ether.h and its includes. Signed-off-by:
-
Pavel Skripkin authored
rtw_deinit_intf_priv() always return success, so there is no need in return value Acked-by:
Martin Kaiser <martin@kaiser.cx> Signed-off-by:
-
Michael Straube authored
Use is_multicast_ether_addr instead of custom macro IS_MCAST, the buffer is properly aligned. Acked-by:
-
Michael Straube authored
Use is_multicast_ether_addr instead of custom macro IS_MCAST, the buffer is properly aligned. Acked-by:
-
Michael Straube authored
Use is_multicast_ether_addr instead of custom macro IS_MCAST, all buffers are properly aligned. Acked-by:
-
Michael Straube authored
Use is_multicast_ether_addr instead of custom macro IS_MCAST, all buffers are properly aligned. Acked-by:
-
Michael Straube authored
Use is_multicast_ether_addr instead of custom macro IS_MCAST, all buffers are properly aligned. Acked-by:
-
Michael Straube authored
Use is_multicast_ether_addr instead of custom macro IS_MCAST, the buffer is properly aligned. Acked-by:
-
Michael Straube authored
Use is_multicast_ether_addr instead of custom macro IS_MCAST, the buffer is properly aligned. Acked-by:
-
Michael Straube authored
Add __aligned(2) to eth address buffers in structs rx_pkt_attrib and pkt_attrib to ensure proper alignment for usage with functions from <linux/etherdevice.h> Acked-by:
-
Michael Straube authored
Remove unnecessary parentheses to improve readability. Signed-off-by:
-
Michael Straube authored
if (0) is never true, remove code that is never executed. Signed-off-by:
-
Michael Straube authored
The driver is for chips that do not operate in the 5 GHz band. Remove some 5 GHz related code. Acked-by:
-
Michael Straube authored
All functions declared in the cmd_osdep.h header file are only used in a single c source file. Make the functions static and remove the header file and its includes. Acked-by:
-
Larry Finger authored
The 16- and 32-bit quantities in the dhcp message definition must be big endian. Acked-by:
Larry Finger <Larry.Finger@lwfinger.net> Link: https://lore.kernel.org/r/20210821151459.26078-1-Larry.Finger@lwfinger.netSigned-off-by:
-
Phillip Potter authored
Remove forward declaration of Efuse_Read1ByteFromFakeContent function from core/rtw_efuse.c, as the function is defined in full directly after this and therefore this forward declaration is redundant. In addition, convert the storage class of the function to static, as the function is only used with rtw_efuse.c, and tidy up the signature alignment. Acked-by:
-
Xiangyang Zhang authored
The "pbackup_remainder_ie" variable is not freed when "pwps_ie_src" is null Fixes: 15865124 ("staging: r8188eu: introduce new core dir for RTL8188eu driver") Acked-by:
Xiangyang Zhang <xyz.sun.ok@gmail.com> Link: https://lore.kernel.org/r/20210821081824.14745-1-xyz.sun.ok@gmail.comSigned-off-by:
-
Martin Kaiser authored
Set the pipe for reading or writing in usbctrl_vendorreq only once. There's no need to set it again for every retry. This patch is an adaptation of commit 889ed8b5 ("staging: rtl8188eu: set pipe only once") for the new r8188eu driver. Acked-by:
-
Martin Kaiser authored
Remove function pointers which are not used by the r8188eu driver. Acked-by:
-
Martin Kaiser authored
Remove unnecessary variables, check the length. Acked-by:
-
Martin Kaiser authored
Remove unnecessary variables, summarize declarations and assignments. Acked-by:
-
Martin Kaiser authored
Remove unnecessary variables, summarize declarations and assignments. Acked-by:
-
Martin Kaiser authored
The VENDOR_READ and VENDOR_WRITE defines are not used. Acked-by:
-
Martin Kaiser authored
Replace the numeric values with USB constants to make their meaning clearer. Acked-by:
-
Martin Kaiser authored
At the moment, usbctrl_vendorreq's requesttype parameter must be set to 1 for reading and 0 for writing. It's then converted to the actual bmRequestType for the USB control request. We can simplify the code and avoid this conversion if the caller passes the actual bmRequestType. This patch is an adaptation of commit 788fde03 ("staging: rtl8188eu: use actual request type as parameter") for the new r8188eu driver. Acked-by:
-
Martin Kaiser authored
_HCI_OPS_OS_C_ is not used in the r8188eu driver. Remove it. Acked-by:
-
