- 14 Feb, 2014 40 commits
-
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Remove the unnecessary comments. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Change the errno returned for an overrun from -EIO to -EOVERFLOW. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog output end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input and output end-of- conversions. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog output end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Since this is the sample skeleton driver, add comments about how the callback function works with comedi_timeout(). Signed-off-by:
-
H Hartley Sweeten authored
Introduce a comedi core helper function to handle the boilerplate needed by the drivers to busy- wait for a condition to occur. Typically this condition is the analog input/output end-of-conversion used with the comedi (*insn_read) and (*insn_write) operations. To use this function, the drivers just need to provide a callback that checks for the desired condition. The callback should return 0 if the condition is met or -EBUSY if it is still waiting. Any other errno will be returned to the caller. If the timeout occurs before the condition is met -ETIMEDOUT will be returned. The parameters to the callback function are the comedi_device, comedi_subdevice, and comedi_insn pointers that were passed to the (*insn_read) or (*insn_write) as well as an unsigned long, driver specific, 'context' that can be used to pass any other information that might be needed in the callback. This 'context' could be anything such as the register offset to read the status or the bits needed to check the status. The comedi_timeout() function itself does not use any of these parameters. This will help remove all the crazy "wait this many loops" used by some of the drivers. It also creates a common errno for comedi to detect when a timeout occurs. ADC/DAC conversion times are typically pretty fast, usually around 100K samples/sec (10 usec). A conservative timeout of 1 second is used in comedi_timeout(). Signed-off-by:
-
Fengguang Wu authored
drivers/staging/lustre/lustre/llite/dir.c:1416:2-8: Replace memcpy with struct assignment Generated by: coccinelle/misc/memcpy-assign.cocci CC: Peng Tao <bergwolf@gmail.com> CC: Andreas Dilger <andreas.dilger@intel.com> CC: Oleg Drokin <oleg.drokin@intel.com> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
-
Peng Tao authored
Cc: Andreas Dilger <andreas.dilger@intel.com> Cc: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
Peng Tao <bergwolf@gmail.com> Signed-off-by:
-
Peng Tao authored
Cc: Andreas Dilger <andreas.dilger@intel.com> Cc: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Fengguang Wu authored
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:191:2-3: Unneeded semicolon Removes unneeded semicolon. Generated by: coccinelle/misc/semicolon.cocci CC: Insop Song <insop.song@gainspeed.com> Signed-off-by:
-
Fengguang Wu authored
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:305:1-3: WARNING: PTR_RET can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: coccinelle/api/ptr_ret.cocci CC: Insop Song <insop.song@gainspeed.com> Signed-off-by:
-
Richard Weinberger authored
The symbol is an orphan, get rid of it. Cc: Paul Bolle <pebolle@tiscali.nl> Cc: Omar Ramirez Luna <omar.ramirez@copitl.com> Signed-off-by:
Richard Weinberger <richard@nod.at> Signed-off-by:
-
navin patidar authored
Remove h2clbk.h and nic_spec.h header files. Signed-off-by:
navin patidar <navin.patidar@gmail.com> Signed-off-by:
-
Larry Finger authored
Smatch reports the following: core/rtw_ieee80211.c:489 rtw_get_wpa_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:491 rtw_get_wpa_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:493 rtw_get_wpa_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:495 rtw_get_wpa_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:497 rtw_get_wpa_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:505 rtw_get_wpa2_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:507 rtw_get_wpa2_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:509 rtw_get_wpa2_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:511 rtw_get_wpa2_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:513 rtw_get_wpa2_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:534 rtw_parse_wpa_ie() warn: add some parenthesis here? core/rtw_ieee80211.c:579 rtw_parse_wpa_ie() warn: add some parenthesis here? core/rtw_ieee80211.c:649 rtw_parse_wpa2_ie() warn: add some parenthesis here? core/rtw_ieee80211.c:803 rtw_get_wps_attr() warn: add some parenthesis here? core/rtw_ieee80211.c:1213 rtw_get_p2p_ie() warn: add some parenthesis here? core/rtw_ieee80211.c:1248 rtw_get_p2p_attr() warn: add some parenthesis here? core/rtw_mlme.c:258 _rtw_find_network() warn: add some parenthesis here? core/rtw_mlme.c:1581 rtw_check_join_candidate() warn: this array is probably non-NULL. 'pmlmepriv->assoc_ssid.Ssid' core/rtw_mlme.c:1843 SecIsInPMKIDList() warn: add some parenthesis here? core/rtw_mlme_ext.c:4189 on_action_public_vendor() warn: add some parenthesis here? core/rtw_recv.c:1157 validate_recv_mgnt_frame() warn: add some parenthesis here? core/rtw_xmit.c:671 xmitframe_addmic() warn: add some parenthesis here? hal/rtl8188e_mp.c:206 Hal_MPT_CCKTxPowerAdjustbyIndex() error: buffer overflow 'CCKSwingTable_Ch1_Ch13' 33 <= 255 hal/rtl8188e_mp.c:215 Hal_MPT_CCKTxPowerAdjustbyIndex() error: buffer overflow 'CCKSwingTable_Ch14' 33 <= 255 Not listed here is one remaining buffer overflow message that I believe to be an error in Smatch. These warnings were reported by Dan Carpenter. Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Malcolm Priestley authored
White space clean up Camel case changes pDevice -> priv pMgmt -> mgmt byTmpMode -> tmp Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
set u64 mc_filter to ~0x0 multi cast filter off and write MAC_REG_MAR0 using MACvWriteMultiAddr to replace pbyData. Signed-off-by:
-
Malcolm Priestley authored
Convert mc_filter to u64, preform netdev_for_each_mc_addr mask filtering. In MACvWriteMultiAddr endian correct mc_filter and write the entire multicast once. Reported-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Paul E. McKenney authored
The rtw_recv_indicatepkt() function in the file named drivers/staging/rtl8188eu/os_dep/recv_linux.c has this strange code: rcu_read_lock(); rcu_dereference(padapter->pnetdev->rx_handler_data); rcu_read_unlock(); This code has no effect. Normally, you would assign the result of rcu_dereference() to some variable, but it is not clear from the code what variable that would be. Therefore, this patch applies to the TODO file instead of the code itself. Signed-off-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
-
Larry Finger authored
After updating Smatch, the following new errors and warnings are reported: drivers/staging/rtl8188eu/core/rtw_recv.c:368 recvframe_chkmic() warn: variable dereferenced before check 'psecuritypriv' (see line 364) drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:2642 rtw_wps_start() warn: variable dereferenced before check 'pdata' (see line 2636) drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:4461 rtw_dbg_port() error: we previously assumed 'pregpriv' could be null (see line 4453) drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:4473 rtw_dbg_port() error: we previously assumed 'pregpriv' could be null (see line 4469) Signed-off-by:
-
Larry Finger authored
Smatch reports the following: drivers/staging/rtl8821ae/rtl8821ae/hw.c:153 _rtl8821ae_set_fw_clock_on() info: ignoring unreachable code. Upon investigation, the code in this region has the capability of creating an infinite loop. Signed-off-by:
-
Paul Bolle authored
There are a few lines in this driver that depend on a macro CONFIG_BT_COEXIST. But there's no Kconfig symbol of that name nor is there a preprocessor define for that string. So remove these lines. Signed-off-by:
Paul Bolle <pebolle@tiscali.nl> Signed-off-by:
-
Chase Southwood authored
In this conditional statement, if (chan < 16), but the instruction passed in data[0] is INSN_CONFIG_DIO_QUERY, the function does not return early, but the else-branch does not get executed either. As a result, mask would be used uninitialized in the next line. We want comedi_dio_insn_config() to use a chan_mask based on the chanspec for the INSN_CONFIG_DIO_QUERY instruction, so mask should be initialized to 0. Then, if instead the instruction is INSN_CONFIG_DIO_{INPUT,OUTPUT}, we return an error if (chan < 16) as these are invalid instructions for ports 0 and 1, or update the mask otherwise, so all the io_bits are modified for port 2. This ensures that mask is always initialized by the time it is used. Signed-off-by:Chase Southwood <chase.southwood@yahoo.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Weijie Yang authored
Set TIF_MEMDIE tsk_thread flag before send kill signal to the selected thread. This is to fit a usual code sequence and avoid potential race issue. Signed-off-by:
Weijie Yang <weijie.yang@samsung.com> Acked-by:
David Rientjes <rientjes@google.com> Signed-off-by:
-
Masanari Iida authored
This patch fixed spelling typo within lustre/lustre/obdclass. Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
