1. 24 Sep, 2011 4 commits
    • sricharan's avatar
      OMAP: Fix sparse warnings in l3 error handler. · 6616aac6
      sricharan authored
      Fix below sparse warnings from the l3-noc and l3-smx error handlers
      files.
      
      arch/arm/mach-omap2/omap_l3_smx.h:209:22: warning: symbol 'omap3_l3_app_bases' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_smx.h:308:22: warning: symbol 'omap3_l3_debug_bases' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_smx.h:325:2: warning: incorrect type in initializer (different address spaces)
      arch/arm/mach-omap2/omap_l3_smx.h:325:2:    expected unsigned int [usertype] *
      arch/arm/mach-omap2/omap_l3_smx.h:325:2:    got unsigned int [noderef] [toplevel] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_smx.h:326:2: warning: incorrect type in initializer (different address spaces)
      arch/arm/mach-omap2/omap_l3_smx.h:326:2:    expected unsigned int [usertype] *
      arch/arm/mach-omap2/omap_l3_smx.h:326:2:    got unsigned int [noderef] [toplevel] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_smx.h:324:5: warning: symbol 'omap3_l3_bases' was not declared. Should it be static?
        CC      arch/arm/mach-omap2/omap_l3_smx.o
        CHECK   arch/arm/mach-omap2/omap_l3_noc.c
      arch/arm/mach-omap2/omap_l3_noc.c:73:13: warning: symbol '__v' shadows an earlier one
      arch/arm/mach-omap2/omap_l3_noc.c:73:13: originally declared here
      arch/arm/mach-omap2/omap_l3_noc.c:83:20: warning: symbol '__v' shadows an earlier one
      arch/arm/mach-omap2/omap_l3_noc.c:83:20: originally declared here
      arch/arm/mach-omap2/omap_l3_noc.c:90:5: warning: symbol '__v' shadows an earlier one
      arch/arm/mach-omap2/omap_l3_noc.c:90:5: originally declared here
      arch/arm/mach-omap2/omap_l3_noc.h:39:5: warning: symbol 'l3_flagmux' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.h:46:5: warning: symbol 'l3_targ_inst_clk1' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.h:54:5: warning: symbol 'l3_targ_inst_clk2' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.h:75:5: warning: symbol 'l3_targ_inst_clk3' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.h:79:6: warning: symbol 'l3_targ_inst_name' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.h:112:5: warning: symbol 'l3_targ' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_l3_noc.c:72:11: warning: cast removes address space of expression
      arch/arm/mach-omap2/omap_l3_noc.c:73:13: warning: incorrect type in argument 1 (different base types)
      arch/arm/mach-omap2/omap_l3_noc.c:73:13:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_noc.c:73:13:    got unsigned int
      arch/arm/mach-omap2/omap_l3_noc.c:83:20: warning: incorrect type in argument 1 (different base types)
      arch/arm/mach-omap2/omap_l3_noc.c:83:20:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_noc.c:83:20:    got unsigned int
      arch/arm/mach-omap2/omap_l3_noc.c:90:5: warning: incorrect type in argument 1 (different base types)
      arch/arm/mach-omap2/omap_l3_noc.c:90:5:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_noc.c:90:5:    got unsigned int
      arch/arm/mach-omap2/omap_l3_noc.c:96:5: warning: incorrect type in argument 1 (different base types)
      arch/arm/mach-omap2/omap_l3_noc.c:96:5:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_noc.c:96:5:    got unsigned int
      arch/arm/mach-omap2/omap_l3_noc.c:108:5: warning: incorrect type in argument 1 (different base types)
      arch/arm/mach-omap2/omap_l3_noc.c:108:5:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/omap_l3_noc.c:108:5:    got unsigned int
      Signed-off-by: default avatarsricharan <r.sricharan@ti.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
      Reported-by: default avatarPaul Walmsley <paul@pwsan.com>
      Reviewed-by: default avatarPaul Walmsley <paul@pwsan.com>
      6616aac6
    • sricharan's avatar
      OMAP: Fix indentation issues in l3 error handler. · ed0e3520
      sricharan authored
      The indentation problems in the l3 noc and smx
      error handler files are fixed.
      Signed-off-by: default avatarsricharan <r.sricharan@ti.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
      Reported-by: default avatarPaul Walmsley <paul@pwsan.com>
      ed0e3520
    • Todd Poynor's avatar
      OMAP: Fix a BUG in l3 error handler. · c1df2dcc
      Todd Poynor authored
      With the current sequence of registering the irq and
      assigning it to the app_irq, debug_irq driver variables,
      there can be corner cases where the pending irq gets
      triggered immediately after registering, handler gets called
      resulting in a crash. So changed this sequence.
      Signed-off-by: default avatarsricharan <r.sricharan@ti.com>
      Signed-off-by: default avatarTodd Poynor <toddpoynor@google.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
      c1df2dcc
    • Todd Poynor's avatar
      OMAP: Improve register access in L3 Error handler. · 342fd144
      Todd Poynor authored
      * Changed the way of accessing L3 target
        registers from standard base rather
        than relative to STDERRLOG_MAIN.
      
      * Use ffs() to find error source from
        the L3_FLAGMUX_REGERRn register.
      
      * Remove extra l3_base[] entry.
      
      * Modified L3 custom error message.
      Signed-off-by: default avatarTodd Poynor <toddpoynor@google.com>
      Signed-off-by: default avatarsricharan <r.sricharan@ti.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
      342fd144
  2. 12 Sep, 2011 9 commits
  3. 11 Sep, 2011 25 commits
  4. 10 Sep, 2011 2 commits