- 24 Aug, 2015 4 commits
-
-
Wolfram Sang authored
The current naming is based on the arguments of the functions and not on what they do. Even I as the maintainer find this confusing, so let's rename them to something more descriptive. Tested-by:
Andrey Danin <danindrey@mail.ru> Acked-by:
Stephen Warren <swarren@nvidia.com> Signed-off-by:
Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Wolfram Sang authored
We want a separate address range for being an I2C slave. Add an offset of 0x1000, so it can be combined with ten bit addresses as well. Add a separate function to create the address value, we will need it later in other places. Tested-by:
Andrey Danin <danindrey@mail.ru> Acked-by:
Stephen Warren <swarren@nvidia.com> Signed-off-by:
Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Wolfram Sang authored
And update indentation with one more tab, sigh... Tested-by:
Andrey Danin <danindrey@mail.ru> Acked-by:
Stephen Warren <swarren@nvidia.com> Signed-off-by:
Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Wolfram Sang authored
Tested-by:
Andrey Danin <danindrey@mail.ru> Acked-by:
Stephen Warren <swarren@nvidia.com> Signed-off-by:
Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
- 11 Aug, 2015 2 commits
-
-
Eddie Huang authored
When occur i2c ack error, i2c controller generate two interrupts, first is the ack error interrupt, then the complete interrupt. i2c interrupt handler should keep the two interrupt value, and only call complete() for the complete interrupt. Signed-off-by:
Liguo Zhang <liguo.zhang@mediatek.com> Signed-off-by:
Eddie Huang <eddie.huang@mediatek.com> Reviewed-by:
Daniel Kurtz <djkurtz@chromium.org> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Eddie Huang authored
Reset DMA in hardware init function to avoid unknown hardware state before do any I2C operation. Signed-off-by:
Liguo Zhang <liguo.zhang@mediatek.com> Signed-off-by:
Eddie Huang <eddie.huang@mediatek.com> Reviewed-by:
Daniel Kurtz <djkurtz@chromium.org> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
- 10 Aug, 2015 34 commits
-
-
Colin Ian King authored
Minor clean up of indenting, no functional change Signed-off-by:
Colin Ian King <colin.king@canonical.com> [wsa: squashed two lines into one] Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Masahiro Yamada authored
The owner of the adapter is missing, while this driver is tristate. Signed-off-by:
Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Wolfram Sang authored
The I2C dir is not for I2C client devices! Move it to the proper folder. Signed-off-by:
Wolfram Sang <wsa@the-dreams.de> Acked-by:
Guenter Roeck <linux@roeck-us.net>
-
Wolfram Sang authored
The I2C dir is not for I2C client devices! Move it to the proper folder. Signed-off-by:
Wolfram Sang <wsa@the-dreams.de> Acked-by:
Guenter Roeck <linux@roeck-us.net>
-
Wolfram Sang authored
The I2C dir is not for I2C client devices! Move it to the proper folder. Signed-off-by:
Wolfram Sang <wsa@the-dreams.de> Acked-by:
Guenter Roeck <linux@roeck-us.net>
-
Wolfram Sang authored
The I2C dir is not for I2C client devices! Move it to the proper folder. Signed-off-by:
Wolfram Sang <wsa@the-dreams.de> Acked-by:
Pavel Machek <pavel@denx.de>
-
Javier Martinez Canillas authored
The I2C core always reports the MODALIAS uevent as "i2c:<client name>" regardless if the driver later is match using the I2C id_table or the of_match_table. So the driver needs to export the I2C table and this be built into the module or udev won't have the necessary information to auto load the correct module when the device is added. Signed-off-by:
Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by:
Jean Delvare <jdelvare@suse.de> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Jarkko Nikula authored
Printing adapter name is irrelevant from this debug print and makes output needlessly long. Having already device and functions names printed here is enough for debugging. While at it remove extra space from "enabled= 0x" and use "%#x" for printing "0x" prefixed hexadecimal values. Signed-off-by:
Jarkko Nikula <jarkko.nikula@linux.intel.com> [wsa: made it a oneliner] Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Vladimir Zapolskiy authored
This change is needed to properly lock I2C parent bus driver. Prior to this change i2c_put_adapter() is misused, which may lead to an overflow over zero of I2C bus driver user counter. Signed-off-by:
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Vladimir Zapolskiy authored
of_find_i2c_adapter_by_node() call requires quite often missing put_device(), and i2c_put_adapter() releases a device locked by i2c_get_adapter() only. In general module_put(adapter->owner) and put_device(dev) are not interchangeable. This is a common error reproduction scenario as a result of the misusage described above (for clearness this is run on iMX6 platform with HDMI and I2C bus drivers compiled as kernel modules): root@mx6q:~# lsmod | grep i2c i2c_imx 10213 0 root@mx6q:~# lsmod | grep dw_hdmi_imx dw_hdmi_imx 3631 0 dw_hdmi 11846 1 dw_hdmi_imx imxdrm 8674 3 dw_hdmi_imx,imx_ipuv3_crtc,imx_ldb drm_kms_helper 113765 5 dw_hdmi,imxdrm,imx_ipuv3_crtc,imx_ldb root@mx6q:~# rmmod dw_hdmi_imx root@mx6q:~# lsmod | grep i2c i2c_imx 10213 -1 ^^^^^ root@mx6q:~# rmmod i2c_imx rmmod: ERROR: Module i2c_imx is in use To fix existing users of these interfaces and to avoid any further confusion and misusage in future, add one more interface of_get_i2c_adapter_by_node(), it is similar to i2c_get_adapter() in sense that an I2C bus device driver found and locked by user can be correctly unlocked by i2c_put_adapter(). Signed-off-by:
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Vladimir Zapolskiy authored
In addition to module_get()/module_put() add get_device()/put_device() calls into i2c_get_adapter()/i2c_put_adapter() exported interfaces. This is done to lock I2C bus device, if it is in use by a client. Signed-off-by:
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Krzysztof Kozlowski authored
i2c_driver does not need to set an owner because i2c_register_driver() will set it. Signed-off-by:
Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Krzysztof Kozlowski authored
i2c_driver does not need to set an owner because i2c_register_driver() will set it. Signed-off-by:
Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Andy Shevchenko authored
The mentioned flag fixes a warning on Intel Edison board since one of the I2C controller shares IRQ line with watchdog timer. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by:
Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Denis Carikli authored
This adds devicetree documentation for the bindings of the ads7828 driver. Signed-off-by:
Denis Carikli <denis@eukrea.com> Acked-by:
Guenter Roeck <linux@roeck-us.net> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Ondrej Zary authored
Add support for VCT-jig parallel port I2C adapter to i2c-parport. The adapter schematic can be found here (in the RAR file): http://remont-aud.net/shop/22/desc/vct-jig-komplekt-dlja-samostojatelnoj-sborkiSigned-off-by:
Ondrej Zary <linux@rainbow-software.org> Reviewed-by:
Jean Delvare <jdelvare@suse.de> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Anurag Kumar Vulisha authored
Cadence 1.0 version has bugs which have been fixed in the cadence 1.4 version. This patch removes the quirks present in the driver for cadence 1.4 version. Signed-off-by:
Anurag Kumar Vulisha <anuragku@xilinx.com> [wsa: fixed indentation issues in r1p10_i2c_def] Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Laxman Dewangan authored
Tegra I2C controller required to configure the clock divisor register inside controller to different value based on the clock speed. The recommended clock divisor for the I2C controller for standard/fast mode is 0x19 and for fast-mode plus is 0x10. Add support to configure clock divisor register of I2C controller based on bus clock rate. This clock divisor is supported form T114 onwards. Signed-off-by:
Chaitanya Bandi <bandik@nvidia.com> Signed-off-by:
Laxman Dewangan <ldewangan@nvidia.com> Tested-by:
Stephen Warren <swarren@nvidia.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Laxman Dewangan authored
Once the new configuration is set on the conifg register of I2C controller, it is require to update the CONFIG_LOAD register to transfer the new SW configuration to actual HW internal registers that would be used in the actual logic. It is like, SW is programming only shadow registers through regular configuration and when these load_config bit fields are set to 1, it causes the regular/shadows registers configuration transferred to the HW internal active registers. So SW has to set these bit fields at the end of all regular registers configuration. And these config_load bits are HW auto-clear bits. HW clears these bit fields once the register configuration is moved to HW internal active registers. So SW has to wait until these bits are auto-cleared before going for any further programming This mechanism is supported on T124 and after this SoCs. Signed-off-by:
Chaitanya Bandi <bandik@nvidia.com> Signed-off-by:
Laxman Dewangan <ldewangan@nvidia.com> Tested-by:
Stephen Warren <swarren@nvidia.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Wolfram Sang authored
Patch "i2c: omap: abolish variable name confusion" triggered a coccinelle warning which we fix here: drivers/i2c/busses/i2c-omap.c:1333:5-24: pm_runtime_get_sync returns < 0 as error. Unecessary IS_ERR_VALUE at line 1334 Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Shubhrajyoti Datta authored
In case of error conditions like Arbitration lost or NACK lets signal the waiting process. Handle error cases in the Rx path Signed-off-by:
Shubhrajyoti Datta <shubhraj@xilinx.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Shubhrajyoti Datta authored
Currently only one interrupt is serviced in the isr. In case the multiple interrupts happen simultenously we service and ack only one of them. Check for all the causes in the isr and service them. Signed-off-by:
Shubhrajyoti Datta <shubhraj@xilinx.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Shubhrajyoti Datta authored
Currently there is no slave mode support in the driver also in the isr we just ack it and do nothing. So disable the AAS interrupt. Signed-off-by:
Shubhrajyoti Datta <shubhraj@xilinx.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Shubhrajyoti Datta authored
Remove the busy loop while waiting for bus busy. Instead let the processor sleep. Signed-off-by:
Shubhrajyoti Datta <shubhraj@xilinx.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Shubhrajyoti Datta authored
Currently before every transfer the interrupts are disabled. So incase the slave nacks in the middle of the transfer the current transfer is not aborted. Upon enabling the interrupts conditions like NACK , arbitration lost will not be masked. Remove the disabling of the interrupts. Signed-off-by:
Shubhrajyoti Datta <shubhraj@xilinx.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Shubhrajyoti Datta authored
Currently before every transfer the controller is reinitialised. We are already resetting the controller upon errors so upon every transfer is a performance kill. Remove the same. Signed-off-by:
Shubhrajyoti Datta <shubhraj@xilinx.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Shubhrajyoti Datta authored
The xiic_process is a 154 line code that runs in isr context currently move it to thread context. Also the name xiic_process suggests that the intension was to run in process context. Signed-off-by:
Shubhrajyoti Datta <shubhraj@xilinx.com> [wsa: initialized irqreturn_t to IRQ_NONE instead of IRQ_HANDLED] Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Shubhrajyoti Datta authored
Currently the interrupts are disabled at the start of the isr and enabled at the end of the isr. Remove the same. In case the slave device NACKs the transaction while in the isr the transfer will continue and the NACK interrupt will arrive only after the isr is serviced. Signed-off-by:
Shubhrajyoti Datta <shubhraj@xilinx.com> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Vaibhav Hiremath authored
This patch cleans up i2c_pxa_probe() function, - Use devm_ variants wherever This will clean both probe exit and i2c_pxa_remove() functions - Check platform resource before parsing any other data from DT/platform - Use dev_err on failure from i2c_add_numbered_adapter() - Use pr_info instead of printk for KERN_INFO Signed-off-by:
Vaibhav Hiremath <vaibhav.hiremath@linaro.org> Acked-by:
Robert Jarzmik <robert.jarzmik@free.fr> [wsa: removed unneeded error prinout after devm_ioremap_resource] Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Vaibhav Hiremath authored
Update i2c_pxa_scream_blue_murder() fn to print more information in case of error. Also, use dev_err variants instead of printk. Signed-off-by:
Jett.Zhou <jtzhou@marvell.com> Signed-off-by:
Vaibhav Hiremath <vaibhav.hiremath@linaro.org> Cc: Wolfram Sang <wsa@the-dreams.de> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Yipeng Yao authored
Fix below warning message, coming from 64 bit toolchain. drivers/i2c/busses/i2c-pxa.c:1237:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] Signed-off-by:
Yipeng Yao <ypyao@marvell.com> [vaibhav.hiremath@linaro.org: Updated Changelog] Signed-off-by:
Vaibhav Hiremath <vaibhav.hiremath@linaro.org> Cc: Wolfram Sang <wsa@the-dreams.de> Acked-by:
Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Shouming Wang authored
In case of timeout in pio mode of operation return I2C_RETRY. This behavior will be same as interrupt mode of operation. Signed-off-by:
Shouming Wang <wangshm@marvell.com> [vaibhav.hiremath@linaro.org: Updated changelog] Signed-off-by:
Vaibhav Hiremath <vaibhav.hiremath@linaro.org> Acked-by:
Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Vaibhav Hiremath authored
Normally i2c controller works as master, so slave addr is not needed, or it will impact some slave device (eg. ST NFC chip) i2c accesses, because it has the same i2c address with controller. For example, On the pxa1928 based platform, where PMIC (88pm860) is present @0x30 address on TWSI0 interface, and if we set 0x30 as a slave address in pxa1928 TWSI0 module, all the transactions towards PMIC would go for toss. Signed-off-by:
Jett.Zhou <jtzhou@marvell.com> Signed-off-by:
Vaibhav Hiremath <vaibhav.hiremath@linaro.org> Acked-by:
Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-
Leilei Shang authored
During suspend there may still be some i2c access happening, as the interrupt is shared between multiple drivers. And if we don't keep i2c irq ON, there may be i2c access timeout if i2c is in irq mode of operation. Signed-off-by:
Raul Xiong <xjian@marvell.com> Signed-off-by:
Xiaofan Tian <tianxf@marvell.com> [vaibhav.hiremath@linaro.org: updated Changelog] Signed-off-by:
Vaibhav Hiremath <vaibhav.hiremath@linaro.org> Cc: Wolfram Sang <wsa@the-dreams.de> Signed-off-by:
Wolfram Sang <wsa@the-dreams.de>
-