Commits · 67c20cfbce53cf6df28681939d9a9621d2a85dfc · Kirill Smelkov / linux

17 Apr, 2014 1 commit

staging: goldfish: switch from spinlock to mutex · 67c20cfb

Kristina Martšenko authored Mar 25, 2014

Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by
the TODO list.
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

67c20cfb

15 Apr, 2014 39 commits

staging: rtl8723au: Make _rtw_free_network23() static · dff22267

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

dff22267

staging: rtl8723au: Remove bogus inline from rtw_set_roaming() prototype · a9339fdd
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
a9339fdd
staging: rtl8723au: Move rtw23a_roaming() so we can declare _rtw_roaming() static · afa7e480
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
afa7e480

staging: rtl8723au: collect_bss_info23a(): Use struct ieee80211_mgmt · d944b721

Jes Sorensen authored Apr 15, 2014

Somplify code by using struct ieee80211_mgmt to calculate offsets
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d944b721

staging: rtl8723au: Remove unused function rtw_get_timestampe_from_ie23a() · 7ca9ed21
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
7ca9ed21
staging: rtl8723au: Fold _rtw_free_mlme_priv23a() into rtw_free_mlme_priv23a() · e418361c
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
e418361c

staging: rtl8723au: Fold rtw_to_roaming() into the code · 56828797

Jes Sorensen authored Apr 15, 2014

Simple read variable from a struct function, having it as an external
function is just silly.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

56828797

staging: rtl8723au: rtw_mlme.c: Clean up mess · 480c865e

Jes Sorensen authored Apr 15, 2014

Clean up spaghetti formatting and avoid NULL initializing variables
where it isn't needed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

480c865e

staging: rtl8723au: Remove dummy function rtw_hostapd_mlme_rx23a() · 684ad6ee

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

684ad6ee

staging: rtl8723au: Remove another unused prototype · c8bdc729

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c8bdc729

staging: rtl8723au: Fold some resource allocation abstraction into their callers · f466c400

Jes Sorensen authored Apr 15, 2014

Fold rtw_os_recvbuf_resource_alloc23a() and
rtw_os_recvbuf_resource_free23a() into the functions calling them.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f466c400

staging: rtl8723au: Remove unnecessary abstraction rtw_os_recv_resource_alloc23a() · 09ae6d75

Jes Sorensen authored Apr 15, 2014

No point calling a function to NULL a pointer that was just cleared in
the malloc call.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

09ae6d75

staging: rtl8723au: Remove unused function rtw_os_read_port23a() · 35a5c6f3

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

35a5c6f3

staging: rtl8723au: Clean up namespace clashes with rtl8188eu driver · 76dc4441

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

76dc4441

staging: rtl8188eu: os_intfs.c: Mark a couple of variables static · 987bc3fe

Jes Sorensen authored Apr 15, 2014

Mark these variables local to avoid namespace clash with other RTL
drivers.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

987bc3fe

staging: rtl8188eu: usb_intf.c: No point processing an empty table · b809fc44

Jes Sorensen authored Apr 15, 2014

In addition, this would globally disable HT if one device in the
system would mark it unsupported. If any device ended up requiring
this, it should be handled on a per-instance basis.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

b809fc44

staging: rtl8723au: os_intfs.c: Declare a couple of local variables static · bc55ae44
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
bc55ae44

staging: rtl8723au: init_channel_set(): Restructure variable names · 68e6831e

Jes Sorensen authored Apr 15, 2014

Shorten variable names allowing for fewer broken lines due to the
large number of indents.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

68e6831e

staging: rtl8723au: mgmt_dispatcher23a(): Use struct ieee80211_mgmt · 34df0dd9

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

34df0dd9

staging: rtl8723au: OnAuth23a(): ieee80211.h-ify · 78d23509

Jes Sorensen authored Apr 15, 2014

Switch to using struct ieee80211_mgmt to obtain offsets. Again a
bizarre +4 offset was applied for the IE scan which doesn't make
sense, since this offset wasn't applied for the auth struct elements.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

78d23509

staging: rtl8723au: OnAuth23aClient23a(): Clean up using struct ieee80211_mgmt · 580e756c

Jes Sorensen authored Apr 15, 2014

Use 80211_mgmt to determine offsets within the received frame. This
also removes a suspicious offset adjustment:

     offset = ieee80211_has_protected(hdr->frame_control) ? 4: 0;

which didn't make any sense, since it was only applied to determining
the auth, sequence number, and status, but wasn't applied to the
location of the IEs.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

580e756c

staging: rtl8723au: OnAssocRsp23a() use ieee80211_mgmt to obtain DA · 6c8207a6

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6c8207a6

staging: rtl8723au: OnAction23a_back23a(): Use struct ieee8011_mgmt to parse action frames · b30f74e0
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
b30f74e0
staging: rtl8723au: OnAction23a(): Use struct ieee80211_mgmt instead of hardcoded offsets · f5f05715
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
f5f05715

staging: rtl8723au: update_TSF() remove unused argument and move to rtw_mlme_ext.c · 0e959699

Jes Sorensen authored Apr 15, 2014

This is only called from rtw_mlme_ext.c, so move it that and declare
it static.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0e959699

staging: rtl8723au: clean up update_TSF() · 04fad92a

Jes Sorensen authored Apr 15, 2014

Clean up and simplify update_TSF() using proper Linux functions and
move it to rtw_mlme_ext.c which is the only user of it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

04fad92a

staging: rtl8723au: OnBeacon23a() tidy up code · 9af36808

Jes Sorensen authored Apr 15, 2014

Clean up the excessive if() levels at the end, and use struct
ieee80211_mgmt to calculate pointers passed on to check_assoc_AP23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9af36808

staging: rtl8723au: rtw_mlme.c: remove commented out debug code · 9aac910a

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9aac910a

staging: rtl8723au: Remove buggy function _rtw_report_sec_ie() · 959226ac

Jes Sorensen authored Apr 15, 2014

This function was extremely buggy calling kmalloc(GFP_KERNEL) while
holding a spin lock and then potentially overflowing the buffer it had
allocated.

Since the generated output wasn't used for anything, simply rip the
whole thing out.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

959226ac

staging: rtl8723au: OnProbeReq23a(): is_valid_p2p_probereq is always false · 8e64bc58
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
8e64bc58

staging: rtl8723au: OnProbeReq23a(): Use struct ieee80211_mgmt · d3c60949

Jes Sorensen authored Apr 15, 2014

Simplify parsing of probe request frame
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d3c60949

staging: rtl8723au: OnAssocReq23a(): use ieee80211_mgmt to calculate offset · 07d2c3b8
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
07d2c3b8

staging: rtl8723au: ioctl_cfg80211.c: Use eth_{zero,broadcast},addr() · 43c34be1

Jes Sorensen authored Apr 15, 2014

Use kernel provided macros instead of own hacks.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

43c34be1

staging: rtl8723au: Remove some unused ieee80211 structs · 29f79e05

Jes Sorensen authored Apr 15, 2014

These are duplicated from the kernel headers and not used anymore
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

29f79e05

staging: rtl8723au: Remove unused ieee880211_is_empty_essid() · 30947bbc

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

30947bbc

staging: rtl8723au: Remove unused dump_wpsie23a() · 5951a5c1

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5951a5c1

staging: rtl8723au: Remove struct rtw_ieee802_11_elems and related code · 7e075832

Jes Sorensen authored Apr 15, 2014

This removes the double content tracking of data from IE elements. The
relevant code to validate IEs is moved to rtw_mlme_ext.c as this is
the only place where it is used.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7e075832

staging: rtl8723au: OnAssocReq23a(): Use cfg80211_find_ie() to locate HT caps · 57ed7bbf

Jes Sorensen authored Apr 15, 2014

Use cfg80211 interface to search for HT capabilities.

This was the last user of struct rtw_ieee802_11_elems, which can now
be removed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

57ed7bbf

staging: rtl8723au: OnAssocReq23a(): Don't check for presence of BSSID twice · 49ae9a5c
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
49ae9a5c