- 18 Sep, 2016 14 commits
-
-
Sandhya Bankar authored
Use !x instead of x == NULL. This patch was found by checkpatch. Signed-off-by:
Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Bhumika Goyal authored
This patch compresses the return logic into a single statement and removes the now unused return variable. Done using coccinelle: @@ type T; identifier r; @@ - T r; ... when !=r - r = + return ...; - return r; Signed-off-by:Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Namrata A Shettar authored
Replace explicit NULL comparison with equivalent expression to resolve checkpatch issue. - x != NULL => x Signed-off-by:
Namrata A Shettar <namrataashettar@gmail.com> Signed-off-by:
-
Anchal Jain authored
Add spaces around operators {+, -, &, /, <<, &&} Signed-off-by:Anchal Jain <anchalj109@gmail.com> Signed-off-by:
-
Anchal Jain authored
Convert pointer comparisons to NULL to NULL pointer 'p' Signed-off-by:
-
sayli karnik authored
This patch removes excess round braces around expressions/variables. Signed-off-by:
sayli karnik <karniksayli1995@gmail.com> Signed-off-by:
-
sayli karnik authored
The patch removes an unnecessary space after a cast, as detected by checkpatch.pl. Signed-off-by:
-
sayli karnik authored
The patch removes unnecessary blank lines as detected by checkpatch.pl. Also, it removes a commented line of unrequired code. Signed-off-by:
-
sayli karnik authored
The patch fixes the following errors detected by checkpatch.pl: ERROR: space prohibited before that close parenthesis ')' ERROR: space prohibited after that open parenthesis '(' Signed-off-by: -
sayli karnik authored
The patch removes braces {} for single statement blocks, as suggested by checkpatch.pl. Signed-off-by: -
sayli karnik authored
This patch replaces <asm/atomic.h> with <linux/atomic.h>, as suggested by checkpatch.pl. Signed-off-by:
-
Cathal Mullaney authored
Fixed three minor coding style issues. Signed-off-by:
Cathal Mullaney <chuckleberryfinn@gmail.com> Signed-off-by:
-
Jon Eyolfson authored
Changed if statement bodies from 2 levels deeper than if statement to 1. Signed-off-by:
Jon Eyolfson <jon@eyl.io> Signed-off-by:
-
Anchal Jain authored
This patch replaces bit shifting on 1 with the BIT(x) macro as it's extensively used by other function in the file olpc_dcon.h . Signed-off-by:
-
- 17 Sep, 2016 20 commits
-
-
Cathal Mullaney authored
Fixed a coding style issue. Signed-off-by:
-
Namrata A Shettar authored
Correct the word 'success' being misspelt in the macro: - LED_BLINK_WPS_SUCESS_INTERVAL_ALPHA => LED_BLINK_WPS_SUCCESS_INTERVAL_ALPHA Signed-off-by:
-
sayli karnik authored
staging: rtl8188eu: core: Replace memcpy() with ether_addr_copy() if ethernet addresses are __aligned(2) This patch fixes the checkpatch warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Done using coccinelle: @@ expression exp1, exp2; @@ - memcpy(exp1, exp2, ETH_ALEN); + ether_addr_copy(exp1, exp2); The output of pahole shows that the addresses are aligned: struct ieee80211_hdr { __le16 frame_control; /* 0 2 */ __le16 duration_id; /* 2 2 */ u8 addr1[6]; /* 4 6 */ u8 addr2[6]; /* 10 6 */ u8 addr3[6]; /* 16 6 */ __le16 seq_ctrl; /* 22 2 */ u8 addr4[6]; /* 24 6 */ /* size: 30, cachelines: 1, members: 7 */ /* last cacheline: 30 bytes */ }; struct wlan_bssid_ex { u32 Length; /* 0 4 */ unsigned char MacAddress[6]; /* 4 6 */ u8 Reserved[2]; /* 10 2 */ struct ndis_802_11_ssid Ssid; /* 12 36 */ u32 Privacy; /* 48 4 */ long int Rssi; /* 52 8 */ enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse; /* 60 4 */ /* --- cacheline 1 boundary (64 bytes) --- */ struct ndis_802_11_config Configuration; /* 64 32 */ enum ndis_802_11_network_infra InfrastructureMode; /* 96 4 */ unsigned char SupportedRates[16]; /* 100 16 */ struct wlan_phy_info PhyInfo; /* 116 4 */ u32 IELength; /* 120 4 */ u8 IEs[768]; /* 124 768 */ /* --- cacheline 13 boundary (832 bytes) was 60 bytes ago --- */ /* size: 892, cachelines: 14, members: 13 */ /* last cacheline: 60 bytes */ }; struct stadel_event { unsigned char macaddr[6]; /* 0 6 */ unsigned char rsvd[2]; /* 6 2 */ int mac_id; /* 8 4 */ /* size: 12, cachelines: 1, members: 3 */ /* last cacheline: 12 bytes */ }; Signed-off-by: -
Andrew Kanner authored
Ran checkpatch.pl -f vme_pio2_core.c Fixed: WARNING: Symbolic permissions are not preferred. Consider using octal permissions (0444) Signed-off-by:
Andrew Kanner <andrew.kanner@gmail.com> Signed-off-by:
-
sayli karnik authored
This patch replaces type u_int8_t with u8 as suggested by checkpatch.pl. Signed-off-by:
-
sayli karnik authored
This patch replaces the explicit NULL comparisons with ! operator. It was found using Coccinelle: @disable is_null@ expression e; @@ - e == NULL + !e Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
sayli karnik authored
This patch replaces left shifts on 1 with the BIT(x) macro, as suggested by checkpatch.pl. This was done using coccinelle script: @@ constant c; @@ - (1 << c) + BIT(c) Signed-off-by:
-
Bhumika Goyal authored
Remove extern specifier from function declaration as they have it by default. Also move extern declaration from .c files to their respective header file 'ks_hostif.h'. Coccinelle was used to remove extern and other changes were done by hand. Script: @@ identifier func; type T; @@ - extern T func(...); Signed-off-by:
-
Namrata A Shettar authored
Add space around binary operators to resolve checkpatch issue. Signed-off-by:
-
Baoyou Xie authored
We get a few warnings when building kernel with W=1: drivers/staging/lustre/lustre/lmv/lmv_obd.c:1640:1: warning: no previous prototype for 'lmv_locate_target_for_name' [-Wmissing-prototypes] drivers/staging/lustre/lustre/lmv/lmv_obd.c:2421:5: warning: no previous prototype for 'lmv_read_page' [-Wmissing-prototypes] .... In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by:
Baoyou Xie <baoyou.xie@linaro.org> Signed-off-by:
-
Baoyou Xie authored
We get 1 warning when building kernel with W=1: drivers/staging/lustre/lustre/obdclass/cl_page.c:488:6: warning: no previous prototype for 'cl_page_disown0' [-Wmissing-prototypes] In fact, this function is declared in drivers/staging/lustre/lustre/obdclass/cl_io.c, but should be removed in a header file. thus can be recognized in other file. So this patch moves the declaration into drivers/staging/lustre/lustre/include/cl_object.h. Signed-off-by:
-
Baoyou Xie authored
We get 3 warnings when building kernel with W=1: drivers/staging/lustre/lustre/obdclass/obd_mount.c:705:5: warning: no previous prototype for 'lustre_check_exclusion' [-Wmissing-prototypes] drivers/staging/lustre/lustre/obdclass/obd_mount.c:1226:5: warning: no previous prototype for 'lustre_register_fs' [-Wmissing-prototypes] drivers/staging/lustre/lustre/obdclass/obd_mount.c:1231:5: warning: no previous prototype for 'lustre_unregister_fs' [-Wmissing-prototypes] In fact, the first function is declared in drivers/staging/lustre/lustre/obdclass/obd_config.c, and the other two functions are declared in drivers/staging/lustre/lustre/obdclass/class_obd.c, but all of these functions should be declared in a header file, thus can be recognized in other file. So this patch moves the declarations into drivers/staging/lustre/lustre/include/obd_class.h. Signed-off-by:
-
Baoyou Xie authored
We get 1 warning when building kernel with W=1: drivers/staging/lustre/lustre/obdclass/obd_config.c:719:6: warning: no previous prototype for 'lustre_register_client_process_config' [-Wmissing-prototypes] In fact, this function is declared in drivers/staging/lustre/lustre/llite/super25.c, but should be moved into a header file, thus can be recognized in other file. So this patch moves the declaration into drivers/staging/lustre/lustre/include/lprocfs_status.h. Signed-off-by:
-
Baoyou Xie authored
We get 1 warning when building kernel with W=1: drivers/staging/lustre/lnet/selftest/conctl.c:804:1: warning: no previous prototype for 'lstcon_ioctl_entry' [-Wmissing-prototypes] In fact, this function is declared in drivers/staging/lustre/lustre/llite/super25.c, but should be moved into a header file, thus can be recognized in other file. So this patch moves the declaration into drivers/staging/lustre/lnet/selftest/console.h Signed-off-by:
-
Richard Groux authored
Minor warnings spotted by checkpatch.pl in lustre Remove unnecessary space before function pointer arguments. Signed-off-by:
Richard Groux <rgroux@sauron-mordor.net> Signed-off-by:
-
Bhumika Goyal authored
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Coccinelle was used to do the replacement and add the header file linux/etherdevice.h if not already present. Script: @header@ @@ #include <linux/etherdevice.h> @r1@ expression e; @@ -memset(e,0,ETH_ALEN); +eth_zero_addr(e); @includeheader depends on r1 && !header@ @@ + #include <linux/etherdevice.h> #include <...> Signed-off-by:
-
sayli karnik authored
The patch uses the size of the dereference to a variable instead of it's type, to make the code more resistant to type changes in the future. The type of the pointer variable here is the same as the type in the argument that is being replaced in sizeof(). Signed-off-by:
-
Ivan Safonov authored
This function used once, and does not improve code readability. Signed-off-by:
Ivan Safonov <insafonov@gmail.com> Signed-off-by:
-
Ivan Safonov authored
This function used once, and does not improve code readability. Signed-off-by:
-
Ivan Safonov authored
This function does not improve code readability. Signed-off-by:
-
- 16 Sep, 2016 6 commits
-
-
Gargi Sharma authored
add spaces around << to fix the checkpatch issue, spaces preferred around that '<<'. Signed-off-by:
Gargi Sharma <gs051095@gmail.com> Signed-off-by:
-
Gargi Sharma authored
add spaces around | to fix the checkpatch issue, spaces preferred around that '|'. Signed-off-by:
-
Gargi Sharma authored
add spaces around >> to fix the checkpatch issue, spaces preferred around that '>>'. Signed-off-by:
-
Gargi Sharma authored
add space around & to fix the checkpatch issue spaces preferred around that '&'. Signed-off-by:
-
Gargi Sharma authored
add spaces around + to fix the checkpatch issue, spaces preferred around that '&'. Signed-off-by:
-
Gargi Sharma authored
add spaces around << to fix the checkpatch issue, spaces preferred around that '<<'. Signed-off-by:
-
