An error occurred fetching the project authors.
  1. 20 Oct, 2010 2 commits
  2. 07 Oct, 2010 1 commit
  3. 23 Aug, 2010 1 commit
  4. 03 Aug, 2010 1 commit
  5. 02 Aug, 2010 1 commit
  6. 27 Jul, 2010 1 commit
  7. 13 Jun, 2010 1 commit
  8. 29 May, 2010 1 commit
  9. 21 May, 2010 1 commit
  10. 17 May, 2010 8 commits
  11. 11 May, 2010 2 commits
  12. 23 Mar, 2010 3 commits
    • Sage Weil's avatar
      ceph: avoid reopening osd connections when address hasn't changed · 87b315a5
      Sage Weil authored
      We get a fault callback on _every_ tcp connection fault.  Normally, we
      want to reopen the connection when that happens.  If the address we have
      is bad, however, and connection attempts always result in a connection
      refused or similar error, explicitly closing and reopening the msgr
      connection just prevents the messenger's backoff logic from kicking in.
      The result can be a console full of
      
      [ 3974.417106] ceph: osd11 10.3.14.138:6800 connection failed
      [ 3974.423295] ceph: osd11 10.3.14.138:6800 connection failed
      [ 3974.429709] ceph: osd11 10.3.14.138:6800 connection failed
      
      Instead, if we get a fault, and have outstanding requests, but the osd
      address hasn't changed and the connection never successfully connected in
      the first place, do nothing to the osd connection.  The messenger layer
      will back off and retry periodically, because we never connected and thus
      the lossy bit is not set.
      
      Instead, touch each request's r_stamp so that handle_timeout can tell the
      request is still alive and kicking.
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      87b315a5
    • Sage Weil's avatar
      ceph: rename r_sent_stamp r_stamp · 3dd72fc0
      Sage Weil authored
      Make variable name slightly more generic, since it will (soon)
      reflect either the time the request was sent OR the time it was
      last determined to be still retrying.
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      3dd72fc0
    • Sage Weil's avatar
      ceph: fix null pointer deref of r_osd in debug output · 12eadc19
      Sage Weil authored
      This causes an oops when debug output is enabled and we kick
      an osd request with no current r_osd (sometime after an osd
      failure).  Check the pointer before dereferencing.
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      12eadc19
  13. 04 Mar, 2010 1 commit
    • Yehuda Sadeh's avatar
      ceph: reset osd after relevant messages timed out · 422d2cb8
      Yehuda Sadeh authored
      This simplifies the process of timing out messages. We
      keep lru of current messages that are in flight. If a
      timeout has passed, we reset the osd connection, so that
      messages will be retransmitted.  This is a failsafe in case
      we hit some sort of problem sending out message to the OSD.
      Normally, we'll get notification via an updated osdmap if
      there are problems.
      
      If a request is older than the keepalive timeout, send a
      keepalive to ensure we detect any breaks in the TCP connection.
      Signed-off-by: default avatarYehuda Sadeh <yehuda@hq.newdream.net>
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      422d2cb8
  14. 01 Mar, 2010 2 commits
  15. 26 Feb, 2010 1 commit
    • Sage Weil's avatar
      ceph: remove fragile __map_osds optimization · c99eb1c7
      Sage Weil authored
      We used to try to avoid freeing and then reallocating the osd
      struct.  This is a bit fragile due to potential interactions with
      other references (beyond o_requests), and may be the cause of
      this crash:
      
      [120633.442358] BUG: unable to handle kernel NULL pointer dereference at (null)
      [120633.443292] IP: [<ffffffff812549b6>] rb_erase+0x11d/0x277
      [120633.443292] PGD f7ff3067 PUD f7f53067 PMD 0
      [120633.443292] Oops: 0000 [#1] PREEMPT SMP
      [120633.443292] last sysfs file: /sys/kernel/uevent_seqnum
      [120633.443292] CPU 1
      [120633.443292] Modules linked in: ceph fan ac battery psmouse ehci_hcd ide_pci_generic ohci_hcd thermal processor button
      [120633.443292] Pid: 3023, comm: ceph-msgr/1 Not tainted 2.6.32-rc2 #12 H8SSL
      [120633.443292] RIP: 0010:[<ffffffff812549b6>]  [<ffffffff812549b6>] rb_erase+0x11d/0x277
      [120633.443292] RSP: 0018:ffff8800f7b13a50  EFLAGS: 00010246
      [120633.443292] RAX: ffff880022907819 RBX: ffff880022907818 RCX: 0000000000000000
      [120633.443292] RDX: ffff8800f7b13a80 RSI: ffff8800f587eb48 RDI: 0000000000000000
      [120633.443292] RBP: ffff8800f7b13a60 R08: 0000000000000000 R09: 0000000000000004
      [120633.443292] R10: 0000000000000000 R11: ffff8800c4441000 R12: ffff8800f587eb48
      [120633.443292] R13: ffff8800f58eaa00 R14: ffff8800f413c000 R15: 0000000000000001
      [120633.443292] FS:  00007fbef6e226e0(0000) GS:ffff880009200000(0000) knlGS:0000000000000000
      [120633.443292] CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
      [120633.443292] CR2: 0000000000000000 CR3: 00000000f7c53000 CR4: 00000000000006e0
      [120633.443292] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      [120633.443292] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
      [120633.443292] Process ceph-msgr/1 (pid: 3023, threadinfo ffff8800f7b12000, task ffff8800f5858b40)
      [120633.443292] Stack:
      [120633.443292]  ffff8800f413c000 ffff8800f587e9c0 ffff8800f7b13a80 ffffffffa0098a86
      [120633.443292] <0> 00000000000006f1 0000000000000000 ffff8800f7b13af0 ffffffffa009959b
      [120633.443292] <0> ffff8800f413c000 ffff880022a68400 ffff880022a68400 ffff8800f587e9c0
      [120633.443292] Call Trace:
      [120633.443292]  [<ffffffffa0098a86>] __remove_osd+0x4d/0xbc [ceph]
      [120633.443292]  [<ffffffffa009959b>] __map_osds+0x199/0x4fa [ceph]
      [120633.443292]  [<ffffffffa00999f4>] ? __send_request+0xf8/0x186 [ceph]
      [120633.443292]  [<ffffffffa0099beb>] kick_requests+0x169/0x3cb [ceph]
      [120633.443292]  [<ffffffffa009a8c1>] ceph_osdc_handle_map+0x370/0x522 [ceph]
      
      Since we're probably screwed anyway if a small kmalloc is
      failing, don't bother with trying to be clever here.
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      c99eb1c7
  16. 23 Feb, 2010 1 commit
  17. 15 Feb, 2010 1 commit
  18. 11 Feb, 2010 1 commit
  19. 10 Feb, 2010 1 commit
  20. 03 Feb, 2010 1 commit
  21. 25 Jan, 2010 3 commits
  22. 14 Jan, 2010 2 commits
  23. 23 Dec, 2009 3 commits
    • Sage Weil's avatar
      ceph: include transaction id in ceph_msg_header (protocol change) · 6df058c0
      Sage Weil authored
      Many (most?) message types include a transaction id.  By including it in
      the fixed size header, we always have it available even when we are unable
      to allocate memory for the (larger, variable sized) message body.  This
      will allow us to error out the appropriate request instead of (silently)
      dropping the reply.
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      6df058c0
    • Sage Weil's avatar
      ceph: control access to page vector for incoming data · 350b1c32
      Sage Weil authored
      When we issue an OSD read, we specify a vector of pages that the data is to
      be read into.  The request may be sent multiple times, to multiple OSDs, if
      the osdmap changes, which means we can get more than one reply.
      
      Only read data into the page vector if the reply is coming from the
      OSD we last sent the request to.  Keep track of which connection is using
      the vector by taking a reference.  If another connection was already
      using the vector before and a new reply comes in on the right connection,
      revoke the pages from the other connection.
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      350b1c32
    • Sage Weil's avatar
      ceph: unregister canceled/timed out osd requests · 529cfcc4
      Sage Weil authored
      Canceled or timed out osd requests were getting left in the request list
      and never deallocated (until umount).  Unregister if they are canceled
      (control-c) or time out.
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      529cfcc4