1. 25 Apr, 2019 34 commits
    • Petr Štetiar's avatar
      mwl8k: Fix rate_idx underflow · 6b583201
      Petr Štetiar authored
      It was reported on OpenWrt bug tracking system[1], that several users
      are affected by the endless reboot of their routers if they configure
      5GHz interface with channel 44 or 48.
      
      The reboot loop is caused by the following excessive number of WARN_ON
      messages:
      
       WARNING: CPU: 0 PID: 0 at backports-4.19.23-1/net/mac80211/rx.c:4516
                                   ieee80211_rx_napi+0x1fc/0xa54 [mac80211]
      
      as the messages are being correctly emitted by the following guard:
      
       case RX_ENC_LEGACY:
            if (WARN_ON(status->rate_idx >= sband->n_bitrates))
      
      as the rate_idx is in this case erroneously set to 251 (0xfb). This fix
      simply converts previously used magic number to proper constant and
      guards against substraction which is leading to the currently observed
      underflow.
      
      1. https://bugs.openwrt.org/index.php?do=details&task_id=2218
      
      Fixes: 85478344 ("mwl8k: properly set receive status rate index on 5 GHz receive")
      Cc: <stable@vger.kernel.org>
      Tested-by: default avatarEubert Bao <bunnier@gmail.com>
      Reported-by: default avatarEubert Bao <bunnier@gmail.com>
      Signed-off-by: default avatarPetr Štetiar <ynezz@true.cz>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      6b583201
    • YueHaibing's avatar
      at76c50x-usb: Don't register led_trigger if usb_register_driver failed · 09ac2694
      YueHaibing authored
      Syzkaller report this:
      
      [ 1213.468581] BUG: unable to handle kernel paging request at fffffbfff83bf338
      [ 1213.469530] #PF error: [normal kernel read fault]
      [ 1213.469530] PGD 237fe4067 P4D 237fe4067 PUD 237e60067 PMD 1c868b067 PTE 0
      [ 1213.473514] Oops: 0000 [#1] SMP KASAN PTI
      [ 1213.473514] CPU: 0 PID: 6321 Comm: syz-executor.0 Tainted: G         C        5.1.0-rc3+ #8
      [ 1213.473514] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014
      [ 1213.473514] RIP: 0010:strcmp+0x31/0xa0
      [ 1213.473514] Code: 00 00 00 00 fc ff df 55 53 48 83 ec 08 eb 0a 84 db 48 89 ef 74 5a 4c 89 e6 48 89 f8 48 89 fa 48 8d 6f 01 48 c1 e8 03 83 e2 07 <42> 0f b6 04 28 38 d0 7f 04 84 c0 75 50 48 89 f0 48 89 f2 0f b6 5d
      [ 1213.473514] RSP: 0018:ffff8881f2b7f950 EFLAGS: 00010246
      [ 1213.473514] RAX: 1ffffffff83bf338 RBX: ffff8881ea6f7240 RCX: ffffffff825350c6
      [ 1213.473514] RDX: 0000000000000000 RSI: ffffffffc1ee19c0 RDI: ffffffffc1df99c0
      [ 1213.473514] RBP: ffffffffc1df99c1 R08: 0000000000000001 R09: 0000000000000004
      [ 1213.473514] R10: 0000000000000000 R11: ffff8881de353f00 R12: ffff8881ee727900
      [ 1213.473514] R13: dffffc0000000000 R14: 0000000000000001 R15: ffffffffc1eeaaf0
      [ 1213.473514] FS:  00007fa66fa01700(0000) GS:ffff8881f7200000(0000) knlGS:0000000000000000
      [ 1213.473514] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [ 1213.473514] CR2: fffffbfff83bf338 CR3: 00000001ebb9e005 CR4: 00000000007606f0
      [ 1213.473514] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      [ 1213.473514] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
      [ 1213.473514] PKRU: 55555554
      [ 1213.473514] Call Trace:
      [ 1213.473514]  led_trigger_register+0x112/0x3f0
      [ 1213.473514]  led_trigger_register_simple+0x7a/0x110
      [ 1213.473514]  ? 0xffffffffc1c10000
      [ 1213.473514]  at76_mod_init+0x77/0x1000 [at76c50x_usb]
      [ 1213.473514]  do_one_initcall+0xbc/0x47d
      [ 1213.473514]  ? perf_trace_initcall_level+0x3a0/0x3a0
      [ 1213.473514]  ? kasan_unpoison_shadow+0x30/0x40
      [ 1213.473514]  ? kasan_unpoison_shadow+0x30/0x40
      [ 1213.473514]  do_init_module+0x1b5/0x547
      [ 1213.473514]  load_module+0x6405/0x8c10
      [ 1213.473514]  ? module_frob_arch_sections+0x20/0x20
      [ 1213.473514]  ? kernel_read_file+0x1e6/0x5d0
      [ 1213.473514]  ? find_held_lock+0x32/0x1c0
      [ 1213.473514]  ? cap_capable+0x1ae/0x210
      [ 1213.473514]  ? __do_sys_finit_module+0x162/0x190
      [ 1213.473514]  __do_sys_finit_module+0x162/0x190
      [ 1213.473514]  ? __ia32_sys_init_module+0xa0/0xa0
      [ 1213.473514]  ? __mutex_unlock_slowpath+0xdc/0x690
      [ 1213.473514]  ? wait_for_completion+0x370/0x370
      [ 1213.473514]  ? vfs_write+0x204/0x4a0
      [ 1213.473514]  ? do_syscall_64+0x18/0x450
      [ 1213.473514]  do_syscall_64+0x9f/0x450
      [ 1213.473514]  entry_SYSCALL_64_after_hwframe+0x49/0xbe
      [ 1213.473514] RIP: 0033:0x462e99
      [ 1213.473514] Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
      [ 1213.473514] RSP: 002b:00007fa66fa00c58 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
      [ 1213.473514] RAX: ffffffffffffffda RBX: 000000000073bf00 RCX: 0000000000462e99
      [ 1213.473514] RDX: 0000000000000000 RSI: 0000000020000300 RDI: 0000000000000003
      [ 1213.473514] RBP: 00007fa66fa00c70 R08: 0000000000000000 R09: 0000000000000000
      [ 1213.473514] R10: 0000000000000000 R11: 0000000000000246 R12: 00007fa66fa016bc
      [ 1213.473514] R13: 00000000004bcefa R14: 00000000006f6fb0 R15: 0000000000000004
      
      If usb_register failed, no need to call led_trigger_register_simple.
      Reported-by: default avatarHulk Robot <hulkci@huawei.com>
      Fixes: 1264b951 ("at76c50x-usb: add driver")
      Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      09ac2694
    • Alexey Khoroshilov's avatar
      mwl8k: fix error handling in mwl8k_post_cmd() · d1717282
      Alexey Khoroshilov authored
      If pci_map_single() fails in mwl8k_post_cmd(),
      it returns -ENOMEM immediately, while cleanup is required.
      
      Found by Linux Driver Verification project (linuxtesting.org).
      Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      d1717282
    • Larry Finger's avatar
      b43: Remove empty function lpphy_papd_cal() · b25105e1
      Larry Finger authored
      In commit d825db346270e ("b43: shut up clang -Wuninitialized variable
      warning"), the message noted that function lpphy_papd_cal() was empty
      and had an old TODO regarding its implementation. As the reverse
      engineering project that created the LP-PHY version of this driver
      has not been active for some time, it is safe to remove this empty
      function.
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      b25105e1
    • Dan Carpenter's avatar
      mwifiex: prevent an array overflow · b4c35c17
      Dan Carpenter authored
      The "rate_index" is only used as an index into the phist_data->rx_rate[]
      array in the mwifiex_hist_data_set() function.  That array has
      MWIFIEX_MAX_AC_RX_RATES (74) elements and it's used to generate some
      debugfs information.  The "rate_index" variable comes from the network
      skb->data[] and it is a u8 so it's in the 0-255 range.  We need to cap
      it to prevent an array overflow.
      
      Fixes: cbf6e055 ("mwifiex: add rx histogram statistics support")
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      b4c35c17
    • Gustavo A. R. Silva's avatar
      zd1211rw: use struct_size() helper · 0c7beb2d
      Gustavo A. R. Silva authored
      Make use of the struct_size() helper instead of an open-coded version
      in order to avoid any potential type mistakes, in particular in the
      context in which this code is being used.
      
      So, replace code of the following form:
      
      sizeof(struct usb_req_write_regs) + count * sizeof(struct reg_data)
      
      with:
      
      struct_size(req, reg_writes, count)
      
      This code was detected with the help of Coccinelle.
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      0c7beb2d
    • Gustavo A. R. Silva's avatar
      mwifiex: use struct_size() in kzalloc() · ae187ba9
      Gustavo A. R. Silva authored
      One of the more common cases of allocation size calculations is finding
      the size of a structure that has a zero-sized array at the end, along
      with memory for some number of elements for that array. For example:
      
      struct foo {
          int stuff;
          struct boo entry[];
      };
      
      size = sizeof(struct foo) + count * sizeof(struct boo);
      instance = kzalloc(size, GFP_KERNEL)
      
      Instead of leaving these open-coded and prone to type mistakes, we can
      now use the new struct_size() helper:
      
      instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL)
      
      Notice that, in this case, variable regd_size is not necessary,
      hence it is removed.
      
      This code was detected with the help of Coccinelle.
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      ae187ba9
    • Siva Rebbagondla's avatar
      rsi: miscallaneous changes for 9116 and common · 0a60014b
      Siva Rebbagondla authored
      Below changes are done:
      * Device 80MHz clock should be disabled for 9116 in 20MHz band.
      * Default edca parameters should be used initially before
        connection.
      * Default TA aggregation is 3 for 9116.
      * Bootup parameters should be loaded first when channel is
        changed.
      * 4 byte register writes are possible for 9116.
      Signed-off-by: default avatarSiva Rebbagondla <siva8118@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      0a60014b
    • Siva Rebbagondla's avatar
      rsi: reset device changes for 9116 · 17ff2c79
      Siva Rebbagondla authored
      Device reset register(watchdog timer related) addresses and
      values are different for 9116.
      Signed-off-by: default avatarSiva Rebbagondla <siva8118@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      17ff2c79
    • Siva Rebbagondla's avatar
      rsi: send new tx command frame wlan9116 features · 1533f976
      Siva Rebbagondla authored
      For 9116 device, we have introduced w9116 features frame, which shall be
      send when radio capabilities confirm is received.
      Signed-off-by: default avatarSiva Rebbagondla <siva8118@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      1533f976
    • Siva Rebbagondla's avatar
      rsi: new bootup parameters for 9116 · f911c861
      Siva Rebbagondla authored
      Bootup parameters are different for 9116 device. Check added for device
      model where-ever bootup parameters are being send.
      Signed-off-by: default avatarSiva Rebbagondla <siva8118@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      f911c861
    • Siva Rebbagondla's avatar
      rsi: change in device init frame sequence for 9116 · 9ba4562a
      Siva Rebbagondla authored
      Initial frame exchange sequence has been changed for 9116 chip. Getting MAC
      address using EEPROM read frame will be once common device configuration is
      done and RESET_MAC frame is sending after bootup parameters confirmation is
      received, which are different from RS9113 device
      Signed-off-by: default avatarSiva Rebbagondla <siva8118@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      9ba4562a
    • Siva Rebbagondla's avatar
      rsi: add firmware loading for 9116 device · e5a1ecc9
      Siva Rebbagondla authored
      New firmware files and firmware loading method are added for 9116.
      Signed-off-by: default avatarSiva Rebbagondla <siva8118@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      e5a1ecc9
    • Siva Rebbagondla's avatar
      rsi: move common part of firmware load to separate function · 3ac61578
      Siva Rebbagondla authored
      Till software bootloader ready state, communication with device is common
      for 9113 and 9116. Hence moved that part of firmware loading to separate
      function rsi_prepare_fw_load(). Also LMAC_VER_OFFSET is different for 9113
      and 9116, so renamed existing macro to LMAC_VER_OFFSET_9113
      Signed-off-by: default avatarSiva Rebbagondla <siva8118@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      3ac61578
    • Siva Rebbagondla's avatar
      rsi: add new device model for 9116 · 54fdb318
      Siva Rebbagondla authored
      9116 device id entry is added in both SDIO and USB interfaces.
      New enumberation value taken for the device model. Based on the
      device model detected run time, few device specific operations
      needs to be performed.
      
      adding rsi_dev_model to get device type in run time, as we can use
      same driver for 9113 and 9116 except few firmware load changes.
      Signed-off-by: default avatarSiva Rebbagondla <siva8118@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      54fdb318
    • Stanislaw Gruszka's avatar
      rt2x00mmio: remove legacy comment · 9ea3812f
      Stanislaw Gruszka authored
      Remove comment about fields that were removed.
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      9ea3812f
    • Stanislaw Gruszka's avatar
      rt2x00: remove not used entry field · d954f9e3
      Stanislaw Gruszka authored
      Remove not used any longer queue_entry field and flag.
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      d954f9e3
    • Stanislaw Gruszka's avatar
      rt2x00: remove last_nostatus_check · eb662b1d
      Stanislaw Gruszka authored
      We do not any longer check txstatus timeout from tasklet, so do not need
      this optimization.
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      eb662b1d
    • Stanislaw Gruszka's avatar
      rt2800mmio: use timer and work for handling tx statuses timeouts · e5ceab9d
      Stanislaw Gruszka authored
      Sometimes we can get into situation when there are pending statuses,
      but we do not get INT_SOURCE_CSR_TX_FIFO_STATUS. Handle this situation
      by arming timeout timer and read statuses (it will fix case when
      we just do not have irq) and queue work to handle case we missed
      statues from hardware FIFO.
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      e5ceab9d
    • Stanislaw Gruszka's avatar
      rt2800mmio: fetch tx status changes · 2c7ba758
      Stanislaw Gruszka authored
      Prepare to use rt2800mmio_fetch_txstatus() in concurrent manner and drop
      return value since is not longer needed.
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      2c7ba758
    • Stanislaw Gruszka's avatar
      rt2800: move txstatus pending routine · 6efa7987
      Stanislaw Gruszka authored
      Move rt2800usb_txstatus_pending routine to rt2800lib. It will be reused
      by rt2800mmio code.
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      6efa7987
    • Stanislaw Gruszka's avatar
      rt2800: new flush implementation for SoC devices · f6113150
      Stanislaw Gruszka authored
      Use new flush_queue() callback for SoC devices, what was already done for
      PCIe devices.
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      f6113150
    • Stanislaw Gruszka's avatar
      rt2800: partially restore old mmio txstatus behaviour · 889bb866
      Stanislaw Gruszka authored
      Do not disable txstatus interrupt and add quota of processed tx statuses in
      one tasklet. Quota is needed to allow to fed device with new frames during
      processing of tx statuses.
      
      Patch fixes about 15% performance degradation on some scenarios caused by
      0b0d556e ("rt2800mmio: use txdone/txstatus routines from lib").
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      889bb866
    • Aditya Pakki's avatar
      rsi: Fix NULL pointer dereference in kmalloc · d5414c23
      Aditya Pakki authored
      kmalloc can fail in rsi_register_rates_channels but memcpy still attempts
      to write to channels. The patch replaces these calls with kmemdup and
      passes the error upstream.
      Signed-off-by: default avatarAditya Pakki <pakki001@umn.edu>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      d5414c23
    • Tomislav Požega's avatar
      rt2x00: code-style fix in rt2800usb.c · 9490c560
      Tomislav Požega authored
      Remove space leftovers.
      Signed-off-by: default avatarTomislav Požega <pozega.tomislav@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      9490c560
    • Stanislaw Gruszka's avatar
      rt2x00: do not print error when queue is full · 61a4e5ff
      Stanislaw Gruszka authored
      For unknown reasons printk() on some context can cause CPU hung on
      embedded MT7620 AP/router MIPS platforms. What can result on wifi
      disconnects.
      
      This patch move queue full messages to debug level what is consistent
      with other mac80211 drivers which drop packet silently if tx queue is
      full. This make MT7620 OpenWRT routers more stable, what was reported
      by various users.
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      61a4e5ff
    • Stanislaw Gruszka's avatar
      rt2x00: check number of EPROTO errors · e383c704
      Stanislaw Gruszka authored
      Some USB host devices/drivers on some conditions can always return
      EPROTO error on submitted URBs. That can cause infinity loop in the
      rt2x00 driver.
      
      Since we can have single EPROTO errors we can not mark as device as
      removed to avoid infinity loop. However we can count consecutive
      EPROTO errors and mark device as removed if get lot of it.
      I choose number 10 as threshold.
      Reported-and-tested-by: default avatarRandy Oostdyk <linux-kernel@oostdyk.com>
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      e383c704
    • Stanislaw Gruszka's avatar
      rt2x00: use ratelimited variants dev_warn/dev_err · bb3b18c9
      Stanislaw Gruszka authored
      As reported by Randy we can overwhelm logs on some USB error conditions.
      To avoid that use dev_warn_ratelimited() and dev_err_ratelimitd().
      Reported-and-tested-by: default avatarRandy Oostdyk <linux-kernel@oostdyk.com>
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      bb3b18c9
    • Kangjie Lu's avatar
      net: cw1200: fix a NULL pointer dereference · 0ed2a005
      Kangjie Lu authored
      In case create_singlethread_workqueue fails, the fix free the
      hardware and returns NULL to avoid NULL pointer dereference.
      Signed-off-by: default avatarKangjie Lu <kjlu@umn.edu>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      0ed2a005
    • YueHaibing's avatar
      ssb: Fix possible NULL pointer dereference in ssb_host_pcmcia_exit · b2c01aab
      YueHaibing authored
      Syzkaller report this:
      
      kasan: GPF could be caused by NULL-ptr deref or user memory access
      general protection fault: 0000 [#1] SMP KASAN PTI
      CPU: 0 PID: 4492 Comm: syz-executor.0 Not tainted 5.0.0-rc7+ #45
      Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014
      RIP: 0010:sysfs_remove_file_ns+0x27/0x70 fs/sysfs/file.c:468
      Code: 00 00 00 41 54 55 48 89 fd 53 49 89 d4 48 89 f3 e8 ee 76 9c ff 48 8d 7d 30 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <80> 3c 02 00 75 2d 48 89 da 48 b8 00 00 00 00 00 fc ff df 48 8b 6d
      RSP: 0018:ffff8881e9d9fc00 EFLAGS: 00010206
      RAX: dffffc0000000000 RBX: ffffffff900367e0 RCX: ffffffff81a95952
      RDX: 0000000000000006 RSI: ffffc90001405000 RDI: 0000000000000030
      RBP: 0000000000000000 R08: fffffbfff1fa22ed R09: fffffbfff1fa22ed
      R10: 0000000000000001 R11: fffffbfff1fa22ec R12: 0000000000000000
      R13: ffffffffc1abdac0 R14: 1ffff1103d3b3f8b R15: 0000000000000000
      FS:  00007fe409dc1700(0000) GS:ffff8881f1200000(0000) knlGS:0000000000000000
      CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      CR2: 0000001b2d721000 CR3: 00000001e98b6005 CR4: 00000000007606f0
      DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
      PKRU: 55555554
      Call Trace:
       sysfs_remove_file include/linux/sysfs.h:519 [inline]
       driver_remove_file+0x40/0x50 drivers/base/driver.c:122
       pcmcia_remove_newid_file drivers/pcmcia/ds.c:163 [inline]
       pcmcia_unregister_driver+0x7d/0x2b0 drivers/pcmcia/ds.c:209
       ssb_modexit+0xa/0x1b [ssb]
       __do_sys_delete_module kernel/module.c:1018 [inline]
       __se_sys_delete_module kernel/module.c:961 [inline]
       __x64_sys_delete_module+0x3dc/0x5e0 kernel/module.c:961
       do_syscall_64+0x147/0x600 arch/x86/entry/common.c:290
       entry_SYSCALL_64_after_hwframe+0x49/0xbe
      RIP: 0033:0x462e99
      Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
      RSP: 002b:00007fe409dc0c58 EFLAGS: 00000246 ORIG_RAX: 00000000000000b0
      RAX: ffffffffffffffda RBX: 000000000073bf00 RCX: 0000000000462e99
      RDX: 0000000000000000 RSI: 0000000000000000 RDI: 00000000200000c0
      RBP: 0000000000000002 R08: 0000000000000000 R09: 0000000000000000
      R10: 0000000000000000 R11: 0000000000000246 R12: 00007fe409dc16bc
      R13: 00000000004bccaa R14: 00000000006f6bc8 R15: 00000000ffffffff
      Modules linked in: ssb(-) 3c59x nvme_core macvlan tap pata_hpt3x3 rt2x00pci null_blk tsc40 pm_notifier_error_inject notifier_error_inject mdio cdc_wdm nf_reject_ipv4 ath9k_common ath9k_hw ath pppox ppp_generic slhc ehci_platform wl12xx wlcore tps6507x_ts ioc4 nf_synproxy_core ide_gd_mod ax25 can_dev iwlwifi can_raw atm tm2_touchkey can_gw can sundance adp5588_keys rt2800mmio rt2800lib rt2x00mmio rt2x00lib eeprom_93cx6 pn533 lru_cache elants_i2c ip_set nfnetlink gameport tipc hampshire nhc_ipv6 nhc_hop nhc_udp nhc_fragment nhc_routing nhc_mobility nhc_dest 6lowpan silead brcmutil nfc mt76_usb mt76 mac80211 iptable_security iptable_raw iptable_mangle iptable_nat nf_nat_ipv4 nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 iptable_filter bpfilter ip6_vti ip_gre sit hsr veth vxcan batman_adv cfg80211 rfkill chnl_net caif nlmon vcan bridge stp llc ip6_gre ip6_tunnel tunnel6 tun joydev mousedev serio_raw ide_pci_generic piix floppy ide_core sch_fq_codel ip_tables x_tables ipv6
       [last unloaded: 3c59x]
      Dumping ftrace buffer:
         (ftrace buffer empty)
      ---[ end trace 3913cbf8011e1c05 ]---
      
      In ssb_modinit, it does not fail SSB init when ssb_host_pcmcia_init failed,
      however in ssb_modexit, ssb_host_pcmcia_exit calls pcmcia_unregister_driver
      unconditionally, which may tigger a NULL pointer dereference issue as above.
      Reported-by: default avatarHulk Robot <hulkci@huawei.com>
      Fixes: 399500da ("ssb: pick PCMCIA host code support from b43 driver")
      Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      b2c01aab
    • YueHaibing's avatar
      ray_cs: use remove_proc_subtree to simplify procfs code · 3b6edcb3
      YueHaibing authored
      Use remove_proc_subtree to remove the whole subtree
      Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      3b6edcb3
    • YueHaibing's avatar
      ray_cs: Check return value of pcmcia_register_driver · 444efbde
      YueHaibing authored
      init_ray_cs does not check value of pcmcia_register_driver,
      if it fails, there maybe cause a NULL pointer dereference in
      exit_ray_cs.
      Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      444efbde
    • Gustavo A. R. Silva's avatar
      rndis_wlan: use struct_size() helper · d442af2e
      Gustavo A. R. Silva authored
      Make use of the struct_size() helper instead of an open-coded version
      in order to avoid any potential type mistakes, in particular in the
      context in which this code is being used.
      
      So, replace code of the following form:
      
      sizeof(*pmkids) + max_pmkids * sizeof(pmkids->bssid_info[0])
      
      with:
      
      struct_size(pmkids, bssid_info, num_pmkids)
      
      This code was detected with the help of Coccinelle.
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      d442af2e
    • Kalle Valo's avatar
      Merge tag 'iwlwifi-next-for-kalle-2019-04-18-2' of... · b99561c5
      Kalle Valo authored
      Merge tag 'iwlwifi-next-for-kalle-2019-04-18-2' of git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next
      
      Third batch of patches intended for v5.2
      
      * Bump the 20000-series FW API version supported;
      * Work on the new debugging infra continues;
      * One clean-up to prevent a bogus warning with clang;
      * A small cleanup in the PCI ID list;
      * Work on new hardware continues;
      * RTT confidence indication support for FTM;
      * An improvement in HE rate-scaling;
      b99561c5
  2. 19 Apr, 2019 6 commits