1. 27 Mar, 2024 10 commits
  2. 26 Mar, 2024 14 commits
  3. 25 Mar, 2024 7 commits
    • Pu Lehui's avatar
      riscv, bpf: Fix kfunc parameters incompatibility between bpf and riscv abi · 443574b0
      Pu Lehui authored
      We encountered a failing case when running selftest in no_alu32 mode:
      
      The failure case is `kfunc_call/kfunc_call_test4` and its source code is
      like bellow:
      ```
      long bpf_kfunc_call_test4(signed char a, short b, int c, long d) __ksym;
      int kfunc_call_test4(struct __sk_buff *skb)
      {
      	...
      	tmp = bpf_kfunc_call_test4(-3, -30, -200, -1000);
      	...
      }
      ```
      
      And its corresponding asm code is:
      ```
      0: r1 = -3
      1: r2 = -30
      2: r3 = 0xffffff38 # opcode: 18 03 00 00 38 ff ff ff 00 00 00 00 00 00 00 00
      4: r4 = -1000
      5: call bpf_kfunc_call_test4
      ```
      
      insn 2 is parsed to ld_imm64 insn to emit 0x00000000ffffff38 imm, and
      converted to int type and then send to bpf_kfunc_call_test4. But since
      it is zero-extended in the bpf calling convention, riscv jit will
      directly treat it as an unsigned 32-bit int value, and then fails with
      the message "actual 4294966063 != expected -1234".
      
      The reason is the incompatibility between bpf and riscv abi, that is,
      bpf will do zero-extension on uint, but riscv64 requires sign-extension
      on int or uint. We can solve this problem by sign extending the 32-bit
      parameters in kfunc.
      
      The issue is related to [0], and thanks to Yonghong and Alexei.
      
      Link: https://github.com/llvm/llvm-project/pull/84874 [0]
      Fixes: d40c3847 ("riscv, bpf: Add kfunc support for RV64")
      Signed-off-by: default avatarPu Lehui <pulehui@huawei.com>
      Tested-by: default avatarPuranjay Mohan <puranjay12@gmail.com>
      Reviewed-by: default avatarPuranjay Mohan <puranjay12@gmail.com>
      Link: https://lore.kernel.org/r/20240324103306.2202954-1-pulehui@huaweicloud.comSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
      443574b0
    • Kurt Kanzenbach's avatar
      igc: Remove stale comment about Tx timestamping · 47ce2956
      Kurt Kanzenbach authored
      The initial igc Tx timestamping implementation used only one register for
      retrieving Tx timestamps. Commit 3ed247e7 ("igc: Add support for
      multiple in-flight TX timestamps") added support for utilizing all four of
      them e.g., for multiple domain support. Remove the stale comment/FIXME.
      
      Fixes: 3ed247e7 ("igc: Add support for multiple in-flight TX timestamps")
      Signed-off-by: Kurt Kanzenbach's avatarKurt Kanzenbach <kurt@linutronix.de>
      Acked-by: default avatarVinicius Costa Gomes <vinicius.gomes@intel.com>
      Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
      Tested-by: default avatarNaama Meir <naamax.meir@linux.intel.com>
      Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
      47ce2956
    • Przemek Kitszel's avatar
      ixgbe: avoid sleeping allocation in ixgbe_ipsec_vf_add_sa() · aec806fb
      Przemek Kitszel authored
      Change kzalloc() flags used in ixgbe_ipsec_vf_add_sa() to GFP_ATOMIC, to
      avoid sleeping in IRQ context.
      
      Dan Carpenter, with the help of Smatch, has found following issue:
      The patch eda0333a: "ixgbe: add VF IPsec management" from Aug 13,
      2018 (linux-next), leads to the following Smatch static checker
      warning: drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c:917 ixgbe_ipsec_vf_add_sa()
      	warn: sleeping in IRQ context
      
      The call tree that Smatch is worried about is:
      ixgbe_msix_other() <- IRQ handler
      -> ixgbe_msg_task()
         -> ixgbe_rcv_msg_from_vf()
            -> ixgbe_ipsec_vf_add_sa()
      
      Fixes: eda0333a ("ixgbe: add VF IPsec management")
      Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
      Link: https://lore.kernel.org/intel-wired-lan/db31a0b0-4d9f-4e6b-aed8-88266eb5665c@moroto.mountainReviewed-by: default avatarMichal Kubiak <michal.kubiak@intel.com>
      Signed-off-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
      Reviewed-by: default avatarShannon Nelson <shannon.nelson@amd.com>
      Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
      Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
      aec806fb
    • Jesse Brandeburg's avatar
      ice: fix memory corruption bug with suspend and rebuild · 1cb7fdb1
      Jesse Brandeburg authored
      The ice driver would previously panic after suspend. This is caused
      from the driver *only* calling the ice_vsi_free_q_vectors() function by
      itself, when it is suspending. Since commit b3e7b3a6 ("ice: prevent
      NULL pointer deref during reload") the driver has zeroed out
      num_q_vectors, and only restored it in ice_vsi_cfg_def().
      
      This further causes the ice_rebuild() function to allocate a zero length
      buffer, after which num_q_vectors is updated, and then the new value of
      num_q_vectors is used to index into the zero length buffer, which
      corrupts memory.
      
      The fix entails making sure all the code referencing num_q_vectors only
      does so after it has been reset via ice_vsi_cfg_def().
      
      I didn't perform a full bisect, but I was able to test against 6.1.77
      kernel and that ice driver works fine for suspend/resume with no panic,
      so sometime since then, this problem was introduced.
      
      Also clean up an un-needed init of a local variable in the function
      being modified.
      
      PANIC from 6.8.0-rc1:
      
      [1026674.915596] PM: suspend exit
      [1026675.664697] ice 0000:17:00.1: PTP reset successful
      [1026675.664707] ice 0000:17:00.1: 2755 msecs passed between update to cached PHC time
      [1026675.667660] ice 0000:b1:00.0: PTP reset successful
      [1026675.675944] ice 0000:b1:00.0: 2832 msecs passed between update to cached PHC time
      [1026677.137733] ixgbe 0000:31:00.0 ens787: NIC Link is Up 1 Gbps, Flow Control: None
      [1026677.190201] BUG: kernel NULL pointer dereference, address: 0000000000000010
      [1026677.192753] ice 0000:17:00.0: PTP reset successful
      [1026677.192764] ice 0000:17:00.0: 4548 msecs passed between update to cached PHC time
      [1026677.197928] #PF: supervisor read access in kernel mode
      [1026677.197933] #PF: error_code(0x0000) - not-present page
      [1026677.197937] PGD 1557a7067 P4D 0
      [1026677.212133] ice 0000:b1:00.1: PTP reset successful
      [1026677.212143] ice 0000:b1:00.1: 4344 msecs passed between update to cached PHC time
      [1026677.212575]
      [1026677.243142] Oops: 0000 [#1] PREEMPT SMP NOPTI
      [1026677.247918] CPU: 23 PID: 42790 Comm: kworker/23:0 Kdump: loaded Tainted: G        W          6.8.0-rc1+ #1
      [1026677.257989] Hardware name: Intel Corporation M50CYP2SBSTD/M50CYP2SBSTD, BIOS SE5C620.86B.01.01.0005.2202160810 02/16/2022
      [1026677.269367] Workqueue: ice ice_service_task [ice]
      [1026677.274592] RIP: 0010:ice_vsi_rebuild_set_coalesce+0x130/0x1e0 [ice]
      [1026677.281421] Code: 0f 84 3a ff ff ff 41 0f b7 74 ec 02 66 89 b0 22 02 00 00 81 e6 ff 1f 00 00 e8 ec fd ff ff e9 35 ff ff ff 48 8b 43 30 49 63 ed <41> 0f b7 34 24 41 83 c5 01 48 8b 3c e8 66 89 b7 aa 02 00 00 81 e6
      [1026677.300877] RSP: 0018:ff3be62a6399bcc0 EFLAGS: 00010202
      [1026677.306556] RAX: ff28691e28980828 RBX: ff28691e41099828 RCX: 0000000000188000
      [1026677.314148] RDX: 0000000000000000 RSI: 0000000000000010 RDI: ff28691e41099828
      [1026677.321730] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
      [1026677.329311] R10: 0000000000000007 R11: ffffffffffffffc0 R12: 0000000000000010
      [1026677.336896] R13: 0000000000000000 R14: 0000000000000000 R15: ff28691e0eaa81a0
      [1026677.344472] FS:  0000000000000000(0000) GS:ff28693cbffc0000(0000) knlGS:0000000000000000
      [1026677.353000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [1026677.359195] CR2: 0000000000000010 CR3: 0000000128df4001 CR4: 0000000000771ef0
      [1026677.366779] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      [1026677.374369] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
      [1026677.381952] PKRU: 55555554
      [1026677.385116] Call Trace:
      [1026677.388023]  <TASK>
      [1026677.390589]  ? __die+0x20/0x70
      [1026677.394105]  ? page_fault_oops+0x82/0x160
      [1026677.398576]  ? do_user_addr_fault+0x65/0x6a0
      [1026677.403307]  ? exc_page_fault+0x6a/0x150
      [1026677.407694]  ? asm_exc_page_fault+0x22/0x30
      [1026677.412349]  ? ice_vsi_rebuild_set_coalesce+0x130/0x1e0 [ice]
      [1026677.418614]  ice_vsi_rebuild+0x34b/0x3c0 [ice]
      [1026677.423583]  ice_vsi_rebuild_by_type+0x76/0x180 [ice]
      [1026677.429147]  ice_rebuild+0x18b/0x520 [ice]
      [1026677.433746]  ? delay_tsc+0x8f/0xc0
      [1026677.437630]  ice_do_reset+0xa3/0x190 [ice]
      [1026677.442231]  ice_service_task+0x26/0x440 [ice]
      [1026677.447180]  process_one_work+0x174/0x340
      [1026677.451669]  worker_thread+0x27e/0x390
      [1026677.455890]  ? __pfx_worker_thread+0x10/0x10
      [1026677.460627]  kthread+0xee/0x120
      [1026677.464235]  ? __pfx_kthread+0x10/0x10
      [1026677.468445]  ret_from_fork+0x2d/0x50
      [1026677.472476]  ? __pfx_kthread+0x10/0x10
      [1026677.476671]  ret_from_fork_asm+0x1b/0x30
      [1026677.481050]  </TASK>
      
      Fixes: b3e7b3a6 ("ice: prevent NULL pointer deref during reload")
      Reported-by: default avatarRobert Elliott <elliott@hpe.com>
      Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
      Reviewed-by: default avatarSimon Horman <horms@kernel.org>
      Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
      Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
      Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
      1cb7fdb1
    • Steven Zou's avatar
      ice: Refactor FW data type and fix bitmap casting issue · 817b1896
      Steven Zou authored
      According to the datasheet, the recipe association data is an 8-byte
      little-endian value. It is described as 'Bitmap of the recipe indexes
      associated with this profile', it is from 24 to 31 byte area in FW.
      Therefore, it is defined to '__le64 recipe_assoc' in struct
      ice_aqc_recipe_to_profile. And then fix the bitmap casting issue, as we
      must never ever use castings for bitmap type.
      
      Fixes: 1e0f9881 ("ice: Flesh out implementation of support for SRIOV on bonded interface")
      Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
      Reviewed-by: default avatarAndrii Staikov <andrii.staikov@intel.com>
      Reviewed-by: default avatarJan Sokolowski <jan.sokolowski@intel.com>
      Reviewed-by: default avatarSimon Horman <horms@kernel.org>
      Signed-off-by: default avatarSteven Zou <steven.zou@intel.com>
      Tested-by: default avatarSujai Buvaneswaran <sujai.buvaneswaran@intel.com>
      Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
      817b1896
    • linke li's avatar
      net: mark racy access on sk->sk_rcvbuf · c2deb2e9
      linke li authored
      sk->sk_rcvbuf in __sock_queue_rcv_skb() and __sk_receive_skb() can be
      changed by other threads. Mark this as benign using READ_ONCE().
      
      This patch is aimed at reducing the number of benign races reported by
      KCSAN in order to focus future debugging effort on harmful races.
      Signed-off-by: default avatarlinke li <lilinke99@qq.com>
      Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c2deb2e9
    • David Thompson's avatar
      mlxbf_gige: stop PHY during open() error paths · d6c30c5a
      David Thompson authored
      The mlxbf_gige_open() routine starts the PHY as part of normal
      initialization.  The mlxbf_gige_open() routine must stop the
      PHY during its error paths.
      
      Fixes: f92e1869 ("Add Mellanox BlueField Gigabit Ethernet driver")
      Signed-off-by: default avatarDavid Thompson <davthompson@nvidia.com>
      Reviewed-by: default avatarAsmaa Mnebhi <asmaa@nvidia.com>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d6c30c5a
  4. 23 Mar, 2024 6 commits
  5. 22 Mar, 2024 1 commit
  6. 21 Mar, 2024 2 commits
    • Linus Torvalds's avatar
      Merge tag 'net-6.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · cba9ffdb
      Linus Torvalds authored
      Pull networking fixes from Jakub Kicinski:
       "Including fixes from CAN, netfilter, wireguard and IPsec.
      
        I'd like to highlight [ lowlight? - Linus ] Florian W stepping down as
        a netfilter maintainer due to constant stream of bug reports. Not sure
        what we can do but IIUC this is not the first such case.
      
        Current release - regressions:
      
         - rxrpc: fix use of page_frag_alloc_align(), it changed semantics and
           we added a new caller in a different subtree
      
         - xfrm: allow UDP encapsulation only in offload modes
      
        Current release - new code bugs:
      
         - tcp: fix refcnt handling in __inet_hash_connect()
      
         - Revert "net: Re-use and set mono_delivery_time bit for userspace
           tstamp packets", conflicted with some expectations in BPF uAPI
      
        Previous releases - regressions:
      
         - ipv4: raw: fix sending packets from raw sockets via IPsec tunnels
      
         - devlink: fix devlink's parallel command processing
      
         - veth: do not manipulate GRO when using XDP
      
         - esp: fix bad handling of pages from page_pool
      
        Previous releases - always broken:
      
         - report RCU QS for busy network kthreads (with Paul McK's blessing)
      
         - tcp/rds: fix use-after-free on netns with kernel TCP reqsk
      
         - virt: vmxnet3: fix missing reserved tailroom with XDP
      
        Misc:
      
         - couple of build fixes for Documentation"
      
      * tag 'net-6.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (59 commits)
        selftests: forwarding: Fix ping failure due to short timeout
        MAINTAINERS: step down as netfilter maintainer
        netfilter: nf_tables: Fix a memory leak in nf_tables_updchain
        net: dsa: mt7530: fix handling of all link-local frames
        net: dsa: mt7530: fix link-local frames that ingress vlan filtering ports
        bpf: report RCU QS in cpumap kthread
        net: report RCU QS on threaded NAPI repolling
        rcu: add a helper to report consolidated flavor QS
        ionic: update documentation for XDP support
        lib/bitmap: Fix bitmap_scatter() and bitmap_gather() kernel doc
        netfilter: nf_tables: do not compare internal table flags on updates
        netfilter: nft_set_pipapo: release elements in clone only from destroy path
        octeontx2-af: Use separate handlers for interrupts
        octeontx2-pf: Send UP messages to VF only when VF is up.
        octeontx2-pf: Use default max_active works instead of one
        octeontx2-pf: Wait till detach_resources msg is complete
        octeontx2: Detect the mbox up or down message via register
        devlink: fix port new reply cmd type
        tcp: Clear req->syncookie in reqsk_alloc().
        net/bnx2x: Prevent access to a freed page in page_pool
        ...
      cba9ffdb
    • Linus Torvalds's avatar
      Merge tag 'kbuild-v6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild · 1d35aae7
      Linus Torvalds authored
      Pull Kbuild updates from Masahiro Yamada:
      
       - Generate a list of built DTB files (arch/*/boot/dts/dtbs-list)
      
       - Use more threads when building Debian packages in parallel
      
       - Fix warnings shown during the RPM kernel package uninstallation
      
       - Change OBJECT_FILES_NON_STANDARD_*.o etc. to take a relative path to
         Makefile
      
       - Support GCC's -fmin-function-alignment flag
      
       - Fix a null pointer dereference bug in modpost
      
       - Add the DTB support to the RPM package
      
       - Various fixes and cleanups in Kconfig
      
      * tag 'kbuild-v6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild: (67 commits)
        kconfig: tests: test dependency after shuffling choices
        kconfig: tests: add a test for randconfig with dependent choices
        kconfig: tests: support KCONFIG_SEED for the randconfig runner
        kbuild: rpm-pkg: add dtb files in kernel rpm
        kconfig: remove unneeded menu_is_visible() call in conf_write_defconfig()
        kconfig: check prompt for choice while parsing
        kconfig: lxdialog: remove unused dialog colors
        kconfig: lxdialog: fix button color for blackbg theme
        modpost: fix null pointer dereference
        kbuild: remove GCC's default -Wpacked-bitfield-compat flag
        kbuild: unexport abs_srctree and abs_objtree
        kbuild: Move -Wenum-{compare-conditional,enum-conversion} into W=1
        kconfig: remove named choice support
        kconfig: use linked list in get_symbol_str() to iterate over menus
        kconfig: link menus to a symbol
        kbuild: fix inconsistent indentation in top Makefile
        kbuild: Use -fmin-function-alignment when available
        alpha: merge two entries for CONFIG_ALPHA_GAMMA
        alpha: merge two entries for CONFIG_ALPHA_EV4
        kbuild: change DTC_FLAGS_<basetarget>.o to take the path relative to $(obj)
        ...
      1d35aae7