- 15 Mar, 2014 40 commits
-
-
Mahesh Rajashekhara authored
This patch fixes kernel panic issue while booting into the kdump kernel. We have triggered crash and kdump vmcore was successful. No issues seen while booting into the OS. Signed-off-by:
Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com> Reviewed-by:
Tomas Henzl <thenzl@redhat.com> Signed-off-by:
James Bottomley <JBottomley@Parallels.com>
-
Dan Carpenter authored
pthru32->dataxferlen comes from the user so we need to check that it's not too large so we don't overflow the buffer. Reported-by:
Nico Golde <nico@ngolde.de> Reported-by:
Fabian Yamaguchi <fabs@goesec.de> Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Acked-by:
Sumit Saxena <sumit.saxena@lsi.com> Signed-off-by:
-
Vaughan Cao authored
This patch makes reject messages show right value for opcode and itt, which is converse previously. Signed-off-by:
Vaughan Cao <vaughan.cao@oracle.com> Acked-by:
Mike Christie <michaelc@cs.wisc.edu> Signed-off-by:
-
Vijaya Mohan Guvva authored
Fixed following smatch warnings in bfa. drivers/scsi/bfa/bfa_ioc.c:3882 bfa_sfp_show_comp() error: memcpy() 'des' too small (64 vs 248) drivers/scsi/bfa/bfa_ioc.c:6859 bfa_flash_status_read() warn: unsigned 'status' is never less than zero. drivers/scsi/bfa/bfa_ioc.c:6881 bfa_flash_status_read() warn: unsigned 'status' is never less than zero. drivers/scsi/bfa/bfa_ioc.c:6917 bfa_flash_read_start() warn: unsigned 'status' is never less than zero. drivers/scsi/bfa/bfa_ioc.c:7043 bfa_flash_raw_read() warn: unsigned 'status' is never less than zero. Signed-off-by:
Vijaya Mohan Guvva <vmohan@brocade.com> Signed-off-by:
-
Wei Yongjun authored
Add the missing unlock before return from function bfad_iocmd_cfg_trunk() in the error handling case. Signed-off-by:
Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by:
-
Hannes Reinecke authored
When the host template doesn't declare an eh_host_reset_handler the eh_deadline mechanism is pointless and will set the device to offline. So disable eh_deadline if no eh_host_reset_handler is present. Signed-off-by:
Hannes Reinecke <hare@suse.de> Signed-off-by:
-
James Bottomley authored
In the highly unusual case where two threads are running concurrently through the scanning code scanning the same target, we run into the situation where one may allocate the target while the other is still using it. In this case, because the reap checks for STARGET_CREATED and kills the target without reference counting, the second thread will do the wrong thing on reap. Fix this by reference counting even creates and doing the STARGET_CREATED check in the final put. Tested-by:
Sarah Sharp <sarah.a.sharp@linux.intel.com> Cc: stable@vger.kernel.org # delay backport for 2 months for field testing Signed-off-by:
-
James Bottomley authored
This patch eliminates the reap_ref and replaces it with a proper kref. On last put of this kref, the target is removed from visibility in sysfs. The final call to scsi_target_reap() for the device is done from __scsi_remove_device() and only if the device was made visible. This ensures that the target disappears as soon as the last device is gone rather than waiting until final release of the device (which is often too long). Reviewed-by:
Alan Stern <stern@rowland.harvard.edu> Tested-by:
-
Bradley Grove authored
Signed-off-by:
Bradley Grove <bgrove@attotech.com> Signed-off-by:
-
Bradley Grove authored
Signed-off-by:
-
Kees Cook authored
This makes sure format strings cannot leak into the printk call via the constructed buffer. Signed-off-by:
Kees Cook <keescook@chromium.org> Acked-by:
-
Daeseok Youn authored
sparse says: drivers/scsi/lpfc/lpfc_sli.c:16547:37: warning: Using plain integer as NULL pointer Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Acked-by:
James Smart <james.smart@emulex.com> Signed-off-by:
-
James Smart authored
Report from coverity Reported-by:
Dave Jones <davej@redhat.com> Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
Signed-off-by:
-
Chad Dupuis authored
Signed-off-by:
Chad Dupuis <chad.dupuis@qlogic.com> Signed-off-by:
Saurav Kashyap <saurav.kashyap@qlogic.com> Signed-off-by:
-
Steven J. Magnani authored
Fix module parameter descriptions mentioning default values that no longer match the code. Signed-off-by:
Steven J. Magnani <steve@digidescorp.com> Acked-by:
-
Dan Carpenter authored
qla2x00_mem_alloc() returns 1 on success and -ENOMEM on failure. On the one hand the caller assumes non-zero is success but on the other hand the caller also assumes that it returns an error code. I've fixed it to return zero on success and a negative error code on failure. This matches the documentation as well. [jejb: checkpatch fix] Fixes: e315cd28 ('[SCSI] qla2xxx: Code changes for qla data structure refactoring') Signed-off-by:
-
Dan Williams authored
isci is needlessly tying libata's hands by returning SAM_STAT_CHECK_CONDITION to some ata errors. Instead, prefer SAS_PROTO_RESPONSE to let libata (via sas_ata_task_done()) disposition the device-to-host fis. For example isci is triggering an HSM Violation where AHCI is showing a simple media error for the same bus condition: isci: ata7.00: failed command: READ VERIFY SECTOR(S) ata7.00: cmd 40/00:01:00:00:00/00:00:00:00:00/e0 tag 0 res 01/04:00:00:00:00/00:00:00:00:00/e0 Emask 0x3 (HSM violation) ahci: ata6.00: failed command: READ VERIFY SECTOR(S) ata6.00: cmd 40/00:01:00:00:00/00:00:00:00:00/e0 tag 0 res 51/40:01:00:00:00/00:00:00:00:00/e0 Emask 0x9 (media error) Note that the isci response matches this from sas_ata_task_done(): /* We saw a SAS error. Send a vague error. */ [..] dev->sata_dev.fis[3] = 0x04; /* status err */ dev->sata_dev.fis[2] = ATA_ERR; The end effect is that isci is needlessly triggering hard resets when they are not necessary. Reported-by:Xun Ni <xun.ni@intel.com> Tested-by:
Nelson Cheng <nelson.cheng@intel.com> Acked-by:
Lukasz Dorau <lukasz.dorau@intel.com> Signed-off-by:
Dan Williams <dan.j.williams@intel.com> Signed-off-by:
-
Dan Williams authored
libsas sometimes short circuits timeouts to force commands into error recovery. It is misleading to log that the command timed-out in sas_scsi_timed_out() when in fact it was just queued for error handling. It's also redundant in the case of a true timeout as libata eh will detect and report timeouts via it's AC_ERR_TIMEOUT facility. Given that some environments consider "timeout" errors to be indicative of impending device failure demote the sas_scsi_timed_out() timeout message to be disabled by default. This parallels ata_scsi_timed_out(). [jejb: checkpatch fix] Reported-by:
-
Armen Baloyan authored
Send aborts to the firmware via the request/response queue mechanism. Signed-off-by:
Armen Baloyan <armen.baloyan@qlogic.com> Signed-off-by:
-
Armen Baloyan authored
- Fix interpreting the wrong IOCB type for task management functions in the response path. - Merge the task management function handling for various adapters. Signed-off-by:
-
Saurav Kashyap authored
Signed-off-by:
Giridhar Malavali <giridhar.malavali@qlogic.com> Signed-off-by:
-
Saurav Kashyap authored
Signed-off-by:
-
Saurav Kashyap authored
Signed-off-by:
-
Chad Dupuis authored
Allow for the capture of a firmware dump but have a sysfs node (allow_cna_fw_dump) to allow the feature to be enabled/disabled dynamically. The default is off. Signed-off-by:
-
Saurav Kashyap authored
Signed-off-by:
-
