- 10 Sep, 2024 12 commits
-
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct pfuze_regulator), so make it const for code safety. Signed-off-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://patch.msgid.link/20240909-regulator-const-v1-13-8934704a5787@linaro.orgSigned-off-by:
Mark Brown <broonie@kernel.org>
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct pcap_regulator), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct regulator_desc), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct regulator_desc), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
The max77826_regulator_info.rdesc is assigned once and never used again. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct tps_driver_data), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct hi6421_spmi_reg_info), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct hi6421_regulator_info), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct da9121_range), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with device variant description (struct da9063_dev_model), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulators description (struct da9055_regulator_info), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulators description (struct da9052_regulator_info), so make it const for code safety. Signed-off-by:
-
- 09 Sep, 2024 4 commits
-
-
Christophe JAILLET authored
'struct regulator_desc' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increases overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 4974 736 16 5726 165e drivers/regulator/tps6287x-regulator.o After: ===== text data bss dec hex filename 5294 416 16 5726 165e drivers/regulator/tps6287x-regulator.o -- Compile tested only Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://patch.msgid.link/7727e493490d37775a653905dfe0cc1d8478f8e0.1725908163.git.christophe.jaillet@wanadoo.frSigned-off-by:
-
Christophe JAILLET authored
'struct regulator_desc' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increases overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 4419 2512 0 6931 1b13 drivers/regulator/wm8400-regulator.o After: ===== text data bss dec hex filename 6307 624 0 6931 1b13 drivers/regulator/wm8400-regulator.o -- Compile tested only Signed-off-by:
-
Christophe JAILLET authored
'struct regulator_desc' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 13982 2118 16 16116 3ef4 drivers/regulator/da9211-regulator.o After: ===== text data bss dec hex filename 14622 1478 16 16116 3ef4 drivers/regulator/da9211-regulator.o -- Compile tested only Signed-off-by:
-
Christophe JAILLET authored
'struct regulator_desc' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 3516 5320 32 8868 22a4 drivers/regulator/mp5416.o After: ===== text data bss dec hex filename 8508 320 32 8860 229c drivers/regulator/mp5416.o -- Compile tested only Signed-off-by:
-
- 07 Sep, 2024 1 commit
-
-
Mark Brown authored
Merge series from Andre Przywara <andre.przywara@arm.com>: This is remainder of the AXP717 fix series, containing support for the boost regulator. This is meant to increase the battery voltage to the 5 volts required to provide the USB VBUS power. It's the usual trinity of DT bindings patch (1/3), the MFD part describing the PMIC registers (2/3) and the final patch to model the regulator (3/3). Compared to v2, this drops the merged patches, and just retains the boost related parts. It also changes the internal name of the register to AXP717_MODULE_EN_CONTROL_2, since there is another control register we will need later for battery support.
-
- 06 Sep, 2024 3 commits
-
-
Andre Przywara authored
The AXP717 also contains an adjustable boost regulator, to provide the 5V USB VBUS rail when running on battery. Add the regulator description that states the voltage range this regulator can cover. Signed-off-by:
Andre Przywara <andre.przywara@arm.com> Reviewed-by:
John Watts <contact@jookia.org> Reviewed-by:
Chen-Yu Tsai <wens@csie.org> Link: https://patch.msgid.link/20240816001824.6028-4-andre.przywara@arm.comSigned-off-by:
-
Andre Przywara authored
The AXP717 also contains a boost regulator, to provide the 5V USB VBUS rail when running on battery. Add the registers to the MFD description to be able to use them from the regulator driver. Signed-off-by:
Lee Jones <lee@kernel.org> Reviewed-by:
-
Andre Przywara authored
The X-Powers AXP717 contains a boost regulator, that it meant to provide the 5V USB VBUS voltage when the devices operates on battery. Add the name "boost" to the regexp describing the allowed node names, to allow the regulator to be described in the devicetree. Signed-off-by:
-
- 05 Sep, 2024 1 commit
-
-
Andy Shevchenko authored
Refactor of_get_*regulator() to decrease indentation and increase readability. No functional changes intended. Signed-off-by:
Andy Shevchenko <andy.shevchenko@gmail.com> Reviewed-by:
Chen-Yu Tsai <wenst@chromium.org> Link: https://patch.msgid.link/20240904190856.1221459-1-andy.shevchenko@gmail.comSigned-off-by:
-
- 04 Sep, 2024 1 commit
-
-
Chen-Yu Tsai authored
There's still a bit of OF-specific code in the regulator device lookup function. Move those bits of code over to of_regulator.c, and create a new function of_regulator_dev_lookup() to encapsulate the code moved out of regulator_dev_lookup(). Also mark of_find_regulator_by_node() as static, since there are no other users in other compile units. There are no functional changes. A line alignment was also fixed. Signed-off-by:
-
- 29 Aug, 2024 10 commits
-
-
Chen-Yu Tsai authored
Previous commits cleaning up kerneldoc used the term "negative error number" to refer to error condition return values. Update remaining instances of other terminology such as "error code" or "errno" as well so the whole regulator subsystem is unified. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by:
-
Chen-Yu Tsai authored
of_regulator_bulk_get_all() has a comment section that pretty much resembles a kerneldoc block, except that the block begins with "/*" instead of "/**". Fix that and also rework the "Return" section and the error code terminology so that it is the same as the other kerneldoc blocks in the same file. Fixes: 27b9ecc7 ("regulator: Add of_regulator_bulk_get_all") Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains about missing "Return" section for the function regulator_irq_map_event_simple(). Add a "Return" section for it based on its behavior. The function actually always returns 0, but fills in fields in its @rid parameter as needed. Expand the description of the parameter to cover this. While at it fix a typo found in the description of the same function. Reported-by:
Matti Vaittinen <mazziesaccount@gmail.com> Closes: https://lore.kernel.org/all/e341240e-1c1f-49a2-91cd-440888fdbda0@gmail.com/Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains about missing "Return" section for the function regulator_register_always_on(). Add a "Return" section for it based on its behavior. Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains about missing "Return" section for kerneldoc of of_get_fixed_voltage_config(). The kerneldoc has a description about the return values, just not in the format kernel-doc wants. Convert it to use the proper "Return:" section header. The existing description have been reworded and moved around to fit the grammar and formatting. Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains about missing "Return" section for many documented functions in the regulator OF-specific code. These all have descriptions about the return values, just not in the format kernel-doc wants. Convert these to use the proper "Return:" section header. The existing descriptions have been reworded and moved around to fit the grammar and formatting. Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains about missing "Return" section for many documented functions in the regulator core. Some with free-form return value descriptions have been fixed in the previous patch. The remaining are completely missing any mention of return values. Add "Return" sections to these kerneldoc blocks with basic descriptions. In a few cases where the functions don't call even more functions and the error numbers are known, those are documented in detail. Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains about missing "Return" section for many documented functions in the regulator core. Many of them actually have descriptions about the return values, just not in the format kernel-doc wants. Convert these to use the proper "Return:" section header. The existing descriptions have been reworded and moved around to fit the grammar and formatting. In a few cases where the functions don't call even more functions and the error numbers are known, those are documented in detail. Signed-off-by:
-
Chen-Yu Tsai authored
The kerneldoc for regulator_is_supported_voltage() states that the return value is a boolean. That is not correct, as it could return an error number if the check failed. Fix the description by expanding it to cover the valid return values and error conditions. The description is also converted to a proper "Return" section. Fixes: c5f3939b ("regulator: core: Support fixed voltages in regulator_is_supported_voltage()") Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains that _regulator_check_status_enabled() is missing a short description. Since the current description is already quite short, just trim it a bit more and use it as the short description. Fixes: f7d7ad42 ("regulator: Allow regulators to verify enabled during enable()") Signed-off-by:
-
- 28 Aug, 2024 2 commits
-
-
Rob Herring (Arm) authored
Use of_property_read_bool() to read boolean properties rather than of_find_property(). This is part of a larger effort to remove callers of of_find_property() and similar functions. of_find_property() leaks the DT property pointer which is a problem for dynamically allocated nodes which may be freed. Signed-off-by:
Rob Herring (Arm) <robh@kernel.org> Link: https://patch.msgid.link/20240828130056.3481050-2-robh@kernel.orgSigned-off-by:
-
Rob Herring (Arm) authored
There's no need to check for presence of "qcom,saw-reg" before parsing it. If the property doesn't exist, parsing it will return NULL. Signed-off-by:
-
- 22 Aug, 2024 5 commits
-
-
Mark Brown authored
Merge series from Chen-Yu Tsai <wenst@chromium.org>: Here are some cleanups for some bits that I saw while reworking my I2C device tree component prober to use of_regulator_bulk_get_all(). These are not directly related to that series, so I send them separately here.
-
Krzysztof Kozlowski authored
Allocate the memory with scoped/cleanup.h to reduce error handling (less error paths) and make the code a bit simpler. Signed-off-by:
-
Chen-Yu Tsai authored
Currently in of_regulator_bulk_get_all(), if any regulator request fails, the error path releases all regulators already requested, but leaves the |struct regulator_bulk_data| memory to the caller to free, and also leaves the regulator consumer pointers dangling. The latter behavior is not documented, and may not be what the caller is expecting. Instead, explicitly clean up everything on error, and make it clear that the result pointer is only update if the whole request succeeds. Signed-off-by:
-
Chen-Yu Tsai authored
If regulator_get() in of_regulator_bulk_get_all() returns an error, that error gets overridden and -EINVAL is always passed out. This masks probe deferral requests and likely won't work properly in all cases. Fix this by letting of_regulator_bulk_get_all() return the original error code. Fixes: 27b9ecc7 ("regulator: Add of_regulator_bulk_get_all") Signed-off-by:
-
Chen-Yu Tsai authored
The original error message simply said "get() with no identifier" without any context as to what was requested or what device the request was related to. The only thing the user or developer could do was grep for the message in the full source tree. Amend the error message to be more specific, and also use dev_* to associate the error message with a device. Signed-off-by:
-
- 15 Aug, 2024 1 commit
-
-
Mark Brown authored
Merge series from Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: Make code a bit smaller/simpler, with less of_node_put() thanks to cleanup.h.
-
