- 15 Jul, 2015 14 commits
-
-
Hari Prasath Gujulan Elango authored
This patch removes the redundant __func__ from dynamic debug prints as the pr_xxx set of functions can be dynamically controlled to include function name.Also fix a typo in debug statement. Signed-off-by:
Hari Prasath Gujulan Elango <hgujulan@visteon.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Santhosh Pai authored
This patch fixes the checkpatch.pl warning: WARNING: ENOSYS means 'invalid syscall nr' and nothing else try_module_get fails when the reference count of the module is not allowed to be incremented ,and hence -ENXIO is returned indicating no device or address. [IA - combined two of santhosh's changes to the error return value!] Signed-off-by:
santhosh pai <santhosh.pai88@yahoo.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Ian Abbott authored
If the "comedi" module has been loaded with the "comedi_num_legacy_minors" module parameter set to a non-zero value, some reserved comedi devices get created. These can be attached to a low-level comedi driver using the `COMEDI_DEVCONFIG` ioctl command, which checks for the `CAP_SYS_ADMIN` capability. Of course, the comedi device needs to be opened before the ioctl command can be sent. If the comedi device is unattached, `comedi_open()` currently requires the `CAP_NET_ADMIN` capability. It makes more sense to just require the `CAP_SYS_ADMIN` capability here, so change it. For the curious, commit a8f80e8f ("Networking: use CAP_NET_ADMIN when deciding to call request_module") changed this capability from `CAP_SYS_MODULE` to `CAP_NET_ADMIN`, even though it doesn't seem relevant here. The original `CAP_SYS_MODULE` capability was due to the function having some code to request a module using a "char-major-%i-%i" alias, but that was never compiled in and was removed by commit f30f2c2d ("staging: comedi: remove check for CONFIG_KMOD"). Signed-off-by:
-
Ian Abbott authored
The analog output range is not programmable, but the ranges for each of the two analog output channels are settable via jumpers. These jumper settings are not readable by the driver. The driver provides a range table containing all the possible internal ranges (+/-10V, +/-5V, 0-10V, 0-5V) to provide information to the user application (although any range selected by the application that differs from the jumper settings will not produce the expected voltage output). The range table does not cover all possible ranges of the analog output channels. The jumpers also allow an external reference voltage between 0 and 10V to be used as bipolar or unipolar output range. Add a couple more ranges to the end of the range table to define these two external ranges. Signed-off-by:
-
Geert Uytterhoeven authored
Signed-off-by:
Geert Uytterhoeven <geert@linux-m68k.org> Reviewed-by:
-
Geliang Tang authored
This patch fixes the following sparse warning: drivers/staging/comedi/comedi_compat32.c:205:16: warning: cast removes address space of expression Signed-off-by:
Geliang Tang <geliangtang@163.com> Reviewed-by:
-
Luis de Bethencourt authored
Warnings found by checkpatch.pl WARNING: line over 80 characters /drivers/staging/comedi/drivers/das16m1.c:414 + if (devpriv->adc_count == 0 && hw_counter == devpriv->initial_hw_count) { /drivers/staging/comedi/drivers/das16m1.c:417 /drivers/staging/comedi/drivers/das16m1.c:418 /drivers/staging/comedi/drivers/das16m1.c:419 /drivers/staging/comedi/drivers/das16m1.c:420 /drivers/staging/comedi/drivers/das16m1.c:421 Signed-off-by:Luis de Bethencourt <luis@debethencourt.com> Reviewed-by:
-
Luis de Bethencourt authored
Warning found by checkpatch.pl WARNING: please, no space before tabs /drivers/staging/comedi/drivers/das16m1.c:83 + 404-407 ^I8254$ Signed-off-by:
-
Abdul Hussain authored
This patch simplify a trivial if-return sequence. Possibly combine with a preceding function call. Signed-off-by:
Abdul Hussain <habdul@visteon.com> Reviewed-by:
-
Abdul Hussain authored
This patch simplify a trivial if-return sequence. Possibly combine with a preceding function call. Signed-off-by:
-
Abdul Hussain authored
This patch simplify a trivial if-return sequence. Possibly combine with a preceding function call. Signed-off-by:
-
Abdul Hussain authored
This patch simplify a trivial if-return sequence. Possibly combine with a preceding function call. Signed-off-by:
-
Abdul Hussain authored
This patch simplify a trivial if-return sequence. Possibly combine with a preceding function call. Signed-off-by:
-
Luis de Bethencourt authored
fixes checkpatch.pl WARNING: quoted string split across lines +MODULE_AUTHOR("David A. Schleef <ds@schleef.org>, " + "Frank Mori Hess <fmhess@users.sourceforge.net>"); Modules with multiple authors have a MODULE_AUTHOR line for each one. Signed-off-by:
-
- 14 Jul, 2015 26 commits
-
-
Guillermo O. Freschi authored
Simple style fix. Signed-off-by:
Guillermo O. Freschi <kedrot@gmail.com> Signed-off-by:
-
Dmitry Kalinkin authored
Prevents false positive "missing empty line after a definition" checkpatch warning. Signed-off-by:
Dmitry Kalinkin <dmitry.kalinkin@gmail.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Markus Elfring authored
The following functions test whether their argument is NULL and then return immediately. * kfree * ll_file_data_put * ptlrpc_connection_put Thus the test around such calls is not needed. This issue was detected by using the Coccinelle software. See also a previous update suggestion: "remove unneeded null test before free" by Julia Lawall https://lkml.org/lkml/2015/5/1/498 https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg878600.htmlSigned-off-by:
Markus Elfring <elfring@users.sourceforge.net> Signed-off-by:
-
Lukasz Janyst authored
This is a patch to the libcfs/module.c file fixing whitespace warnings found by checkpatch.pl. Signed-off-by:
Lukasz Janyst <lj@buggybrain.net> Signed-off-by:
-
Oleg Drokin authored
Apparently kstrtouint could return not just -EINVAL, but also -ERANGE, so make sure we just check the return value for something negative. Noticed by Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Dmitry Eremin authored
Remove portal_enter_debugger because it's not used any more. Signed-off-by:
Dmitry Eremin <dmitry.eremin@intel.com> Signed-off-by:
-
Dmitry Eremin authored
They are just fancy module parameters wrappers, so just the same functionality now would be accessible via /sys/module/libcfs/parameters/libcfs_console_{min,max}_delay Also install compatibility symlinks Signed-off-by: -
Oleg Drokin authored
It's just a fancy libcfs_debug_mb module parameter wrapper, so just add debug buffer size check and resizing and the same functionality now would be accessible via /sys/module/libcfs/parameters/libcfs_debug_mb Also add a symlink for backwards compatibility. Signed-off-by:
-
Perry Hooker authored
Found by checkpatch.pl Signed-off-by:
Perry Hooker <perry.hooker@gmail.com> Signed-off-by:
-
Ronit Halder authored
Fixed a blank line after declarations coding style issue Signed-off-by:
Ronit Halder <ronit.crj@gmail.com> Signed-off-by:
-
Kris Baumann authored
Fixed several brace coding style issues. Signed-off-by:
Kris Baumann <krisbaumann@gmail.com> Signed-off-by:
-
Anders Fridlund authored
This is a patch to the cl_page.c file that fixes a "space required after that ','" error found by the checkpatch.pl tool. Signed-off-by:
Anders Fridlund <anders.fridlund@gmail.com> Signed-off-by:
-
Matt Mooney authored
fix sparse warning in lustre/ptlrpc/ptlrpc_module.c:54:12: warning: symbol 'ptlrpc_init' was not declared. Should it be static? The __init macro is moved before the function name to match standard usage. Signed-off-by:Matt Mooney <mfm@muteddisk.com> Signed-off-by:
-
Hari Prasath Gujulan Elango authored
This patch removes commented code. Signed-off-by:
-
Dmitry Eremin authored
It is no longer used anywhere. Signed-off-by:
-
Dmitry Eremin authored
/proc/sys/lnet/lnet_memused Remove memory tracking for LNet. Remove redundant enums definition. Signed-off-by:
-
Oleg Drokin authored
module parameter libcfs_console_backoff accessible through /sys/module/libcfs/parameters/libcfs_console_backoff would do the same thing, just add a special "uintpos" parameter type to disallow 0 values too. Also add a symlink to the module parameter variable for backwards compatibility Signed-off-by:
-
Oleg Drokin authored
/proc/sys/lnet/console_ratelimit, debug_path and panic_on_lbug are module parameters with no special magic accessible via /sys/module/libcfs/parameters/libcfs_console_ratelimit, /sys/module/libcfs/parameters/libcfs_debug_file_path and /sys/module/libcfs/parameters/libcfs_panic_on_lbug respectively. As such just replace them with corresponding symlinks Signed-off-by:
-
Oleg Drokin authored
Parameters in lnet sysctl are of debug quantity, so let's move them to debugfs instead. Signed-off-by:
-
Oleg Drokin authored
Since all of the variables from /proc/sys/lustre were moved to /sys/fs/lustre, get rid of the remaining infrastructure. Signed-off-by:
-
Oleg Drokin authored
Adaptive Timeouts controls are being moved from /proc/sys/lustre to /sys/fs/lustre Signed-off-by:
-
Oleg Drokin authored
debug_peer_on_timeout, dump_on_timeout and dump_on_eviction controls from /proc/sys/lustre to /sys/fs/lustre Signed-off-by:
-
Oleg Drokin authored
max_dirty_mb is now a parameter in /sys/fs/lustre/ Signed-off-by:
-
Oleg Drokin authored
This is the first step of moving lustre sysctls from /proc/sys/lustre to /sys/fs/lustre Signed-off-by:
-
Oleg Drokin authored
ldlm_timeout is used server-side to determine AST timeouts, so it makes no sense on the client, esp. since it's not really used anywhere. Remove all traces of it except from the config where make it a noop. Signed-off-by:
-
Oleg Drokin authored
In the past when Lustre did its own allocation amounts tracking the results were shown in sysctl as current and overall max number of bytes and pages allocated. Now that we don't track these, remove the sysctls. Signed-off-by:
-
