Skip to content

L
linux
Switch branch/tag
  1. 18 Dec, 2008 2 commits
    • KOSAKI Motohiro's avatar
      locking, irq: enclose irq_desc_lock_class in CONFIG_LOCKDEP · 74c8a613
      KOSAKI Motohiro authored 
      Impact: simplify code

commit "08678b08: generic: sparse irqs: use irq_desc() [...]" introduced
the irq_desc_lock_class variable.

But it is used only if CONFIG_SPARSE_IRQ=Y or CONFIG_TRACE_IRQFLAGS=Y.
Otherwise, following warnings happen:

	CC      kernel/irq/handle.o
	kernel/irq/handle.c:26: warning: 'irq_desc_lock_class' defined but not used

Actually, current early_init_irq_lock_class has a bit strange and messy ifdef.
In addition, it is not valueable.

1. this function is protected by !CONFIG_SPARSE_IRQ, but that is not necessary.
   if CONFIG_SPARSE_IRQ=Y, desc of all irq number are initialized by NULL
   at first - then this function calling is safe.

2. this function protected by CONFIG_TRACE_IRQFLAGS too. but it is not
   necessary either, because lockdep_set_class() doesn't have bad side
   effect even if CONFIG_TRACE_IRQFLAGS=n.

This patch bloat kernel size a bit on CONFIG_TRACE_IRQFLAGS=n and
CONFIG_SPARSE_IRQ=Y - but that's ok. early_init_irq_lock_class() is not
a fastpatch at all.

To avoid messy ifdefs is more important than a few bytes diet.
Signed-off-by: default avatarKOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      74c8a613
    • Jeremy Fitzhardinge's avatar
      sparseirq, xen: make sure irq_desc is allocated for interrupts · 6f8a0ed4
      Jeremy Fitzhardinge authored 
      Impact: fix crash

Make sure all Xen irqs have an irq_desc.
Signed-off-by: default avatarJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      6f8a0ed4
  3. 16 Dec, 2008 3 commits
  5. 12 Dec, 2008 2 commits
  7. 09 Dec, 2008 2 commits
    • Yinghai Lu's avatar
      sparseirq: fix !SMP && !PCI_MSI && !HT_IRQ build · 8a4830f8
      Yinghai Lu authored 
      Ingo Molnar wrote:

>>>  drivers/pci/intr_remapping.c: In function 'irq_2_iommu_alloc':
>>>  drivers/pci/intr_remapping.c:72: error: 'boot_cpu_id' undeclared (first use in this function)
>>>  drivers/pci/intr_remapping.c:72: error: (Each undeclared identifier is reported only once
>>>  drivers/pci/intr_remapping.c:72: error: for each function it appears in.)

sparseirq should only be used with SMP for now.
      8a4830f8
    • Yinghai Lu's avatar
      sparseirq: fix Alpha build failure · 240d367b
      Yinghai Lu authored 
      Impact: build fix on Alpha

-tip testing found this build failure on the Alpha defconfig:

/home/mingo/tip/fs/proc/stat.c: In function 'show_stat':
/home/mingo/tip/fs/proc/stat.c:48: error: implicit declaration of function 'for_each_irq_desc'
/home/mingo/tip/fs/proc/stat.c:48: error: expected ';' before '{' token

can not use irq_desc() in stat.c on older architectures.
Signed-off-by: default avatarYinghai Lu <yinghai@kernel.orgg>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      240d367b
  9. 08 Dec, 2008 5 commits
  11. 05 Dec, 2008 21 commits
  13. 04 Dec, 2008 5 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7