- 22 Sep, 2016 5 commits
-
-
Luca Coelho authored
We were assigning the return value of iwl_mvm_ctdp_command() to a variable, but never checking it. If this command fails, we should not allow the interface up process to proceed, since it is potentially dangerous to ignore thermal management requirements. Fixes: commit 5c89e7bc ("iwlwifi: mvm: add registration to cooling device") Signed-off-by:
Luca Coelho <luciano.coelho@intel.com>
-
Johannes Berg authored
The various TFD/TB helpers have two code paths depending on the type of TFD supported, with variable shadowing due to the new if branches. Move the fall-through code into else branches to avoid variable shadowing. While doing so, rename some of the variables and do some other cleanups (like removing void * casts of void * pointers.) Signed-off-by:
Johannes Berg <johannes.berg@intel.com> Signed-off-by:
-
Oren Givon authored
Add two new PCI IDs for the 9560 series. Signed-off-by:
Oren Givon <oren.givon@intel.com> Signed-off-by:
-
Sara Sharon authored
Move the init_dbg check to earlier in the function to simplify the code. Signed-off-by:
Sara Sharon <sara.sharon@intel.com> Signed-off-by:
-
Sara Sharon authored
This is never really used anymore. Signed-off-by:
-
- 19 Sep, 2016 25 commits
-
-
Johannes Berg authored
There's no need to declare a list and then init it manually, just use the LIST_HEAD() macro. Signed-off-by:
-
Johannes Berg authored
There's no need to declare a list and then init it manually, just use the LIST_HEAD() macro. Signed-off-by:
-
Sara Sharon authored
Currently it is logged as UNKNOWN. Also, 0x6c seems to be the permanent ID for this command, remove incorrect comment and uncomment the command from the commands list. Signed-off-by:
-
Ido Yariv authored
In order to access cached/paged memory, there are a couple of firmware commands (one for UMAC and one for LMAC) that let the host access memory and registers indirectly. Since this is done by the firmware on behalf of the host, even if memory is paged out or cached, the host will retrieve the memory as the firmware sees it (paged out memory will get paged in). Export this mechanism via a debugfs entry for both read and write access. WARNING: This mechanism has no protections at all. Invalid addresses may crash or hang the firmware. Writing to arbitrary memory also comes with no guarantees. Signed-off-by:
Ido Yariv <idox.yariv@intel.com> Signed-off-by:
-
Johannes Berg authored
There's no need for the common MAC context function to have an if on AP mode, the values can be overridden in the AP-specific function later. Clean that up by adding the full command as a new parameter to the AP-specific function, and doing it there. Signed-off-by:
-
Oren Givon authored
Add a new PCI ID for the 8265 series. Signed-off-by:
-
Roee Zamir authored
New function, reveals the diff between gp2 and host time. Signed-off-by:
Roee Zamir <roee.zamir@intel.com> Signed-off-by:
-
Sharon Dvir authored
Change PCIE and trans resource allocations to managed resources. Signed-off-by:
Sharon Dvir <sharon.dvir@intel.com> Signed-off-by:
-
Sara Sharon authored
AP queue is properly released, but P2P queue isn't. Fixes: commit 4c965139 ("iwlwifi: mvm: support p2p device frames tx on dqa queue #2") Signed-off-by:
-
Emmanuel Grumbach authored
This can save a few bytes Signed-off-by:
Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by:
-
Johannes Berg authored
When we get an unexpected Block Ack Request frame, the BAID from the hardware will be invalid, and we'll pass it to mac80211 for further handling (sending a delBA action frame.) Add a comment explaining that, in case anyone looks in the future. Signed-off-by:
-
Sara Sharon authored
Due to firmware design considerations, move to wide ID for all commands. Signed-off-by:
-
Johannes Berg authored
There's no point in making this an out-of-line function since it just calls a single other function with a few changed parameters. Signed-off-by:
-
Sara Sharon authored
Log group as well. Remove 0x prefix to match TX logging. Signed-off-by:
-
Arik Nemtsov authored
This will be used by more than MVM, so move it to iwlwifi While at it, rename WRD_METHOD to the more appropriate WRDD_METHOD and add some documentation. Signed-off-by:
Arik Nemtsov <arikx.nemtsov@intel.com> Signed-off-by:
-
Sara Sharon authored
For automatic testing packet injection can be useful. Support injection through debugfs. Signed-off-by:
-
Avrahams Stern authored
Implement support for RRM by adding an option to configure the scan dwell time and reporting scan start time and BSS detection time, and Advertise support for these features. Signed-off-by:
David Spinadel <david.spinadel@intel.com> Signed-off-by:
Avraham Stern <avraham.stern@intel.com> Signed-off-by:
-
Sara Sharon authored
On default queue we will not receive frame release notification, but the BAR itself. Upon receiving the BAR driver should look at the NSSN and adjust window accordingly. Fixes: b915c101 ("iwlwifi: mvm: add reorder buffer per queue") Signed-off-by:
-
Sara Sharon authored
There was recently a Full AP mode feature added where hostap adds the station at auth stage, and not assoc. However, when running with legacy hostapd, we get the auth response before station was added, and tx_skb_non_sta fails to allocate a queue, resulting in a complete failure of association. Take care of this situation as well. Add a warning when no valid queue is returned at all and make mvm drop the packet instead of passing it on. Refactor the function a bit while at it. Signed-off-by:
-
Haim Dreyfuss authored
In 9000 family products we added an option to let the OEM fuse the mac address via registers. If these registers are zeroed we use the OTP address instead. Make sure that the address provided by the OEM is valid and, if not, fall back to the OTP address as well. Fixes: commit 17c867bf ("iwlwifi: add support for getting HW address from CSR") Signed-off-by:
Haim Dreyfuss <haim.dreyfuss@intel.com> Signed-off-by:
-
Aviya Erenfeld authored
enable MU-MIMO air sniffer if it's supported by the NIC Signed-off-by:
Aviya Erenfeld <aviya.erenfeld@intel.com> Signed-off-by:
-
Johannes Berg authored
When comparing command IDs, the group should be taken into account so the same command/notification from a different group doesn't trigger anything unexpected. Fix this by comparing to the wide ID. Fixes: commit 1738d60b ("iwlwifi: mvm: handle RX MPDUs separately") Signed-off-by:
-
Sara Sharon authored
Use skb_queue_empty() and not skb_peek_tail() to check for empty list. Avoid a redundant check as well - loop will take care of it. Signed-off-by:
-
Sara Sharon authored
commit 3cd1980b ("iwlwifi: pcie: introduce new tfd and tb formats") Signed-off-by:
-
Liad Kaufman authored
Variable "ac" defined twice. Fix that. Fixes: commit 93f436e2 ("iwlwifi: mvm: set sta_id in SCD_QUEUE_CONFIG cmd") Signed-off-by:
Liad Kaufman <liad.kaufman@intel.com> Signed-off-by:
-
- 17 Sep, 2016 10 commits
-
-
Colin Ian King authored
If adapter is null the error exit path in mwifiex_shutdown_sw is to down the semaphore sem and print some debug via mwifiex_dbg. However, passing a NULL adapter to mwifiex_dbg causes a null pointer deference when accessing adapter->dev. This fix checks for a null adapter at the start of the function and to exit without the need to up the semaphore and we also skip the debug to avoid the null pointer dereference. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
Kalle Valo <kvalo@codeaurora.org>
-
Bob Copeland authored
smatch reports: sta_cmdresp.c:1053 mwifiex_create_custom_regdomain() warn: possible memory leak of 'regd' Indeed, mwifiex_create_custom_regdomain() returns NULL in the case that channel is missing in the TLV without freeing regd. Moreover, some other error paths in this function return ERR_PTR values which are assigned without checking to the regd field in the mwifiex_adapter struct. The latter is only null-checked where used. Fix by freeing regd in the error path, and only update priv->adapter->regd if the returned pointer is valid. Cc: Amitkumar Karwar <akarwar@marvell.com> Cc: Nishant Sarmukadam <nishants@marvell.com> Signed-off-by:
Bob Copeland <me@bobcopeland.com> Signed-off-by:
-
Jes Sorensen authored
This powers down the 8192e correctly, or at least to the point where the firmware will load again, when reloading the driver module. Signed-off-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Kalle Valo authored
Merge tag 'iwlwifi-next-for-kalle-2016-09-15-2' of git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next * work for new hardware support continues * dynamic queue allocation stabilization * improvements in the MSIx code * multiqueue support work continues * new firmware version support * general cleanups and improvements
-
David S. Miller authored
Alexei Starovoitov says: ==================== ip_tunnel: add collect_md mode to IPv4/IPv6 tunnels Similar to geneve, vxlan, gre tunnels implement 'collect metadata' mode in ipip, ipip6, ip6ip6 tunnels. ==================== Signed-off-by:David S. Miller <davem@davemloft.net>
-
Alexei Starovoitov authored
the test creates 3 namespaces with veth connected via bridge. First two namespaces simulate two different hosts with the same IPv4 and IPv6 addresses configured on the tunnel interface and they communicate with outside world via standard tunnels. Third namespace creates collect_md tunnel that is driven by BPF program which selects different remote host (either first or second namespace) based on tcp dest port number while tcp dst ip is the same. This scenario is rough approximation of load balancer use case. The tests check both traditional tunnel configuration and collect_md mode. Signed-off-by:
Alexei Starovoitov <ast@kernel.org> Signed-off-by:
-
Alexei Starovoitov authored
extend existing tests for vxlan, geneve, gre to include IPIP tunnel. It tests both traditional tunnel configuration and dynamic via bpf helpers. Signed-off-by:
-
Alexei Starovoitov authored
Similar to gre, vxlan, geneve tunnels allow IPIP6 and IP6IP6 tunnels to operate in 'collect metadata' mode. Unlike ipv4 code here it's possible to reuse ip6_tnl_xmit() function for both collect_md and traditional tunnels. bpf_skb_[gs]et_tunnel_key() helpers and ovs (in the future) are the users. Signed-off-by:
Thomas Graf <tgraf@suug.ch> Acked-by:
Daniel Borkmann <daniel@iogearbox.net> Signed-off-by:
-
Alexei Starovoitov authored
Similar to gre, vxlan, geneve tunnels allow IPIP tunnels to operate in 'collect metadata' mode. bpf_skb_[gs]et_tunnel_key() helpers can make use of it right away. ovs can use it as well in the future (once appropriate ovs-vport abstractions and user apis are added). Note that just like in other tunnels we cannot cache the dst, since tunnel_info metadata can be different for every packet. Signed-off-by:
-
Julia Lawall authored
Check for net_device_ops structures that are only stored in the netdev_ops field of a net_device structure. This field is declared const, so net_device_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct net_device_ops i@p = { ... }; @ok@ identifier r.i; struct net_device e; position p; @@ e.netdev_ops = &i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct net_device_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct net_device_ops i = { ... }; // </smpl> The result of size on this file before the change is: text data bss dec hex filename 3401 931 44 4376 1118 net/l2tp/l2tp_eth.o and after the change it is: text data bss dec hex filename 3993 347 44 4384 1120 net/l2tp/l2tp_eth.o Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
