Commits · 7863ff276d2a151aaf1b4ad7798ff2610e7b2996 · Kirill Smelkov / linux

04 Feb, 2011 29 commits

staging/easycap: kill declaration of not existing variables · 7863ff27
Tomas Winkler authored Feb 03, 2011
```
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
7863ff27

staging/easycap: don't shadow rc variable from macros · f8cc1e93

Tomas Winkler authored Feb 03, 2011

rc is used extensively in code as return code variable
so it is better not shadowing it in macros
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

f8cc1e93

staging/easycap: replace underscored types with regular once · 055e3a3a

Tomas Winkler authored Feb 03, 2011

the underscored types should be used in user space headers only
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

055e3a3a

staging/easycap: rename variable s16 to tmp · 1a4cb0fb

Tomas Winkler authored Feb 03, 2011

naming variable s16 is confusing since it is also a type name.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1a4cb0fb

staging/easycap: rename variable u8 to tmp · 0117f779

Tomas Winkler authored Feb 03, 2011

naming variable u8 is confusing since it is also a type name.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

0117f779

staging/easycap: rename variable s32 to tmp · 27d17669

Tomas Winkler authored Feb 03, 2011

1. naming variable s32 is confusing since it is also
a type name.
2. use s32 instead of __s32, the later is for user space
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

27d17669

staging/easycap: remove explicit NULL initialization · b737f3b8

Tomas Winkler authored Feb 03, 2011

remove intializations to NULL where not needed and let the compiler
find flows with unitilized variables.
Fix one such flow in easycap_vma_fault function
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

b737f3b8

staging/easycap: improve coding style when checking return value · 6911e7e4

Tomas Winkler authored Feb 03, 2011

use idiom 'if (rc)' for checking return value
instead of if (0 != rc)
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

6911e7e4

staging/easycap: fix artificial line breaks · e0a691e3

Tomas Winkler authored Feb 03, 2011

fix style issue:
		if (NULL !=
				pdata_urb->purb) {
created by the patch:
	'staging/easycap: don't cast NULL pointer'

After dropping the casting there is no longer 80 columns
limitation
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

e0a691e3

staging/easycap: repace #if defined with simpler #ifdef · 3fc0dae8

Tomas Winkler authored Feb 03, 2011

for sake of readability replace #if defined with #ifdef
and #if (!defined with #ifndef
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

3fc0dae8

staging/easycap: kill EASYCAP_NEEDS_UNLOCKED_IOCTL · f2b3c685

Tomas Winkler authored Feb 03, 2011

we can kill this option for in-kernel driver
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

f2b3c685

staging/easycap: remove comment: EASYCAP_NEEDS_ALSA · 9306b1bb

Tomas Winkler authored Feb 03, 2011

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

9306b1bb

staging/easycap: don't cast NULL pointer · 3c1fb66e

Tomas Winkler authored Feb 03, 2011

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

3c1fb66e

staging: ft1000: Remove unnecessary assignment. · dfc9539f

Marek Belisko authored Feb 03, 2011

dsp_img_info->version and requested_version have same type
so additional temporary variable creation could be omitted
because variables could be compares directly.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

dfc9539f

staging: ft1000: Create common function for buffers check. · e7af0786

Marek Belisko authored Feb 03, 2011

Same check was done on three places which make code unreadable.
Put repeat routine to separate function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

e7af0786

staging: ft1000: Remove unused variables. · 672dfeba

Marek Belisko authored Feb 03, 2011

Remove variables which was defined and assigned
but never used in function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

672dfeba

staging: ft1000: Fix indentation in scram_dnldr() function. · 6f953fbb

Marek Belisko authored Feb 03, 2011

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

6f953fbb

staging: ft1000: Fix coding style in write_blk_fifo() function. · 857af455

Marek Belisko authored Feb 03, 2011

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

857af455

staging: ft1000: Fix coding style in get_handshake() function. · d7a7318b

Marek Belisko authored Feb 03, 2011

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

d7a7318b

staging: ft1000: Fix coding style in hdr_checksum() function. · 78395f67

Marek Belisko authored Feb 03, 2011

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

78395f67

staging: ft1000: Fix coding style in put_request_value() function. · cc4f65bf
Marek Belisko authored Feb 03, 2011
```
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
cc4f65bf
staging: ft1000: Fix coding style in get_request_value() function. · 114a06ae
Marek Belisko authored Feb 03, 2011
```
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
114a06ae
staging: ft1000: Fix coding style in get_request_type_usb() function. · c3ed5d2f
Marek Belisko authored Feb 03, 2011
```
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
c3ed5d2f
staging: ft1000: Fix coding style in get_request_type() function. · 9b43f374
Marek Belisko authored Feb 03, 2011
```
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
9b43f374
staging: ft1000: Fix coding style in put_handshake_usb() function. · 5acc5396
Marek Belisko authored Feb 03, 2011
```
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
5acc5396
staging: ft1000: Fix coding style in get_handshake_usb() function. · 5865a18e
Marek Belisko authored Feb 03, 2011
```
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
5865a18e

staging: ft1000: Fix coding style in put_handshake() function. · a8d4d198

Marek Belisko authored Feb 03, 2011

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a8d4d198

staging: ft1000: Fix coding style in check_usb_db() function. · c5d680c0

Marek Belisko authored Feb 03, 2011

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

c5d680c0

staging: ft1000: Remove dead code. · 165d290f

Marek Belisko authored Feb 03, 2011

Remove code which was under #if 0.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

165d290f

02 Feb, 2011 11 commits

staging: ath6kl: Remove #define A_OK · 4f69cef0

Joe Perches authored Feb 02, 2011

Just use 0.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

4f69cef0

staging: ath6kl: Convert (status != A_OK) to (status) · a1d46529

Joe Perches authored Feb 02, 2011

Just use the status variable as a test not a comparison.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a1d46529

staging: ath6kl: Convert A_INT32 to s32 · f68057e6

Joe Perches authored Feb 02, 2011

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

f68057e6

staging: ath6kl: Convert A_INT16 to s16 · cb1e3709

Joe Perches authored Feb 02, 2011

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

cb1e3709

staging: ath6kl: Convert A_INT8 to s8 · f2ab1275

Joe Perches authored Feb 02, 2011

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

f2ab1275

staging: ath6kl: Convert A_UINT64 to u64 · c353f4b3

Joe Perches authored Feb 02, 2011

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

c353f4b3

staging: ath6kl: Convert A_UINT32 to u32 · e1ce2a3a

Joe Perches authored Feb 02, 2011

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

e1ce2a3a

staging: ath6kl: Convert A_UINT16 to u16 · 4853ac05

Joe Perches authored Feb 02, 2011

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

4853ac05

staging: ath6kl: Convert A_UINT8 to u8 · ab3655da

Joe Perches authored Feb 02, 2011

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

ab3655da

staging: ath6kl: Convert A_CHAR to char · 4c42080f

Joe Perches authored Feb 02, 2011

Remove obfuscating A_CHAR uses, just use char.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

4c42080f

staging: ath6kl: Remove A_BOOL and TRUE/FALSE · 1071a134

Joe Perches authored Feb 02, 2011

Use kernel bool and true/false.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1071a134