1. 13 Sep, 2012 14 commits
  2. 12 Sep, 2012 2 commits
    • Joe Perches's avatar
      netfilter: log: Fix log-level processing · 16af511a
      Joe Perches authored
      auto75914331@hushmail.com reports that iptables does not correctly
      output the KERN_<level>.
      
      $IPTABLES -A RULE_0_in  -j LOG  --log-level notice --log-prefix "DENY  in: "
      
      result with linux 3.6-rc5
      Sep 12 06:37:29 xxxxx kernel: <5>DENY  in: IN=eth0 OUT= MAC=.......
      
      result with linux 3.5.3 and older:
      Sep  9 10:43:01 xxxxx kernel: DENY  in: IN=eth0 OUT= MAC......
      
      commit 04d2c8c8
      ("printk: convert the format for KERN_<LEVEL> to a 2 byte pattern")
      updated the syslog header style but did not update netfilter uses.
      
      Do so.
      
      Use KERN_SOH and string concatenation instead of "%c" KERN_SOH_ASCII
      as suggested by Eric Dumazet.
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      cc: auto75914331@hushmail.com
      Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
      16af511a
    • Eric Dumazet's avatar
      net-sched: sch_cbq: avoid infinite loop · bdfc87f7
      Eric Dumazet authored
      Its possible to setup a bad cbq configuration leading to
      an infinite loop in cbq_classify()
      
      DEV_OUT=eth0
      ICMP="match ip protocol 1 0xff"
      U32="protocol ip u32"
      DST="match ip dst"
      tc qdisc add dev $DEV_OUT root handle 1: cbq avpkt 1000 \
      	bandwidth 100mbit
      tc class add dev $DEV_OUT parent 1: classid 1:1 cbq \
      	rate 512kbit allot 1500 prio 5 bounded isolated
      tc filter add dev $DEV_OUT parent 1: prio 3 $U32 \
      	$ICMP $DST 192.168.3.234 flowid 1:
      Reported-by: default avatarDenys Fedoryschenko <denys@visp.net.lb>
      Tested-by: default avatarDenys Fedoryschenko <denys@visp.net.lb>
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bdfc87f7
  3. 11 Sep, 2012 1 commit
  4. 10 Sep, 2012 4 commits
  5. 09 Sep, 2012 2 commits
  6. 08 Sep, 2012 1 commit
    • Chema Gonzalez's avatar
      net: small bug on rxhash calculation · 68622342
      Chema Gonzalez authored
      In the current rxhash calculation function, while the
      sorting of the ports/addrs is coherent (you get the
      same rxhash for packets sharing the same 4-tuple, in
      both directions), ports and addrs are sorted
      independently. This implies packets from a connection
      between the same addresses but crossed ports hash to
      the same rxhash.
      
      For example, traffic between A=S:l and B=L:s is hashed
      (in both directions) from {L, S, {s, l}}. The same
      rxhash is obtained for packets between C=S:s and D=L:l.
      
      This patch ensures that you either swap both addrs and ports,
      or you swap none. Traffic between A and B, and traffic
      between C and D, get their rxhash from different sources
      ({L, S, {l, s}} for A<->B, and {L, S, {s, l}} for C<->D)
      
      The patch is co-written with Eric Dumazet <edumazet@google.com>
      Signed-off-by: default avatarChema Gonzalez <chema@google.com>
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      68622342
  7. 07 Sep, 2012 8 commits
  8. 06 Sep, 2012 1 commit
  9. 05 Sep, 2012 7 commits