- 24 May, 2015 40 commits
-
-
Sudip Mukherjee authored
if we load the module, unload and then again try to load the module, we will get a stackdump. In the module_exit function we are unregistering the device and releasing the parport. So when we reach the detach function parport is already null and the unregister_reboot_notifier() is never called. When we again try to load the module it again tries register_reboot_notifier() and gives us a stackdump as its earlier registration is still not removed. It was caused by the commit bb046fef ('staging: panel: register reboot') Fix this by moving all the unregistering and releasing in the detach function, which should be the ideal case as the detach will be called if we try to unregister the driver or if the parport is removed. Fixes: bb046fef ('staging: panel: register reboot') Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Huacai Chen authored
If image->depth != 1, lynxfb_ops_imageblit() should fallback to call cfb_imageblit(), not return directly. Otherwise it can't display the boot logo. Cc: Teddy Wang <teddy.wang@siliconmotion.com> Acked-by:
Sudip Mukherjee <sudipm.mukherjee@gmail.com> Signed-off-by:
Huacai Chen <chenhc@lemote.com> Signed-off-by:
-
Luis R. Rodriguez authored
The same area used for ioremap() is used for the MTRR area. Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also ensure the ioremap'd area is requested as write-combining. There are a few motivations for this: a) Take advantage of PAT when available b) Help bury MTRR code away, MTRR is architecture specific and on x86 its replaced by PAT c) Help with the goal of eventually using _PAGE_CACHE_UC over _PAGE_CACHE_UC_MINUS on x86 on ioremap_nocache() (see commit de33c442 titled "x86 PAT: fix performance drop for glx, use UC minus for ioremap(), ioremap_nocache() and pci_mmap_page_range()") The conversion done is expressed by the following Coccinelle SmPL patch, it additionally required manual intervention to address all the #ifdery and removal of redundant things which arch_phys_wc_add() already addresses such as verbose message about when MTRR fails and doing nothing when we didn't get an MTRR. @ mtrr_found @ expression index, base, size; @@ -index = mtrr_add(base, size, MTRR_TYPE_WRCOMB, 1); +index = arch_phys_wc_add(base, size); @ mtrr_rm depends on mtrr_found @ expression mtrr_found.index, mtrr_found.base, mtrr_found.size; @@ -mtrr_del(index, base, size); +arch_phys_wc_del(index); @ mtrr_rm_zero_arg depends on mtrr_found @ expression mtrr_found.index; @@ -mtrr_del(index, 0, 0); +arch_phys_wc_del(index); @ mtrr_rm_fb_info depends on mtrr_found @ struct fb_info *info; expression mtrr_found.index; @@ -mtrr_del(index, info->fix.smem_start, info->fix.smem_len); +arch_phys_wc_del(index); @ ioremap_replace_nocache depends on mtrr_found @ struct fb_info *info; expression base, size; @@ -info->screen_base = ioremap_nocache(base, size); +info->screen_base = ioremap_wc(base, size); @ ioremap_replace_default depends on mtrr_found @ struct fb_info *info; expression base, size; @@ -info->screen_base = ioremap(base, size); +info->screen_base = ioremap_wc(base, size); Generated-by: Coccinelle SmPL Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Cc: Teddy Wang <teddy.wang@siliconmotion.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Suresh Siddha <sbsiddha@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Juergen Gross <jgross@suse.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Dave Airlie <airlied@redhat.com> Cc: Antonino Daplas <adaplas@gmail.com> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: devel@driverdev.osuosl.org Cc: linux-fbdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by:
Luis R. Rodriguez <mcgrof@suse.com> Signed-off-by:
-
Valentin Rothberg authored
Remove the last reference on menuconfig I20 that has been removed by commit 4a72a7af ("staging: remove i2o subsystem"). Signed-off-by:
Valentin Rothberg <valentinrothberg@gmail.com> Signed-off-by:
-
Valentin Rothberg authored
Commit 53490b54 ("staging: unisys: move periodic_work.c into the visorbus directory") removed the Kconfig option UNISYS_VISORUTIL, but left one reference in a Kconfig select. Remove this last reference. Signed-off-by:
-
Don Zickus authored
Most device functions pass bus_no and dev_no around and then do a lookup inside each function to find the dev_info struct. Instead just pass the pointer. This prepares us for a later conversion to using visor device. No real technical changes. Just function header changes and little cleanups as a result. Signed-off-by:
Don Zickus <dzickus@redhat.com> Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Don Zickus authored
Most bus functions pass bus_no around and then do a lookup inside each function to find the bus_info struct. Instead just pass the pointer. This prepares us for a later conversion to using visor_device. Signed-off-by:
-
Don Zickus authored
Convert the device attribute files to properly use visor_device. This removes a whole bunch of checks and assumptions and simplifies the code. Everything is straightforward. No testing down as I can't mimic channel info correctl. Signed-off-by:
-
Don Zickus authored
The conversion to visor_device caused some compile issues.The main problem was the new fields in 'struct visor_device' were not public. Remove one that wasn't being used for now. struct irq_info intr Signed-off-by:
-
Don Zickus authored
There was a bunch of channel creation checks before the visorchannel_create function was called, moving some of those checks inside. This keeps the outside code cleaner and handles the situation where a caller forgets to make these checks. Signed-off-by:
-
Don Zickus authored
This patch is an attempt to help hide the channel info behind accessory functions. I was trying to keep visorchannel as private as possible. The only function missing that seemed to be needed for now was the ability to set the clientpartition. So I expose that here. Signed-off-by:
-
Don Zickus authored
If we are going to remove the bus_info structs than we need a way to find the devices when the *_create/destroy cmds are sent over the vmchannel. This function crudely impements what pci has. It takes a bus_no and dev_no and finds the matching 'struct visor_device'. This function can/should be optimzed later once we get our heads wrapped around its needs. For now, I am using dev_no=0 to mean the visorbus itself. The function is limited to chipset.c only because it is only needed to do the lookups upon receiving a vmchannel command. Future patches will make sure the resulting 'struct visor_device' is used every where else. Also allow visorbus_type to be more visible for use. Signed-off-by:
-
Don Zickus authored
The visorbus driver has three _info structs lying around (device, bus, channel) that store subsets of info from the bigger structs. Having these structs around make resource handling very difficult and more complicated than it needs to be. Use the device infrastructure and instead pass 'struct visor_device' all over the place. In order to do that 'struct visor_device' needs to get smarter. This patch adds the pieces to prep for it. The new elements will be used in later patches. Signed-off-by:
-
Don Zickus authored
Properly hook into the struct device groups element. This allows the core infrastructure to manage the files instead of the bus layer. And makes the code easier to read. I didn't clean up the _show functions just modified them a bit to handle the different args for now and to prevent a build warning. Signed-off-by:
-
Don Zickus authored
Remove stale code. Signed-off-by:
-
Don Zickus authored
Simplify things by moving the version file handling into the core. Signed-off-by:
-
Don Zickus authored
Mimicing what other drivers do, this seems appropriate. Yeah, it is a bus, but it is a bus _device_. This makes things work better and smoother. Now the sysfs looks like [root@dhcp-17-174 visorbus]# ls -l /sys/bus/visorbus/devices/ total 0 lrwxrwxrwx. 1 root root 0 Apr 17 16:09 vbus1:dev2 -> ../../../devices/visorbus1/vbus1:dev2 lrwxrwxrwx. 1 root root 0 Apr 17 16:09 visorbus1 -> ../../../devices/visorbus1 Which looks correct. All the attributes are still correct too, based on my very minimal testing of 'ls -lR'. :-) Signed-off-by:
-
Don Zickus authored
This patch moves the attributes to underneath the bus device correctly. This will help remove a bunch of cruft from the code and let the kernel infrastructure manage the sysfs files instead of the driver. After the move remove all the leftover code. Signed-off-by:
-
Don Zickus authored
Handling the sysfs attributes become easier to deal with when you can just run container_of(dev) to get devdata. Signed-off-by:
-
Don Zickus authored
Now that the header file movement is complete, remove the temporary ccflags include Signed-off-by:
-
David Kershner authored
remove uisqueue.h, uisthread.h, and uisutils.h replace HOSTADDRESS with u64 remove "uisutils.h" from header list in visorchipset.c Signed-off-by:
David Kershner <david.kershner@unisys.com> Signed-off-by:
-
David Kershner authored
Signed-off-by:
-
David Kershner authored
Makefiles still had common-spar listed in ccflags. This gets rid of them. Signed-off-by:
-
David Kershner authored
Move last three files out of common-spar iochannel.h --> include (will be used by visorhba and visornic) version.h --> moved to include controlvmcompletionstatus.h --> moved to visorbus, part of controlvmchannel.h Signed-off-by:
-
David Kershner authored
Diagchannel needs to go to standard include. Signed-off-by:
-
David Kershner authored
Move vbuschannel.h into visorbus. Signed-off-by:
-
David Kershner authored
Channel.h is used by all channels, it needs to be in include. Controlvm Channel is only used by visorbus, it needs to just be there. Signed-off-by:
-
David Kershner authored
Controlframework was only needed by controlvmchannel, move the structures into that header file. Signed-off-by:
-
David Kershner authored
Move hypervisor calls into visorbus and move vbusdeviceinfo.h into visorbus. Drivers will call into that to update clientInfo field. Signed-off-by:
-
Don Zickus authored
To prep for the moving of include files, temporarily add the visorbus/ as a ccflags -I. Once the header files are all transitioned, we can remove this. Signed-off-by:
-
Jes Sorensen authored
This preps for the possible build breakage in the next few patches. Signed-off-by:
Jes Sorensen <Jes.Sorensen@redhat.com> [updated changelog to reflect new patch order; instead of 'fixes' the patch 'prevents' - dcz] Signed-off-by:
-
David Kershner authored
Get rid of common-spar/include/diagnostics/appos_subsystems.h. No one is using it. Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Shailendra Verma authored
Fix to avoid possible memory leak if the ion device registration get failed.Free the allocated device creation memory before return in case the ion device registration get failed. Signed-off-by:
Shailendra Verma <shailendra.capricorn@gmail.com> Signed-off-by:
-
Jagan Teki authored
This patch adds more help description on android Kconfig for - lowmemory killer - Timed gpio (same for timed output) Signed-off-by:
Jagan Teki <jteki@openedev.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Brian Swetland <swetland@google.com> Signed-off-by:
-
Amaury Denoyelle authored
This patch reformat multi-line comments which are not properly written according to the kernel coding style in cb_pcidas64.c Signed-off-by:
Amaury Denoyelle <amaury.denoyelle@gmail.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Amaury Denoyelle authored
This patch fixes coding style errors reported by checkpatch.pl for cb_pcidas64.c, about too long source code lines. Signed-off-by:
-
