Commits · 7f234006d4701f6d86048f6bb605634b6b373960 · Kirill Smelkov / linux

23 May, 2014 40 commits

staging: rtl8723au: rtw_ieee80211.c: Remove a number of unused functions · 7f234006
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
7f234006

staging: rtl8723au: rtw_cmd.h: Remove some more unused #defines · 60682873

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

60682873

staging: rtl8723au: Get rid of some unused tdls definitions · 77931b7b

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

77931b7b

staging: rtl8723au: Move dummy_event_callback() to rtw_mlme_ext.c · cdaf6ef7

Jes Sorensen authored May 21, 2014

In addition get rid of a couple of empty *_event_callback() handlers
and use dummy_event_callback() instead.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

cdaf6ef7

staging: rtl8723au: Get rid of unused get_bsstype23a() · 41a5a460

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

41a5a460

staging: rtl8723au: Declare SetBWMode23a() static · 9b0cb4b6

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9b0cb4b6

staging: rtl8723au: Don't compile rtw_ap.c when CONFIG_8723AU_AP_MODE=n · f3c9d640
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
f3c9d640

staging: rtl8723au: rtw_mlme_ext.c: Fix compile warnings · a402b800

Jes Sorensen authored May 21, 2014

Fixup #ifdefs to not build issue_assocrsp() and OnAuth23a() when
CONFIG_8723AU_AP_MODE is not set.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a402b800

staging: rtl8723au: rtw_mlme_ext.c: Declare a number of functions static · 0e176853

Jes Sorensen authored May 21, 2014

These are all just used locally, no point cluttering the kernel
namespace with them.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0e176853

staging: rtl8723au: wifi.h: Get rid of last ugly frame_control manipulation macros · 33a46422
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
33a46422
staging: rtl8723au: rtl8723a_cmd.c: Get rid of SetToDs()/SetFrDs() usage · cade4108
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
cade4108

staging: rtl8723au: rtw_xmit.c: Get rid of SetToDs()/SetFrDs() usage · c26e9573

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c26e9573

staging: rtl8723au: rtw_mlme_ext.c: Get rid of SetToDs()/SetFrDs() usage · 863b314f
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
863b314f

staging: rtl8723au: Get rid of duplicate ieee80211 frame_control defines · d181ee37

Jes Sorensen authored May 21, 2014

This is all defined nicely in ieee80211.h, this was all duplication
serving no other purpose than to obfuscate the code.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d181ee37

staging: rtl8723au: Fix issue_assocrsp() to use IEEE80211_STYPE_* defines · 6ebd2948
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
6ebd2948

staging: rtl8723au: Declare issue_asocrsp() static · 5986a3f2

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5986a3f2

staging: rtl8723au: rtw_mlme_ext.c: Get rid of most WIFI_* frame type usage · c2bfb149
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
c2bfb149
staging: rtl8723au: ioctl_cfg80211.c: Use ieee80211.h provided fctl bits · 036cdd9c
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
036cdd9c

staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h provided fctl bits · 6023377b

Jes Sorensen authored May 21, 2014

v2: Fix endian bug reported by Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6023377b

staging: rtl8723au: rtw_xmit.c: Use IEEE80211_[FS]TYPE_ defines · b2f72cae

Jes Sorensen authored May 21, 2014

In addition pkt_attrib->type a u16 and get rid of pattrib->stype
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

b2f72cae

staging: rtl8723au: Remove unused SetFrameType() macro · 0d280584

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0d280584

staging: rtl8723au: Get rid of obsolete SetPriority()/SetEOSP()/SetAckpolicy() · cd700341
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
cd700341
staging: rtl8723au: _issue_qos_nulldata23a(): Use struct ieee80211_qos_hdr · 24af77b4
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
24af77b4

staging: rl8723au: rtw_make_wlanhdr(): Use ieee80211_qos_hdr · e5b2a429

Jes Sorensen authored May 21, 2014

Use the kernel provided struct and defines to fill in qos_ctrl
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e5b2a429

staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h defines to set qos_ctrl · ec3f4e2a
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
ec3f4e2a

staging: rtl8723au: rtl8723a_update_ramask(): Get rid of annoying debug message · 316f6211

Jes Sorensen authored May 21, 2014

There really is no need to print this message for anyone not trying to
debug the driver:

  rtl8723a_update_ramask => mac_id:0, networkType:0x0b, mask:0x000fffff
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

316f6211

staging: rtl8723au: Get rid of SetPrivacy()/SetPwrMgt()/SetMData() macros · c6716e1f

Jes Sorensen authored May 21, 2014

Set these bits directly in the code instead of fiddling with wrapper
macros.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c6716e1f

staging: rtl8723au: Get rid of ugly SetDuration() macro usage · fd602993

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

fd602993

staging: rtl8723au: wifi.h: Remove unused SetFragNum() macro · 2bdbf939

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2bdbf939

staging: rtl8723au: Get rid of SetSeqNum() · aeda8250

Jes Sorensen authored May 21, 2014

In every last use case, the header was just cleared with memset() so
there is no need to use the complex SetSeqNum() macro when
cpu_to_le16(IEEE80211_SN_TO_SEQ()) output will do just fine.

In addition, get rid of __le16 *fctrl usage when there is no need for
it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

aeda8250

staging: rtl8723au: Declare rtw_make_wlanhdr() static · 39ef8915

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

39ef8915

staging: rtl8723au: rtw_make_wlanhdr23a(): Use IEEE80211_SN_TO_SEQ() to set seq_ctrl · 670ce688
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
670ce688

staging: rtl8723au: rtl8723a_cmd.c: Properly initialize seq_ctrl · 0b218f4c

Jes Sorensen authored May 21, 2014

Control frames will not be fragmented, so we should fully initialize
the seq_ctrl field to zero. This avoids leftover stack bits remaining
set in the generated frame's seq_ctrl field.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0b218f4c

staging: rtl8723au: ioctl_cfg80211.c: Properly initialize seq_ctrl · 1daffaee

Jes Sorensen authored May 21, 2014

Using SetSeqNum() on an uninitialized stack frame leaves us open to
leaving random fragment bits set in seq_ctrl in the frame header.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1daffaee

staging: rtl8723au: rtw_cfg80211_inform_bss(): Use get_unaligned_le16() · 9a7e35f1
Jes Sorensen authored May 21, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
9a7e35f1

staging: rtl8723au: ioctl_cfg80211.c: Rip out < 3.14 kernel support · 14423cd7

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

14423cd7

staging: rtl8723au: cfg80211_rtw_mgmt_tx(): type is always -1 · aa69fa65

Jes Sorensen authored May 21, 2014

Rip out P2P defines since they are effectively never used.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

aa69fa65

staging: rtl8723au: Get rid of last HT OP mode duplicate defines · c3899287

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c3899287

staging: rtl8723au: wifi.h: Remove a pile of unused WDS_ defines · 95a4c8c2

Jes Sorensen authored May 21, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

95a4c8c2

staging: rtl8723au: Remove unused enum WIFI_REG_DOMAIN · 15b4ff5d

Jes Sorensen authored May 21, 2014

Must be the 17th duplicate of this list in the kernel
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

15b4ff5d