- 17 Sep, 2017 40 commits
-
-
Aviya Erenfeld authored
The linkstatus variable in the info struct received as __le16 but handled in every other place in the driver as u16 Fix that and remove the sparse warning that occurred due to it: prism2sta.c:1450:29: warning: incorrect type in assignment (different base types) prism2sta.c:1450:29: expected unsigned short [unsigned] [usertype] link_status_new prism2sta.c:1450:29: got restricted __le16 [usertype] linkstatus Signed-off-by:
Aviya Erenfeld <aviyae42@gmail.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ivan Safonov authored
Return value of request_module() does not handled, so it is possible to use shorter try_then_request_module(). Signed-off-by:
Ivan Safonov <insafonov@gmail.com> Signed-off-by:
-
Liam Ryan authored
Fix checkpath-reported unbalanced braces in the following areas 221: FILE: drivers/staging/rtl8712/hal_init.c:221: 392: FILE: drivers/staging/rtl8712/os_intfs.c:392: 363: FILE: drivers/staging/rtl8712/rtl8712_cmd.c:363: 889: FILE: drivers/staging/rtl8712/rtl8712_recv.c:889: 902: FILE: drivers/staging/rtl8712/rtl871x_cmd.c:902: 84: FILE: drivers/staging/rtl8712/rtl871x_ioctl_set.c:84: 580: FILE: drivers/staging/rtl8712/rtl871x_mlme.c:580: 593: FILE: drivers/staging/rtl8712/usb_intf.c:593: Signed-off-by:
Liam Ryan <liamryandev@gmail.com> Signed-off-by:
-
Srishti Sharma authored
Remove the variable monitor_lock as it is not used anywhere. Signed-off-by:
Srishti Sharma <srishtishar@gmail.com> Reviewed-by:
Sean Paul <seanpaul@chromium.org> Acked-by:
Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by:
-
Harsha Sharma authored
This coding style (foo *bar) is more common for the kernel code. Change foo* bar to foo *bar. Change foo * bar to foo *bar. Change (foo*) to (foo *). Signed-off-by:
Harsha Sharma <harshasharmaiitr@gmail.com> Signed-off-by:
-
Shreeya Patel authored
Logging messages that show some type of "out of memory" error are generally unnecessary as there is a generic message and a stack dump done by the memory subsystem. These messages generally increase kernel size without much added value. Problem found by checkpatch. Signed-off-by:
Shreeya Patel <shreeya.patel23498@gmail.com> Signed-off-by:
-
Harsha Sharma authored
Space between function name and open parentheses '(' is prohibited. Space is required around most binary operators '=', '==', '+=', '<', ':', '+', '-' Space required before '&', '*' Space is required after ',', ';' Signed-off-by:Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Haneen Mohammed authored
This patch convert printk() to the preferred variant dev_dbg() and remove unnecessary comment line. Issue detected with checkpatch.pl. Signed-off-by:
Haneen Mohammed <hamohammed.sa@gmail.com> Signed-off-by:
-
Harsha Sharma authored
Blank lines aren't necessary after an open brace and before a close brace Signed-off-by:
-
Harsha Sharma authored
Follow linux-kernel code style for conditional statements Signed-off-by:
-
Harsha Sharma authored
Use spaces between concatenated strings Signed-off-by:
-
Harsha Sharma authored
No spaces at the start of a line Signed-off-by:
-
Harsha Sharma authored
Use spaces around most binary operators Signed-off-by:
-
Harsha Sharma authored
Use one space around most binary operators Signed-off-by:
-
Harsha Sharma authored
Use one space around (on each side of) '=' operator Signed-off-by:
-
Harsha Sharma authored
Fixes checkpatch warning -- "occured" and "succesfully" are misspelled Signed-off-by:
-
Meghana Madhyastha authored
Replace S_IRUGO by 0444 in module parameter declaration. 0444 is more readable and matches the style used in other declarations nearby. Problem found using checkpatch. Signed-off-by:
Meghana Madhyastha <meghana.madhyastha@gmail.com> Signed-off-by:
-
Harsha Sharma authored
Static variables are initialised to 0 by gcc Signed-off-by:
-
Joe Perches authored
These functions now return void * and no longer need casts. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Joe Perches authored
Using char * for a return from allocation functions means the code has to cast generic allocations to specific types. Allow the compiler to not need casts on the allocations. Signed-off-by:
-
Joe Perches authored
These are similar macros so use the normal kernel one. As well, there are odd games being played with casting a plist to a union recv_frame by using LIST_CONTAINOR. Just use a direct cast to union recv_frame instead. Signed-off-by:
-
Srishti Sharma authored
Remove extra blank line. Signed-off-by:
-
Srishti Sharma authored
Fix alignment so that it matches open parentheses. Signed-off-by:
-
Harsha Sharma authored
This was reported by checkpatch.pl Signed-off-by:
-
Meghana Madhyastha authored
Fixes a spelling mistake in the comments. Problem found using checkpatch. Signed-off-by:
-
Tobin C. Harding authored
Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the driver. Both functions call rtl_addr_delay(), this function is unused outside of these call sites.The driver (and kernel) code base is cleaner if unused functions are removed. Remove unused functions. Signed-off-by: -
Tobin C. Harding authored
checkpatch emits multiple warnings of type WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply Replace two calls to kzalloc() with calls to kcalloc(). Signed-off-by: -
Srishti Sharma authored
Merge the assignment and the return statements to return the value directly. Done using coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: -
Gilad Ben-Yossef authored
Replace BUG() macro usage that crash the kernel with alternatives that signal error and/or try to recover. Signed-off-by:
-
Gilad Ben-Yossef authored
Replace noop macro with a noop inline function Signed-off-by:
-
Gilad Ben-Yossef authored
Use BIT macro for bit definitions where needed. Signed-off-by:
-
Gilad Ben-Yossef authored
icache_setup_completion is no longer used. Remove it. Signed-off-by:
-
Gilad Ben-Yossef authored
The resource release on probe/init error was being handled in an awkward manner and possibly leaking memory on certain (unlikely) error path. Fix it by simplifying the error resource release and making it easier to track. Reported-by:
-
Suniel Mahesh authored
It is recommended to use managed function devm_request_irq(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace platform_get_resource(), request_irq() and corresponding error handling with platform_get_irq() and devm_request_irq(). (b) remove struct resource pointer(res_irq) in struct ssi_drvdata as it seems redundant. (c) change type of member irq in struct ssi_drvdata from unsigned int to int, as return type of platform_get_irq is int and can be used in error handling. (d) remove irq_registered variable from driver probe as it seems redundant. (e) free_irq is not required any more, devm_request_irq() free's it on driver detach. (f) adjust log messages accordingly and remove any blank lines. Signed-off-by:
Suniel Mahesh <sunil.m@techveda.org> Acked-by:
-
Suniel Mahesh authored
It is recommended to use managed function devm_ioremap_resource(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace request_mem_region(), ioremap() and corresponding error handling with devm_ioremap_resource(). (b) remove struct resource pointer(res_mem) in struct ssi_drvdata as it seems redundant, use struct resource pointer which is defined locally and adjust return value of platform_get_resource() accordingly. (c) release_mem_region() and iounmap() are dropped, since devm_ioremap_ resource() releases and unmaps mem region on driver detach. (d) adjust log messages accordingly and remove any blank lines. Signed-off-by:
-
Suniel Mahesh authored
It is recommended to use managed function devm_kzalloc, which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace kzalloc with devm_kzalloc. (b) drop kfree(), because memory allocated with devm_kzalloc() is automatically freed on driver detach, otherwise it leads to a double free. (c) remove unnecessary blank lines. Signed-off-by:
-
Srishti Sharma authored
Remove the local variable inflight_counter as it is never used. Signed-off-by:
-
Justin Skists authored
correct the following warning from checkpatch.pl:- WARNING: Prefer using '"%s...", __func__' to using 'speak_char', this function's name, in a string Signed-off-by:
Justin Skists <j.skists@gmail.com> Acked-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by:
-
Janani Sankara Babu authored
This patch is created to solve the code indentation issue Signed-off-by:
Janani Sankara Babu <jananis37@gmail.com> Signed-off-by:
-
Janani Sankara Babu authored
This patch is creates in order to correct the coding style issues. It removes the unwanted parenthesis from the code. Signed-off-by:
-
