- 22 Sep, 2017 11 commits
-
-
Colin Ian King authored
Don't populate const array LCDARefreshIndex on the stack, instead make it static. Makes the object code smaller by 340 bytes: Before: text data bss dec hex filename 84949 12336 0 97285 17c05 drivers/staging/xgifb/vb_setmode.o After: text data bss dec hex filename 84506 12432 0 96938 17aaa drivers/staging/xgifb/vb_setmode.o (gcc version 7.2.0 x86_64) Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Dan Carpenter authored
BCM2835_VCHIQ_SUPPORT_MEMDUMP lets you look through any user memory. That's too big of an information leak from a security perspective. The debugging dumps need to be more specific to this driver. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Janani Sankara Babu authored
This patch solves the warning "Using comparison to false is error prone" Signed-off-by:
Janani Sankara Babu <jananis37@gmail.com> Signed-off-by:
-
Janani Sankara Babu authored
This patch removes the semicolon at the end of while statement in the do while macro , inorder to avoid it behaving like compound statement. Signed-off-by:
-
Kees Cook authored
With timer initialization made unconditional, there is no reason to make del_timer_sync() calls conditionally, there by removing the test of the .data field. Cc: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: devel@driverdev.osuosl.org Signed-off-by:
Kees Cook <keescook@chromium.org> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Georgiana Chelu authored
Fix minor coding style issues found by checkpatch.pl. Signed-off-by:
Georgiana Chelu <georgiana.chelu93@gmail.com> Signed-off-by:
-
Georgiana Chelu authored
Fix issues find by checkpatch.pl. CHECK: Comparison to NULL could be written "!dongles" CHECK: Comparison to NULL could be written "!tasks" Signed-off-by:
-
Georgiana Chelu authored
There is no need to initialize static variables to NULL because they are stored in .bss segment. This segment is initialized to 0 at the beginning of the code execution. Issue found by checkpatch.pl. ERROR: do not initialise statics to NULL Signed-off-by:
-
Harsha Sharma authored
Remove typedef from struct as linux-kernel coding style tends to avoid using typedefs Done using following coccinelle semantic patch @r1@ type T; @@ typedef struct { ... } T; @script:python c1@ T2; T << r1.T; @@ if T[-2:] =="_t" or T[-2:] == "_T": coccinelle.T2 = T[:-2]; else: coccinelle.T2 = T; print T, coccinelle.T2 @r2@ type r1.T; identifier c1.T2; @@ -typedef struct + T2 { ... } -T ; @r3@ type r1.T; identifier c1.T2; @@ -T +struct T2 Signed-off-by:Harsha Sharma <harshasharmaiitr@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Georgiana Chelu authored
Remove unnecessary messages because OOM (Out Of Memory Manager) reports memory allocation fail messages. The return value is clear regarding the problem, so there is no need for the 'out of memory' comments. Also, delete braces {} for single if statement blocks to improve the coding style. Fix issues found by by checkpatch.pl. WARNING: Possible unnecessary 'out of memory' message. WARNING: braces {} are not necessary for single statement blocks Signed-off-by:Georgiana Chelu <georgiana.chelu93@example.com> Signed-off-by:
-
Georgiana Chelu authored
Replace printk with netdev_info because struct ieee80211_device contains a net_device structure. Issue found by checkpatch.pl script. WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by:
-
- 18 Sep, 2017 29 commits
-
-
Nadav Amit authored
rq_reqbuf is allocated using kvmalloc() but released in one occasion using kfree() instead of kvfree(). The issue was found using grep based on a similar bug. Fixes: d7e09d03 ("add Lustre file system client support") Fixes: ee0ec194 ("lustre: ptlrpc: Replace uses of OBD_{ALLOC,FREE}_LARGE") Cc: Peng Tao <bergwolf@gmail.com> Cc: Oleg Drokin <oleg.drokin@intel.com> Cc: James Simmons <jsimmons@infradead.org> Signed-off-by:
Nadav Amit <namit@vmware.com> Signed-off-by:
Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Colin Ian King authored
txbuf16 is being initialized at declaration time and then later set to another value without it being read inbetween, hence making the initialization redundant. Fix this by setting txbuf16 just the once. Also clean up some incorrect indentations. Cleans up clang build warning: warning: Value stored to 'txbuf16' during its initialization is never read Signed-off-by:
-
Colin Ian King authored
Variable idx is being set but never read and thus it can be removed because it is redundant. Cleans up clang build warnings: warning: Value stored to 'idx' during its initialization is never read warning: Value stored to 'idx' is never read warning: Value stored to 'idx' is never read Signed-off-by:
-
Castulo J. Martinez authored
Remove unnecessary parentheses from if statements to make the code easier to read. Issue found by checkpatch. Signed-off-by:
Castulo J. Martinez <castulo.martinez@intel.com> Signed-off-by:
-
Valentine Sinitsyn authored
rtl8188eu contains some spelling errors in comment lines as well as in constants. Harmless as they are, they still make the code feel a bit unclean, which is not something we want in the kernel. Improve this by fixing typos so they won't catch eyes of future driver developers anymore. Signed-off-by:
Wolfgang Hartmann <wolfgang.hartmann@siemens.com> Signed-off-by:
Manish Shrestha <manishshrestha2006@gmail.com> Signed-off-by:
Valentine Sinitsyn <valentine.sinitsyn@gmail.com> Signed-off-by:
-
Greg Kroah-Hartman authored
It's already in a .h file, don't redefine it as the compiler doesn't like it if it does not match identically. Signed-off-by: -
Aastha Gupta authored
Fixes checkpatch.pl error: ERROR: open brace '{' following function declarations go on the next line Signed-off-by:Aastha Gupta <aastha.gupta4104@gmail.com> Signed-off-by:
-
Aastha Gupta authored
Fixex checkpatch.pl warning: WARNING: space prohibited before semicolon Signed-off-by:
-
Aastha Gupta authored
Fixes 'space required after ','', reported by checkpatch.pl Signed-off-by:
-
Aastha Gupta authored
Fixes checkpatch.pl warning: WARNING: Unnecessary space before function pointer arguments Signed-off-by:
-
Aastha Gupta authored
Fixes checkpatch.pl error: ERROR: open brace '{' following enum go on the same line Signed-off-by: -
Aastha Gupta authored
Fixes checkpatch.pl errors: ERROR: space required before the open parenthesis '(' ERROR: space required before the open brace '{' Signed-off-by: -
Aastha Gupta authored
Fixes checkpatch.pl warnings: WARNING: missing space after enum definition WARNING: missing space after struct definition Signed-off-by:
-
Aastha Gupta authored
Fixes checkpatch.pl error: ERROR: space prohibited before that close parenthesis ')' Signed-off-by:
-
Aastha Gupta authored
ERROR: space prohibited after the open parenthesis '(' Signed-off-by: -
Aastha Gupta authored
This patch fixes checkpatch.pl error: ERROR: space required after that close brace '}' Signed-off-by:
-
Aastha Gupta authored
Fixes prefer spaces around '+', '_', '?', '&', '==', '!=', '|', '&&', '=' as reported by checkpatch.pl. Signed-off-by:
-
Haneen Mohammed authored
This patch replace pr_debug with netdev_dbg when appropriate net_device structure is found. Issue found using the following Coccinelle script: @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL ( pr_err@p(...); | pr_info@p(...); | pr_debug@p(...); ) ...+> } @rr@ identifier r.s, fld; @@ struct s { ... struct net_device *fld; ... }; @@ identifier r.i, r.s, rr.fld; position r.p; @@ ( -pr_err@p +netdev_err ( + i->fld, ...) | -pr_info@p +netdev_info ( + i->fld, ...) | -pr_debug@p +netdev_dbg ( + i->fld, ...) ) Signed-off-by:Haneen Mohammed <hamohammed.sa@gmail.com> Acked-by:
-
Meghana Madhyastha authored
Removes the unnecessary assignment of retval preceding the return statement. Detected using the following Coccinelle script: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by:Meghana Madhyastha <meghana.madhyastha@gmail.com> Acked-by:
-
Keerthi Reddy authored
- Add a new line after struct declaration - remove extra new line. Signed-off-by:
Keerthi Reddy <keerthigd4990@gmail.com> Acked-by:
-
Aastha Gupta authored
This patch fixes the checkpatch.pl warning: WARNING: Avoid multiple line dereference - prefer'XGI330_EModeIDTable[ModeIdIndex].Ext_ModeFlag' Signed-off-by:
-
Srishti Sharma authored
Use kcalloc instead of kzalloc to check for overflow before multiplication. Done using the following semantic patch by coccinelle. http://coccinelle.lip6.fr/rules/kzalloc.cocciSigned-off-by:
Srishti Sharma <srishtishar@gmail.com> Acked-by:
-
Aishwarya Pant authored
Parenthesis are not needed around the right hand side of an assignment. This patch was made on the core files of rtl8188eu using the following coccinelle script. @@ binary operator op = {==,!=,&&,||,>=,<=,&,|}; expression l, r, t; @@ ( l = (r op t) | l = -( r -) ) Signed-off-by:Aishwarya Pant <aishpant@gmail.com> Signed-off-by:
-
Meghana Madhyastha authored
Remove typecast of pointer in kfree((u8 *)pdvobj) as it is not needed. Found using the following Coccinelle semantic patch: @@ identifier x; type t; @@ -kfree((t *)x) +kfree(x) Signed-off-by:
-
Harsha Sharma authored
Merge assignment with return statement to directly return the value. Done using following coccinelle semantic patch @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: -
Srishti Sharma authored
Test for NULL as !x where functions that return NULL on failure are used. Done using the following semantic patch by coccinelle. @ is_null @ expression E; statement S; @@ E = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); ( if(!E) S | -if(E==NULL) +if(!E) S ) Signed-off-by: -
Meghana Madhyastha authored
Move the left curly brace to the same line as the if statement. This coding style is more common and also reduces the number of lines of code. Signed-off-by:
-
Srishti Sharma authored
Parentheses are not needed on the right hand side of assignment statement in most cases. Done using the following semantic patch by coccinelle. @@ identifier E,F,G,f; expression e,r; @@ ( E = (G == F); | E = (e == r); | E = -( ... -) ; ) Signed-off-by:
-
Srishti Sharma authored
Write assignment statement outside of the if statement. Done using the following semantic patch by coccinelle. @@ identifier E; expression F; statement S; @@ -if((E = F)) +E = F; +if(E) S Signed-off-by:
-
