Commits · 84e07b9d0ac8728b1865b23498d746861a8ab4c2 · Kirill Smelkov / linux

22 Feb, 2018 23 commits

staging: lustre: improve API and implementation of blocking signals. · 84e07b9d

NeilBrown authored Feb 20, 2018

According to comment for set_current_blocked() in
kernel/signal.c, changing ->blocked directly is wrong.
sigprocmask() should be called instead.

So change cfs_block_sigsinv() and cfs_restore_sigs()
to use sigprocmask().
For consistency, change them to pass the sigset_t by reference
rather than by value.

Also fix cfs_block_sigsinv() so that it correctly blocks
signals above 32 on a 32bit host.
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

84e07b9d

staging: lustre: simplify linux-prim.c · 99c1ffc9

NeilBrown authored Feb 20, 2018

cfs_block_sigs() is never used.
cfs_clear_sigpending() is never used.
cfs_block_allsigs() is no longer used.

So those three functions can go.
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

99c1ffc9

staging: lustre: lnet: remove cfs_block_allsigs calls. · 2a4b6881

NeilBrown authored Feb 20, 2018

Both places that cfs_block_allsigs() is used here,
the goal is to turn an interruptible wait into an
uninterruptible way.
So instead of blocking the signals, change TASK_INTERRUPTIBLE to
TASK_NOLOAD.
In each case, no other functions called while signals are blocked
will sleep - just the one that has been fixed.
In one case, an extra 'interruptible' flag needs to be passed
down so the waiting decision can be made at the right place.
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2a4b6881

staging: lustre: remove unnecessary cfs_block_allsigs() calls · 1b2dad14

NeilBrown authored Feb 20, 2018

Threads started by kthread_run() ignore all signals,
as kthreadd() calls ignore_signals(), and this is
inherited by all children.
So there is no need to call cfs_block_allsigs() in functions
that are only run from kthread_run().
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1b2dad14

staging: lustre: remove linux-curproc.c · 37d3b407

NeilBrown authored Feb 20, 2018

The only functionality remaining here is
cfs_curproc_cap_pack(),
and it can be trivially implemented as an inline
in curproc.h.
So do that and remove the file.
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

37d3b407

staging: lustre: opencode cfs_cap_{raise, lower, raised} · cc738c1a

NeilBrown authored Feb 20, 2018

Each of these functions is used precisely once, so having
a separate exported function seems like overkill.

cfs_cap_raised() is trivial - one line.
cfs_cap_raise() and cfs_cap_lower() are used as a pair
which is more effectively implemented with
override_cred() / revert_creds().
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

cc738c1a

staging: lustre: replace all CFS_CAP_* macros with CAP_* · 5ebaa2d1

NeilBrown authored Feb 20, 2018

Lustre defines a few CFS_CAP_* macros which are exactly the
same as the corresponding CAP_* macro, with one exception.

CFS_CAP_SYS_BOOT is 23
CAP_SYS_BOOT is 22.

CFS_CAP_SYS_BOOT is only used through CFS_CAP_FS_MASK and
causes capability 23 (CAP_SYS_NICE) to be dropped in certain
circumstances.
It is probable that the intention was to drop CAP_SYS_BOOT,
and this is what is now done.

CFS_CAP_CHOWN_MASK and CFS_CAP_SYS_RESOURCE_MASK are never
used, so they have been removed.
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5ebaa2d1

staging: rtl8188eu: Remove unneeded cast · f23ccf86

Christopher Diaz Riveros authored Feb 20, 2018

Fix Coccinelle alert:

drivers/staging//rtl8188eu/os_dep/usb_intf.c:336:13-27: WARNING: casting value returned by memory allocation function to (struct adapter *) is useless.

This issue was detected by using the Coccinelle software.
Signed-off-by: Christopher Diaz Riveros <chrisadr@gentoo.org>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f23ccf86

staging: emxx_udc: Remove unneeded cast · 2bd27b93

Christopher Diaz Riveros authored Feb 20, 2018

Fix Coccinelle alert:

drivers/staging//emxx_udc/emxx_udc.c:2689:19-21: WARNING: casting value returned by memory allocation function to (u8 *) is useless.

This issue was detected by using the Coccinelle software.
Signed-off-by: Christopher Diaz Riveros <chrisadr@gentoo.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2bd27b93

staging: rtl8723bs: Remove unneeded cast · 8b6c7a34

Christopher Diaz Riveros authored Feb 20, 2018

Fix Coccinelle alert:

drivers/staging//rtl8723bs/os_dep/sdio_intf.c:340:13-27: WARNING: casting value returned by memory allocation function to (struct adapter *) is useless.

This issue was detected by using the Coccinelle software.
Signed-off-by: Christopher Diaz Riveros <chrisadr@gentoo.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

8b6c7a34

staging: net: netlogic: Remove unneeded cast · 5841b903

Christopher Diaz Riveros authored Feb 20, 2018

Fix Coccinelle alert:

drivers/staging//netlogic/xlr_net.c:996:12-30: WARNING: casting value returned by memory allocation function to (struct xlr_adapter *) is useless.

This issue was detected by using the Coccinelle software.
Signed-off-by: Christopher Diaz Riveros <chrisadr@gentoo.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5841b903

Staging: bcm2048: Fix function argument alignment in radio-bcm2048.c. · 444634f5

Quytelda Kahja authored Feb 19, 2018

Fix a coding style problem.
Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

444634f5

Staging: ks7010: hostif: Convert the ps_confirm_wait_inc() macro to a real function. · b6520468

Quytelda Kahja authored Feb 19, 2018

Convert the unsafe macro into an inline function.
Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

b6520468

Staging: ks7010: hostif: Convert SME queue macros to real functions. · e4281f38

Quytelda Kahja authored Feb 19, 2018

Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e4281f38

Staging: ks7010: sdio: Convert RX/TX queue macros into real functions. · 2ec999e5

Quytelda Kahja authored Feb 19, 2018

Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2ec999e5

staging: wilc1000: remove 'if' on field address · 1646ff6c

Dafna Hirschfeld authored Feb 22, 2018

Remove 'if' statements testing struct's field address.
Since such statements always return true, they are redundant.
Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1646ff6c

staging: pi433: fix CamelCase for addressFiltering · e69a0500

Valentin Vidic authored Feb 20, 2018

Fixes checkpatch warning:

  CHECK: Avoid CamelCase: <addressFiltering>
Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e69a0500

staging: pi433: fix CamelCase for thresholdDecrement · b52a5b79

Valentin Vidic authored Feb 20, 2018

Fixes checkpatch warning:

  CHECK: Avoid CamelCase: <thresholdDecrement>
Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

b52a5b79

staging: pi433: fix CamelCase for txStartCondition · 6252016c

Valentin Vidic authored Feb 20, 2018

Fixes checkpatch warning:

  CHECK: Avoid CamelCase: <txStartCondition>
Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6252016c

staging: comedi: Use '"%s:", __func__' instead of function name · 38614ed8

Eisha Chen-yen-su authored Feb 20, 2018

Replace all occurrences of functions' names in strings by a reference
to __func__, to improve robustness. Problem found with checkpatch.
Signed-off-by: Eisha Chen-yen-su <chenyensu0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

38614ed8

staging: comedi: Remove a "tracing" call · 4f7b006f

Eisha Chen-yen-su authored Feb 20, 2018

Remove a "tracing" call as it is not needed anymore
because there is an in-kernel function for that.
Signed-off-by: Eisha Chen-yen-su <chenyensu0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4f7b006f

staging: android: ion: Remove check of idev->debug_root · 81286d3e

Yisheng Xie authored Feb 22, 2018

We will go on initial idev if failed to create debug_root, and it does
not matter to check the return value of this debugfs call, just remove it.
Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

81286d3e

staging: android: ion: Remove check of debug_file · 6a1b0b33

Yisheng Xie authored Feb 22, 2018

There's no need to check the return value of debug_file for it is just a
debugfs and we will go on the following process if we failed to create
debug_file. So just remove it.
Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6a1b0b33

20 Feb, 2018 5 commits

Merge tag 'iio-for-4.17a' of... · 59142f80

Greg Kroah-Hartman authored Feb 20, 2018

Merge tag 'iio-for-4.17a' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next

Jonathan writes:

First round of new devices, features and cleanups for IIO in the 4.17 cycle.

Outside of IIO
* Strongly typed 64bit int_sqrt function needed by the mlx90632

New device support
* adc081s
  - New driver supporting adc081s, adc101s and adc121s TI ADCs.
* ad5272
  - New driver supproting the ad5272 and ad5274 ADI digital potentiometers
    with DT bindings.
* axp20x_adc
  - support the AXP813 ADC - includes rework patches to prepare for this.
* mlx90632
  - New driver with dt bindings for this IR temperature sensor.

Features
* axp20x_adc
  - Add DT bindings and probing.
* dht11
  - The sensor has a wider range than advertised in the datasheet - support it.
* st_lsm6dsx
  - Add hardware timestamp su9pport.

Cleanups
* ABI docs
  - Update email contact for Matt Ranostay
* SPDX changes
  - Matt Ranostay has moved his drivers over to SPDX.  Currently we are making
    this an author choice in IIO.
* ad7192
  - Disable burnout current on misconfiguration.  No actually effect as
    they simply won't work otherwise.
* ad7476
  - Drop a license definition that was replicating information in SPDX tag.
* ade7758
  - Expand buf_lock to cover both buffer and state protection allowing
    unintented uses of mlock in the core to be removed.
* ade7759
  - Align parameters to opening parenthesis.
* at91_adc
  - Depend on sysfs instead of selecting it - for try wide consistency.
* ccs811
  - trivial naming type for a define.
* ep93xx
  - Drop a redundant return as a result checking platform_get_resource.
* hts221
  - Regmap conversion which simplifies the driver somewhat.
  - Clean up some restricted endian cast warnings.
  - Drop a trailing whitespace from a comment
  - Drop an unnecessary get_unaligned by changing to the right 16bit data type.
* ms5611
  - Fix coding style in the probe function (whitespace)
* st_accel
  - Use strlcpy instead of strncpy to avoid potentially truncating a string.

59142f80

staging: android: ion: Initialize dma_address of new sg list · 54ef5b9d

Liam Mark authored Feb 16, 2018

Fix the dup_sg_table function to initialize the dma_address of the new
sg list entries instead of the source dma_address entries.

Since ION duplicates the sg_list this issue does not appear to result in
an actual bug.
Signed-off-by: Liam Mark <lmark@codeaurora.org>
Acked-by: Laura Abbott <labbott@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

54ef5b9d

staging: lustre: use memdup_user to allocate memory and copy from user · 2baddf26

Dafna Hirschfeld authored Feb 19, 2018

Replace a call to kmalloc and a call to copy_from_user with a
call to memdup_user to simplify the code.
Issue found with coccicheck.
Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2baddf26

staging: pi433: Split subtraction across 2 lines · f1345b2f

Eisha Chen-yen-su authored Feb 20, 2018

Split a subtraction across 2 lines in order to make these lines
no longer than 80 columns. Problem found with checkpatch.
Signed-off-by: Eisha Chen-yen-su <chenyensu0@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f1345b2f

staging: pi433: Split some function calls · 20e5f042

Eisha Chen-yen-su authored Feb 20, 2018

Split some function calls on several lines in order to make these
lines no longer than 80 columns. Problem found with checkpatch.
Signed-off-by: Eisha Chen-yen-su <chenyensu0@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

20e5f042

19 Feb, 2018 12 commits