1. 25 Jan, 2013 23 commits
  2. 24 Jan, 2013 5 commits
  3. 22 Jan, 2013 12 commits
    • Mark Einon's avatar
      staging: et131x: Fix all sparse warnings · c0594ee9
      Mark Einon authored
      Dan Carpenter has pointed out that there are several sparse warnings
      from et131x.c, listed below. This patch fixes all these errors.
      
      drivers/staging/et131x/et131x.c:1870:33: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:1870:33:    expected unsigned int [usertype] *num_des
      drivers/staging/et131x/et131x.c:1870:33:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:1871:37: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:1871:37:    expected unsigned int [usertype] *full_offset
      drivers/staging/et131x/et131x.c:1871:37:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:1872:33: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:1872:33:    expected unsigned int [usertype] *min_des
      drivers/staging/et131x/et131x.c:1872:33:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:1873:33: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:1873:33:    expected unsigned int [usertype] *base_hi
      drivers/staging/et131x/et131x.c:1873:33:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:1874:33: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:1874:33:    expected unsigned int [usertype] *base_lo
      drivers/staging/et131x/et131x.c:1874:33:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:1876:33: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:1876:33:    expected unsigned int [usertype] *num_des
      drivers/staging/et131x/et131x.c:1876:33:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:1877:37: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:1877:37:    expected unsigned int [usertype] *full_offset
      drivers/staging/et131x/et131x.c:1877:37:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:1878:33: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:1878:33:    expected unsigned int [usertype] *min_des
      drivers/staging/et131x/et131x.c:1878:33:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:1879:33: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:1879:33:    expected unsigned int [usertype] *base_hi
      drivers/staging/et131x/et131x.c:1879:33:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:1880:33: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:1880:33:    expected unsigned int [usertype] *base_lo
      drivers/staging/et131x/et131x.c:1880:33:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:1898:24: warning: incorrect type in argument 2 (different address spaces)
      drivers/staging/et131x/et131x.c:1898:24:    expected void volatile [noderef] <asn:2>*addr
      drivers/staging/et131x/et131x.c:1898:24:    got unsigned int [usertype] *base_hi
      drivers/staging/et131x/et131x.c:1900:24: warning: incorrect type in argument 2 (different address spaces)
      drivers/staging/et131x/et131x.c:1900:24:    expected void volatile [noderef] <asn:2>*addr
      drivers/staging/et131x/et131x.c:1900:24:    got unsigned int [usertype] *base_lo
      drivers/staging/et131x/et131x.c:1901:60: warning: incorrect type in argument 2 (different address spaces)
      drivers/staging/et131x/et131x.c:1901:60:    expected void volatile [noderef] <asn:2>*addr
      drivers/staging/et131x/et131x.c:1901:60:    got unsigned int [usertype] *num_des
      drivers/staging/et131x/et131x.c:1902:39: warning: incorrect type in argument 2 (different address spaces)
      drivers/staging/et131x/et131x.c:1902:39:    expected void volatile [noderef] <asn:2>*addr
      drivers/staging/et131x/et131x.c:1902:39:    got unsigned int [usertype] *full_offset
      drivers/staging/et131x/et131x.c:1910:24: warning: incorrect type in argument 2 (different address spaces)
      drivers/staging/et131x/et131x.c:1910:24:    expected void volatile [noderef] <asn:2>*addr
      drivers/staging/et131x/et131x.c:1910:24:    got unsigned int [usertype] *min_des
      drivers/staging/et131x/et131x.c:2583:32: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:2583:32:    expected unsigned int [usertype] *offset
      drivers/staging/et131x/et131x.c:2583:32:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:2585:32: warning: incorrect type in assignment (different address spaces)
      drivers/staging/et131x/et131x.c:2585:32:    expected unsigned int [usertype] *offset
      drivers/staging/et131x/et131x.c:2585:32:    got unsigned int [noderef] <asn:2>*<noident>
      drivers/staging/et131x/et131x.c:2602:24: warning: incorrect type in argument 2 (different address spaces)
      drivers/staging/et131x/et131x.c:2602:24:    expected void volatile [noderef] <asn:2>*addr
      drivers/staging/et131x/et131x.c:2602:24:    got unsigned int [usertype] *offset
      drivers/staging/et131x/et131x.c:4093:13: warning: symbol 'et131x_isr' was not declared. Should it be static?
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarMark Einon <mark.einon@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c0594ee9
    • Harvey Yang's avatar
      staging: usbip: replace the interrupt safe spinlocks with common ones. · 50b66b5c
      Harvey Yang authored
      On the client side, we have a virtual hcd driver, there actually no
      hardware interrupts, so we do not need worry about race conditions
      caused by irq with spinlock held. Turning off irq is not good for system
      performance after all. Just replace them with a non interrupt safe
      version.
      Signed-off-by: default avatarHarvey Yang <harvey.huawei.yang@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      50b66b5c
    • Harvey Yang's avatar
      staging: usbip: use interrupt safe spinlock to avoid potential deadlock. · dcf14779
      Harvey Yang authored
      The function 'usbip_event_add()' may be called in interrupt context on
      the stub side:
      'stub_complete'->'stub_enqueue_ret_unlink'->'usbip_event_add'.
      In this function it tries to get the lock 'ud->lock', so we should
      disable irq when we get this lock in process context.
      Signed-off-by: default avatarHarvey Yang <harvey.huawei.yang@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      dcf14779
    • Mark Einon's avatar
      staging: et131x: Modify block comments to fit with networking style · 26ef1021
      Mark Einon authored
      In preparation for moving et131x to drivers/net, fixup the block
      comments to match the preferred networking style - no /* on separate
      line, but */ are on a seperate line.
      Signed-off-by: default avatarMark Einon <mark.einon@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      26ef1021
    • Mark Einon's avatar
      staging: et131x: Trivial camel case fixes · c655dee9
      Mark Einon authored
      Checkpatch now highlights some camel case flag names. Fix these issues.
      
      Also fix some remaining lines > 80chars issues for completeness.
      Signed-off-by: default avatarMark Einon <mark.einon@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c655dee9
    • Mark Einon's avatar
      staging: et131x: Fix endian bugs in et131x_get_regs() · c8b0a484
      Mark Einon authored
      et131x_get_regs() calls et131x_mii_read(), passing the address of a u32
      which is cast to a (u16 *). This works fine for little endian systems,
      but not for big endian. Change so that the types are cast, not pointers
      to the types.
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarMark Einon <mark.einon@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c8b0a484
    • Devendra Naga's avatar
      staging: sep: remove assignment to i and j in sep_crypto_setup · c095454e
      Devendra Naga authored
      the i and j are used in for loop and they assigned to zeros in the
      for loop, so no need to assign them to zeros again.
      Signed-off-by: default avatarDevendra Naga <devendra.aaru@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c095454e
    • Devendra Naga's avatar
      staging: dgrp: check for a valid proc dir entry pointer · 7b63c577
      Devendra Naga authored
      while proc_create fails, the register_proc_table can do a derefernce of the
      null pointer causing to oops the system, instead check for a valid pointer
      at register and unregister
      Signed-off-by: default avatarDevendra Naga <devendra.aaru@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7b63c577
    • H Hartley Sweeten's avatar
      staging: comedi: addi_apci_16xx: add defines for the PCI device ids · b194218d
      H Hartley Sweeten authored
      The PCI device ids supported by this driver are used multiple
      places in the code. To improve maintainability, create #define's
      for them.
      Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
      Cc: Ian Abbott <abbotti@mev.co.uk>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b194218d
    • H Hartley Sweeten's avatar
      staging: comedi: addi_apci_16xx: change the MODULE_DESCRIPTION · 5e72c174
      H Hartley Sweeten authored
      Change the MODULE_DESCRIPTION to something more useful than the
      generic "Comedi low-level driver" so that modinfo provides a
      better description of the driver.
      Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
      Cc: Ian Abbott <abbotti@mev.co.uk>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      5e72c174
    • H Hartley Sweeten's avatar
      staging: comedi: addi_apci_16xx: remove unnecessary include · 1cc2be91
      H Hartley Sweeten authored
      This driver does not use any of the functionality provided by
      comedi_fc.h. Remove the #include.
      Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
      Cc: Ian Abbott <abbotti@mev.co.uk>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      1cc2be91
    • H Hartley Sweeten's avatar
      staging: comedi: addi_apci_16xx: add missing copyright comment · 0ecb3ea9
      H Hartley Sweeten authored
      Add the missing copyright information. This information was
      originally in the hwdrv_apci16xx.c file.
      Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
      Cc: Ian Abbott <abbotti@mev.co.uk>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      0ecb3ea9