- 27 Oct, 2014 40 commits
-
-
Benjamin Romer authored
Fix CamelCase name: PathName_Last_N_Nodes => pathname_last_n_nodes Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Benjamin Romer authored
Rename the macro to SPAR_CHANNEL_CLIENT_CHK_TRANSITION, and rename CamelCase parameters to: chanId => id logCtx => log Signed-off-by:
-
Benjamin Romer authored
Simplify this macro so it is only one macro, rename it to SPAR_CHANNEL_SERVER_READY, and get rid of the CamelCase parameter name. Signed-off-by:
-
Benjamin Romer authored
Fix CamelCase names: Signature => signature LegacySignature => legacy_signature HeaderSize => header_size Size => size Features => features Type => chtype PartitionHandle => partition_handle Handle => handle oChannelSpace => ch_space_offset VersionId => version_id PartitionIndex => partition_index ZoneGuid => zone_uuid oClientString => cli_str_offset CliStateBoot => cli_state_boot CmdStateCli => cmd_state_cli CliStateOs => cli_state_os ChannelCharacteristics => ch_characteristic CmdStateSrv => cmd_state_srv srvState => srv_state CliErrorBoot => cli_error_boot CliErrorOs => cli_error_os Filler => filler RecoverChannel => recover_channel Signed-off-by:
-
Benjamin Romer authored
Switch everywhere that CHANNEL_HEADER, pCHANNEL_HEADER, or ULTRA_CHANNEL_PROTOCOL was used, to struct channel_header. Signed-off-by:
-
Benjamin Romer authored
Remove all the extraneous spaces in typecasts in ULTRA_CHANNELCLI_STRING(). Signed-off-by:
-
Benjamin Romer authored
The enumeration needs to have a blank line after it. Signed-off-by:
-
Benjamin Romer authored
Remove the typedef for CHANNEL_CLIENTSTATE and just use enum channel_clientstate instead. Signed-off-by:
-
Benjamin Romer authored
Remove the typedef for CHANNEL_SERVERSTATE and use enum channel_serverstate instead. Signed-off-by:
-
Benjamin Romer authored
Remove the UltraLogEvent macro from channel.h, and fix all references so they call pr_info directly. CamelCase names used by functions that called UltraLogEvent will be fixed in later patches. Signed-off-by:
-
Benjamin Romer authored
Simplify the code in channel.h by removing CHANNEL_GUID_MISMATCH, CHANNEL_u64_MISMATCH, and CHANNEL_U32_MISMATCH, and printing the messages directly instead. The CamelCase names in the functions that used to use these macros will be fixed in a later patch. Signed-off-by:
-
Benjamin Romer authored
Just remove extra blank lines in channel_guid.h. Signed-off-by:
-
Benjamin Romer authored
The channel definitions in channel_guid.h contain several CamelCase constants. Fix these so they are no longer incorrectly cased, and use the name spar instead of the old "ultra" reference. Also, rename the corresponding UUID macros to match. Update all references to constants or UUID macros that were changed. Fix CamelCase names: UltraVhbaChannelProtocolGuid => spar_vhba_channel_protocol_uuid UltraVnicChannelProtocolGuid => spar_vnic_channel_protocol_uuid UltraSIOVMGuid => spar_siovm_uuid UltraControlDirectorChannelProtocolGuid => spar_controldirector_channel_protocol_uuid Signed-off-by:
-
Benjamin Romer authored
Nobody was using this, so just remove it. Signed-off-by:
-
Benjamin Romer authored
Fix the parameter name in ISSUE_IO_VMCALL and ISSUE_IO_EXTENDED_VMCALL. Fix CamelCase names: InterfaceMethod => method Signed-off-by:
-
Benjamin Romer authored
Get rid of the typedef for VMCALL_MONITOR_INTERFACE_METHOD_TUPLE in favor of enum vmcall_monitor_interface_method_tuple. Signed-off-by:
-
Benjamin Romer authored
There's no need for that extra space in the typecast in vbuschannel_itoa(), so just delete it. Signed-off-by:
-
Benjamin Romer authored
Get rid of the unnecessary parenthesis in several assignments in vbuschannel_devinfo_to_string(). Signed-off-by:
-
Benjamin Romer authored
Fix the parameter indentation for vbuschannel_devinfo_to_string(), in vbusdeviceinfo.h. Signed-off-by:
-
Benjamin Romer authored
The bracing in vbuschannel_sanitize_buffer() in vbusdeviceinfo.h is messy. Clean these up. Signed-off-by:
-
Shrikrishna Khare authored
Fixed a coding style issue. Signed-off-by:
Shrikrishna Khare <shrikrishna.khare@gmail.com> Signed-off-by:
-
WANG Chao authored
kmalloc_kernel() previously declared in timskmodutils.h which recently got removed. Now also remove kmalloc_kernel(), because it's not used anywhere. Signed-off-by:
WANG Chao <wangchao19890207@gmail.com> Signed-off-by:
-
tssurya authored
Removed unneeded braces with the help of checkpatch.pl tool. Signed-off-by:
Surya Seetharaman <suryaseetharaman.9@gmail.com> Signed-off-by:
-
Tapasweni Pathak authored
This patch is generated by the following semantic patch // <smpl> @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; // </smpl> Signed-off-by:Tapasweni Pathak <tapaswenipathak@gmail.com> Signed-off-by:
-
Tapasweni Pathak authored
kfree on NULL pointer is a no-op. This used the following semantic patch to identify such a instance // <smpl> @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; // </smpl> As rxb is always null at this point, so the code to kfree it and intializing it to NULL is removed completely. Suggested by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: -
Surya Seetharaman authored
Removed unnecessary braces with the help of checkpatch.pl tool. Signed-off-by:
-
Jiayi Ye authored
In assignments such as value = (FLASH_CMD_STATUS_REG_READ << 24);, parentheses are not needed. The Coccinelle semantic patch was used to find cases. @r@ identifier x; expression e1, e2; @@ - x = (e1 << e2); + x = e1 << e2; Signed-off-by:
Jiayi Ye <yejiayily@gmail.com> Signed-off-by:
-
Tina Ruchandani authored
This patch fixes the following checkpatch errors in rtw_cmd.c : ERROR: switch and case should be at the same indent Signed-off-by:
Tina Ruchandani <ruchandani.tina@gmail.com> Signed-off-by:
-
Tina Ruchandani authored
This patch fixes the following checkpatch errors: ERROR: that open brace { should be on the previous line ERROR: else should follow close brace '}' Exceptions: { is left on a new line to itself when fixing this error makes the line longer than 80 characters. Signed-off-by: -
Tina Ruchandani authored
This patch fixes the following checkpatch errors: ERROR: that open brace { should be on the previous line ERROR: else should follow close brace '}' Exceptions: { is left on a new line to itself when fixing this error makes the line longer than 80 characters. Signed-off-by: -
Aybuke Ozdemir authored
This patch focuses on fixing the following warning generated by checkpatch.pl for the file lirc_sasem.c: WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... WARNING: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... Signed-off-by:
Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by:
-
Tapasweni Pathak authored
Remove the if condition, as the code inside the if condition is commented and does not have any FIXME or TODO comment. Signed-off-by:
-
Jiayi Ye authored
If adapter is null, null dereference may occur. This patch fixes it. The following Coccinelle semantic patch was used to find the case. @@ expression E, E1; identifier f; statement S1,S2,S3; @@ * if (E == NULL) { ... when != if (E == NULL) S1 else S2 when != E = E1 * E->f ... when any return ...; } else S3 Signed-off-by: -
Sarah Khan authored
Replaced C99 // comments by /* */ in wroute.c Signed-off-by:
Sarah Khan <sarahjmi07@gmail.com> Signed-off-by:
-
Sarah Khan authored
Used coccinelle patch @@ expression data; identifier f; @@ -data = +return f(...); -return (data); Signed-off-by: -
Tapasweni Pathak authored
Use kstrdup when the goal of an allocation is copy a string into the allocated region. Patch found by coccicheck. Signed-off-by:
-
Ebru Akagunduz authored
This patch fixes "cast to restricted __be32" sparse warning. remove temporary value assignment and use inplace __be32 conversion for ntohl function which is can get big endian format Signed-off-by:
Ebru Akagunduz <ebru.akagunduz@gmail.com> Reviewed-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Vaishali Thakkar authored
This patch uses kasprintf which combines kmalloc and sprintf. kasprintf also takes care of the size calculation. This is done using Coccinelle. Semantic patch used is as follows: @@ expression a,flag; expression list args; statement S; @@ a = - \(kmalloc\|kzalloc\)(...,flag) + kasprintf (flag,args) <... when != a if (a == NULL || ...) S ...> - sprintf(a,args); Signed-off-by:
Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by:
-
Somya Anand authored
'struct timeval t' is used to return remaining time in milliseconds. 32-bit systems using 'struct timeval' will break in the year 2038, so we have to replace that code with more appropriate types. This patch changes the android driver to use ktime_t. Signed-off-by:
Somya Anand <somyaanand214@gmail.com> Signed-off-by:
-
Somya Anand authored
'struct timeval last' is used for recording last time interrupt. 'struct timeval now' is used for calculating elapsed time. 32-bit systems using 'struct timeval' will break in the year 2038, so we have to replace that code with more appropriate types. This patch changes the comedi driver to use ktime_t. Since this code doesn't communicate the time values to the outside (user space, file system, network).Thus ktime_get() is a better than using do_gettimeofday() as it uses monotonic clock. ktime_to_us() returns an 's64', and using the '%' operator on that requires doing a 64-bit division which needs an expensive library function call the specific value of usec_current does not actually matter although it might matter that it's not always the same which will start with the offset from the lower 32 bit of the microsecond. Therefore: devpriv->usec_current = (ktime_to_us(devpriv->last) % USEC_PER_SEC) % devpriv->usec_period; is replaced by devpriv->usec_current = ((u32)ktime_to_us(devpriv->last)) % devpriv->usec_period; Signed-off-by:
-
