1. 18 Jan, 2019 30 commits
  2. 17 Jan, 2019 10 commits
    • Peter Oskolkov's avatar
      net: add a route cache full diagnostic message · 22c2ad61
      Peter Oskolkov authored
      In some testing scenarios, dst/route cache can fill up so quickly
      that even an explicit GC call occasionally fails to clean it up. This leads
      to sporadically failing calls to dst_alloc and "network unreachable" errors
      to the user, which is confusing.
      
      This patch adds a diagnostic message to make the cause of the failure
      easier to determine.
      Signed-off-by: default avatarPeter Oskolkov <posk@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      22c2ad61
    • Ioana Ciocoi Radulescu's avatar
      dpaa2-eth: Fix ndo_stop routine · 68d74315
      Ioana Ciocoi Radulescu authored
      In the current implementation, on interface down we disabled NAPI and
      then manually drained any remaining ingress frames. This could lead
      to a situation when, under heavy traffic, the data availability
      notification for some of the channels would not get rearmed correctly.
      
      Change the implementation such that we let all remaining ingress frames
      be processed as usual and only disable NAPI once the hardware queues
      are empty.
      
      We also add a wait on the Tx side, to allow hardware time to process
      all in-flight Tx frames before issueing the disable command.
      Signed-off-by: default avatarIoana Radulescu <ruxandra.radulescu@nxp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      68d74315
    • Colin Ian King's avatar
      wan: dscc4: fix various indentation issues · 5191673b
      Colin Ian King authored
      There are some lines that have indentation issues, fix these.
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5191673b
    • David S. Miller's avatar
      Merge branch 'vxlan-FDB-veto' · 039d52e1
      David S. Miller authored
      Petr Machata says:
      
      ====================
      vxlan: Allow vetoing FDB operations
      
      mlxsw does not implement handling of the more advanced types of VXLAN
      FDB entries. In order to provide visibility to users, it is important to
      be able to reject such FDB entries, ideally with an explanation passed
      in extended ack. This patch set implements this.
      
      In patches #1-#4, vxlan is gradually transformed to support vetoing of
      FDB entries added (or modified) through vxlan_fdb_update(), and the
      default FDB entry added in __vxlan_dev_create().
      
      Patches #5-#7 deal with vxlan_changelink(). The existing code recognizes
      that vxlan_fdb_update() may fail, but doesn't attempt to keep things
      intact if it does. These patches change the function in several steps to
      gracefully handle vetoes (or other failures).
      
      Then in patches #8-#11, extack arguments are added, respectively, to
      ndo_fdb_add(), mlxsw's mlxsw_sp_nve_ops.fdb_replay, the functions that
      connect to the VXLAN vetoing code, and call_switchdev_notifiers(). Note
      that call_switchdev_blocking_notifiers() already does support extack.
      
      Finally in patch #12, mlxsw is extended to add extack messages to
      rejected FDB entries. In patch #13, the functionality is tested.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      039d52e1
    • Petr Machata's avatar
      selftests: mlxsw: Test veto of unsupported VXLAN FDBs · 7e1046fd
      Petr Machata authored
      mlxsw doesn't implement offloading of all types of FDB entries that the
      VXLAN driver supports. Test that such FDB entries are rejected. That
      makes sure that the decision made by the existing validation code in
      mlxsw propagates up the stack. It also exercises rollback functionality
      in VXLAN, and tests that extack is returned.
      Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7e1046fd
    • Petr Machata's avatar
      mlxsw: spectrum: Add extack messages to VXLAN FDB rejection · a40313d9
      Petr Machata authored
      Annotate the rejections in mlxsw_sp_switchdev_vxlan_work_prepare() with
      textual reasons.
      
      Because this code ends up being invoked for FDB replay as well, drop the
      default message from there, so that the more accurate error message is
      not overwritten.
      Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a40313d9
    • Petr Machata's avatar
      switchdev: Add extack argument to call_switchdev_notifiers() · 6685987c
      Petr Machata authored
      A follow-up patch will enable vetoing of FDB entries. Make it possible
      to communicate details of why an FDB entry is not acceptable back to the
      user.
      Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6685987c
    • Petr Machata's avatar
      vxlan: Add extack to switchdev operations · 4c59b7d1
      Petr Machata authored
      There are four sources of VXLAN switchdev notifier calls:
      
      - the changelink() link operation, which already supports extack,
      - ndo_fdb_add() which got extack support in a previous patch,
      - FDB updates due to packet forwarding,
      - and vxlan_fdb_replay().
      
      Extend vxlan_fdb_switchdev_call_notifiers() to include extack in the
      switchdev message that it sends, and propagate the argument upwards to
      the callers. For the first two cases, pass in the extack gotten through
      the operation. For case #3, pass in NULL.
      
      To cover the last case, extend vxlan_fdb_replay() to take extack
      argument, which might come from whatever operation necessitated the FDB
      replay.
      Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4c59b7d1
    • Petr Machata's avatar
      mlxsw: Add extack to mlxsw_sp_nve_ops.fdb_replay · d907f58f
      Petr Machata authored
      A follow-up patch will extend vxlan_fdb_replay() with an extack
      argument. Extend the fdb_replay callback in mlxsw likewise so that the
      argument is ready for the vxlan conversion.
      Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d907f58f
    • Petr Machata's avatar
      net: Add extack argument to ndo_fdb_add() · 87b0984e
      Petr Machata authored
      Drivers may not be able to support certain FDB entries, and an error
      code is insufficient to give clear hints as to the reasons of rejection.
      
      In order to make it possible to communicate the rejection reason, extend
      ndo_fdb_add() with an extack argument. Adapt the existing
      implementations of ndo_fdb_add() to take the parameter (and ignore it).
      Pass the extack parameter when invoking ndo_fdb_add() from rtnl_fdb_add().
      Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      87b0984e