- 23 Feb, 2017 40 commits
-
-
Jaegeuk Kim authored
It turns out a stakable filesystem like sdcardfs in AOSP can trigger multiple vfs_create() to lower filesystem. In that case, f2fs will add multiple dentries having same name which breaks filesystem consistency. Until upper layer fixes, let's work around by f2fs, which shows actually not much performance regression. Cc: <stable@vger.kernel.org> Signed-off-by:Jaegeuk Kim <jaegeuk@kernel.org>
-
Jaegeuk Kim authored
This patch shows actual device information in the tracepoints. Signed-off-by: -
Jaegeuk Kim authored
We have had node chains, but haven't used it so far due to stale node blocks. Now, we have crc|cp_ver in node footer and give random cp_ver at format time, we can start to use it again. Signed-off-by: -
Chao Yu authored
In android, since SElinux is enable, security policy will be appliedd for each file, it stores in inode as an xattr entry, so it will take one 4k size node block additionally for each file. Let's enable inline_xattr by default in order to save storage space. Signed-off-by:
Chao Yu <yuchao0@huawei.com> Signed-off-by:
-
Chao Yu authored
This patch introduces new mount option 'noinline_xattr', so we can disable inline xattr functionality which is already set as a default mount option. Signed-off-by:
-
Jaegeuk Kim authored
We've not seen this buggy case for a long time, so it's time to avoid this unnecessary get_node_info() call which reading NAT page to cache nat entry. Signed-off-by: -
Jaegeuk Kim authored
Let's avoid build_free_nids() in checkpoint path. Signed-off-by: -
Chao Yu authored
Currently, if we call fsync after updating the xattr date belongs to the file, f2fs needs to trigger checkpoint to keep xattr data consistent. But, this policy cause low performance as checkpoint will block most foreground operations and cause unneeded and unrelated IOs around checkpoint. This patch will reuse regular file recovery policy for xattr node block, so, we change to write xattr node block tagged with fsync flag to warm area instead of cold area, and during recovery, we search warm node chain for fsynced xattr block, and do the recovery. So, for below application IO pattern, performance can be improved obviously: - touch file - create/update/delete xattr entry in file - fsync file Signed-off-by:
-
Bhumika Goyal authored
Declare fscrypt_operations structure as const as it is only stored in the s_cop field of a super_block structure. This field is of type const, so fscrypt_operations structure having this property can be made const too. File size before: fs/f2fs/super.o text data bss dec hex filename 54131 31355 184 85670 14ea6 fs/f2fs/super.o File size after: fs/f2fs/super.o text data bss dec hex filename 54227 31259 184 85670 14ea6 fs/f2fs/super.o Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Jaegeuk Kim authored
If we mounted f2fs successfully, let's show current checkpoint version. Signed-off-by: -
Tiezhu Yang authored
There is a typo "f2f2" in f2fs.txt, this patch fixes it. Signed-off-by:
Tiezhu Yang <kernelpatch@126.com> Signed-off-by:
-
Jaegeuk Kim authored
This patch removes REQ_PREFLUSH in the nobarrier case. Signed-off-by: -
Jaegeuk Kim authored
If the cached bio has the last page's index, then we need to submit it. Otherwise, we don't need to submit it and can wait for further IO merges. Reviewed-by:
-
Jaegeuk Kim authored
This patch check IO submission more precisely than previous rough check. Signed-off-by: -
Jaegeuk Kim authored
This patch introduces __write_data_page to call it by f2fs_write_cache_pages directly.. Signed-off-by: -
Jaegeuk Kim authored
We need to flush data writes before flushing last node block writes by using FUA with PREFLUSH. We don't need to guarantee precedent node writes since if those are not written, we can't reach to the last node block when scanning node block chain during roll-forward recovery. Afterwards f2fs_wait_on_page_writeback guarantees all the IO submission to disk, which builds a valid node block chain. Reviewed-by:
-
Jaegeuk Kim authored
This patch just moves write_node_page and introduces an inner function. Reviewed-by:
-
Jaegeuk Kim authored
This patch moves the tracepoint location for flush command. Reviewed-by:
-
Jaegeuk Kim authored
This patch shows cached # of APPEND and UPDATE inode entries. Reviewed-by:
-
DongOh Shin authored
1) Nine coding style warnings below have been resolved: "Missing a blank line after declarations" 2) 435 coding style warnings below have been resolved: "function definition argument 'x' should also have an identifier name" 3) Two coding style warnings below have been resolved: "macros should not use a trailing semicolon" Signed-off-by:
DongOh Shin <doscode.kr@gmail.com> Signed-off-by:
-
DongOh Shin authored
Two coding style errors below have been resolved: "Macros with complex values should be enclosed in parentheses" And a coding style error below has been resolved: "space prohibited before that ',' (ctx:WxW)" Signed-off-by:
-
Jaegeuk Kim authored
We missed two functions declared as static functions. Signed-off-by: -
Kaixu Xia authored
This patch shows the fault injection mount option in f2fs_show_options(). Signed-off-by:
Kaixu Xia <xiakaixu@huawei.com> Signed-off-by:
-
Chao Yu authored
We only allocate flush merge control structure sbi::sm_info::fcc_info when flush_merge option is on, but in f2fs_issue_flush we still try to access member of the control structure without that option, it incurs panic as show below, fix it. Call Trace: __remove_ino_entry+0xa9/0xc0 [f2fs] f2fs_do_sync_file.isra.27+0x214/0x6d0 [f2fs] f2fs_sync_file+0x18/0x20 [f2fs] vfs_fsync_range+0x3d/0xb0 __do_page_fault+0x261/0x4d0 do_fsync+0x3d/0x70 SyS_fsync+0x10/0x20 do_syscall_64+0x6e/0x180 entry_SYSCALL64_slow_path+0x25/0x25 RIP: 0033:0x7f18ce260de0 RSP: 002b:00007ffdd4589258 EFLAGS: 00000246 ORIG_RAX: 000000000000004a RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007f18ce260de0 RDX: 0000000000000006 RSI: 00000000016c0360 RDI: 0000000000000003 RBP: 00000000016c0360 R08: 000000000000ffff R09: 000000000000001f R10: 00007ffdd4589020 R11: 0000000000000246 R12: 00000000016c0100 R13: 0000000000000000 R14: 00000000016c1f00 R15: 00000000016c0100 Code: fb 81 e3 00 08 00 00 48 89 45 a0 0f 1f 44 00 00 31 c0 85 db 75 27 41 81 e7 00 04 00 00 74 0c 41 8b 45 20 85 c0 0f 85 81 00 00 00 <f0> 41 ff 45 20 4c 89 e7 e8 f8 e9 ff ff f0 41 ff 4d 20 48 83 c4 RIP: f2fs_issue_flush+0x5b/0x170 [f2fs] RSP: ffffc90003b5fd78 CR2: 0000000000000020 ---[ end trace a09314c24f037648 ]--- Reported-by:
Shuoran Liu <liushuoran@huawei.com> Signed-off-by:
-
Chao Yu authored
We use following method to calculate size with current page index: size = index << PAGE_SHIFT If type of index has only 32-bits size, left shifting will incur overflow, which makes result incorrect. So let's cast index with 64-bits type to avoid such issue. Signed-off-by:
-
Chao Yu authored
Previously, in getxattr we will load all entries both in inline xattr and xattr node block, and then do the lookup in all entries, but our lookup flow shows low efficiency, since if we can lookup and hit in inline xattr of inode page cache first, we don't need to load and lookup xattr node block, which can obviously save cpu time and IO latency. Signed-off-by:
-
Masanari Iida authored
This patch fix a typo in f2fs.txt Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Wei Fang authored
A dead loop can be triggered in f2fs_fiemap() using the test case as below: ... fd = open(); fallocate(fd, 0, 0, 4294967296); ioctl(fd, FS_IOC_FIEMAP, fiemap_buf); ... It's caused by an overflow in __get_data_block(): ... bh->b_size = map.m_len << inode->i_blkbits; ... map.m_len is an unsigned int, and bh->b_size is a size_t which is 64 bits on 64 bits archtecture, type conversion from an unsigned int to a size_t will result in an overflow. In the above-mentioned case, bh->b_size will be zero, and f2fs_fiemap() will call get_data_block() at block 0 again an again. Fix this by adding a force conversion before left shift. Signed-off-by:
Wei Fang <fangwei1@huawei.com> Acked-by:
-
Jaegeuk Kim authored
Sheng Yong reports needless preallocation if write(small_buffer, large_size) is called. In that case, f2fs preallocates large_size, but vfs returns early due to small_buffer size. Let's detect it before preallocation phase in f2fs. Reported-by:
Sheng Yong <shengyong1@huawei.com> Signed-off-by:
-
Jaegeuk Kim authored
This patch adds stat information for flush and discard commands. Reviewed-by:
-
Jaegeuk Kim authored
This patch adds a kernel thread to issue discard commands. It proposes three states, D_PREP, D_SUBMIT, and D_DONE to identify current bio status. Reviewed-by:
-
Jaegeuk Kim authored
This patch adds discard_cmd_control with the existing discarding controls. Reviewed-by:
-
Jaegeuk Kim authored
This patch modifies stat information more clearly. Reviewed-by:
-
Jaegeuk Kim authored
This patch simply cleans up the names for flush/discard commands. Reviewed-by:
-
Chao Yu authored
This patch adds a mirror for sit version bitmap, and use it to detect in-memory bitmap corruption which may be caused by bit-transition of cache or memory overflow. Signed-off-by:
-
Chao Yu authored
This patch adds a mirror for nat version bitmap, and use it to detect in-memory bitmap corruption which may be caused by bit-transition of cache or memory overflow. Signed-off-by:
-
Chao Yu authored
This patch adds a mirror for valid block bitmap, and use it to detect in-memory bitmap corruption which may be caused by bit-transition of cache or memory overflow. Signed-off-by:
-
Chao Yu authored
This patch introduces a new flag to indicate inode status of doing atomic write committing, so that, we can keep atomic write status for inode during atomic committing, then we can skip GCing pages of atomic write inode, that avoids random GCed datas being mixed with current transaction, so isolation of transaction can be kept. Signed-off-by:
-
Chao Yu authored
Signed-off-by:
-
Jaegeuk Kim authored
If there is no candidate to submit discard command during f2fs_trim_fs, let's return without checkpoint. Reviewed-by:
-
