- 17 Feb, 2022 17 commits
-
-
Phillip Potter authored
Remove all remaining DBG_88E calls from the os_dep subdirectory. After some thought, it makes more sense to just entirely strip all of these calls, so that debugging code in the driver can be more consistent and useful going forwards. Signed-off-by:
Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20220216010709.791-8-phil@philpotter.co.ukSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Phillip Potter authored
Remove all remaining DBG_88E calls from os_dep/ioctl_linux.c, patching separately from the rest of the os_dep subdirectory for ease of review due to the sheer number of calls. After some thought, it makes more sense to just entirely strip all of these calls, so that debugging code in the driver can be more consistent and useful going forwards. Signed-off-by:
-
Phillip Potter authored
Remove all remaining DBG_88E calls from the hal subdirectory. After some thought, it makes more sense to just entirely strip all of these calls, so that debugging code in the driver can be more consistent and useful going forwards. Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
-
Phillip Potter authored
Remove all remaining DBG_88E calls from the core subdirectory. After some thought, it makes more sense to just entirely strip all of these calls, so that debugging code in the driver can be more consistent and useful going forwards. Signed-off-by:
-
Phillip Potter authored
Remove all the netdev_dbg/pr_debug calls that were previously converted from DBG_88E inside core/rtw_mlme_ext.c. Due to the sheer number of lines, this patch is separated out for ease of review. After some thought, it makes more sense to just entirely strip all of these calls, so that debugging code in the driver can be more consistent and useful going forwards. Signed-off-by:
-
Phillip Potter authored
Remove all the smaller sets of dev_dbg/netdev_dbg/pr_debug calls that were previously converted from DBG_88E. After some thought, it makes more sense to just entirely strip all of these calls, so that debugging code in the driver can be more consistent and useful going forwards. Signed-off-by:
-
Phillip Potter authored
Remove all netdev_dbg and dev_dbg calls that were previously converted from DBG_88E_LEVEL. After some thought, it makes more sense to just entirely strip all of these calls, so that debugging code in the driver can be more consistent and useful going forwards. Signed-off-by:
-
Martin Kaiser authored
struct usb_suspend_parm is not used. Remove it. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20220216081657.622467-4-martin@kaiser.cxSigned-off-by:
-
Martin Kaiser authored
evt_done_cnt in struct evt_priv is set but not used. Remove it. Signed-off-by:
-
Martin Kaiser authored
evt_allocated_buf in struct evt_priv is not used. Remove it. Signed-off-by:
-
Colin Ian King authored
There is a spelling mistake in a dev_warn message. Fix it. Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20220217104747.15424-1-colin.i.king@gmail.comSigned-off-by:
-
Jérôme Pouiller authored
Currently, the DT bindings the wfx driver cannot be processed by make dt_binding_check. We need to place it somewhere into Documentation/devicetree/bindings/. After that change, we are able to get warnings from dt_binding_check and fix them. Signed-off-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/20220217103248.183770-1-Jerome.Pouiller@silabs.comSigned-off-by:
-
Jérôme Pouiller authored
Until now, the SDIO quirks are applied directly from the driver. However, it is better to apply the quirks before driver probing. So, this patch relocate the quirks in the MMC framework. Note that the WF200 has no valid SDIO VID/PID. Therefore, we match DT rather than on the SDIO VID/PID. Reviewed-by:
Pali Rohár <pali@kernel.org> Reviewed-by:
Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by:
-
Jérôme Pouiller authored
Some may think that SDIO_VENDOR_ID_SILABS / SDIO_DEVICE_ID_SILABS_WF200 are official SDIO IDs. However, it is not the case, the values used by WF200 are not official (BTW, the driver rely on the DT rather than on the SDIO IDs to probe the device). To avoid any confusion, remove the definitions SDIO_*_ID_SILABS* and use raw values. Reviewed-by:
-
Michael Straube authored
After removing CCKSwingTable_Ch14 there is only one table left and we can rename CCKSwingTable_Ch1_Ch13 to simply cck_swing_table. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20220216194038.6762-4-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
The variable bCCKinCH14 in struct odm_rf_cal is never set. It stays at its default value 0. Remove bCCKinCH14 from struct odm_rf_cal and remove related dead code. Signed-off-by:
-
Michael Straube authored
Remove an unused enum from usb_halinit.c. Signed-off-by:
-
- 15 Feb, 2022 23 commits
-
-
Marcelo Aloisio da Silva authored
Remove if condition that is always true. It is useless and makes the code less readable. Signed-off-by:
Marcelo Aloisio da Silva <marcelo.as@aol.com> Link: https://lore.kernel.org/r/20220215023926.GA52339@snoopySigned-off-by:
-
Abdun Nihaal authored
Some of the sta_* and STA_* macros are not used. Remove those unused macros. Signed-off-by:
Abdun Nihaal <abdun.nihaal@gmail.com> Link: https://lore.kernel.org/r/c2453078b2d46119d167f2d0e4690cc87fc4b77e.1644422181.git.abdun.nihaal@gmail.comSigned-off-by:
-
Abdun Nihaal authored
The function argument padapter is not used in chk_ap_is_alive. Remove it. Signed-off-by:
-
Abdun Nihaal authored
The function argument action is not used in on_action_public_default. Remove it. Signed-off-by:
-
Abdun Nihaal authored
The argument priv is not used in function __nat25_has_expired. Remove it. Signed-off-by:
-
Abdun Nihaal authored
The definition of function __nat25_db_print is empty. Remove it. Signed-off-by:
-
Abdun Nihaal authored
The definition of function _InitOperationMode is empty. Remove it. Signed-off-by:
-
Abdun Nihaal authored
The definition of function rtw_mfree_mlme_priv_lock is empty. Remove it. Signed-off-by:
-
Abdun Nihaal authored
The definition of function rtw_get_encrypt_decrypt_from_registrypriv is empty. Remove it. Signed-off-by:
-
Abdun Nihaal authored
struct zero_bulkout_context is not used. Remove it. Signed-off-by:
-
Vihas Makwana authored
_rtw_free_sta_priv() always returns _SUCCESS and it's return value isn't checked either. So it makes sense to mark it as void instead of u32. Signed-off-by:
Vihas Makwana <makvihas@gmail.com> Link: https://lore.kernel.org/r/20220213173424.39935-1-makvihas@gmail.comSigned-off-by:
-
Arınç ÜNAL authored
GB-PC1 uses some of the rgmii2 pins (22 - 33) as GPIO. Therefore, the rgmii2 bus cannot be used on this device. Overwrite pinctrl-0 property under the ethernet node without rgmii2_pins on the GB-PC1 devicetree. Tested-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by:
Arınç ÜNAL <arinc.unal@arinc9.com> Link: https://lore.kernel.org/r/20220215081725.3463-2-arinc.unal@arinc9.comSigned-off-by:
-
Arınç ÜNAL authored
Fix pinctrl-0 items under the ethernet node to be size-1 items. Current notation would be used on specifications with non-zero cells. Fixes: 0a93c0d7 ("staging: mt7621-dts: fix pinctrl properties for ethernet") Reported-by:
Sander Vanheule <sander@svanheule.net> Signed-off-by:
-
Martin Kaiser authored
The r8188eu driver does no longer access rf path b registers via PHYRegDef. Change the PHYRegDef array in struct hal_data_8188e to a single variable that holds the register addresses for rf path a. Remove the initialisation of path b register addresses. Signed-off-by:
-
Martin Kaiser authored
All callers of phy_RFSerialRead set the eRFPath parameter to RF_PATH_A. Remove the parameter and use RF_PATH_A directly. Signed-off-by:
-
Martin Kaiser authored
All callers of rtl8188e_PHY_QueryRFReg set the eRFPath parameter to RF_PATH_A. Remove the parameter and use RF_PATH_A directly. Signed-off-by:
-
Martin Kaiser authored
Rf registers can be read by rtw_wx_read_rf or via the private ioctl 0x0B. The latter calls rtw_dbg_port. Limit rf register reads to path a in rtw_debug_port. Signed-off-by:
-
Martin Kaiser authored
Commit 3b011b09 ("staging: r8188eu: limit rf register writes to path a") limits rf register writes by private ioctls to RF_PATH_A. Apart from private ioctls, the rest of the driver uses only path a. This patch limits rf register reads by the private ioctl 0x0D, which calls rtw_wx_read_rf, to path a. Signed-off-by:
-
Martin Kaiser authored
The path variable is always 0 in bb_reg_dump. Remove the path variable and replace the constant 0 with RF_PATH_A to make it clearer that path a is used. Signed-off-by:
-
Martin Kaiser authored
The only caller of phy_RFSerialWrite sets the eRFPath parameter to RF_PATH_A. Remove the parameter and use RF_PATH_A directly. Signed-off-by:
-
Martin Kaiser authored
All callers of rtl8188e_PHY_SetRFReg set the eRFPath parameter to RF_PATH_A. Remove the parameter and use RF_PATH_A directly. Signed-off-by:
-
Martin Kaiser authored
Commit 3b011b09 ("staging: r8188eu: limit rf register writes to path a") limited the rtw_wx_write_rf function to write only rf registers for path a. The private ioctl 0x0B invokes the rtw_dbg_port function. This ioctl can also be used for writing rf registers. We should limit these register writes to rf path a as well. Signed-off-by:
-
Martin Kaiser authored
We've already limited the rtw_wx_write_rf function to RF_PATH_A in commit 3b011b09 ("staging: r8188eu: limit rf register writes to path a"). Set RF_PATH_A explicitly when we call rtl8188e_PHY_SetRFReg. This will make it easier later to verify that all callers of rtl8188e_PHY_SetRFReg use path a. Signed-off-by:
-
