- 23 May, 2014 40 commits
-
-
Gengis Dave authored
Return values cleanup Signed-off-by:
Davide Gianforte <davide@gengisdave.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Peter Senna Tschudin authored
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // </smpl> Signed-off-by:
Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by:
-
Benoit Taine authored
This patch enhances kernel style usage for the rts5208 driver. We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. Signed-off-by:
Benoit Taine <benoit.taine@lip6.fr> Signed-off-by:
-
Julia Lawall authored
Delete unnecessary use of a local variable to immediately return 0. A simplified version of the semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ local idexpression ret; expression e; position p; @@ -ret = 0; ... when != ret = e return - ret + 0 ; // </smpl> Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
Masaru Nomura authored
Remove a prohibited space before a closed parenthesis of if statement to meet kernel coding style. Signed-off-by:
Masaru Nomura <massa.nomura@gmail.com> Signed-off-by:
-
Masaru Nomura authored
Add a required space before an open parenthesis of if statement to meet kernel coding style. Signed-off-by:
-
Eli Billauer authored
Suggested-by:
Baruch Siach <baruch@tkos.co.il> Signed-off-by:
Eli Billauer <eli.billauer@gmail.com> Signed-off-by:
-
Masanari Iida authored
This patch converts printk to dev_err in ft1000_cs.c Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Mark Hounschell authored
Removes dgap_savestring function to use kstrdup instead. Signed-off-by:
Mark Hounschell <markh@compro.net> Tested-by:
-
Mark Hounschell authored
This patch removes an unnecessary test. We've already tested it by the time we get here with no possiblity of it being changed. Signed-off-by:
-
Mark Hounschell authored
This patch removes a false comment Signed-off-by:
-
Mark Hounschell authored
The sniff buffer was a /proc filesystem file. This module no longer uses /proc. This patch removes the deaed code associated with the sniff buffer. Signed-off-by:
-
Mark Hounschell authored
This patch fixes a smatch warning about an unsigned integer being tested for less than zero. Signed-off-by:
-
Daeseok Youn authored
- alloc_tty_driver() is deprecated so it is changed to tty_alloc_driver() - Pointers which are allocated by alloc_tty_driver() and kzalloc() can be NULL so it need to check NULL for them. - If one of those is failed, it need to add proper handler for avoiding memory leak. - If both of drivers are registered normally, and then set TRUE to dgap_major_serial{print}_registered. If one of drivers is failed to register, leave a default value as FALSE. Signed-off-by:Daeseok Youn <daeseok.youn@gmail.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Vitaly Osipov authored
Replaced all uses of printk() in wlan-ng with netdev_err / _warn where a netdev exists. If a few cases where a netdev does not yet exist, dev_ or pr_ was used. Checkpatch complains about lines over 80 chars or split string constants - the messages are just too long, keeping it completely happy would make the code less readable. Signed-off-by:
Vitaly Osipov <vitaly.osipov@gmail.com> Signed-off-by:
-
Denis Pithon authored
Wherever possible, replaced printk() and pr_xxx() calls with netdev_xxx() / dev_xxx() calls; used pr_xxx() otherwise. Signed-off-by:
Denis Pithon <denis.pithon@gmail.com> Signed-off-by:
-
Denis Pithon authored
Gathered together comments in front of multicast filtering block. Signed-off-by:
-
Denis Pithon authored
Used is_multicast_ether_addr() to perform the checking. Signed-off-by:
-
Denis Pithon authored
Replaced generic memcmp() with dedicated ether_addr_equal_unaligned() call. I did not find any clue of u16 alignment for both addresses. Signed-off-by:
-
Denis Pithon authored
Renamed convert_frame_to_ether() to p80211_convert_to_ether(). Signed-off-by:
-
Paul Davies C authored
Some lines with more than 80 characters are converted in to multiple lines. Signed-off-by:
Paul Davies C <pauldaviesc@gmail.com> Signed-off-by:
-
Paul Davies C authored
Add blank lines after each declarations in drivers/staging/octeon-usb/octeon-hcd.c. Signed-off-by:
-
Aaro Koskinen authored
Use generic prefetch. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Aaro Koskinen authored
cvmx_usb_pipe fits into a cache-line so additional prefetches are not really helping anything. Signed-off-by:
-
Pawel Lebioda authored
Fix bad function definitions in all files from drivers/staging/usbip directory Signed-off-by:
Pawel Lebioda <pawel.lebioda89@gmail.com> Signed-off-by:
-
Pawel Lebioda authored
Fix "Missing a blank line after declaration" style problems for all files in drivers/staging/usbip. Signed-off-by:
-
Rickard Strandqvist authored
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Reviewed-by:
-
Marcus Farkas authored
This commit fixes the following checkpatch warning: rtl8712/rtl871x_security.c - 1178: WARNING: Avoid unnecessary line continuations Signed-off-by:Marcus Farkas <marcus.farkas@finitebox.com> Signed-off-by:
-
Marcus Farkas authored
This commit fixes the following checkpatch warnings: rtl8712/rtl871x_security.c - 1167: WARNING: Unnecessary parentheses - maybe == should be = ? - 1374: WARNING: Unnecessary parentheses - maybe == should be = ? Signed-off-by: -
Marcus Farkas authored
This commit fixes the following checkpatch warnings: rtl8712/rtl871x_security.c - 275: WARNING: Missing a blank line after declarations - 768: WARNING: Missing a blank line after declarations - 801: WARNING: Missing a blank line after declarations Signed-off-by: -
Christian Engelmayer authored
Fix potential leaks in the error paths of r8712_set_key(). In case the algorithm specific checks fail, the function returns without enqueuing or freeing the already allocated command and parameter structs. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 144370, 144371. Signed-off-by:
Christian Engelmayer <cengelma@gmx.at> Signed-off-by:
-
Christian Engelmayer authored
Fix a potential leak in the error path of r871x_wx_set_enc_ext(). In case the requested algorithm is not supported by the driver, the function returns without freeing the already allocated 'param' struct. Move the input verification to the beginning of the function so that the direct return is safe. Detected by Coverity - CID 144373. Signed-off-by:
-
Raghavendra Ganiga authored
This is a patch to remove warnings reported by checkpatch tool on cb_pcimdas.c file Signed-off-by:
Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Peter Senna Tschudin authored
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // </smpl> Signed-off-by:
-
Julia Lawall authored
Delete unnecessary local variable whose value is always 0 and that hides the fact that the result is always 0. A simplified version of the semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ local idexpression ret; expression e; position p; @@ -ret = 0; ... when != ret = e return - ret + 0 ; // </smpl> Signed-off-by:
-
John Church authored
This patch fixes a coding style issue for a line that was over 80 characters long. Signed-off-by:
John Church <sleeveroller@gmail.com> Reviewed-by:
-
Rickard Strandqvist authored
Removal of null pointer checks that could never happen Signed-off-by:
Josh Triplett <josh@joshtriplett.org> Signed-off-by:
-
Jes Sorensen authored
Copying 16 bits into an uninitialized 32 bit stack variable and then byteswapping it can provide 'interesting' results. Signed-off-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
navin patidar authored
Signed-off-by:
navin patidar <navin.patidar@gmail.com> Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
