1. 19 Feb, 2017 4 commits
    • Mitch Williams's avatar
      i40evf: free rings in remove function · 8a68badd
      Mitch Williams authored
      When the i40evf_remove() calls netdev close, the device doesn't actually
      close - it schedules the work for the watchdog to perform. Since we're
      stopping the watchdog, this work doesn't get done. However, we're
      resetting the part, so we can free resources after the reset request has
      gone through. This plugs a memory leak.
      
      Change-ID: Id5335dcaf76ce00d2a4c3d26e9faf711d7f051cf
      Signed-off-by: default avatarMitch Williams <mitch.a.williams@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      8a68badd
    • Jacob Keller's avatar
      i40e: remove unnecessary call to i40e_update_link_info · 03aa268b
      Jacob Keller authored
      This call is made just prior to running i40e_link_event. In
      i40e_link_event, we set hw->phy.get_link_info to true just prior to
      calling i40e_get_link_status, which conveniently runs
      i40e_update_link_info for us. Thus, we are running i40e_update_link_info
      twice, which seems like something we don't need to do...
      
      Change-ID: I36467a570f44b7546d218c99e134ff97c2709315
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      03aa268b
    • Joshua Hay's avatar
      i40e: enable mc magic pkt wakeup during power down · 1d68005d
      Joshua Hay authored
      This patch adds a call to the mac_address_write admin q function during
      power down to update the PRTPM_SAH/SAL registers with the MC_MAG_EN bit
      thus enabling multicast magic packet wakeup.
      
      A FW workaround is needed to write the multicast magic wake up enable
      bit in the PRTPM_SAH register. The FW expects the mac address write
      admin q cmd to be called first with one of the WRITE_TYPE_LAA flags
      and then with the multicast relevant flags.
      
      *Note: This solution only works for X722 devices currently. A PFR will
      clear the previously mentioned bit by default, but X722 has support for a
      WOL_PRESERVE_ON_PFR flag which prevents the bit from being cleared. Once
      other devices support this flag, this solution should work as well.
      
      Change-ID: I51bd5b8535bd9051c2676e27c999c1657f786827
      Signed-off-by: default avatarJoshua Hay <joshua.a.hay@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      1d68005d
    • Alan Brady's avatar
      i40e: fix disable overflow promiscuous mode · a410c821
      Alan Brady authored
      There exists a bug in which the driver is unable to exit overflow
      promiscuous mode after having added "too many" mac filters.  It is
      expected that after triggering overflow promiscuous, removing the
      failed/extra filters should then disable overflow promiscuous mode.
      
      The bug exists because we were intentionally skipping the sync_vsi_filter
      path in cases where we were removing failed filters since they shouldn't
      have been added to the firmware in the first place, however we still
      need to go through the sync_vsi_filter code path to determine whether or
      not it is ok to exit overflow promiscuous mode.  This patch fixes the
      bug by making sure we go through the sync_vsi_filter path in cases of
      failed filters.
      
      Change-ID: I634d249ca3e5fa50729553137c295e73e7722143
      Signed-off-by: default avatarAlan Brady <alan.brady@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      a410c821
  2. 17 Feb, 2017 36 commits