- 07 Dec, 2021 29 commits
-
-
Luiz Augusto von Dentz authored
This introduces mgmt_alloc_skb and mgmt_send_event_skb which are convenient when building MGMT events that have variable length as the likes of skb_put_data can be used to insert portion directly on the skb instead of having to first build an intermediate buffer just to be copied over the skb. Signed-off-by:
Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by:
Marcel Holtmann <marcel@holtmann.org>
-
Mark Chen authored
If there are failure cases in getting patch status, it should return the error code (-EIO). Fixes: fc342c4d ("Bluetooth: btusb: Add protocol support for MediaTek MT7921U USB devices") Co-developed-by:
Sean Wang <sean.wang@mediatek.com> Signed-off-by:
Mark Chen <mark-yw.chen@mediatek.com> Signed-off-by:
-
Mark Chen authored
For Mediatek chipset, it can not enabled if there are something wrong in btmtk_setup_firmware_79xx(). Thus, the process must be terminated and returned error code. Fixes: fc342c4d ("Bluetooth: btusb: Add protocol support for MediaTek MT7921U USB devices") Co-developed-by:
-
Luiz Augusto von Dentz authored
This fixes compilation when CONFIG_BT_MSFTEXT is not set. Fixes: 6b3d4c8fcf3f2 ("Bluetooth: hci_event: Use of a function table to handle HCI events") Signed-off-by: -
Luiz Augusto von Dentz authored
This adds support for Set Privacy Mode when updating the resolving list when HCI_CONN_FLAG_DEVICE_PRIVACY so the controller shall use Device Mode for devices programmed in the resolving list, Device Mode is actually required when the remote device are not able to use RPA as otherwise the default mode is Network Privacy Mode in which only allows RPAs thus the controller would filter out advertisement using identity addresses for which there is an IRK. Signed-off-by:
-
Luiz Augusto von Dentz authored
This introduces HCI_CONN_FLAG_DEVICE_PRIVACY which can be used by userspace to indicate to the controller to use Device Privacy Mode to a specific device. Signed-off-by:
-
Luiz Augusto von Dentz authored
This makes btusb to queue ACL and events during a polling interval by using of a delayed work, with the interval working as a time window where frames received from different endpoints are considered to be arrived at same time and then attempt to resolve potential conflics by processing the events ahead of ACL packets. It worth noting though that priorizing events over ACL data may result in inverting the order compared to how they appeared over the air, for instance there may be packets received before a disconnect event that will be discarded and unencrypted packets received before encryption change which would considered encrypted, because of these potential changes on the order the support for queuing during the polling interval is not enabled by default so it requires setting force_poll_sync debugfs while the adapter is down. Signed-off-by:
-
Luiz Augusto von Dentz authored
This reworks hci_conn_params flags to use bitmap_* helpers and add support for setting the supported flags in hdev->conn_flags so it can easily be accessed. Signed-off-by:
-
Luiz Augusto von Dentz authored
This make use of hci_dev_test_and_{set,clear}_flag instead of doing 2 operations in a row. Fixes: cbbdfa6f ("Bluetooth: Enable controller RPA resolution using Experimental feature") Signed-off-by: -
Aditya Garg authored
Some Macs with the T2 security chip had Bluetooth not working. To fix it we add DMI based quirks to disable querying of LE Tx power. Signed-off-by:
Aditya Garg <gargaditya08@live.com> Reported-by:
Orlando Chamberlain <redecorating@protonmail.com> Tested-by:
-
Aditya Garg authored
Some devices have a bug causing them to not work if they query LE tx power on startup. Thus we add a quirk in order to not query it and default min/max tx power values to HCI_TX_POWER_INVALID. Signed-off-by:
-
Sean Wang authored
Similar to MT7921 btusb, we enable AOSP extension for MT7921 btmtksdio as well. Signed-off-by:
-
Łukasz Bartosik authored
Enable msft opcode for mt7921 chip. Signed-off-by:
Łukasz Bartosik <lb@semihalf.com> Signed-off-by:
-
Zijun Hu authored
Add a USB ID 0489:e0e3 of HP to usb_device_id table for WCN6855. -Device(0489:e0e3) from /sys/kernel/debug/usb/devices T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=12 MxCh= 0 D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=0489 ProdID=e0e3 Rev= 0.01 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms I: If#= 1 Alt= 7 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 65 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 65 Ivl=1ms Signed-off-by:
Zijun Hu <quic_zijuhu@quicinc.com> Signed-off-by:
-
Luiz Augusto von Dentz authored
This change the use of switch statement to a function table which is easier to extend. Signed-off-by:
-
Luiz Augusto von Dentz authored
This change the use of switch statement to a function table which is easier to extend and can include min/max length of each command. Signed-off-by:
-
Luiz Augusto von Dentz authored
This change the use of switch statement to a function table which is easier to extend and can include min/max length of each subevent. Signed-off-by:
-
Luiz Augusto von Dentz authored
This change the use of switch statement to a function table which is easier to extend and can include min/max length of each HCI event. Signed-off-by:
-
Luiz Augusto von Dentz authored
This uses skb_pull_data to check the LE Direct Advertising Report events received have the minimum required length. Signed-off-by:
-
Luiz Augusto von Dentz authored
This uses skb_pull_data to check the LE Extended Advertising Report events received have the minimum required length. Signed-off-by:
-
Luiz Augusto von Dentz authored
This uses skb_pull_data to check the LE Advertising Report events received have the minimum required length. Signed-off-by:
-
Luiz Augusto von Dentz authored
This uses skb_pull_data to check the LE Metaevents received have the minimum required length. Signed-off-by:
-
Luiz Augusto von Dentz authored
This uses skb_pull_data to check the Extended Inquiry Result events received have the minimum required length. Signed-off-by:
-
Luiz Augusto von Dentz authored
This uses skb_pull_data to check the Inquiry Result with RSSI events received have the minimum required length. Signed-off-by:
-
Luiz Augusto von Dentz authored
This uses skb_pull_data to check the Inquiry Result events received have the minimum required length. Signed-off-by:
-
Luiz Augusto von Dentz authored
This uses skb_pull_data to check the Number of Complete Packets events received have the minimum required length. Signed-off-by:
-
Luiz Augusto von Dentz authored
This uses skb_pull_data to check the Command Complete events received have the minimum required length. Signed-off-by:
-
Luiz Augusto von Dentz authored
This uses skb_pull_data to check the BR/EDR events received have the minimum required length. Signed-off-by:
-
Luiz Augusto von Dentz authored
Like skb_pull but returns the original data pointer before pulling the data after performing a check against sbk->len. This allows to change code that does "struct foo *p = (void *)skb->data;" which is hard to audit and error prone, to: p = skb_pull_data(skb, sizeof(*p)); if (!p) return; Which is both safer and cleaner. Acked-by:Jakub Kicinski <kuba@kernel.org> Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
- 03 Dec, 2021 6 commits
-
-
Sean Wang authored
btmtksdio have to rely on MMC_PM_KEEP_POWER in pm_flags to avoid that SDIO power is being shut off during the device is in suspend. That fixes the SDIO command fails to access the bus after the device is resumed. Fixes: 7f3c563c ("Bluetooth: btmtksdio: Add runtime PM support to SDIO based Bluetooth") Co-developed-by:
-
Sean Wang authored
Runtime pm ops is not aware the sdio_func status that is probably being disabled by btmtksdio_close. Thus, we are only able to access the sdio_func for the runtime pm operations only when the sdio_func is available. Fixes: 7f3c563c ("Bluetooth: btmtksdio: Add runtime PM support to SDIO based Bluetooth") Co-developed-by:
-
Benjamin Berg authored
Cancel sync commands when transmission of URBs fail. This is done for both failures to send a command URB and also when the interrupt URB used to retrieve a response fails. This approach is sufficient to quickly deal with certain errors such as a device being disconnected while synchronous commands are done during initialization. Signed-off-by:
Benjamin Berg <bberg@redhat.com> Signed-off-by:
-
Benjamin Berg authored
If sending a frame failed any sync command associated with it will never be completed. As such, cancel any such command immediately to avoid timing out. Signed-off-by:
-
Benjamin Berg authored
After transfer errors it makes sense to cancel an ongoing synchronous command that cannot complete anymore. To permit this, export the old hci_req_sync_cancel function as hci_cmd_sync_cancel in the API. Signed-off-by:
-
Benjamin Berg authored
Resetting the timers and cmd_cnt means that we assume the device will be in a good state after the sync command finishes. Without this a chain of synchronous commands might get stuck if one of them is cancelled. Signed-off-by:
-
- 25 Nov, 2021 4 commits
-
-
Archie Pusaka authored
When doing remote name request, we cannot scan. In the normal case it's OK since we can expect it to finish within a short amount of time. However, there is a possibility to scan lots of devices that (1) requires Remote Name Resolve (2) is unresponsive to Remote Name Resolve When this happens, we are stuck to do Remote Name Resolve until all is done before continue scanning. This patch adds a time limit to stop us spending too long on remote name request. Signed-off-by:
Archie Pusaka <apusaka@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Signed-off-by:
-
Archie Pusaka authored
Introducing NAME_REQUEST_FAILED flag that will be sent together with device found event on name resolve failure. This will provide the userspace with an information so it can decide not to resolve the name for these devices in the future. Signed-off-by:
-
Luiz Augusto von Dentz authored
num_keys is actually 2 octects not 1: BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 4, Part E page 1989: Num_Keys_Deleted: Size: 2 octets 0xXXXX Number of Link Keys Deleted Signed-off-by:
-
Luiz Augusto von Dentz authored
Both max_num_keys and num_key are 2 octects: BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 4, Part E page 1985: Max_Num_Keys: Size: 2 octets Range: 0x0000 to 0xFFFF Num_Keys_Read: Size: 2 octets Range: 0x0000 to 0xFFFF Signed-off-by:
-
- 24 Nov, 2021 1 commit
-
-
Brian Gix authored
Check for out-of-bound read was being performed at the end of while num_reports loop, and would fill journal with false positives. Added check to beginning of loop processing so that it doesn't get checked after ptr has been advanced. Signed-off-by:
Brian Gix <brian.gix@intel.com> Signed-off-by:
-
