- 20 Dec, 2021 11 commits
-
-
Larry Finger authored
Syzbot reports the following WARNING: [200~raw_local_irq_restore() called with IRQs enabled WARNING: CPU: 1 PID: 1206 at kernel/locking/irqflag-debug.c:10 warn_bogus_irq_restore+0x1d/0x20 kernel/locking/irqflag-debug.c:10 Hardware initialization for the rtl8188cu can run for as long as 350 ms, and the routine may be called with interrupts disabled. To avoid locking the machine for this long, the current routine saves the interrupt flags and enables local interrupts. The problem is that it restores the flags at the end without disabling local interrupts first. This patch fixes commit a53268be ("rtlwifi: rtl8192cu: Fix too long disable of IRQs"). Reported-by: syzbot+cce1ee31614c171f5595@syzkaller.appspotmail.com Cc: stable@vger.kernel.org Fixes: a53268be ("rtlwifi: rtl8192cu: Fix too long disable of IRQs") Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/20211215171105.20623-1-Larry.Finger@lwfinger.net
-
Chris Chiu authored
The A-MPDU TX retransmission rate is always high (> 20%) even in a very clean environment. However, the vendor driver retransimission rate is < 10% in the same test bed. The difference is the vendor driver starts the A-MPDU TXOP with initial RTS/CTS handshake which is observed in the air capture and the TX descriptor. Since the driver does not know how many frames will be aggregated and the estimated duration, forcing the RTS/CTS protection for A-MPDU helps to lower the retransmission rate from > 20% to ~12% in the same test setup with the vendor driver. Signed-off-by:
Chris Chiu <chris.chiu@canonical.com> Signed-off-by:
-
Po-Hao Huang authored
These settings enables mac to detect and recover when rx fifo circuit deadlock occurs. Previous version missed this, so we fix it. Signed-off-by:
Po-Hao Huang <phhuang@realtek.com> Signed-off-by:
Ping-Ke Shih <pkshih@realtek.com> Signed-off-by:
-
Chin-Yen Lee authored
Currently all realtek wifi chip is set to check CRC of VHT-SIG-B in 802.11ac signal, but some AP don't calculate the CRC and packets from these AP can't be received and lead to disconnection. We disable the check defaultly to avoid this case. Signed-off-by:
Chin-Yen Lee <timlee@realtek.com> Signed-off-by:
-
Kai-Heng Feng authored
Many Intel based platforms face system random freeze after commit 9e2fd298 ("rtw88: add napi support"). The commit itself shouldn't be the culprit. My guess is that the 8821CE only leaves ASPM L1 for a short period when IRQ is raised. Since IRQ is masked during NAPI polling, the PCIe link stays at L1 and makes RX DMA extremely slow. Eventually the RX ring becomes messed up: [ 1133.194697] rtw_8821ce 0000:02:00.0: pci bus timeout, check dma status Since the 8821CE hardware may fail to leave ASPM L1, manually do it in the driver to resolve the issue. Fixes: 9e2fd298 ("rtw88: add napi support") Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215131 BugLink: https://bugs.launchpad.net/bugs/1927808Signed-off-by:
Kai-Heng Feng <kai.heng.feng@canonical.com> Acked-by:
Jian-Hong Pan <jhp@endlessos.org> Signed-off-by:
-
Dan Carpenter authored
Smatch complains that there is a double free in probe: drivers/net/wireless/microchip/wilc1000/spi.c:186 wilc_bus_probe() error: double free of 'spi_priv' drivers/net/wireless/microchip/wilc1000/sdio.c:163 wilc_sdio_probe() error: double free of 'sdio_priv' The problem is that wilc_netdev_cleanup() function frees "wilc->bus_data". That's confusing and a layering violation. Leave the frees in probe(), delete the free in wilc_netdev_cleanup(), and add some new frees to the remove() functions. Fixes: dc8b338f ("wilc1000: use goto labels on error path") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Claudiu Beznea <claudiu.beznea@microchip.com> Signed-off-by:
-
Luca Coelho authored
If iwl_transt_start_hw() failed, we were returning without calling wiphy_unlock() and rtnl_unlock(), causing a locking imbalance: drivers/net/wireless/intel/iwlwifi/mvm/ops.c:686:12: warning: context imbalance in 'iwl_mvm_start_get_nvm' - wrong count at exit Fix that by adding the unlock calls. Signed-off-by:
Luca Coelho <luciano.coelho@intel.com> Signed-off-by:
-
Johannes Berg authored
We forgot to link this to debugfs, so the code is all dead. Add it for real. Signed-off-by:
Johannes Berg <johannes.berg@intel.com> Signed-off-by:
-
Johannes Berg authored
On struct iwl_rx_handlers we should document the min_size member, do that. Signed-off-by:
-
Johannes Berg authored
There are a few warnings due to kernel-doc not understanding the constructs the way they're done here, fix them. Signed-off-by:
-
https://github.com/nbd168/wirelessKalle Valo authored
mt76 patches for 5.17 * decap offload fixes * mt7915 fixes * mt7921 fixes * eeprom fixes * powersave handling fixes * SAR support * code cleanups
-
- 19 Dec, 2021 29 commits
-
-
Deren Wu authored
During heavy loading throughtput test, the RX buffer (128) would be exhausted and some RX pkts dropped randomly. Increase buffer size from 128 to 512 (a safer length) to avoid tput degrade or cmd-timeout problem. Signed-off-by:
Deren Wu <deren.wu@mediatek.com> Signed-off-by:
Felix Fietkau <nbd@nbd.name>
-
Sean Wang authored
Fix the false positive suspend error that may occur on mt7921s with enlarging mcu timeout value. The reason why we have to enlarge mcu timeout from HZ / 3 to HZ is we should consider the additional overhead caused by running concurrently with btmtksdio (a MT7921 bluetooth SDIO driver) that would compete for the same SDIO bus in process context to complete the suspend procedure. Fixes: 48fab5bb ("mt76: mt7921: introduce mt7921s support") Signed-off-by:
Sean Wang <sean.wang@mediatek.com> Signed-off-by:
-
Sean Wang authored
Update pm->suspended usage to be consistent with mt7921e driver. Signed-off-by:
-
Sean Wang authored
Fix the possible resume failure due to mt76_connac_mcu_set_hif_suspend timeout. That is because clearing the flag pm->suspended too early opened up a race window, where mt7921_poll_tx/rx scheduled a ps_work to put the device in doze mode, that is unexpected for the device is being resumed from the suspend state and would make the remaining MCU comamnds in resume handler failed to execute. Fixes: ffa1bf97 ("mt76: mt7921: introduce PM support") Co-developed-by:
YN Chen <YN.Chen@mediatek.com> Signed-off-by:
-
Sean Wang authored
clear pm->suspended in mt7921_mac_reset_work to allow pm runtime can be enabled after wifi reset in any circumstance. Signed-off-by:
-
Lorenzo Bianconi authored
Rely on le16_add_cpu() in mt76_connac_mcu_add_nested_tlv routine. Signed-off-by:
Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by:
-
Lorenzo Bianconi authored
to_wcid_lo and to_wcid_hi are no longer used in mt7921/mcu.c Signed-off-by:
-
MeiChia Chiu authored
Add mu-mimo and ofdma packet counters statistics. The statistics are clear on read. Reviewed-by:
Money Wang <Money.Wang@mediatek.com> Reviewed-by:
Ryder Lee <ryder.lee@mediatek.com> Signed-off-by:
MeiChia Chiu <meichia.chiu@mediatek.com> Signed-off-by:
-
Lorenzo Bianconi authored
Align mt7915_vif layout to mt7921_vif and mt7615_vif Signed-off-by:
-
Tzung-Bi Shih authored
"ASIC revision" and "Firmware init done" shouldn't be error messages. Reduces the severity levels. Signed-off-by:
Tzung-Bi Shih <tzungbi@google.com> Signed-off-by:
-
Lorenzo Bianconi authored
Remove duplicated mcu definitions in mt7915 mcu.h and reused connac ones. Signed-off-by:
-
Lorenzo Bianconi authored
Similar to mt7915 driver, rely on MCU_CMD macro and do not command definitions directly Signed-off-by:
-
Lorenzo Bianconi authored
Similar to MCU_EXT_CMD, introduce MCU_CE_CMD for CE commands Signed-off-by:
-
Lorenzo Bianconi authored
Similar to MCU_EXT_CMD, introduce MCU_UNI_CMD for unified commands Signed-off-by:
-
Lorenzo Bianconi authored
Get rid of MCU_FW_PREFIX bit since it is no longer used Signed-off-by:
-
Lorenzo Bianconi authored
Align MCU_EXT and MCU_FW definitions between mt76_connac and mt7915 driver. This is a preliminary patch to reuse mt76_connac in mt7915 driver. Signed-off-by:
-
Lorenzo Bianconi authored
Introduce MCU_EXT_CMD and MCU_EXT_QUERY macros in mt76_connac module. This is a preliminary patch to reuse mt76_connac module in mt7915 driver. Signed-off-by:
-
Deren Wu authored
TXS in mt7921 may be forwared to tx_done event. Should try to catch TXS information in tx_done event as well. Signed-off-by:
-
Felix Fietkau authored
The hardware only supports WMM index 0-2 and registers for index 3 return bogus data. Signed-off-by: -
Felix Fietkau authored
Reduces pressure on the memory allocator Signed-off-by: -
Felix Fietkau authored
This can be used to free received events without allocating an extra skb Signed-off-by: -
Lorenzo Bianconi authored
4addr is not supported by the offload firmware yet Signed-off-by:
-
Felix Fietkau authored
Should fix issues with error recovery Signed-off-by: -
Ryder Lee authored
Get rid of unsafe access since mt76_insert_ccmp_hdr moves the header. Signed-off-by:
-
Lorenzo Bianconi authored
Move wiphy SAR capability configuration in mt76 module and remove duplicated code. Signed-off-by:
-
Lorenzo Bianconi authored
last_ch configuration must not be dependent on the current configured band but it is defined by hw capabilities since the fw always expects the following order: - 2GHz - 5GHz - 6GHz Fixes: 9b2ea8ee ("mt76: connac: set 6G phymode in single-sku support") Signed-off-by:
-
Sean Wang authored
Return the proper error code when out-of-range the Rx aggregation count are reported from the hardware that would create the unreasonable extreme large Rx buffer. [ 100.873810] show_stack+0x20/0x2c [ 100.873823] dump_stack+0xc4/0x140 [ 100.873839] bad_page+0x110/0x114 [ 100.873854] check_new_pages+0xf8/0xfc [ 100.873869] rmqueue+0x5a0/0x640 [ 100.873884] get_page_from_freelist+0x124/0x20c [ 100.873898] __alloc_pages_nodemask+0x114/0x2a4 [ 100.873918] mt76s_rx_run_queue+0xd4/0x2e4 [mt76_sdio 8280a88a0c8c9cf203f16e194f99ac293bdbb2f5] [ 100.873938] mt76s_rx_handler+0xd4/0x2a0 [mt76_sdio 8280a88a0c8c9cf203f16e194f99ac293bdbb2f5] [ 100.873957] mt76s_txrx_worker+0xac/0x17c [mt76_sdio 8280a88a0c8c9cf203f16e194f99ac293bdbb2f5] [ 100.873977] mt7921s_txrx_worker+0x5c/0xd8 [mt7921s d0bdbc018082dbc8dc1407614be3c2e7bd64423b] [ 100.874003] __mt76_worker_fn+0xe8/0x170 [mt76 b80af3483a8f9d48e916c12d8dbfaa0d3cd15337] [ 100.874018] kthread+0x148/0x3ac [ 100.874032] ret_from_fork+0x10/0x30 [ 100.874067] Kernel Offset: 0x1fe2000000 from 0xffffffc010000000 [ 100.874079] PHYS_OFFSET: 0xffffffe800000000 [ 100.874090] CPU features: 0x0240002,2188200c Fixes: 48fab5bb ("mt76: mt7921: introduce mt7921s support") Signed-off-by:
-
Deren Wu authored
Accroding to chip hw flow, mt7921s need to re-acquire privilege again before normal running. Otherwise, the bus may be stuck in an abnormal status. Tested-by:
Leon Yen <Leon.Yen@mediatek.com> Co-developed-by:
Eric-SY Chang <Eric-SY.Chang@mediatek.com> Signed-off-by:
-
Shayne Chen authored
Set 6GHz cap to iftype data which is matched to the type of current interface. Fixes: 50ac15a5 ("mt76: mt7921: add 6GHz support") Signed-off-by:
Shayne Chen <shayne.chen@mediatek.com> Acked-by:
-
