- 01 Aug, 2017 37 commits
-
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 11940 660 16 12616 3148 drivers/video/fbdev/pm2fb.o File size after adding 'const': text data bss dec hex filename 12068 532 16 12616 3148 drivers/video/fbdev/pm2fb.o Signed-off-by:
Arvind Yadav <arvind.yadav.cs@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Antonino Daplas <adaplas@gmail.com> Cc: Maik Broemme <mbroemme@libmpq.org> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> Signed-off-by:
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 6736 856 0 7592 1da8 drivers/video/fbdev/imsttfb.o File size after adding 'const': text data bss dec hex filename 6832 760 0 7592 1da8 drivers/video/fbdev/imsttfb.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 170 488 0 658 292 drivers/video/fbdev/sunxvr500.o File size after adding 'const': text data bss dec hex filename 394 264 0 658 292 drivers/video/fbdev/sunxvr500.o Signed-off-by: -
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 8432 1456 16 9904 26b0 drivers/video/fbdev/tdfxfb.o File size after adding 'const': text data bss dec hex filename 8560 1328 16 9904 26b0 drivers/video/fbdev/tdfxfb.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 7326 1320 0 8646 21c6 fbdev/mb862xx/mb862xxfbdrv.o File size after adding 'const': text data bss dec hex filename 7454 1192 0 8646 21c6 fbdev/mb862xx/mb862xxfbdrv.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 12149 768 36 12953 3299 video/fbdev/nvidia/nvidia.o File size after adding 'const': text data bss dec hex filename 12213 704 36 12953 3299 video/fbdev/nvidia/nvidia.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 7953 568 96 8617 21a9 fbdev/vermilion/vermilion.o File size after adding 'const': text data bss dec hex filename 8017 504 96 8617 21a9 fbdev/vermilion/vermilion.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 3190 2704 24 5918 171e video/fbdev/kyro/fbdev.o File size after adding 'const': text data bss dec hex filename 3290 2640 24 5918 171e video/fbdev/kyro/fbdev.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 12511 1920 0 14431 385f drivers/video/fbdev/arkfb.o File size after adding 'const': text data bss dec hex filename 12607 1824 0 14431 385f drivers/video/fbdev/arkfb.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 13132 520 56 13708 358c video/fbdev/i810/i810_main.o File size after adding 'const': text data bss dec hex filename 13356 296 56 13708 358c video/fbdev/i810/i810_main.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 13285 2080 3 15368 3c08 video/fbdev/riva/fbdev.o File size after adding 'const': text data bss dec hex filename 14677 688 3 15368 3c08 video/fbdev/riva/fbdev.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 19916 1240 8 21164 52ac fbdev/savage/savagefb_driver.o File size after adding 'const': text data bss dec hex filename 20684 472 8 21164 52ac fbdev/savage/savagefb_driver.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 3856 968 128 4952 1358 video/fbdev/via/via-core.o File size after adding 'const': text data bss dec hex filename 4304 520 128 4952 1358 video/fbdev/via/via-core.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 13206 1232 40 14478 388e video/fbdev/tridentfb.o File size after adding 'const': text data bss dec hex filename 13910 528 40 14478 388e video/fbdev/tridentfb.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 5155 1312 40 6507 196b drivers/video/fbdev/pvr2fb.o File size after adding 'const': text data bss dec hex filename 5219 1248 40 6507 196b drivers/video/fbdev/pvr2fb.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 11749 896 24 12669 317d video/fbdev/intelfb/intelfbdrv.o File size after adding 'const': text data bss dec hex filename 12173 472 24 12669 317d video/fbdev/intelfb/intelfbdrv.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 4703 512 0 5215 145f drivers/video/fbdev/asiliantfb.o File size after adding 'const': text data bss dec hex filename 4767 448 0 5215 145f drivers/video/fbdev/asiliantfb.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 390 552 0 942 3ae drivers/video/fbdev/sunxvr2500.o File size after adding 'const': text data bss dec hex filename 686 256 0 942 3ae drivers/video/fbdev/sunxvr2500.o Signed-off-by: -
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 11525 2048 8 13581 350d video/fbdev/aty/aty128fb.o File size after adding 'const': text data bss dec hex filename 13061 512 8 13581 350d video/fbdev/aty/aty128fb.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 17534 1824 48 19406 4bce video/fbdev/aty/atyfb_base.o File size after adding 'const': text data bss dec hex filename 18686 672 48 19406 4bce video/fbdev/aty/atyfb_base.o Signed-off-by:
-
Arvind Yadav authored
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by <linux/pci.h> work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 19709 5024 32 24765 60bd video/fbdev/aty/radeon_base.o File size after adding 'const': text data bss dec hex filename 22893 1840 32 24765 60bd video/fbdev/aty/radeon_base.o Signed-off-by:
-
Arvind Yadav authored
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 5227 560 0 5787 169b panel-sony-acx565akm File size after adding 'const': text data bss dec hex filename 5291 496 0 5787 169b panel-sony-acx565akm.o Signed-off-by:
-
Arvind Yadav authored
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 2673 368 0 3041 be1 panel-tpo-td043mtea1.o File size after adding 'const': text data bss dec hex filename 2737 304 0 3041 be1 panel-tpo-td043mtea1.o Signed-off-by:
-
Arvind Yadav authored
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 15426 4952 187 20565 5055 drivers/video/fbdev/uvesafb.o File size after adding 'const': text data bss dec hex filename 15490 4888 187 20565 5055 drivers/video/fbdev/uvesafb.o Signed-off-by:
-
Gustavo A. R. Silva authored
This dev_pm_ops structure is only stored in the pm field of a device_driver structure. This field is declared const, so dev_pm_ops structures that have this property can be declared as const also. Signed-off-by:
Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by:
-
Julia Lawall authored
Drop static on a local variable, when the variable is initialized before any possible use. Thus, the static has no benefit. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; // </smpl> Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Cc: Kees Cook <keescook@chromium.org> Signed-off-by:
-
Bhumika Goyal authored
Make lcd_panel structure const as it is only copied to some object. As the only usage of this structure is a copy operation, so it can be made const. Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Cc: Julia Lawall <julia.lawall@lip6.fr> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Signed-off-by:
-
Gustavo A. R. Silva authored
This structure is only used to copy into other structures, so declare it as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct fb_fix_screeninfo i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p @bad@ position p != {r.p,ok.p}; identifier r.i; struct fb_fix_screeninfo e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct fb_fix_screeninfo i = { ... }; Signed-off-by:Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by:
-
Gustavo A. R. Silva authored
These structures are only used to copy into other structures, so declare them as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct fb_fix_screeninfo i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p @bad@ position p != {r.p,ok.p}; identifier r.i; struct fb_fix_screeninfo e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct fb_fix_screeninfo i = { ... }; The semantic patch for fb_var_screeninfo is analogous. Signed-off-by:Michal Simek <michal.simek@xilinx.com> Cc: Soren Brinkmann <soren.brinkmann@xilinx.com> Signed-off-by:
-
Gustavo A. R. Silva authored
These structures are only used to copy into other structures, so declare them as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct fb_fix_screeninfo i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p @bad@ position p != {r.p,ok.p}; identifier r.i; struct fb_fix_screeninfo e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct fb_fix_screeninfo i = { ... }; The semantic patch for fb_var_screeninfo is analogous. Signed-off-by: -
Gustavo A. R. Silva authored
These structures are only used to copy into other structures, so declare them as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct fb_fix_screeninfo i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p @bad@ position p != {r.p,ok.p}; identifier r.i; struct fb_fix_screeninfo e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct fb_fix_screeninfo i = { ... }; The semantic patch for fb_var_screeninfo is analogous. Signed-off-by: -
Lynn Lei authored
Fixed a constant-left comparison warning issue check by scripts/checkpatch.pl: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by:
Lynn Lei <lynnl.wit@gmail.com> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Cc: Teddy Wang <teddy.wang@siliconmotion.com> Signed-off-by:
-
Lynn Lei authored
Fixed several prefer 'unsigned int' over 'unsigned' warnings checked by scripts/checkpatch.pl: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by:
-
Lynn Lei authored
Fixed unaligned block comments warning generated by scripts/checkpatch.pl: WARNING: Block comments should align the * on each line Signed-off-by:
-
Lynn Lei authored
Inside function sm7xx_vga_setup() Using a generic function macro for debug information display Signed-off-by:
-
Kuninori Morimoto authored
Now, we can use of_graph_get_remote_endpoint(). Let's use it. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Signed-off-by:
-
- 31 Jul, 2017 3 commits
-
-
Dave Airlie authored
This patch allows the user to disable write combined mapping of the efifb framebuffer console using an nowc option. A customer noticed major slowdowns while logging to the console with write combining enabled, on other tasks running on the same CPU. (10x or greater slow down on all other cores on the same CPU as is doing the logging). I reproduced this on a machine with dual CPUs. Intel(R) Xeon(R) CPU E5-2609 v3 @ 1.90GHz (6 core) I wrote a test that just mmaps the pci bar and writes to it in a loop, while this was running in the background one a single core with (taskset -c 1), building a kernel up to init/version.o (taskset -c 8) went from 13s to 133s or so. I've yet to explain why this occurs or what is going wrong I haven't managed to find a perf command that in any way gives insight into this. 11,885,070,715 instructions # 1.39 insns per cycle vs 12,082,592,342 instructions # 0.13 insns per cycle is the only thing I've spotted of interest, I've tried at least: dTLB-stores,dTLB-store-misses,L1-dcache-stores,LLC-store,LLC-store-misses,LLC-load-misses,LLC-loads,\mem-loads,mem-stores,iTLB-loads,iTLB-load-misses,cache-references,cache-misses For now it seems at least a good idea to allow a user to disable write combining if they see this until we can figure it out. Note also most users get a real framebuffer driver loaded when kms kicks in, it just happens on these machines the kernel didn't support the gpu specific driver. Signed-off-by:Dave Airlie <airlied@redhat.com> Acked-by:
Peter Jones <pjones@redhat.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by:
-
Arnd Bergmann authored
Removing the default display name left a harmless warning: fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable] This removes the now-unused variable as well. Fixes: 278cba7e ("drm: omapdrm: Remove unused default display name support") Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Reviewed-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Signed-off-by:
-
Dan Carpenter authored
We free "info" then dereference it on the next line. Really this whole function would be better if we wrote it to unwind in the mirror of how things are allocated in the probe. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Cc: Alexander Shiyan <shc_work@mail.ru> Cc: Sascha Hauer <kernel@pengutronix.de> Signed-off-by:
-
