- 13 Sep, 2015 40 commits
-
-
Nayeemahmed Badebade authored
Fixed warnings reported by checkpatch.pl: - Block comments use a trailing */ on a separate line - Block comments use * on subsequent lines Signed-off-by:
Nayeemahmed Badebade <itachi.opsrc@gmail.com> Acked-by:
Willy Tarreau <w@1wt.eu> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Luis de Bethencourt authored
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by:
Luis de Bethencourt <luis@debethencourt.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Javier Martinez Canillas authored
The SPI core always reports the MODALIAS uevent as "spi:<modalias>" regardless of the mechanism that was used to register the device (i.e: OF or board code) and the table that is used later to match the driver with the device (i.e: SPI id table or OF match table). So drivers needs to export the SPI id table and this be built into the module or udev won't have the necessary information to autoload the needed driver module when the device is added. But this means that OF-only drivers needs to have both OF and SPI id tables that have to be kept in sync and also the dev node compatible manufacturer prefix is stripped when reporting the MODALIAS. Which can lead to issues if two vendors use the same SPI device name for example. To avoid the above, the SPI core behavior may be changed in the future to not require an SPI device table for OF-only drivers and report the OF module alias. So, it's better to also export the OF table even when is unused now to prevent breaking module loading when the core changes. Signed-off-by:
Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Anish Bhatt authored
Add blank spaces around operators where recommended by checkpatch.pl Signed-off-by:
Anish Bhatt <anish@chelsio.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Anish Bhatt authored
Remove or add blank lines as recommended by checkpatch.pl Signed-off-by:
Anish Bhatt <anish@chelsio.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Anish Bhatt authored
Remove stray unicode quotes around name Signed-off-by:
Anish Bhatt <anish@chelsio.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Anish Bhatt authored
fbtft_par_dbg(DEBUG_SET_ADDR_WIN.. ) is repeated in every set_addr_win() handler, this could be replicated by using the kernel function tracer instead. Signed-off-by:
Anish Bhatt <anish@chelsio.com> Suggested-by:
Greg KH <gregkh@linuxfoundation.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Anish Bhatt authored
Based on checkpatch.pl recommendations, (1 << x) is replaced by BIT(x) Signed-off-by:
Anish Bhatt <anish@chelsio.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Mike Rapoport authored
instead of devm_kzalloc'ing them Signed-off-by:
Mike Rapoport <mike.rapoport@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Mike Rapoport authored
instead of devm_kzalloc'ing them Signed-off-by:
Mike Rapoport <mike.rapoport@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Mike Rapoport authored
Returning immediately if no platform_data or platform_data->gpios is specified reduceis code nesting Signed-off-by:
Mike Rapoport <mike.rapoport@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Mike Rapoport authored
instead of devm_kzalloc'ing them Signed-off-by:
Mike Rapoport <mike.rapoport@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Mike Rapoport authored
The only usage of bl_ops variable in fbtft_unregister_backlight function was assigment of a value to that variable, therefore the assignment and the variable itself can be safely removed Signed-off-by:
Mike Rapoport <mike.rapoport@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Anish Bhatt authored
checkpatch.pl recommends that this is no longer required. Also replaces ASCII-art copyright notice with simple text Signed-off-by:
Anish Bhatt <anish@chelsio.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
Quoted strings should not be split to help text grep in the source. All quoted strings that were split have thus been merged to one unique quoted string each to follow the code style. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
Adds whitespaces to separate the variables declarations and the function content. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
Whitespaces are not necessary before a quoted newline. Remove those. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
An else statement is not useful after a return. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
Two sets of parentheses were used to contain the same statement. In those cases, one of them has been removed, as unnecessary. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
kfree(NULL) is safe and the checks were not required. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
Checkpatch was giving a "externs should be avoided in .c files" because of these forward declarations. As these were not useful in this case, they have been removed. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
braces {} are not necessary for any arm of a statement containing one statement on each side. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
void function return statement was not useful in this case. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
Replace C99 // comments by /* comments */ to follow the kernel code style. Remove some unuseful comments. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
Clean-up the file by using a cleaner spacing around symbols and words. Mostly use the automatic checkpatch whitespacing fixes. This takes care of the consistent spacing errors reported by checkpatch. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
A missing struct keyword in variable declaration triggered a need consistent spacing around '*' code style error. The struct keyword thus has been added everywhere for the rtl8192_rx_info struct, and therefore its typedef removed as not needed anymore. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
Fix "else should follow close brace" checkpatch error. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
Fix "code indent should use tabs where possible" checkpatch error Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
A space existed before the close parenthesis of an if statement. This patch removes it to follow the kernel code style. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Raphaël Beamonte authored
Some switch and case were not be at the same indent level. Signed-off-by:
Raphaël Beamonte <raphael.beamonte@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ronit Halder authored
This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by:
Ronit halder <ronit.crj@gmail.com> Acked-by:
Christian Gromm <christian.gromm@microchip.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sudip Mukherjee authored
checkpatch complains when a variable comparison to NULL is written as: variable == NULL or variable != NULL. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sudip Mukherjee authored
The Makefile is including "drivers/media/video". But there is no such directory in kernel tree. Since it is aim-v4l2 this might have been "drivers/media/v4l2-core", but the Kconfig already mentions that it depends on VIDEO_V4L2. So no need to mention that again in the Makefile. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sudip Mukherjee authored
The variable conf was only assigned the value but was never used. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sudip Mukherjee authored
sparse was complaining that an integer is used as NULL pointer. Fix it by using NULL. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sudip Mukherjee authored
split_arg_list() and audio_set_pcm_format() are being called from the same file and is not referenced from outside, so make them as static. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sudip Mukherjee authored
These functions were only defined but not used anywhere. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sudip Mukherjee authored
If kzalloc fails it will print lots of debugging information in the log, no need to have another in the code. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sudip Mukherjee authored
Multiple blank lines are not recommended in the kernel coding style. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-