The variable 'ret' is set but unused in l2tp_nl_register_ops().

This was obviously meant to maintain error codes which are
returned to the caller, make it so.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'd' is set but unused in irda_proc_register().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'ret' is set but unused in irlap_state_sclose().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'caifdef' is set but unused in modemcmd().

Similarly for 'net' in receive(), and 'res' in
caif_device_notify() and caif_exit_net().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'rc' is set but unused in bnx2x_timer().

Similarly for 'hc_index_p' in bnx2x_init_sb(), and 'port' in
bnx2x_get_hwinfo().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'pgoff' is set but unused in bfa_nw_ioc_fwver_get()
and bfa_ioc_download_fw().

Similarly for 'cmd_h' in bna_mbox_flush_q and the entirety of
bna_rit_mod_uninit() is unused since variables are purely set but no
action is made using them.

Same for 'bna' in bna_rit_create() and 'ret' in bna_rx_create().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'len' is set but unused in data_sock_getsockopt().

The code should use 'len' to validate that the user's socket option is
indeed the right size.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'unused' is set but unused in
isdn_net_ciscohdlck_slarp_in().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'ch' is set but unused in isdn_capi_rec_hl_msg().  Just
kill it off.

Similarly for 'chidx' in isdn_ioctl() and 'di' in
isdn_capi_rec_hl_msg().
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'dev' is set but unused in teles_cs_config().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'cause' is set but unused in ni1up().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'cause' is set but unused in dss1up().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'i' is set but unused in JadeVersion().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'cda2_cr' is set but unused in ctrl_complete().  Just
kill it off.

Keep the cs->readisac() call just in case the register read has side
effects.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'buf' is set but unused in
ctrl_complete().  Just kill it off.

Similarly for 'err' in hfc_usb_init().
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'bits' is set but unused in
change_speed().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'dev' is set but unused in
elsa_cs_config().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'val' is set but unused in
send_arcofi().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'buf' is set but unused in
ctrl_complete().  Just kill it off.

Similarly for the variable 'err' in setup_hfcsusb().
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'total' is set but unused in
hfcpci_empty_bfifo().  Just kill it off.

Similarly for the variable 'val' in ph_state_nt().
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'best_id' is set but unused in
diva_mnt_add_xdi_adapter().  Just kill it off.

Similarly for the variable 'CIP' in connect_req(), 'Number' in
sig_ind(), 'Info' in dtmf_confirmation() mixer_command()
fax_connect_ack_command() fax_edata_ack_command()
rtp_connect_b3_res_command() and rtp_connect_b3_res_command(), and 'a'
in mixer_indication_coefs_set(),
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'offset' is set but unused in
write_iso_tasklet().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'extra_size' is set but unused in
atl1c_configure_tx().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'tx_ring' is set but unused in
atl1e_init_ring_resources().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'tpc' is set but unused in atl1_intr_tx().
Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'vlan_dev' is set but unused in
bond_send_gratuitous_arp().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'eth' is set but unused in lec_handle_bridge().  Also,
the variable 'priv' is set but unused in lane_module_cleanup().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 's' is set but unused in ax25_protocol_release().
Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

#if 0'd out code for IP handling in aun_data_available() has
been commented out since the beginning, which makes the variable
"ip" set but not used.

Kill it off as well as the stub code.
Signed-off-by: David S. Miller <davem@davemloft.net>

"next" in dn_rebuild_zone() is set but not actually used,
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

"iph" in pktgen_output_ipsec() is set but never actually
used.  Kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

This is just a readback to entire completion of a register
write, keep the readback but kill the unused variable.
Signed-off-by: David S. Miller <davem@davemloft.net>

Two cases here:

1) idt77252_rx_raw() really does not make any use of the
   extracted PTI field of the atm header.

2) idt77252_collect_stat() only uses the register values
   in code which has been compiled out by a "NOTDEF" cpp
   test for more than 10 years.  Just kill this NOTDEF
   code entirely, but keep the register reads in case
   they have side effects.
Signed-off-by: David S. Miller <davem@davemloft.net>

GCC complains in these queue index operations because we
perform operations of the form:

	x = some_operation(++x);

which is undefined.  Replace with:

	x = some_operation(x + 1);

which is well defined and provides the intended operation.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable eni_dev is initialized but never subsequently used in
these two functions.
Signed-off-by: David S. Miller <davem@davemloft.net>

Note: I bet that gfar_set_features() don't really need a full reset.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

This also fixes a race around np->txrxctl_bits while changing RXCSUM offload.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>